From nobody Sat Jun 20 17:33:39 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 125092F290B for ; Sun, 12 Apr 2026 17:45:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776015945; cv=none; b=opbOruEjVlLgeWMrjA5yeS2f6Ax1kyk5TlwCrlOHMgECJrVB1WgqcV3DzFLBLr1X5fZLvFPK8Y/657GmZNzPhjDEIgkMC067LjZ9Vp3kezEI0E7N8dsajJ4s4OzjE/Gkz4tr17ROeoiWEYKZMmI3jXelv2LO9S6NS6RVOmAzQJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776015945; c=relaxed/simple; bh=MvFqTtD18D5DAv92JGkSRWZaXoO1lYwBKr6BusmvkEg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Z0Uw3vJtGru9EYQsImI6eq0uSvNicL0HvWQXsmK4DcOLWEhIQTx8K6UySwdqClaKILp3BHDrNQ1Hd+aIEzQ8agTfn8KQp3HulXaWDmBnrc2J+pLdh2wmvIqCB/UZ5SmZjt1o83P1nxdCKHrmmLF61njdlD8XLccQhpBD8LM7OP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m9/xkXd1; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m9/xkXd1" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82f0884bcfaso1926774b3a.1 for ; Sun, 12 Apr 2026 10:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776015940; x=1776620740; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/OoU5jmpe1DqxkQY//ANPB23eMZd7k19jDj8fX9LlbM=; b=m9/xkXd1+VePVXd/wRrhpvwXmPE104FdETsUUVnDZfunl6jKJcgN51Hlw03J/WKWfs y68H0G8yiHjqUwkhbjpa/ZsNcp6NbFIdskZM9bhF7EY5pdzdpns2KYFMgrwNROuV+Cyi IscnSBfR2dRcctyrWX4CHALqRMrMEQAmXrbheytT0Zaso22bPPae4TM0YRRcU2o467Rm TFNQfXrfJ+Fhtjyk5JXYalukcJ+ElOeDrYe9L4Su01ijiJF+6a6nrhLGM9DWynCGp+rx zbz7peRrwoqUEOFMzyooImNMGy4Aqy/4HJLEE563ixx8OF6B+8MnpyYzQO+tV1lRzh5d sy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776015940; x=1776620740; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/OoU5jmpe1DqxkQY//ANPB23eMZd7k19jDj8fX9LlbM=; b=aNzuLfQUv7I1PEjhd9d9qa4szEbeWRRgKXVoJl/2SBkLeZATaQCXskU2t/nD/21yet Zh4WrMDDnvzgFMQQpZZPf/vcvnPy1KNl/o+87FMduHp/Ap20drp198LeA63LjtCCqVJh T9chDoXb12f+pOE6nK/hWcJ+qbrGMbwdI9T1xM6MAgu9OSQA4hHA1OepKz7Z6UOBdMGC RwMbbDE5mYYM/C1HNBm8BZWvNFpnGasnV23eicyj5smrFn/+8kEvVyopNOQLzNACOKrr s/ZYOivmEHdtuIt0uisi1kIzNJDtA8pb0AOSQgWw8xOqtxRSfP5QbmUhh8AGTvbonZOX l2ew== X-Forwarded-Encrypted: i=1; AJvYcCV+EKagIcNa8bp3NF5Ogp8eChT9+KF4v31CGutvJl4Tsdb/eYdyda0W5LYQs9wro8fzJE8upgdyh0/nLxo=@vger.kernel.org X-Gm-Message-State: AOJu0YwXIFBEOkJza+uYtTc0oyUys3L4TCnzgJXYY1UOlc4jvYUorA1u 7ttRxxBlIdN7BvGWYoyBVkaT2WjDZCGT3/biQChK8TMX0NTLhVXa/Ooj X-Gm-Gg: AeBDieuF0weU2dtkEcq7b1Yl4oUgE3ojL1+ZZ66Cb1bFdCeSSVyEleMS59Lmnyn07Wv iygKaRR0Jh8OpjOSCL54elpJ5JV31Kakbi0lGGlWTA91bdMHw3Y17QbCQPAe2aLTfvzwUoi8B+E NZNS5mMMoAy18X7pRs/HI51FgklbibBDn8flH1X2BIjo/91Bwx+KiRNrHU9bm+wZYnBi6r94Jcn 0RmH3sNu9X0mdZu17umglwOePXNSBRZGob4Ytq77tYICT+fmQu/g0Y4JewpXBtYiklrFlQ6Hv+q NyE1ue1JcZA38sqnuld6P5zOT/WajKNO0M81QJ14auaA8nobIWhTmbXJtv3WLmUD0DDkg81JNUq pbnJ3pBZ1u1YeOS+oucU3RROpfxKKiRjyFWQZ4nvimmmxX6XqiuuOXVAMsXlB8ALTXca9tiZQEf D5GWolNTkCXpKKbsYKpDm/+/q+mw== X-Received: by 2002:a05:6a00:a245:b0:82c:6d88:2a8e with SMTP id d2e1a72fcca58-82f0c28903fmr11551470b3a.20.1776015940377; Sun, 12 Apr 2026 10:45:40 -0700 (PDT) Received: from lgs.. ([2409:893d:1188:142d:6dbb:2e05:75d3:967e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c4e182csm8999464b3a.45.2026.04.12.10.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 10:45:39 -0700 (PDT) From: Guangshuo Li To: Jaroslav Kysela , Takashi Iwai , Guangshuo Li , Curtis Malainey , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] ALSA: hwdep: fix NULL dereference on error path Date: Mon, 13 Apr 2026 01:45:29 +0800 Message-ID: <20260412174529.2597250-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_hwdep_new() allocates a hwdep instance first and then allocates hwdep->dev via snd_device_alloc(). When snd_device_alloc() fails, hwdep->dev remains NULL, because snd_device_alloc() clears *dev_p before attempting to allocate the device object. The error path then calls snd_hwdep_free(), which unconditionally invokes put_device(hwdep->dev). This may lead to a NULL pointer dereference in put_device(). Fixes: 897c8882df58 ("ALSA: hwdep: Don't embed device") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- sound/core/hwdep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c index 09200df2932c..aa35bee8da6b 100644 --- a/sound/core/hwdep.c +++ b/sound/core/hwdep.c @@ -343,7 +343,8 @@ static void snd_hwdep_free(struct snd_hwdep *hwdep) return; if (hwdep->private_free) hwdep->private_free(hwdep); - put_device(hwdep->dev); + if (hwdep->dev) + put_device(hwdep->dev); kfree(hwdep); } =20 --=20 2.43.0