From nobody Sat Jun 20 17:33:36 2026 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7D7A292B54 for ; Sun, 12 Apr 2026 16:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776011791; cv=none; b=chveu2sscq82qGengfMnFWina57H568owb09s7012l8h/iZdQjSKejA558fVSnVrtoKzvmh3Znx3uDvJf5yl1Te64pn4zzlYiQfDIVA8Nz6DjwucAEqyvm7IafJLM5F1IADaNA/JGAq153IW13K6xNmhZGDBkr+koyPICD4jSHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776011791; c=relaxed/simple; bh=QrDJhhk0twAoCgQb0RphuWTv0vbxFxQEpBvzjFSkNow=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=lwHQC5zjOvKspgPSKUp8BOPtA5WoPfMhwdcQsycPyZJ0xI8ya94vVOv8+gK86/Yo9ZUM+4Dhqeij7SGFLo7+zkpF3aO3ADy6ni4EX/oLkpaSfhxZLmmrvfQwEElaksFSzioSPd8aFbJFYmzeeiWg3GHqOQ0gtibr5RtuZ8oz8Hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l2mATZi0; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l2mATZi0" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-1273349c56bso4663804c88.0 for ; Sun, 12 Apr 2026 09:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776011786; x=1776616586; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/9Q7XW5fCWd+W/KHOAvk90/HILYyws38daEBVyb/sVw=; b=l2mATZi0OrSws6PqfWE9zYTMpcD/sk6v7AL/1rpXpBrt9mrSqNHl0zyfeRWEhThVsm sTazkxNvRBdTLFPCTLoeqOM4tREWA1ZBmSzuXWk7W/+bMcua+1ESpR/DY5V079oZqJ2+ GMnXox604nGvG2Iy/deES6RJ3TaaIBY7DncGkMetI9ZWm9fSgnTeDb6tkfiNs/z0ZLOr 2naXwW4cQ/Rmjk0wWHfdRTe/+J4tMJrvAJ0xEvx/6FU/VDEZwvmJPZXgCQ+gl/dfLek7 zplPDL7Iowg7HVGhPDFXVuFhY2ce4PrZzOjdaFBE5sISUW1R5LBZghQn6mQCAoyPXGva iI+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776011786; x=1776616586; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/9Q7XW5fCWd+W/KHOAvk90/HILYyws38daEBVyb/sVw=; b=e1THlT+QcWYxPwhVUTw2x+B0QJtlB1+F0J1tV5pRcfUpbNlzJ0+Xh9W+SOmSBd81gE JpVgZ8ScrVV68wU0+wyhOZgjR6uQN7yQdSnJyAzNlreuxowcGy4E43IgZuhXy/4BgMFZ 0Y0ha3EVQDPHtN9KNLmWvpB0kAf36YxjlOHLVt7NqY0URtPmsN9ElguFfYg0Vkf3ouuN xBsSesBCEzHp91BJblgEY2KW4iiJpjutK6sCK/nMxLt1us4NOBPAtV3IV9wl9BWT8F3u /NiUlfjqL74jDTKFX//jT4101AxpFTF2eOym9NKCK/VZ1nCQZ/siVS1507VRijbOvFzF 9JJw== X-Forwarded-Encrypted: i=1; AJvYcCWHb785cBdcqwJI1JQeVDThxk7XLisbRvbPSWWzK+r7eMqfw5QhdSvTxYxFumxUiVbM/K/WfQcUMK4+aFE=@vger.kernel.org X-Gm-Message-State: AOJu0YxUXLxH7kYp17jnleQwrc+fLUtkjTiKUQvoutatDExIzTlxYPG9 cY8oHT/ruziOYmNU8gbkwU+96dsPYYj8cjQOwtjh3UcM7v8KW7J1eHun X-Gm-Gg: AeBDievH0+8oGLdxdjn6yXcpQqsy/gXl2B0etAitq6BodcCQ1CZzKsPZucYp0RGRhvt +w43JASmMSKDSlg3h6az8/Q2MOoFKmh1HR/SIVjCSNwFaB5xetay7XZn65cRW9V4HsQREUscnqH ycKubhI3ZKtkmjyfaW2dqb2fCGu76VAaOixntFhtRuSHmmP5zcaoUvWRvc7lDm+GPPHHyUtbMYi I5hGkh2uSpvUU0v2kHvSeRjX6fDuspiJ+lrsn0dYV55N2zSqrvv8+jARB+nZa36a2vIsYnL5l12 hqEWDnKR0AqOHRsPcd5wbBEuW13YsIpJzui6Ix+uG6Hv+pyZfs2gRXNBCgYcZac1lFezQpwNHNO 8swVtsodL9aGf+eP13GF5nbAqGtKRfYphWx/f0x23iGx6omPNxukvhDSwSpg2DfaGRub0hqYgOC 4DkPfTtDBd2CVUmDHX4clrEmlbVTw9IH4VHMKbEwfj6PodGtzfq5c74Qs= X-Received: by 2002:a05:7022:6a9:b0:123:3488:899f with SMTP id a92af1059eb24-12c34f14188mr5695800c88.32.1776011785777; Sun, 12 Apr 2026 09:36:25 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c34acb077sm10201730c88.6.2026.04.12.09.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 09:36:24 -0700 (PDT) From: Hungyu Lin To: thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path Date: Sun, 12 Apr 2026 16:36:00 +0000 Message-Id: <20260412163600.29925-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" tegra210_csi_port_start_streaming() enables the CSI PHY regardless of pg_mode, but tegra210_csi_port_stop_streaming() skips disabling the PHY when pg_mode is set due to an early return. Remove the early return so that the PHY disable path is always executed, ensuring consistent teardown. Signed-off-by: Hungyu Lin --- drivers/staging/media/tegra-video/tegra210.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/tegra-video/tegra210.c b/drivers/staging= /media/tegra-video/tegra210.c index da99f19a39e7..57b5da11da93 100644 --- a/drivers/staging/media/tegra-video/tegra210.c +++ b/drivers/staging/media/tegra-video/tegra210.c @@ -1095,11 +1095,9 @@ tegra210_csi_port_stop_streaming(struct tegra_csi_ch= annel *csi_chan, u8 portno) (0xf << CSI_PP_START_MARKER_FRAME_MAX_OFFSET) | CSI_PP_DISABLE); =20 - if (csi_chan->pg_mode) { + if (csi_chan->pg_mode) tpg_write(csi, portno, TEGRA_CSI_PATTERN_GENERATOR_CTRL, PG_DISABLE); - return; - } =20 if (csi_chan->numlanes =3D=3D 4) { csi_write(csi, portno, TEGRA_CSI_PHY_CIL_COMMAND, --=20 2.34.1