From nobody Sat Jun 20 17:35:19 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED6018EB0 for ; Sun, 12 Apr 2026 12:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775998539; cv=none; b=SIeW8NGNgsqb4DMbesCtbkLHoB2uxOGQJL8mHXhMar/SAdXJN0PIjrMl1tGxYkB0xSH11L33Ic0NwpWz74k15yoKIXXBXqLMSrxWxPMR0krPtK/ukAunFtZpxk2jPn1m135qT6RHmU4Vgg373zF5bXOpYN/ruouXF1+liWR7SMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775998539; c=relaxed/simple; bh=YdktwupOCGYDsXBTCp/6UncgNDvXr/nreRmag7N1hVo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OztWIjh94ACaQUjXykVd2vRZ4e9vwSG3oys+rPdxcJ39GAit5SqXqPBggeQwYYewGj/fT6a97cvjeSBp6jW/wFLlNFNScUah4vvMekP/2V0Hsj4TOg+5sZDQJBQKA+4WRr/3YHAsJVFfNvMzichhwiG+hlN+ertt30AKe0mb5ZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bVcqOo8J; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bVcqOo8J" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35dac556bb2so2061808a91.1 for ; Sun, 12 Apr 2026 05:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775998538; x=1776603338; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qxOe3LAamwoRd6++BiNK2MTql5chiY2Vdpn2Z4OwuWg=; b=bVcqOo8Jvoe1L6QXbziWmAhyWrgPxr9lofUOovJZ14okenwZV2HnMHI9rE6IidT/sZ eIyfhxKw7LZeSDrTcD5lNQa2M+7ietcMLu8rk2kpe/dXz38lWuvRPb2rXwM6WSinCS3n X9Ghg8oBlW+WzX3cQVtcMrXs8d2oriYceTQk9LSuQCxLalN3bhMkUBLcjhLRaiyFt0wn 5RVpeDyfZAbE2qrkvM1QfpHV0hUOyqaSQfz2xL0jg+fLY+K5I1azMpqLbgbK/EAzBIPT rQKsSMFXL2e5buL8JxZ3aBlNwftpypvdmB0r47tIZ++YjWxsHxTbc2IomQJdjLhD7n8z OA6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775998538; x=1776603338; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qxOe3LAamwoRd6++BiNK2MTql5chiY2Vdpn2Z4OwuWg=; b=UgdRFIVLTgA8yRi/s2hkGTan2rdt2PauZUXqVXVCugRAepOiWhVtc1drzphsxSAcv7 hFWfE3K7LS7RxypAqIlbAdApnGkpe64uHfhTPGhNupKPGFeIdKIXucG6QPOYj8D7CXDG AVvfeOmYzemyIkfwm5ORodpkkEWZ1XzWpQ4eDxdzHeZqQRqP5KrYBrX/SdJSzNxZ7jt9 tBcoCX2sIO3kkxdSbM/E46sRar5zJ9K6magWuDeeTDeJyvWliwb/O2J3EA1hEnaAtF2N ZWGZtcT78gb+YL45r2NHCyxXUV2u8n+aKTDRpfsKYsZ6PcSj80f+F2jgXbSJD4YgiVdQ 9NwQ== X-Forwarded-Encrypted: i=1; AFNElJ85aiNWEwD59ZvEF1sAdyUmi0Dhgj1GEam8wyyHAxCM+XWNyg8D60c01hbce8oUznCbiBPYC+7Zj7M9b3Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzOvUBFukxvbIHN/U0r6eAM54kXOD9S3x1WPKen2B5mUAVZ5LrM ls2ixqaN95LvowQawp8k9ALB5yi01XtsFs/z+iX5x//m4Imqd9VEPAF/ X-Gm-Gg: AeBDieuLJAGpzuI/6eBj05DJhNlgbGqXknm73/8gi0PKLSEA7jlp3f+6JfrH6yiXvY6 7ZbkxauQ8HXYBvpNiDvCvl6dToj4Jz5dS1if7xsUOTBWzLvJibkDFviWmsffn6nLHAWnLj2339H TPBP6HJOed5XeTEIKf0j0mEHrIe+MoFq8z58OI+aBZE0UUOeCNcR7cAzSWDxQSDBXlSddJmZxrJ 7KGSZZLHZYd4pv1nYDa+gkpdm587s9uTG9e4h8gbpym6LISqTudMtwltR053pW//5MSe3tVXhfU Skw4XSjTb51M7j3yHBEBkYbu3vI2nZMVwSMa6U8jd4MHk5HPYHZGqMqMbUUXr1XTHFcGV0Prv/z 0/3mQ3v7amL5lnmMhbLijzs/gbnAczWckL2Y2uzbuvMn2j4IPaQVqjBZoqMtgT2wamT1ofgOIH8 j5qCtdOz9vQC4sqw== X-Received: by 2002:a17:90a:1089:b0:35f:b1ad:fdfc with SMTP id 98e67ed59e1d1-35fb1ae003fmr1164183a91.27.1775998538284; Sun, 12 Apr 2026 05:55:38 -0700 (PDT) Received: from lgs.. ([101.32.189.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fb1ed394csm1481298a91.11.2026.04.12.05.55.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 05:55:37 -0700 (PDT) From: Guangshuo Li To: Emil Renner Berthing , Hal Feng , Michael Turquette , Stephen Boyd , Conor Dooley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] clk: starfive: jh7110: fix memory leak in jh7110_reset_controller_register() error path Date: Sun, 12 Apr 2026 20:54:50 +0800 Message-ID: <20260412125450.2509092-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" jh7110_reset_controller_register() allocates a jh71x0_reset_adev with kzalloc() before calling auxiliary_device_init(). When auxiliary_device_init() returns an error, the function exits without freeing rdev. Since the release callback is only expected to handle cleanup after successful initialization, rdev should be freed explicitly in this path. Add the missing kfree(rdev) before returning from the auxiliary_device_init() error path. Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock drive= r") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/clk/starfive/clk-starfive-jh7110-sys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/starfive/clk-starfive-jh7110-sys.c b/drivers/clk/s= tarfive/clk-starfive-jh7110-sys.c index 52833d4241c5..55cd0ccbdb84 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-sys.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-sys.c @@ -360,8 +360,10 @@ int jh7110_reset_controller_register(struct jh71x0_clk= _priv *priv, adev->id =3D adev_id; =20 ret =3D auxiliary_device_init(adev); - if (ret) + if (ret) { + kfree(rdev); return ret; + } =20 ret =3D auxiliary_device_add(adev); if (ret) { --=20 2.43.0