From nobody Sat Jun 20 17:33:40 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 518F92701CB for ; Sun, 12 Apr 2026 12:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775997783; cv=none; b=jAZmuItpRDhxB5aiNPrUaIUOdu0cVFIgmD4A57dRY2ML4WcCaJIT6Rs93SRlneQjN5WZJEwj1mX/Jk5TbBqFS32GxUMtmg7uVfwXhz/VVWA4hvDHbkSGnAxJgJR2HWskFzWKaYLHS6oFX+0YvTuVMZ/lg9xUfgEzd2/CrHDiL1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775997783; c=relaxed/simple; bh=j/V6kvnhuhlsoN7ZuzaHKSXaC7u5794AySSBjPax8WU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NPtLAG2acCrk9AyVHhFn3q/v0GqXEB16inguvraOZqaT0vg5sM4ZhGlucP9+HQz8m4KoLF0jI/yu0azqIEOorMyFkdh48HOhdmli6+2980C+8F1hgA29DZRdoHnpSRPqe0NUZfQ6+ScvPt9/ourZco9lASHNTt6itzqF2/c6tCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pKUdFXdD; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pKUdFXdD" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so26825475ad.2 for ; Sun, 12 Apr 2026 05:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775997782; x=1776602582; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=g7QWVaN0FaywpyGDYy623KiFtyqheURnD6LA050XwQY=; b=pKUdFXdDd9q4VYszMsiDUGcF60PQh6qKswjLPkSMlAdwpTumb7hBDM9nM1xAOWlpNg JHdZbEYtoP3RXLuqOa//BpETu6XROLM4eq7gRgx6bqTidkCfj2cG2m8SSFAevw4/OsJm A9nmPFkleI+inT0oeVFyGPMFmKiSleyaD0BKwHkEZd8SXJ27jdFabHBztzrDVArRE7Dj KDQd1aHfERhHU5Sic5cdQC/pGmhOrZvDIOu99PEwj5iJ9jIEjhilG7Q6mCOQbp164rT4 N5xzCdUGiwMDly+W+ZmUKujm57pdVcq28M9htwxnIqKf6xNCf/9EMbZVjyr2RMSC2Vbi GweQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775997782; x=1776602582; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g7QWVaN0FaywpyGDYy623KiFtyqheURnD6LA050XwQY=; b=K6ct4EuF3o1LQsVrFf4+66bmpb5WVZm+AT7Tq8sDg8BmHjdi3Z00Q6Pu+AiFMn8K23 fyi/elO/72Eot017hPSxRFbE68qB1KrxrMfKHe8I/oPuosuZ1yszA8cyq03YIE3Aufg6 pMGhUQK7daFLrBOKaLwXOQ1peKUjxkMokEvEecAOBE+z3U9ZwkmCanyYetj1r6pIPZm+ BnKbD4ISnRUezZXpqFphifBzmILhQ80lmBvXBjU14RDaErC72vRokdqOOA09CAgkyUsH 8BNnWylXu6Eqz/ExCbfIAtYRYDHpzqz//dkmU5B7gw9NJvnG4MFjMBXFcAn0C9ycGo2F CwSQ== X-Forwarded-Encrypted: i=1; AFNElJ9INk7hKJzT5lGGf/gfrdRbwBuru8dS+V5rlgCtKkQXiU5KCX0zouekiRg1a8QUSz4GlYVu5vhaFrT9kzA=@vger.kernel.org X-Gm-Message-State: AOJu0YzlYUOzCBt00ahiLOP8nbHkRsg+wxflz+Lv4lPlh+97Wi1m0+b7 lG7w3EZVCa/wV7ZvS9+HvD54L+FlswK099BOMjueXNhubq5OrYsG9K83 X-Gm-Gg: AeBDietpFLKr6vVSddCnjDRcMhug90V0DvgOdwy5rDSBqeYLJXf5UgVCq1AyRgYvmqp bgFBS6cOEw2ZNKO2g2lCNNr5mEci6bcJm7R596oaNztq8ryGzmsLcy1oVD306LCo8spLqlzNztp Z8RaGNvAfqvSxqrfvEPhfupsD8StcqQJzPZJFnHZ7XxAnnt5WOBuuXE90sFLfc1uu9A9LO0RIb/ /wdaXs1g8azBH/nDKXTh1WYF2rkR8XfMnRnAOJNxxyEC5+MsTuunzpGEj9myp9oCncNM1+SXVaT hk2aLsGs8IQpQKI24YS5XqRPX4d8QtE50K4uUUhBWoWIu3WfKF2x4lDCDACxNG9WWbsxqYIuetl kbJ7/HeMEWwaQAfRy+QuXTod58OQRtvPiHf3P6CCzffSDDURD8JMT5MoMK/aWx6k7LqO8R3QkV6 lx+3pa5+AJYFQ/zA== X-Received: by 2002:a17:903:40c6:b0:2b4:5ddf:24f with SMTP id d9443c01a7336-2b45ddf0454mr4606985ad.10.1775997781786; Sun, 12 Apr 2026 05:43:01 -0700 (PDT) Received: from lgs.. ([101.32.189.54]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b45cbf0f87sm7731895ad.6.2026.04.12.05.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 05:43:01 -0700 (PDT) From: Guangshuo Li To: Vladimir Kondratiev , Gregory CLEMENT , =?UTF-8?q?Th=C3=A9o=20Lebrun?= , Michael Turquette , Stephen Boyd , linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] clk: eyeq: fix memory leak in eqc_auxdev_create() error path Date: Sun, 12 Apr 2026 20:42:46 +0800 Message-ID: <20260412124247.2494971-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" eqc_auxdev_create() allocates an auxiliary_device with kzalloc() before calling auxiliary_device_init(). When auxiliary_device_init() returns an error, the function exits without freeing adev. Since the release callback is only expected to handle cleanup after successful initialization, adev should be freed explicitly in this path. Add the missing kfree(adev) before returning from the auxiliary_device_init() error path. Fixes: 25d904946a0b ("clk: eyeq: add driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/clk/clk-eyeq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-eyeq.c b/drivers/clk/clk-eyeq.c index ea1c3d78e7cd..a48ecec4c9a5 100644 --- a/drivers/clk/clk-eyeq.c +++ b/drivers/clk/clk-eyeq.c @@ -346,8 +346,10 @@ static int eqc_auxdev_create(struct device *dev, void = __iomem *base, adev->id =3D id; =20 ret =3D auxiliary_device_init(adev); - if (ret) + if (ret) { + kfree(adev); return ret; + } =20 ret =3D auxiliary_device_add(adev); if (ret) --=20 2.43.0