From nobody Sat Jun 20 17:34:33 2026 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFAAE30E0C0 for ; Sun, 12 Apr 2026 12:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775996805; cv=none; b=Zj6LdyUF11LrJ0XQmVaN2Qh1aJu0D5UeSIcqlOc7i+N56uqy/cd7MOttYZXvRCl42b3MML9dhEbLuxwuZHBTHPH5jnpNVBFV/p9zGAN0hQrvrmjjQThDySvzVTg6ixmHdRbhSQlN/OX5MGEkq102OJcSxPniKY+G0lqIpTZq5DI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775996805; c=relaxed/simple; bh=5PH6HgTFfPOB4nkrcwcyggoXwvHL/fdGKGMj2V4rxX8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gMik8aXLuKfhJ1PZzcTZT5TCAcDwSQQzDKuIIQFI0O9xwm4vGIZxYw0n8gElPzwNwZyztWWkVExTaZ+gPpeZy1okKT48Y89Pv9IK2OIpwONrL+431hu2RWrUNMm+25vD1LTTPmGBgrTQYXPOKZ2jaXolhoAe2hhnahZkcAW9PcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EJFAeGyX; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EJFAeGyX" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c76af7b0f94so2377951a12.1 for ; Sun, 12 Apr 2026 05:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775996803; x=1776601603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1LE6huvR6spyj6pXFbXVnPFFoN9AhuKNeTxygPGeaug=; b=EJFAeGyXF0Ln65yiUZakpPVMHgMpUdVJLp/ZKH22pjF79EBqMGgh6roZLzq242V24B YqolMT0w3BBe4fhAh5+O4bF1Cq72JG5DmCnsUuTXAfHxaJdjx3KOWaGqkXWcSkzMXTdy mUdw1OMWBGMCJ3f8vnAk9smtl9EzIk03XhwEy0qwSkzFaNygQhfj1uV71gGUk1SuwIig C+DHZWJk92Rl4nT+HWV0kOHwp4i7iD1W0YSoLcJogdpEHprxOnywGXzOCJseIe9wppUW Q1MToGvUUD/TpVbvpYS6Id15ix7LwuuCFnYNzep64XmKGbYfq4PzZmp4mTnxjBXG3ChJ m+Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775996803; x=1776601603; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1LE6huvR6spyj6pXFbXVnPFFoN9AhuKNeTxygPGeaug=; b=UY6KXHSj6gfS2iIuKbIQ6S/P+MtReg5QHyRlZHihAwqS/L0UCp3JEieMnNhPgRnpIX VRnhQhnEdZcv95uIsu9KWw38BXvzLSI0M/4aQWNp4oYZC8f7VGRBlJ9pgKwY3iVlUJze sPouHFdiVlrXPtjk1mjpBXHeNPuzEYaAYlGxZJC5pDdv81yAcLyclQCv/kr5lKSDSXc5 GfXC9wGeWR/5zGvaG1sYdZNn26EMkIsIlSUbVaN54+0rsxYxrmC0iAwGK06l9TgTbGEA 8AuO4uQva66m4JfNCimSdXwzZEttjr3rlZk+N7nsIf0TAsXot8pJvl9hU5sSBM1HzWJ5 B+4Q== X-Forwarded-Encrypted: i=1; AJvYcCXpfbt3sew2cn+PZpfVaR0LR9kVL44pW/tnhXwG3w/K1Wc6GdGlHgLgl56OhfYwR5azvlcnelbj4WePUfo=@vger.kernel.org X-Gm-Message-State: AOJu0YwfMW1UF0injXQxLL2Vz5livh22gdGhDVXDN6Zy0Hf7r+wMicGQ mtsJcPfcDP8oeocM502dXiBYXcq7J0gUSyX43Z+0Y+ZnlhN0nYQgxv6T X-Gm-Gg: AeBDieuC3YXzYf5OgRbs4Qo3ER6gdqJ8EGxNBYZw0Y2EEGub/jid1ThBUpmDLwclqnj 3Uzbw4Kfr8fb8ptedl7qrYucYV9Bad++UhmsA7L4Qx3h0TsWZaH43Tig2eItQnECK+w1KYwLlJT v/ZzswVTnVOxA7RmU9IEG4DuBh9w2W3/rWRYTtesJmTrGhmSYzn18hKYUCzfBDDUuTLvEE+Wkti Gp5/jgEdYrYeSAnP2x0z1EVoScxHQKc8zXbj5rHpGj8nuB5AHTT3exAfY0fMUEZU0d29GDoWhzq OGycl6PGzo6PLmleRLzpTDmnea73nEaxbhzRyjTNDTJrHmScB342JKH77Zn7D6wOkuai7XIyeDA LNzjpiMadYpsRxQdsK3EV3nfiSbsPSwXSAK8s7QgDSxwAz4S5r8Lqhe5flr+MSuVJ5TYOZyVTDA G9j/sYiw9IUzL/bA== X-Received: by 2002:a05:6a20:1592:b0:39b:e789:7d20 with SMTP id adf61e73a8af0-39fe3ff14c3mr10951914637.44.1775996803341; Sun, 12 Apr 2026 05:26:43 -0700 (PDT) Received: from lgs.. ([101.32.189.54]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79218fc462sm7633431a12.8.2026.04.12.05.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 05:26:42 -0700 (PDT) From: Guangshuo Li To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Sean Paul , Mark Zhang , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH v2] gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path Date: Sun, 12 Apr 2026 20:26:33 +0800 Message-ID: <20260412122633.2487800-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_initialize(), the embedded struct device in struct host1x_device should be released through the device core with put_device(). In host1x_device_add(), if host1x_device_parse_dt() fails, the current error path frees the object directly with kfree(device). That bypasses the normal device lifetime handling and leaks the reference held on the embedded struct device. Fix this by using put_device() in the host1x_device_parse_dt() failure path. Fixes: f4c5cf88fbd50 ("gpu: host1x: Provide a proper struct bus_type") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- v2: - add Cc: stable@vger.kernel.org drivers/gpu/host1x/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index 723a80895cd4..f97567e6ae87 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -452,7 +452,7 @@ static int host1x_device_add(struct host1x *host1x, =20 err =3D host1x_device_parse_dt(device, driver); if (err < 0) { - kfree(device); + put_device(&device->dev); return err; } =20 --=20 2.43.0