From nobody Sat Jun 20 17:33:50 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B468B36A01E for ; Sun, 12 Apr 2026 12:06:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775995621; cv=none; b=ujJcfqHMfXmM015jD7UpwCtLCLwj9TEAxz0TTJl89Z74iB/2FaykD0YY/Y2cP0zIcJXPJIfIFj4H3T9iaeLXS6++/ONszNEG9pg747WmeUHK1WiW6APgiVHu9gdlPXcPvZ/pOFkhgtxhW6I96u6JNbb67YxxXxeRYP/EfbnU2bY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775995621; c=relaxed/simple; bh=oHSFf7/X2Ol8/Td4EihiLGhPeRmAfpxGq7jBu/AYfoA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NmBlYc7RInWp6a8y7tMu7s15JHE21jwwzMNm/14GCdxUIsK3A98BeU+2vUZ9sr2Kx8xytwuCWWLfF2t+lWYIkg7FjK2bAEQ9rNOfpxPzaUeYTJ3veuWm4BKIUlwvtXPPliBO3FelZOufp7ibh+rAi/zjMcYndZuu9TBJk4sSQ8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZX77l/4z; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZX77l/4z" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-35fb0bb27e7so225438a91.1 for ; Sun, 12 Apr 2026 05:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775995618; x=1776600418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=96a3K+dWsyVQ0u2hcswt9wA9QXsiax09F0/1rMk4SCI=; b=ZX77l/4zvP3c3+vlwmo1IT3/BF21r8ab31mOtD/4q54D3KC/NDCPjGTT/108Hg4HIN M3OQM4Wk/wYp3AXLgdbzOgLTEer70HiN9Wa3VpoZ8u3vVl3UvUrmGtQmVysHPs7Eovil NcMbcBQvP/eu0FuUgEFonjVWcdhx3T5/ZUgir2g5MYesjcxtS3iaHsDnuegzEeNQLf9B P+1iIDuHRIn8fknTr0/TBGb/bkXLv9mwotLGbJGvKf+YPbHecIavYiFyV9e8HQQyljy6 eI9oJ8vMDUu0eOIU2m1WG9qTlmdJGYyVMhxiHTrt2dkoSEckkd5OzG/lhtjqqf68MpFZ rQPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775995618; x=1776600418; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=96a3K+dWsyVQ0u2hcswt9wA9QXsiax09F0/1rMk4SCI=; b=miKRNtJzDrpP3CMosMkoBzYnLWxRRcLO+xDPQCpNYF5+ZN29Xmy83jLaJcPAA9vPbL BQuXxPcdTD7PRh3Sqf33ib3ur4wFDaWYfK9Lck35dHe3JGq7sQdQc7XFJeigRIsCDdUz KYogK0+Gcu3BUkXT7J5YYpeS6nZz57vuqX471PfyJAnw/EBmPdDXBv19A2b1dhxpB8oO bh1ZFrOoz7hUwzpa4wAoebasAEWO6B4bM1Mueg/edfFLEERgU4kmDw4X21QWItyTVjaK FVMKU1RHhJf8iqylOEWdg4SBcOSxn//M89OdKyawLcS9gKF3SW26lz8RrE8GkrMvpcWF 2iIw== X-Forwarded-Encrypted: i=1; AFNElJ8DRrLRCsvlgOU2vkwHKTZM9nDjzRcHEXFYQKjFsgCy375ZKlf+8h+ll8Ltu4wn33pOWoi2piQtcB0QOho=@vger.kernel.org X-Gm-Message-State: AOJu0YzcENdnxHF/8ZvG6AmL/+fYo/m/sMk7gK/lwFYLq7XCqnNDMPDQ PuXzsSHmfkzpzWShfTi1FmuorIF5Qddh+aDbLOAk8q8nHeRn6MQH7MIw X-Gm-Gg: AeBDiesGgVSI9F6Y2Kfync/NP7aq5OvEsmfrlGE/QusCLVKDc7SyGLqwnmjONf/v5aO G2BBv/SZwQST7dAWoy7C6RybEN/QdAEzZvBp3wiP2lTYYMfdnAGWBwGCDFWU6FLpuXYcQok2ZKP /d8KxfkVyBzRIqCBPL7Qo1JAl23N/PEtALd8NP1SZRlly75yM9x0k41Go93nABQtHZEL77KBixE JDrsXn5J8ZwiRgM/0XYoidzJgGQc4yxpE1BcQ9YnNnMakzaO0TmHQppzpYlMDRVRLOm+jP3N4fU FEcbYnkJH93uuNbuPK9d1HjtT6mrVpti7IhHkJ0wMfNuUVlJqPwCUWKs0HMMNd5ajbLrfPCTwkw 7Jx5mhSxm47jHE6lCjvyZHWTrmUsgIzOMEvFDoVpMKr9W4tpY6QYoEn4bjyyRdVrm3zZhGQMh8N oYUZ6ZxrZsDn7xD7g= X-Received: by 2002:a17:90a:ec85:b0:35d:a542:2dc5 with SMTP id 98e67ed59e1d1-35e4254116emr9347519a91.2.1775995618057; Sun, 12 Apr 2026 05:06:58 -0700 (PDT) Received: from lgs.. ([199.182.234.55]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35fb617725esm144261a91.1.2026.04.12.05.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 05:06:57 -0700 (PDT) From: Guangshuo Li To: Thierry Reding , Mikko Perttunen , David Airlie , Simona Vetter , Mark Zhang , Sean Paul , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path Date: Sun, 12 Apr 2026 20:06:43 +0800 Message-ID: <20260412120644.2449624-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_initialize(), the embedded struct device in struct host1x_device should be released through the device core with put_device(). In host1x_device_add(), if host1x_device_parse_dt() fails, the current error path frees the object directly with kfree(device). That bypasses the normal device lifetime handling and leaks the reference held on the embedded struct device. Fix this by using put_device() in the host1x_device_parse_dt() failure path. Fixes: f4c5cf88fbd50 ("gpu: host1x: Provide a proper struct bus_type") Signed-off-by: Guangshuo Li --- drivers/gpu/host1x/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index 723a80895cd4..f97567e6ae87 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -452,7 +452,7 @@ static int host1x_device_add(struct host1x *host1x, =20 err =3D host1x_device_parse_dt(device, driver); if (err < 0) { - kfree(device); + put_device(&device->dev); return err; } =20 --=20 2.43.0