From nobody Sat Jun 20 17:33:50 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E437E7082D for ; Sun, 12 Apr 2026 11:38:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775993913; cv=none; b=lp/ZqagQ0MpoJ4NZ3r6OgguxK5PokQo2uoUO3nHcbpPqTmOK8lqmfH0t2ceoYsdmaHmYr0U1dTuMelGi0aMuMcuLhlg+FrPsnp12RbEf+1h5xScR2H1Hk86whCyq7uPt5HdfDc0Tq1pBXf1Hws+acMVTurE9qcndobpzDxzC4Hc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775993913; c=relaxed/simple; bh=qR+WK0jjMPmav4QyFJaS6gFDNswPcBduals7hFU+fWY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=uYWyW5LW+k3sfRZ34AU57MUcKd8polfUSCwuNx+QQpGADprRT4z7sIrJkJiqPJ14l1EUcB5Z7VvHW0iQIe9srHK6cocyhk/xaBfa0nLpGNhwMZrSmKI6U7AwITGN5oLNKM4SN3FretwBXEy2ADx2U2nClBR3X+DLpq622FEB9mc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bxSoAhmU; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bxSoAhmU" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-824c9da9928so2501684b3a.3 for ; Sun, 12 Apr 2026 04:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775993911; x=1776598711; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=iAsbeYjH1O3Lwp3qBm1L+sgXvi54T6WTkr5KlroxCGI=; b=bxSoAhmUWUslpdlqRoyyWIJ29XXPe7vI7+4M91WajZP4FUcx9aTHRxFTLD8JDiXt0v MfbuTwb0pSK1U15Gojgt6G6Jr2fL9XHkz69YVheaiqdJRrKn+RSkfaRhDrKpv/V62JKE alO6ImhQNnG96mxj0yVFBCdh9a5vD7Jl5XLBT0MetdDG6ezjX4QALjIIzmjhu38SuVAD ceUfOBbhq0932BocZCEo0P7ercoMLzaqG4M+nJFWCCWn4uTVET5JnGzrI4FiDRwFPvDM 8ESxCm9Jn5zr+1wzhTJSyl8ZvUfpM93CoZmQ1QEwenVojZDom9FijITcQzyJgMu/UJHj YW+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775993911; x=1776598711; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iAsbeYjH1O3Lwp3qBm1L+sgXvi54T6WTkr5KlroxCGI=; b=ak517QgPFGXqQbKPyhSAVYqYTaBmInfdU778U/qz3SIEqOb4ywW/Dcto8JeBVfNbSl lm8SzGlIqx0t4fCPtd+AuFoFZrKO0lf2Qlbkj+we5xOlBDq1+8pgOjvuj3VnlTC4KqLo VvI8kM6LhoZJ4L7Xsco/XqMLm5mWskI2pbCYwhx9YvzWTcaRa9ODq/SAV384CSDKEe+X VAKaR7gORnu4dxRLmX2oo9wq5QeJjX9iCNBpYT99O+ObBHmaUGKdQIWvsi1goOuv6Cwi iFe1n9DRESQ6AoIE1a+FkCxrKabx67+wVUYUJ7vUTKEMCb3GUA7sq+rFQNRO2RBqv46U O18g== X-Forwarded-Encrypted: i=1; AJvYcCWcSyA2aursLOPWHMwCw/2I1p9scDQMGLA+lc+4aV6ZV3Qc0G40fhaHTDdGxshyEzxAaM+lfft9kEIr73c=@vger.kernel.org X-Gm-Message-State: AOJu0YzRRfVLJMrSn5i9XWEpgiuCDxnf31o5x9Sz5qptbD3GTyYYRX6n DNiJTtc7IB/FYQv6yPv9RUKUT8Bg7JGFrxEpPYyjnu7KfWoCo83d7rkESRfMkwIpncM= X-Gm-Gg: AeBDieshsO/AEwu4IN3j2ez+FxN3XF9IwGFh9ZRYeq6+6pBfW25nFu0n/OfBkYH9puE OcX10DMNdI+M1P1dKg7kb1CM3ry8qeHF6vcNsq4rtaa3tsMTncdfGbl+FyipyAenZQZTUYcHNCR beaOe45G7P8zMzq5bFwh5iWGeMgHTAQGvXtoZNfZbQOMujc3iVpJ0s1C0VObta4VCwORo9mKvQ5 kM2T7/j/AQSM4D7ywBWKzuS6+ITmtv16zFXRnmyQcTcxpGzernqAmiJhlhfn0aUQw7jK6O5zT4L o7Md+tSh9J9fhjM7Z6xWTSyLmMwCej/ZXHYUHYx68cc53ob8dMA7bDqspPxV53c6Em8MiN/HLQQ l3UscS1RM8LSM8kaufvzuBQHiONbXdVGspR4shMax170cVRJv7cEmlYsYL3M/bTl3ZkgaridZ9Y GTByNf0zS4ro+p0Wr92/G5 X-Received: by 2002:a05:6a20:c515:b0:39b:f750:a6f5 with SMTP id adf61e73a8af0-39fe400f748mr7735275637.51.1775993911331; Sun, 12 Apr 2026 04:38:31 -0700 (PDT) Received: from lgs.. ([223.80.110.53]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79219c4a97sm7644180a12.19.2026.04.12.04.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 04:38:30 -0700 (PDT) From: Guangshuo Li To: Guangshuo Li , linux-kernel@vger.kernel.org Subject: [PATCH] edd: Fix kobject reference leak in edd_init() error path Date: Sun, 12 Apr 2026 19:38:20 +0800 Message-ID: <20260412113820.2440982-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" edd_device_register() initializes the embedded kobject for struct edd_device via: edd_device_register() -> kobject_init_and_add(&edev->kobj, &edd_ktype, ...) -> edd_ktype.release =3D edd_release() -> kfree(edev) So once edd_device_register() has called kobject_init_and_add(), edev should be released via kobject_put(), not by freeing it directly. However, in edd_init(), when edd_device_register() fails, the error path calls kfree(edev) directly. That bypasses the normal kobject lifetime handling and leaks the reference held on the embedded kobject. Fix this by using kobject_put() in the edd_device_register() failure path so the object is released through edd_release(). Signed-off-by: Guangshuo Li --- drivers/firmware/edd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index 55dec4eb2c00..82b326ce83ce 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -748,7 +748,7 @@ edd_init(void) =20 rc =3D edd_device_register(edev, i); if (rc) { - kfree(edev); + kobject_put(&edev->kobj); goto out; } edd_devices[i] =3D edev; --=20 2.43.0