From nobody Mon Jun 15 16:27:43 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2297E1A5B9E for ; Sat, 11 Apr 2026 19:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775934210; cv=none; b=eccnqH/phMRmXeNTllXLnM0tAL6oG1qmGXFjZjaHAQlr9lEjm7RkgaQbC96oyrpO/g/ABU6ph7mkshUK7KNc0RyXRyMA+qyMnL7wBwYejnlUHcLjdpwGYq0qxybL8GgjrNlBcP5bkK31LUtEJ/N6h5usFpIeTHQTmdAmYxAOQaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775934210; c=relaxed/simple; bh=HdJtNYVZoBcseIrEtuqZHe4dtTSU6Ka5kLHKaWeLYmo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=anpIZULj9lHADBScxeWJQckNwNJUANlFMID5jvyFJzoxoiiakweUDdv8n013Kxjjyp5TtLTe83lM05VAevGo9FigIwO1EBsFt+7Qz/GmRogNIdC8aCcEYa648Ge9SBSHCX9Dz9q+Lp5kMU5o0zm3YV9Wy0WdNThr4BdYBW/HfGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hSsQHBWT; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hSsQHBWT" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-82cd70febc7so2093069b3a.2 for ; Sat, 11 Apr 2026 12:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775934208; x=1776539008; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SZCcfd2j80fnOyI9eoqdL6EvakDEWReMcJQ9OZ/rF64=; b=hSsQHBWT+QTiJ6HnPR+eM+YFMo9svBQcINrhj2wzomNbXgE4EzBepYzconZ9D8zslf 0oJZ6i0wlcN/n6nEmZ9zoQjQ7SSeZX48ERurTHyjN9jqWWn0FRxYNKz1VybWy+Hh+j0i twxZAj/r6I1dw40D73zWcQIrF89gRTcsNG3rZVw5jvomR1xut2Uosvx51YCoCc6XXie9 Se6XsFgQLwLAQvyNQDDcROVmnoMTI6yD8BCbjR5qgdi+8LqRuE9kD8CF3jLEFJp/vYJB etiUkQQuTsrViXXSHLfQDw63eR9mCJZAhORJ/Eurr4WqZGBdbSyYFX8SNCMEhSROCo6g bXTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775934208; x=1776539008; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SZCcfd2j80fnOyI9eoqdL6EvakDEWReMcJQ9OZ/rF64=; b=R85UpFIt5enuRhfNpWqKZEGxcNX09uE19u8HwLLCbKv6Sflw9OLcXhQOUPr4Ofw4J0 ZXIcytOG+XnDOlUZ54Zn6oBxJzwgxVDtcGGILlwUNzQjeF9cPVxEOVTcZiRofTGg9rUp 8wEZ3T32qUj3XIiZRVzWocNMZhJHIsa88NQZuP3eNM9duymzneb2oDo+oE/7S2Fj8ipk uI2oaUv2PS/WYzS23z3/VOvyo25fPYfRbgbSN0urxjJoYqMuJIzBMjeiQCREfMiFxRYD kZoZIk4ZzEmGfJypHzBrNSJZC8ni6fbQKpcWjGFenIbi6/0g5OyZB4s1f+4SvQWJdXgt Fa9Q== X-Forwarded-Encrypted: i=1; AJvYcCUuqfK+f5QZlFF/oYlFNC458H7VaJo1Zg9f8V7EDsp9Y7yuu1z9yNrnLpnWR9ZZJoc6K6DQAbp1O0Eba2g=@vger.kernel.org X-Gm-Message-State: AOJu0YwrqyQc2ocOdX2MLkhEADPddQoUpm8EfJmGRwn8iEn4H897dp1x oJ8xGc/ioxx1FMiHr3IV5wq2ARhYeWBq5JdTXCXpxxU5HtuTQajRoGKMc1Zy29o7ga0= X-Gm-Gg: AeBDievK9ycBnu/YBSL14mX62647sxN8lx9Q/aHss/fxGuPAuudbbdT9HBlCiKIKy6H zrkepQz9fmpJ0o4o5RKjxYzanfA45dpRn9DIo9lEQS/ZEM8cnoFD/5ZIfhwd/0P5fe2XlOQjIF8 nRI4WRcOi916kY/V+TG6z6zziknNO2u8Ginn2H02TnY9l6zoqGhQWqEecrISc2ul17iLeT2Xbqn dCF1MVpjv851GrEsQcLD+SRld++64NNvDCFk1ypiGyIQhBXxoKlyqafbMVutkshjwgWYQZZv1po mwEm/pNg0Zty7iiUu2vRvVEljHU5kIliRjEqwiqo/xeuAe7wtrrCGhUVGn+wefYyyJrrIBhBgZj f/cgY00wxCmpRuLqC0hyw3P7TVkPlyMIBjh3By7H1BTTq1gar9ChgG6nDbIzEFHkhhC50Ur9Z+x UyH2Wn1wfQML/ntmg/emRcbDHf2cwNRiZqvU4uNhqlHIuqVcaoWNqKkH9CEC3fPHkiSwa2HCtNo K8NxBv263HCm/Xy5rrH X-Received: by 2002:a05:6a00:aa85:b0:824:93e4:2ddf with SMTP id d2e1a72fcca58-82f0c2108e5mr7582747b3a.13.1775934208443; Sat, 11 Apr 2026 12:03:28 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c338dafsm7058962b3a.17.2026.04.11.12.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 12:03:28 -0700 (PDT) From: Felix Gu Date: Sun, 12 Apr 2026 03:03:03 +0800 Subject: [PATCH 1/2] thermal/drivers/imx: Fix thermal zone leak on probe error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260412-imx-v1-1-cc3b45d63811@gmail.com> References: <20260412-imx-v1-0-cc3b45d63811@gmail.com> In-Reply-To: <20260412-imx-v1-0-cc3b45d63811@gmail.com> To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel Cc: linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775934187; l=1641; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=HdJtNYVZoBcseIrEtuqZHe4dtTSU6Ka5kLHKaWeLYmo=; b=neNOP4zpKWvHPkLkH0wdVnaTfqhzSv/BpzFq9DKrR/JAJc10E6mAsmmekeCLKiDqbQNajMH0i B6BD4UMtexGDr1MJj8lbme6hvP/nA6/CmECAFZ/qJQoFx/UM6NYNdPC X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= If pm_runtime_resume_and_get() fails after the thermal zone has been registered, the probe error path cleans up runtime PM but skips thermal_zone_device_unregister(), leaking the thermal zone device. Move thermal_zone_device_unregister() into disable_runtime_pm so all failures after thermal zone registration unwind the probe path correctly. Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support") Signed-off-by: Felix Gu --- drivers/thermal/imx_thermal.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index 38c993d1bcb3..68f9ce41a670 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -727,25 +727,24 @@ static int imx_thermal_probe(struct platform_device *= pdev) data->irq_enabled =3D true; ret =3D thermal_zone_device_enable(data->tz); if (ret) - goto thermal_zone_unregister; + goto disable_runtime_pm; =20 ret =3D devm_request_threaded_irq(dev, data->irq, imx_thermal_alarm_irq, imx_thermal_alarm_irq_thread, 0, "imx_thermal", data); if (ret < 0) { dev_err(dev, "failed to request alarm irq: %d\n", ret); - goto thermal_zone_unregister; + goto disable_runtime_pm; } =20 pm_runtime_put(data->dev); =20 return 0; =20 -thermal_zone_unregister: - thermal_zone_device_unregister(data->tz); disable_runtime_pm: pm_runtime_put_noidle(data->dev); pm_runtime_disable(data->dev); + thermal_zone_device_unregister(data->tz); clk_disable: clk_disable_unprepare(data->thermal_clk); legacy_cleanup: --=20 2.43.0 From nobody Mon Jun 15 16:27:43 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC00239E63 for ; Sat, 11 Apr 2026 19:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775934220; cv=none; b=ixUjA6UE1p7AZX8mFRmNIH9dF58r6SmCU8CWGd6L0JGBz47gab1R/OynXDM90fDrInPpes2q+W6zVudAPnrP49X/bRDltuVH6mRSzQ6iu2Hoo4fGEpDBq/jwL2qMcVSHUjD7L7B/jhF4ySG3oZlybHRQu5eeSb/EYZmBVOFgcUI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775934220; c=relaxed/simple; bh=6RaDDsGnWQW8DuDWURtJZzjEsjLR60hKYlROb26NIUM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GO4zTcV2x55OCFseadN3OumCMyN6AGX8c90c1+r0TusxVfYjrYXjyEox6C2+0BU98SmBYi7QX5LqLiW0a95x37tBnE/Uogfj0/apx4XhCCDhARplIgbzqudtFzUGPFiZoB79emFE4JiPJv2WrJxkZebKJ9Wvdoik0EodqvNIur4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=otuCmUPx; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="otuCmUPx" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82a7539851fso1496018b3a.1 for ; Sat, 11 Apr 2026 12:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775934219; x=1776539019; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tGIk18dSjHKSjMBfr2zRSzrPhhMb1Wy+tDs49j3GVxc=; b=otuCmUPxyhei2q1Yr4vb9OXtOea6zrN2HW/sGsGMQorr4yiYlJf7k3re3MTOSJuHbe hz59epv3G8+Xqr41AQhhlfsSa5YxesBlspp3J7sZ5oqlvsRLIWqd7AlcDIjhCoHSo0RY rAQWLw9/iF2NO4gMe/4xXleX+yNhkoOv03n4Fz/2xC+yABamIhNRydhcx26SpxfCzzSc 9TvDVvBIgOrmDLrlcGhj3xyU0ou2lZGjqe/IEuPdKytY64DjLwDI6DnKuTop6gm2ZsNN oBJsOWnjXhosv/kmwQqzKG7zWtuuQZuf7w1Ax7divQcAvvFDCjfmobjvwgVpsMtd2pCt v+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775934219; x=1776539019; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tGIk18dSjHKSjMBfr2zRSzrPhhMb1Wy+tDs49j3GVxc=; b=pJYam3RV2ful6DbqIsnrV78dUqcO+0yRGQEQ221qocE/C3qvG8/Nh6yyGJycmldfdP wnUwkbC8wn2SV2T9ymWZpwJpQcGBFQpPjA5Iqo5xQC/lvYOIRdQpratmid0thRnYvVCj TsMweJFru6yIl/Gpn+xpZxlHB2jOMaltBKG/SquClfgrrGssyXJHZx5egFhJJvo5857U 6AMKDeHcoAzKihyzzKEWqMEgRczZBI0JfDfsz/9LckjlnsPK8HvE5TWjJuKj6pVMMB8a oinxxaUbsuwg7oijmVQ+IISzcm2Fwb6LiRcvYQlmD8Ugzf7vMW++VuGgz99ldbPWQ64+ VGtg== X-Forwarded-Encrypted: i=1; AJvYcCU8S6/JJSw0xRHG9h2jNESB9I8I/NvWx14zHzCRiWweMjRmXKzWvU09F0RXpdLkbRzjvPyNO7nUPjFA1ok=@vger.kernel.org X-Gm-Message-State: AOJu0YxHHmcMRolO/t00J3JiTgJxQIg+s47jWHsVcWSX8HsTEBwHJwHn elZkHLivJRk+/N4VLD8z9KuzCW2h1zr+LEAuxDT1UVi939BphdOqTveJ X-Gm-Gg: AeBDiev5OJ1IchvA6TElajK/CrQunUgccSM5b1Fmv36h9CWuNtJW2hcO7IMIFikZIsl ZKzja2hFX7FdBl/MDXAKoOkoMeZkqYlIUSyPwpr/7sXyhi0vSvlFuYWYrip72/0xdudCP8chxAD JFUzgKlAli3+kGaQahGoHAeApBwEH9ppNKlhnX2GmmW8Ogd6CAlMlKQm+7ftYQTuB/p7/uCNUcM RpGF5iU4rRAKuVuu66gQ2//DzYMWxWy/U8h6CNw6Dm7Ikw/nZuGWAWgCT2LwEPW93v/lwR+TTCf lNA7fF6rFYySjsQPI/7GG8FN1rUi+A6rzTs6D3HLwNOm6kGZ3RarTkYz0C4dlrTboSH0Cxl6VM0 tvco/9MXKDvIIvVbmZ9yAtdPdPI0MNdPcLgRBNW4edD/lZFmf/NfUGYnWJDUprJ5OqGUTD9MO/k BJp0ZKwRK4IDpozdDi6wHgKjiCr5OK9I/PUd8NGh23ahKq3NC4zDpILK3R4caWjdyo6vjB9MeEj vcF0rOAVNT9wLHHJsKe X-Received: by 2002:a05:6a00:4507:b0:82f:120:fd6f with SMTP id d2e1a72fcca58-82f0c0faafemr7383565b3a.0.1775934218598; Sat, 11 Apr 2026 12:03:38 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c338dafsm7058962b3a.17.2026.04.11.12.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 12:03:38 -0700 (PDT) From: Felix Gu Date: Sun, 12 Apr 2026 03:03:04 +0800 Subject: [PATCH 2/2] thermal/drivers/imxl:Fix runtime PM handling on early returns Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260412-imx-v1-2-cc3b45d63811@gmail.com> References: <20260412-imx-v1-0-cc3b45d63811@gmail.com> In-Reply-To: <20260412-imx-v1-0-cc3b45d63811@gmail.com> To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel Cc: linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775934187; l=1725; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=6RaDDsGnWQW8DuDWURtJZzjEsjLR60hKYlROb26NIUM=; b=4BLCl7id57T/9qyuxB+Ons1cJ9eYH6GtrniSvJYEyQhYBOSdzQdtJxj+AGj/GX768L8KTU3Jk 6v7hShaEIfWAOZx3KDCW/X/UvqA2JHhNFWhD2XBRFeFw7gejFAC9ZC/ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Use PM_RUNTIME_ACQUIRE() in imx_get_temp() and imx_set_trip_temp() so runtime PM references are released correctly even when the functions return early on errors. Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support") Signed-off-by: Felix Gu Reviewed-by: Frank Li --- drivers/thermal/imx_thermal.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index 68f9ce41a670..9d9ae7871068 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -260,8 +260,9 @@ static int imx_get_temp(struct thermal_zone_device *tz,= int *temp) u32 val; int ret; =20 - ret =3D pm_runtime_resume_and_get(data->dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE(data->dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; =20 regmap_read(map, soc_data->temp_data, &val); @@ -302,8 +303,6 @@ static int imx_get_temp(struct thermal_zone_device *tz,= int *temp) enable_irq(data->irq); } =20 - pm_runtime_put(data->dev); - return 0; } =20 @@ -337,8 +336,9 @@ static int imx_set_trip_temp(struct thermal_zone_device= *tz, struct imx_thermal_data *data =3D thermal_zone_device_priv(tz); int ret; =20 - ret =3D pm_runtime_resume_and_get(data->dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE(data->dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; =20 /* do not allow passive to be set higher than critical */ @@ -348,8 +348,6 @@ static int imx_set_trip_temp(struct thermal_zone_device= *tz, imx_set_alarm_temp(data, temp); trips[IMX_TRIP_PASSIVE].temperature =3D temp; =20 - pm_runtime_put(data->dev); - return 0; } =20 --=20 2.43.0