From nobody Sat Jun 20 18:34:37 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA4DD36D4E1 for ; Sat, 11 Apr 2026 16:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775923680; cv=none; b=C6LYkspNvM+35yMdzd7lVU2BGfjdnpjXo/Tgv/LgVKbBDGAt2j+KCFiSd05cjkUDapoFPbBR3m66bgypCuGOhInYOuxblt53n3zO/LcPBPGwQVSg9sK0JlfcqeCwjrDuyzp9Jd9A5srH0WM2Ntkdwf8rGZnnlwCuQ671C+W9wV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775923680; c=relaxed/simple; bh=IoRvBl5NbwVmePrT/sLsz6MCHOaWq/wLqfn9iURD72A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aFc3WzBPkgZ1NOkFYp2ksJDPCtVV2UUMhjjeIHfh7/orFck2dF52c5cHydrrvcDlhchdin5tQHcPhhk/tl8WSQaVcujElUWgG07sVHDPM043O50O+5411GOnY6tQlb8clR83Z0RGTX3MnorpOG62G7cRKzjHghl0oJTS3cEmo6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QGk70xXO; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QGk70xXO" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so40234715e9.0 for ; Sat, 11 Apr 2026 09:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775923676; x=1776528476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=X4ngqPMcB97z9LiWUOSiTShgxTHtSI2/jBhJeR2rFVk=; b=QGk70xXOueS0TRYHlkyxWAaOKtJM5KTjB6nXIuJYBcfw3YPA1F3QZ5V5MvET0MTLf3 rrUv4TwARnASrleKSUfFJpN2ZDVQHssqeL0TZCsA9fgd9ZrestbFC8Exsy3X4F/sg3lN 4+req7peOggnNrYuTvz9SE2nEBpMx9bGkl+OjfP77eLOj8T1KlTzRnbRFzi0wnxn7gCD RZZhhIWQmsY/4U0bD9CYc5W+C9Xc8ftK2kGE4S+NRLcVzZ9DpVWgXxFNJ5ogUYnY/eX4 MxK1H66XChb6r0wc6McTR8Jc3+ug8TfMTkUJBXnDrZ1iq2nw2P1zfMi594iDCSSdBLXk PUtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775923676; x=1776528476; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X4ngqPMcB97z9LiWUOSiTShgxTHtSI2/jBhJeR2rFVk=; b=BVxxS8N3Lbe3WQll6h+HbFWwpjG6KVu5l0AgYHL48GFbOWibA2dJG+wjdJjUD6F1Dy IDyTXSXwffD0QujtWECc7lb9m9/TFUSBk8xhqjyp9HUET7q9I84aqwXg+q4iHjE1o0ol Bu7WrPStYCdMrJRxWEhP7mDAhLfRclkXshhKj21ij/Sj1GS9Gtd5geQJfK/8nJ6583a+ H1oCEeopWLNRrCf8Lx0N8u3jWSUTR0k7WqmzYShkBJT6lwO+55LAEdF0MmCeXgrt4R+N CHGT0tZhNPlVibr7zL4K2DPBYuv2qrN/KfB4GiBzINayV+ABTzjTVX9XB+FWq1VPZacD itWA== X-Forwarded-Encrypted: i=1; AJvYcCXak4m2CsrYx9UrhlVAnHhre79p9iN/PfjZjglo/fy8bq/FRZ/WzmXmVEmrIZUPoqnMixQTYe+x0S4R3M0=@vger.kernel.org X-Gm-Message-State: AOJu0YyLeJQTSGev9+tO7WXNnRVB1PfkelwW9rIKRu5zCTWoLexjg2Eb HuKPneWo1CYkMJ0oU9n0SVZzNysrm9Z3jSzZSYZZ2e4PGSN50IjrAcL8 X-Gm-Gg: AeBDieshibab9bcmYPTDgtiddh12+rIeS5dtEeS/JLfwSqvBTZKbTbvL7gqifWUpcmH 8W/6THwN33szMYwcJB6OxK9CoWKJyCbeiLoXA/AjRbw5j0IM3B4Qmvxp/0bOa3jnuqywUfDjU23 BBVwQbL7HM0C9vxvqtozjEsclpSE7J3CJat6KnRIG/FdqdV1JYTUShYKsuIzqY+yLpboBuGepSg 5bjCEj6cBf+ps6ZuPZ6Sb+jvJhfQNYiH5wUUJqYqPf35YYIA32OgsfMzqAmBw8qWEjMFH5g2dSc xOvfGssjN3kAo1vMMLRNPLNWij/0PjQu9VUQgfJMD2N2rhrYtTf35OSia78WQ76kidJY7zj20Q6 OyL7l5oQDpxYTxf5jiBu+yMx5r6VNA9zEQSqUSEAwO6aCrMajzP4VDU0luMjVvBKF435h5i2cDd dBRw5Ion3FSNzrldPc0f/oDZ4QABActd+YnFv1Dk0Jlw== X-Received: by 2002:a05:600c:5308:b0:488:8d44:bf98 with SMTP id 5b1f17b1804b1-488d67f088amr97620445e9.7.1775923676105; Sat, 11 Apr 2026 09:07:56 -0700 (PDT) Received: from biju.lan ([2a00:23c4:a758:8a01:1ef3:1f1e:3a7e:32e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d531f1f9sm199900805e9.1.2026.04.11.09.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 09:07:55 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Heiner Kallweit , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Biju Das , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH net-next] r8169: Drop redundant phy_init_hw() call in rtl8169_up() Date: Sat, 11 Apr 2026 17:07:50 +0100 Message-ID: <20260411160753.201182-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das phy_resume() called immediately after already invokes phy_init_hw() internally as part of the resume sequence. Remove the explicit phy_init_hw() call in rtl8169_up() as it is redundant. No functional change intended. Signed-off-by: Biju Das --- This patch depend upon [1] [1] https://lore.kernel.org/all/20260411142956.88343-1-biju.das.jz@bp.renes= as.com/ --- drivers/net/ethernet/realtek/r8169_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethern= et/realtek/r8169_main.c index 791277e750ba..cb22105f323f 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5032,7 +5032,6 @@ static void rtl8169_up(struct rtl8169_private *tp) rtl8168_driver_start(tp); =20 pci_set_master(tp->pci_dev); - phy_init_hw(tp->phydev); phy_resume(tp->phydev); rtl8169_init_phy(tp); napi_enable(&tp->napi); --=20 2.43.0