From nobody Mon Jun 15 15:10:24 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1E78241C8C for ; Sat, 11 Apr 2026 13:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775914531; cv=none; b=otm6ybrCNEFfCFaW/YtK+ilr4YQllVoMeffSqIQJZcIf2zlyd4SrU3FdUylCYITY7wIE7TlCx8n5rkKpnlAOYLZDBUHAjJmr0Zh4QPPp+4xcDgAohjL38qQMyvCIC21JUvuWyY4678PC/YX19LQ6NJEh5hvUUlCBrmhdZfSdz3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775914531; c=relaxed/simple; bh=OtSFvIvNO2UsQhwYhpaoeFLi0Y5BtoWJurPvxz8r300=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RXUrGJngXZLGXGLvhbBLx5p0yYJ096OCD+mKR13cdmXDyf54QittZhsA053xj/xl5yXsmic0X45YAFoclEhebINOA9IctHhrYE1daJVfXNkeszTM9NbjhTvn/jYer5+tk9D17A/8Y1PtNlnWm73Yyu7vNJV1QlV3faDf0A3l62Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R4GZP5k3; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R4GZP5k3" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-35d95017a68so1952084a91.3 for ; Sat, 11 Apr 2026 06:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775914529; x=1776519329; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d0Or23BS7mDFDSkUDM2f976vD3FVKjgJPHCZRQcp6vA=; b=R4GZP5k3LAAU99ggcXw+Wc2U+v9ARuD/zhbCXFfF0kFgK9WtrjuBNbELhSrxf+xo8v oNmOQRrlxY42ILDrJQBkhwF2HXYCRYFBDifzYjf/p7FdHJf4Mo/KlTIsk7mUegx9SJ2P RipYTnLJIk1iWSDFneKS+FgznfQpPEhd/KaIJO/KmsMRcEtVpSSWOtC9zAjsWKA7J67K FH2OtWHyHDU4ssvZ+iA+geguULjEySVfwenE0b2HoHjdrruc7hV9dkMs0+I2kQXMivXl FYYI0tDcfojCMnhFSvgcuQlwoSwqDuGk4aQBhjAZCs7Y0gPjvUjczXBHZvhN5Xg3x2Mk 0Dig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775914529; x=1776519329; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d0Or23BS7mDFDSkUDM2f976vD3FVKjgJPHCZRQcp6vA=; b=iKn3yqwc6hI67bx/cI9ezoneduynZF64a0VLNaMzzwtCT27lAaAtOlly9/IoJ67O2w xH/yY6N2oWphfZiWgiCtfCHDVS8QjEo62Fbw41gXlFYjsOMMtQEpVY+rNkCYgT9AnQs1 cBKTMKJvP0Ajab2YNMdDxHpKBjySRtUSW1/nhGRU6NrRun7LwVnKAwwAX0U4GnxKjMIr WLkQL6dT0edPIpOdnY9UX2i2nKA8DOs84gqU31eIlwxOWyp1R5mppebfiI7TSqWTa3Ga xMftEDllpH8QZWqRxpvjKGfxDTqgAsW4A8YPIZATn2dIt2a9ehjPnGs7BLbsLhnpFTth 3D1A== X-Forwarded-Encrypted: i=1; AJvYcCU75OIh1p7wEjqJIZPQztQWXHj71QaOcji/gh2PrQEQN9J0Ew4h3FN6hp4YM4cRRI0xLHvXb1wR8m+qnvU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9GCvPMfJXPdickhgIqGzmOQfWCWzqZZIbLEKo+khfiqxdhMjd dpgQR73QxCa8iLS4gWRRI79pOPdIa1hQrAsxqyXUgi2SAZ2QR0J2Jlwt X-Gm-Gg: AeBDies5lQxdQgGs61tGgFVZtSJkvnsNTvBBL+cFDXjiNDDlKOxYd1IIysIfhOPVxKH nU+gAANo4FYSw0SfHNhIH9ig5VLpHxgfKIlTeFqD4kE7lIdXK+Bzqcoc4zxG3KEnVP0f2Gs0BDo Q/zOmAeCQyOSVx8I6CwhB+YN79clwkWBzjZmK/Hm/epyJ+YXyPIb4fUYP1XF6OEBxsK4yFM5Idy JSPctIbCJWoJFCCsO/UaOcjIV1gCoWEdC/7KJS8BuKtMPhMAHygvQGHAlwEhnGF4Z/2KwZUGJ0g TyKm1NolFbJCiNUZtqxRZADIw26tECuwxQPaa0inmBVwj62tN6zuRKM5qBTyABUDQovijSP4/vA MaM0s5u9xWmAz1A3or0YbFkvXqoWORBDbFkIBmXk3Qmd/+JgukjCZi9qL9WYFlI1wFJe/QiGOvd GWeeHSXC6VQVE/9pysOQLWgQ== X-Received: by 2002:a17:90a:741:b0:35e:5723:85e3 with SMTP id 98e67ed59e1d1-35e5723894dmr364580a91.9.1775914529394; Sat, 11 Apr 2026 06:35:29 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e34e959bcsm10056720a91.0.2026.04.11.06.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 06:35:29 -0700 (PDT) From: Guangshuo Li To: William Breathitt Gray , Greg Kroah-Hartman , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] counter: Fix refcount leak in counter_alloc() error path Date: Sat, 11 Apr 2026 21:35:11 +0800 Message-ID: <20260411133511.2214024-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_initialize(), the lifetime of the embedded struct device is expected to be managed through the device core reference counting. In counter_alloc(), if dev_set_name() fails after device_initialize(), the error path removes the chrdev, frees the ID, and frees the backing allocation directly instead of releasing the device reference with put_device(). This bypasses the normal device lifetime rules and may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. Fix this by using put_device() in the dev_set_name() failure path and let counter_device_release() handle the final cleanup. Fixes: 4da08477ea1f ("counter: Set counter device name") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/counter/counter-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/counter/counter-core.c b/drivers/counter/counter-core.c index 50bd30ba3d03..12dc18c78672 100644 --- a/drivers/counter/counter-core.c +++ b/drivers/counter/counter-core.c @@ -123,10 +123,10 @@ struct counter_device *counter_alloc(size_t sizeof_pr= iv) return counter; =20 err_dev_set_name: + put_device(dev); + return NULL; =20 - counter_chrdev_remove(counter); err_chrdev_add: - ida_free(&counter_ida, dev->id); err_ida_alloc: =20 --=20 2.43.0