From nobody Mon Jun 15 15:10:10 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC04E33E37C for ; Sat, 11 Apr 2026 10:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775903200; cv=none; b=SzAPSNfXalRykMJ6tp9h8u+XaUKYgImuhz9lAy8JMGAk6+mM3haye8FaPZHrFbjO8BEztMsZtRRLBrozCdIGCw24ZlKiIB4gBl45PrEBCZkWTEUJs3J7iPpJ3BN2bfAffVOaJGkFjl1NsdAvZP1ei3isIPbOM/WBJwW3fystXbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775903200; c=relaxed/simple; bh=FZDR3+Rc9FvZ/sgfMRVwO8frIbcuzsj+Ut3/dkRIjxI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hzDPRjWnIOOkVCsHLca8h5XEzZFXRhn5uXmorBckCdnhn34oTSB7VvOpmwLZQ5MustP2/vD3PU5Ox6M4HHyAQk/5gLKKilhKAJZISXkzJKh7pUjimeOWGh+clPj9nMK3HDFuW7eDWEIxqaa8bpFvSpAqYgsBbgekSJDDu6EAgS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NJaOXIUL; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NJaOXIUL" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-827270d50d4so2675592b3a.3 for ; Sat, 11 Apr 2026 03:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775903198; x=1776507998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qeNd481C1ZbDhTU10FEq/8MhbzfHtLZH1eKNdN6F17s=; b=NJaOXIULBUM4S2H7Z4B3eWAD+HBnxWekqIij1eotsw/OncUWdRLSXTM3rA68UEKQiM Pr5+IyoUgYkdG3Cug8KAylW4B+/yxVP5U7v7QWYB6ZAyJldW8gST3KFAKjmRJwmagdTe ZxLBzwvoHs6Dl7OALCS3HfufmubUWAJ2U+Fr80Aof5R3OGYz9Z2oRg6KhIi8EVuB7f3T pTHiLoO5Biw6/pZVErjiD6dUmKBbKh++FRw1lF2s0DuVPNB40WABimPmMrH+PXgEcDsw 3vcNR7r8xLmgmuIDXfpx7JJ8bkMfT4XK/Jo03MUPV02VBv1mVdqm4pWp3+i9lNM2Lk+j UMyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775903198; x=1776507998; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qeNd481C1ZbDhTU10FEq/8MhbzfHtLZH1eKNdN6F17s=; b=MT3oQheBrBOoxZ6ECiajKEGqZZqIRQGsVxbNhRYsIPYb8spKOTxr8+sZfVmYPOc6X8 12mrtMXXbMURtnHnRjFENLl+WPn/45ixJagVgBp1hVYOcGveCgIowOb93IPLow4fd6HR OEICW5K7f/zvnx151TDPMzwicip7XAizwqAEX4y5hxr27ZWoCLTAjbllu1D54XPpd5GQ i14B7kljbgRh98AoNyL2NoZCM9+VR4s++HxFz9tjreLjd8nc+11f/YF8HZL842FXPoxb MpQcO2joV49i3bJ49uIc/02UkCecxZ2uLZYFk9VK40goDS3pv67l0ymgCCXlKWwjRnt0 1Ypg== X-Forwarded-Encrypted: i=1; AJvYcCVR8FrFLABA5CoFaNRSc08k+0KqybHPvBP0CtKOgvV2FI97nFxQ+MoteedqkWLZO5Jd621pxHhtOIvIZ8U=@vger.kernel.org X-Gm-Message-State: AOJu0YzPznIYpIX/xKPzdc0eGFnzVMwjZTk4tAFy53P58u0dF9CaJyJh gRse13OTYS59KmfElSsaCuZOdnlVR0QTW1aZwiyADvyEZKyjCeLuWMpv X-Gm-Gg: AeBDieupyrK+nUIpPGegchhQ8Pr9E28AduQbYKoLlA1mpGUsccUhQSM0r86RKGH1VbZ QUhE0/AXczg13oA5/f1JKrkW4iKPZQ5twMwBRT+0DGnRrkXNyTtOckCqNtunUrtgT5cbFxTAXxC 8nHtQJZC6paPKNhLEYY4eFYm+zR0SeIXTSdrOVc9rlMvFxj1duJFUZBXKlPbjtYsCo01P4MEI26 k6N6odL4GjUSAGcerNV7cddvitkWXqThlQayTEy1QCMIAdE2m6GnOBsb6/FbeypT4wQSwOlaLX3 wXiJWvoGA73W1GIvVUOliqJ8OIB2wCvNGBtK+AowAoOIJFGZCcLBnCmAzDm7S/ZQXEtxJLrSLl7 o7qPRQRJ5JL61ZO/bUpmDF6IBtDzYwAFhLeBWZWzgqqUmQzKi0X5k2YxcFOj5iUfiAajBIMv+2G 0aNw4RbyhRGm2+bqZhjtcrxA== X-Received: by 2002:a05:6a20:6a03:b0:398:98ab:71a8 with SMTP id adf61e73a8af0-39fe4041550mr8030808637.47.1775903198127; Sat, 11 Apr 2026 03:26:38 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79219fe2d5sm4929266a12.24.2026.04.11.03.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 03:26:37 -0700 (PDT) From: Guangshuo Li To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Cameron , Keith Busch , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] driver core: Fix refcount leak in node_init_node_access() error path Date: Sat, 11 Apr 2026 18:26:23 +0800 Message-ID: <20260411102623.2174422-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_register(), the lifetime of the embedded struct device is expected to be managed through the device core reference counting. In node_init_node_access(), if device_register() fails, the error path frees access_node directly instead of releasing the device reference with put_device(). This bypasses the normal device lifetime rules and may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. Fix this by using put_device(dev) in the device_register() failure path and let node_access_release() handle the final cleanup. Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/base/node.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index 00cf4532f121..2b19959a374c 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -171,13 +171,13 @@ static struct node_access_nodes *node_init_node_acces= s(struct node *node, goto free; =20 if (device_register(dev)) - goto free_name; + goto put_device; =20 pm_runtime_no_callbacks(dev); list_add_tail(&access_node->list_node, &node->access_list); return access_node; -free_name: - kfree_const(dev->kobj.name); +put_device: + put_device(dev); free: kfree(access_node); return NULL; --=20 2.43.0