From nobody Mon Jun 15 15:10:19 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF4479DA for ; Sat, 11 Apr 2026 10:09:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775902172; cv=none; b=MYFv+ZrPufegHsWVMg3zBZiwNWDoJjIB5BQsCUgYboPtKAeh15sgvPAcgKQfk+KUNH6gkkN0g3Gt2DkwLw4q3YiQtf1Z8Z05rQXdzEnK9ci5GTB1Aaj6c7EYnxromvm+laHxQHtWH4RhjIHv2AFBCnsmV6dnaIEKcuGyaKmw8Js= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775902172; c=relaxed/simple; bh=puAg1PH9gNxn0enq37DgTWM3U45cvpnO/Tob4vSV9tk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bMKaZ6xyf6X0/QlKmPuriRiuHAKLJe0n4fmEkpw5jTDZyRfEE7ZQ1SZWulhcI03pr51IvJq3KNNm52xyMTCGTFZuBxvfOU5drW0qENr+QUrKzQ8Cpq6QQDD0vNRFRww/q/eeKlSH4i5f1mgcsVmLDThyiZGpMW1JdNebtpL2Ll8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qUE1fy8/; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qUE1fy8/" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35da9692ec3so2882199a91.1 for ; Sat, 11 Apr 2026 03:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775902171; x=1776506971; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IYUywUOo7YYuo8bk+o5cGUlmZfbEJGcfbPVStvAYnNY=; b=qUE1fy8/1eDNNDNWkOBBEnemCvDHUa4BeCZdQes3mAJGB/5WLW1awtK6TJn3+3Yx6v bL75H3/qHMXWw3zBhMtE2r3fPajVCGv8HW8IFiBU9eLFewfDv09TFrQW2EhnKwLHtdcw 2Ygz2RH20+ERU7KNbXmEi6wVhZPj3vCNmfMyODG0afnZ6GtA1NTJqbAMwCExEJk92XmQ 9rdG3sr8bNW1KukbvdBRFoHs7zMG9DNV5aaBIodnf5sU4gFYI4/fEbqVxWb3WEZHSuP+ j3idizpuAqb90cs+UzyM7IDzKJc11/GR4mDseorABfRt8aLzhXNMD6hevTsLFQfFn9EZ zjlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775902171; x=1776506971; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IYUywUOo7YYuo8bk+o5cGUlmZfbEJGcfbPVStvAYnNY=; b=ZHu7xSlDc7JALr3UQcDmvFy19Rq68p7sRyfH1AeYsRwG3ppxR/lUWtVfX3KUr+EECc FHQY5TjsXuxgU0kQeiuKbNCqSHKu97oMQY+JFCvyFec7YfGYE5EJc1S1J9J8rKd+4hL0 Q9vAT/OFRrFkAEf0rEeKnZgchNLfQTfi7py7VG6sVsKDSS0ThpCK8I6JoszZ+lYSH/b1 oMRwhA4wR7HYOJESg1bxUbOF9WcG8Qti+xISoI/5aAix3PDutvFUiIc4F1mXn/LHeNrw p4fPWLfuNEKE/QtfXcZA1IfyWt+nDnz5IanlgSsGzPB7EUggFtOoYQpcjcAyWC7mtE08 wCEw== X-Forwarded-Encrypted: i=1; AJvYcCU4E0ozvRR3OVX0jEKb4+XyCYk88Wa1ciy7gmlJ/KKCRgfWl0At9gDyQiSzP0XQOmlknqfFIo7a7BhUCZI=@vger.kernel.org X-Gm-Message-State: AOJu0YxqP7Tstc9oC2S6y5L9aiIhqJnSTYwNV+wL/SXQv1JBmD2cqREc Zl1uoWySJ+2zF1I1As+iKNtjZoBE3qC96dyS+KeX8rH8v7vjq9Bn3ioH X-Gm-Gg: AeBDiesr4D2Dd/3moz1auntw4KioIVWgM23cuD5ByN2kZAOM/8xwISuIjeFamTKM+hq IWc9ACBcRUxZBDR9xVXcICQfisAvXFeQuQJ2tUsnZKkkGvN6odFGS8pACiGTvCuGzVj6L0YNm5M NobJ8AHaz6Czf1V2EQsch7hCCfOHbo4GSYhQcDz44MX3Ty6D1AVZRUrnOcJACiZIUIVZARknQ27 inzIQ2R9X/o9Ypczl4EG4AUftgaA2gbpuJ9ROyM36U/HVBjZda8qD1iZ4m7QWtBR+f0+UjYQTAK bJ6hGRcc3DiNKjKz1wxutNvP1SJ9CZVTM5DtrjfbZpSR1JDGleTYRKMFjV/zaTm71TaUZ/8I5hT 2RlB2adoIF8IA/85gUaqx+ua75WAgn+7tybx08rXkYB6WMye7q95q7uRJpaQpQuqOWM0TX4TJeT GHqwYi/z4RY7/D1rQkTc4OIw== X-Received: by 2002:a17:90a:e7ca:b0:359:974a:3d65 with SMTP id 98e67ed59e1d1-35e4285280dmr6940463a91.16.1775902171065; Sat, 11 Apr 2026 03:09:31 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e35156445sm9145443a91.14.2026.04.11.03.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 03:09:30 -0700 (PDT) From: Guangshuo Li To: Arnd Bergmann , Greg Kroah-Hartman , Tony Jones , Kay Sievers , linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] enclosure: Fix refcount leak in enclosure_register() error path Date: Sat, 11 Apr 2026 18:09:19 +0800 Message-ID: <20260411100919.2160169-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_register(), the lifetime of the embedded struct device is expected to be managed through the device core reference counting. In enclosure_register(), if device_register() fails, the error path drops the parent device reference and frees edev directly instead of releasing the device reference with put_device(&edev->edev). This bypasses the normal device lifetime rules and may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. Fix this by using put_device(&edev->edev) in the failure path and let enclosure_release() handle the final cleanup. Fixes: ee959b00c335 ("SCSI: convert struct class_device to struct device") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/misc/enclosure.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index ca4c420e4a2f..9532ad8f8b4e 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -148,8 +148,7 @@ enclosure_register(struct device *dev, const char *name= , int components, return edev; =20 err: - put_device(edev->edev.parent); - kfree(edev); + put_device(&edev->edev); return ERR_PTR(err); } EXPORT_SYMBOL_GPL(enclosure_register); --=20 2.43.0