From nobody Mon Jun 15 15:11:07 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BACCC28C5CB for ; Sat, 11 Apr 2026 08:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775895732; cv=none; b=rTtrcY895kwioB6AARW1AxTeXIJqOXxlDCl2ATPyaPdtvN3dShyzQ/xXSpF4c1yakr4DNaSd7owtK3RYBGfO+Ez6l/m253gt1MMCNO40i6Lwf9e83TEOvQIzxPMBTaqd41gMuI/UJEH3EQUOVe73JJt6mZtT1zOedCBhB9xamE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775895732; c=relaxed/simple; bh=g5G1jbvCtPhemn7bt6Lq5DU+qDh/jWWfyp/ph4HszDk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FZWacgEd4g4/9pM/KmcwpXKfeo2H1i40FgsLAAhPqg7WVfCBdqx6aOodQpRkbAHATFD43ODKbAoFtggS6XptybaqXfsLX1gdFtRzmSOP2cLwfiiokzkl5P5Azy+rUqgOtVoNLdbel/oXjg2l6vMWRLNruMRxbCtyoIlVQ+pGtXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fYYybFfQ; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fYYybFfQ" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-358d80f60ccso1964425a91.3 for ; Sat, 11 Apr 2026 01:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775895730; x=1776500530; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BtdM5uITMmBVA7R8e5kqDwM++QCawCGm45tIFxInokM=; b=fYYybFfQwWjbR+yr/ickql259LKkwDVZvawNOuaOzGdbE/80gRDdeJPphhaRwksC4L EpFZoILcZoqcaKrvYvuKz+Npc+d78lDy7SA8sYy7ETyR+MnE4PZRkc+lmzCnTXOQ4pre TDtFv6wdJn/toSQ+quYBiwWGav5k9uQF5dps9cqYQ0pImDrcfpzlnAf6dCoyQ15MuvJb +EcV7YclCGgzKOtQ3k87PMsAFkIXUEoCYj/QplTnVEU2LUpaWfxgi0LQDJH+ouXjP6Tu tYu5wjiXDuZo4ROyqgciSU2PJggcHVpI03DdITAwRq7wM9I9yNpyq7SY2yvqOZmgUkbZ GRbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775895730; x=1776500530; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BtdM5uITMmBVA7R8e5kqDwM++QCawCGm45tIFxInokM=; b=ndT36KuXcZWwm9XxCb3aA2OUkF8yVwLXeVNzsv2s6OfYZjr3svf+LouTsdBVo5d3f5 D3flHWPIcG42oUuCG/QP0Bed2QcxaugXeUWy443sXJiL2ux4w1b2iM5HcbJz0MgmFNTx 5SEK7C7x1jI+JHkWwXq9u15K1IFx7M8gHVJh+OcjOWZGSeVu2DqN69sKKsPnUx7skAwm mEeiD53u7ZgTAAYN6AeHMJ7fKn4ZsaknV3zDRBGBcRb8rrX2AkuK0SiQzyUUa/hmyuwm 7QNgoG1/DROOBdYx4MJupOcyYZxlLFosbM6PwpTS3+GkKkNiszv9WyaEvYyXKRDo0HUY o6qw== X-Gm-Message-State: AOJu0Yx0aMo6g4fLBlE9XKqd0Vcf4G4mcKb7t66AWftLq9e8r2c4Acq8 4ZFPNx3RXqZQLU5RWcCDfTSc5yA4+wDsiAbFbEfEvA0rbPmP8L7ESmvxS6eqLg== X-Gm-Gg: AeBDiesN1aOTi0AVFx2WHVYeQFC/wOa9iF36kotVikFbV2F4RXyYOpGthmoC4GtI27q zICjqZl7tSLJuAl8YPU6cmrL8OvpeMTAoNVPxqkjeZuvgb5Q833ASSyijJOPczrR8YPH3ix1KEr 8n4oJGjOsP+5LxhK3Y5bbA4xZcg7O6bnI2Q5fJl0G/Ecnk5CCkVhj7ca0saJeZDJQKYMkoIEvXA qSl1aynruydSyIQ3PcpHi5TnRkgTcyx3kJvFD7uRcTAclfNZ/TTM/eCdQmabKmbiiTY01EP8B/t aJ9gg0dIsurqkaEQ3qKHi7ctEsGykdfziOvbey8XcLMYV4LYuUnGVmuVVi02YisZLxtSkFuwU1v p588J82r2kDkJUHikzBhpgM2gH29PXxJrJqvi/T3/F8J8Dub1jznP0dtS64kD3X0kTFzVO/5W68 6oAo0q48SvxnhYz3ZC5Mog1VYtHSX55iMvEqQOfWAqp3CoMpk3T/6LMxhkyE7wssuLL0TwbBb+T VCkdVTocg+N/L0N44oM5HM= X-Received: by 2002:a17:90a:d40b:b0:35b:cd3e:c4ab with SMTP id 98e67ed59e1d1-35e42815adbmr6808700a91.14.1775895730408; Sat, 11 Apr 2026 01:22:10 -0700 (PDT) Received: from shyam-VMware-Virtual-Platform.localdomain ([223.181.113.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e41e1196asm1856283a91.1.2026.04.11.01.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 01:22:09 -0700 (PDT) From: Shyam Sunder Reddy Padira To: linux-kernel@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: Shyam Sunder Reddy Padira Subject: [PATCH] char: ds1620: clean up system_rev declaration and logging. Date: Sat, 11 Apr 2026 13:50:25 +0530 Message-ID: <20260411082112.46588-1-shyamsunderreddypadira@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the local extern declaration of system_rev and included to use the existing declaration. Convert printk() calls to pr_err() and pr_info(), and fix other checkpatch.pl reported warnings and errors. No functional changes intended. Signed-off-by: Shyam Sunder Reddy Padira --- drivers/char/ds1620.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/char/ds1620.c b/drivers/char/ds1620.c index 44a1cdbd4bfb..1eab82b50aa5 100644 --- a/drivers/char/ds1620.c +++ b/drivers/char/ds1620.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * linux/drivers/char/ds1620.c: Dallas Semiconductors DS1620 + * Dallas Semiconductors DS1620 * thermometer driver (as used in the Rebel.com NetWinder) */ #include @@ -16,6 +16,7 @@ #include #include #include +#include =20 #ifdef CONFIG_PROC_FS /* define for /proc interface */ @@ -37,7 +38,7 @@ #define CFG_1SHOT 1 =20 static DEFINE_MUTEX(ds1620_mutex); -static const char *fan_state[] =3D { "off", "on", "on (hardwired)" }; +static const char *const fan_state[] =3D { "off", "on", "on (hardwired)" }; =20 /* * Start of NetWinder specifics @@ -46,7 +47,6 @@ static const char *fan_state[] =3D { "off", "on", "on (ha= rdwired)" }; * chance that the WaveArtist driver could touch these bits to * enable or disable the speaker. */ -extern unsigned int system_rev; =20 static inline void netwinder_ds1620_set_clk(int clk) { @@ -245,7 +245,7 @@ ds1620_ioctl(struct file *file, unsigned int cmd, unsig= ned long arg) =20 uarg.i =3D (int __user *)arg; =20 - switch(cmd) { + switch (cmd) { case CMD_SET_THERMOSTATE: case CMD_SET_THERMOSTATE2: if (!capable(CAP_SYS_ADMIN)) @@ -310,7 +310,7 @@ ds1620_ioctl(struct file *file, unsigned int cmd, unsig= ned long arg) =20 netwinder_set_fan(i); break; - =09 + default: return -ENOIOCTLCMD; } @@ -393,14 +393,14 @@ static int __init ds1620_init(void) =20 #ifdef THERM_USE_PROC if (!proc_create_single("therm", 0, NULL, ds1620_proc_therm_show)) - printk(KERN_ERR "therm: unable to register /proc/therm\n"); + pr_err("therm: unable to register /proc/therm\n"); #endif =20 ds1620_read_state(&th); ret =3D cvt_9_to_int(ds1620_in(THERM_READ_TEMP, 9)); =20 - printk(KERN_INFO "Thermostat: high %i.%i, low %i.%i, " - "current %i.%i C, fan %s.\n", + pr_info("Thermostat: high %i.%i, low %i.%i, + current %i.%i C, fan %s.\n", th.hi >> 1, th.hi & 1 ? 5 : 0, th.lo >> 1, th.lo & 1 ? 5 : 0, ret >> 1, ret & 1 ? 5 : 0, --=20 2.43.0