From nobody Mon Jun 15 15:10:46 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A0E2EC09F for ; Sat, 11 Apr 2026 08:05:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775894724; cv=none; b=J26/CX1n3+BmJlCI/oAVmgHgLiRGdEBKeKIElMKIJPxnlJaRqgI/n+xJatqGpmxOQqAgkD83yswEPsc1XGmCZ46hygi085Azn/bYqk4GrHv1npcC6e3EMO97klwE5jhRZFQSxmXPXOodpKIjODZ+hdx6zt4EjbdhV+GFuHqEFq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775894724; c=relaxed/simple; bh=BTffGS/gCY2Nhw4JwAa2fMfT8m8fmomn9ZHDLdl05cs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ubiJMB5KMk+KLHHAbgKWKteq1zNhqicIaAQC9kVtJD8eKj1x8Brc+edhcvBBTJr2z02Bg+7USKlf0/mx8kQ47xd6p3jwHQPixj5ZADvw/+FA6F6Ck6K5Tdb1ywzI+FhLAaAbgFFRWcCw+KcNMNqkUNrlJTC+/j1VdX7BTxxE3Io= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I5P1Rsnn; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I5P1Rsnn" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82f22ec4501so89398b3a.0 for ; Sat, 11 Apr 2026 01:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775894723; x=1776499523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KAoYJAvzB2HJXU7lElfXwN21XkOVJNicGBCcf7Ya3j8=; b=I5P1RsnnYChFxGNvZVaAw/lS5uJoNNe5v/L9BQ9J2iaH/qggbw+r3ASv8EjyuNMxGD F/WeB9EZH7TP1oG9EqsFWm0hmsxmcttgWV4Gf09IF9I4g4Q+jlnOdk5+nH2sLfP6ZQWa nyS8HXv7UjzOdJhFgJbdplZMF+INJ8KJXva6+IUIl7tM4dY2aYK3pZT3NDV2zGMGJQp7 j2gB5RQdP5O5iFiUwUdi2IZvUu37tQVRmJHL4SfdJ9kemrBPFBTnEECleKB4uPMfuqQT oHuK8xmZP4vmGkrXBvhOG2l7QeDrxLQCWBsqfKmW9Hw1hIVDEOOdSUVX1LJwysaNDK0c F4OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775894723; x=1776499523; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KAoYJAvzB2HJXU7lElfXwN21XkOVJNicGBCcf7Ya3j8=; b=hkzr9dav4mddWaITwPtYBEpmUHurHED6PDFcH/PzTk5gyLS7UGrAqs6PP7I2zBgn1j S0oYjUvFV4tXrSSLvPDUgeFReJX8gq1mXqkLDJtvqOAZiiIZ8d0QrlJWn3dXVM7lLJJd 0Mj2Tj6dn0aMWIoa4aAvtWOmHOUFK0YdOr35UiuR1cUmr+64dz+Pvre8cmTWbBjwJuJi BH5PQVJWrhrpB/14GSAJHK6gjN5LIKDDPy3DN2Gz5VMegz0hrA83WlWEiirhCAEg2eua 4ZaLmqhsgZdUOU24xfGvS4nKwO9EnN/e9sx9ZM4c5h2VQ5sH0FpHokMssyvBxXMiTPnm uLcQ== X-Forwarded-Encrypted: i=1; AJvYcCUUtFpugEMcUL+sXyWVWompWokDMeIR/dwNc39LCax+D2YZM9PBLoHKHgT18eUXn8cjrYSKqEc5uo7pLpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyEE/4sbzR3bRogJlF+s35ND8yJF3sLjVkNBPfEFE6HauK91UFO CAKGA5O7kCwjef837AVfKAqfniGtO+FAE1boV2L3LKdNmcOymmNE4Djw X-Gm-Gg: AeBDieueSom4D8KkLzKYKe2gK14xcP58mwmO8gmNffZAOBhHLLsDOXHcXritB/LwvKV F+oXlreKS+RaU6YSMPEDKTb8NThAeWuF/wfngwbsvSUJZ7UwJ7xWqhqIH8Bb8RoSIQ96NWk7O1o K5o9P5ttcrZLZK0MyL0SiFNBb9yMVt777KZJdqkB6ls0eIGAX1AXJfdljWUYh5DPoK+u/TbxTgT R5vexvtvCdZV/zWrOcev3c+tjudBqlK3PgPmOy3467bFmNtST+LC4uulzjRLXp1XDWoR9Yf77Ct 8zP0Ry93ZJ1CgwLD4iz8I0xzplOClnOEIoOsoO5vrF9XWfBeQR1juUUiepQgLJ+HR2UMFGY3rVA sv6EwO3D3VAz/Zns0ftSru+2iHxYVU7MrU2lab/ca/C58uXCpntVrH1i+bRZuPGvOHLF6v1DxvS LU8OOq1eMcv1cJY91LLsn2bA== X-Received: by 2002:a05:6a00:12c1:b0:82c:e1a3:986f with SMTP id d2e1a72fcca58-82f0c324538mr6784698b3a.43.1775894722730; Sat, 11 Apr 2026 01:05:22 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c4b251esm4820466b3a.37.2026.04.11.01.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Apr 2026 01:05:22 -0700 (PDT) From: Guangshuo Li To: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Dan Carpenter , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] iio: trigger: Fix refcount leak in viio_trigger_alloc() error path Date: Sat, 11 Apr 2026 16:04:35 +0800 Message-ID: <20260411080435.2125626-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_initialize(), the lifetime of the embedded struct device is expected to be managed through the device core reference counting. In viio_trigger_alloc(), if irq_alloc_descs() or kvasprintf() fails, the error path frees trig directly with kfree() rather than releasing the device reference with put_device(). This bypasses the normal device lifetime rules and may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. Fix this by using put_device(&trig->dev) in the failure path and let iio_trig_release() handle the final cleanup. Also update the subirq_base check in iio_trig_release() to test for >=3D 0, so that a negative error code from irq_alloc_descs() is not treated as a valid IRQ descriptor base during cleanup. Fixes: 2c99f1a09da3 ("iio: trigger: clean up viio_trigger_alloc()") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/iio/industrialio-trigger.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-= trigger.c index 54416a384232..ab544976018f 100644 --- a/drivers/iio/industrialio-trigger.c +++ b/drivers/iio/industrialio-trigger.c @@ -509,7 +509,7 @@ static void iio_trig_release(struct device *device) struct iio_trigger *trig =3D to_iio_trigger(device); int i; =20 - if (trig->subirq_base) { + if (trig->subirq_base >=3D 0) { for (i =3D 0; i < CONFIG_IIO_CONSUMERS_PER_TRIGGER; i++) { irq_modify_status(trig->subirq_base + i, IRQ_NOAUTOEN, @@ -572,11 +572,11 @@ struct iio_trigger *viio_trigger_alloc(struct device = *parent, CONFIG_IIO_CONSUMERS_PER_TRIGGER, 0); if (trig->subirq_base < 0) - goto free_trig; + goto err_put; =20 trig->name =3D kvasprintf(GFP_KERNEL, fmt, vargs); if (trig->name =3D=3D NULL) - goto free_descs; + goto err_put; =20 INIT_LIST_HEAD(&trig->list); =20 @@ -594,10 +594,8 @@ struct iio_trigger *viio_trigger_alloc(struct device *= parent, =20 return trig; =20 -free_descs: - irq_free_descs(trig->subirq_base, CONFIG_IIO_CONSUMERS_PER_TRIGGER); -free_trig: - kfree(trig); +err_put: + put_device(&trig->dev); return NULL; } =20 --=20 2.43.0