From nobody Sun Jun 14 17:21:05 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011066.outbound.protection.outlook.com [40.107.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7359527A107; Sat, 11 Apr 2026 02:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775875289; cv=fail; b=cpLPf0lln4nY4lozrlKGLZHHc11jw8Ac+B1eLxRgzn/b/MeK+6A+u+0X+IaLnZ75TnQB5q8PoM5LDgL/8n2PtOezXF6dTOE20vfWIJisPCiJ28idmJCn4bnN7slOSA713XA8V+N9FDkIupOExcgkyO9/ADn1wHywz9vesvLuzgY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775875289; c=relaxed/simple; bh=vgxBjhUyKyVb7pa6m30Q6BtfMcfH1nV7CqZdAKCJ8mc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=VVPV8bEzXMjLINntqs6e1cAMc3XzDVF+sjoXGwGbCTmFCbgRarvV9JijED74dW9QsUmB7oJXZM3k5tOZNEIPfidRTNLEX9E1VMLYIOoF8NaAPXLD7WCE5gPh++U+6G8et5ljeQj0/uI5NC5sUhMM2HEVeRz+ROjN49eBKbWpgA4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XA74Bdsx; arc=fail smtp.client-ip=40.107.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XA74Bdsx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nGNGRWt1W/7W7Gp+4klk/B2xX5Gz+Sx+dkhxIXX2ADdIhFiFCt+vuajmzBQ75sFBJczdao6a5EwHYdiATwAJrTV5i0K0OG3s9MFm/nJuftYC7H9drfuAzY6Qs7y9Lbhb33yGC+aKnBNYuW2dC1E+2Sr/J3WV9/LwWybFUMwP3S4E7H/0Ao81koxIFE+1nvYpEgV6kGBu+dXKNrNaJ338nZAX+OztgAzOWTBIXxfGhsVsdgFD/f78/zr39srOiGWlPm9O1k2OovGS+VTnuN3KgViDnQjRLKU3fjAkAw4or002zsRCki6QSAXgHr+3mX/+yVs84az04CtNjhNi5iGjcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z6qFQ9VH9VvDNQu8T3dMZ1+3vdENM2PB2G0pnKVcW9Y=; b=f/15u8ipF0zfXAVHdvYBcnvK7whA6616oU0AeTh1WOwfyWwk5hwrN+VNBobH6UhuKjRusXVym4IF9sfrqiSMxLZvxt3P3QgA/qD9T6N1s7o9i1VJh+DkToxx16nCnwTbVEAm8FQc12xS42gF+81lyCPYDaQ9c6WaeBazHTo51Es2AO8S2s8umklhKLL8X0lRrLXgWhEaVsM4dUpjsScMPPVR8jKnyE4O3QMLbizsAFz9m6PNie4M8qFAhg2NxuB7Rq2w3wi4hChZdOyp1JJEUTFWQDmSvEgyDntHXR4s1PS4dew+DOvPoOZFyTvxmMiYyb/bpA2iA8sn5+SWRC57aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6qFQ9VH9VvDNQu8T3dMZ1+3vdENM2PB2G0pnKVcW9Y=; b=XA74BdsxNnjLv3vdtDJz1qAKbZatOh5DtMC0GodTcbu2hT2f1t8w62aiBAt47HqknXdo3qRbAXaLmQl51r6VDc6SDP0UvpSNWtr+vkeaRzHWKSNbscL3mdJ+HNGENj55Y24YnOMMBNDOr2ALkKDySpkhwyI9jSg4RpHsXIqSqp/YKrSXHecNNDtuTTQSNz6ThkW7mC3+IDRI15s0QyUkJHwvd4Z/Avi9Sp+LeSgDehBdA7OCFKEp/FXMtap0b/5RE4YwiL/ZsTWY+/weTfZ461fmBkgMo6gVmjYPYegME3gprKev2P6pK+YJTmKVAtTMWrwezEiAxh9U7/nVrHFNFw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by PH0PR12MB8775.namprd12.prod.outlook.com (2603:10b6:510:28e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.46; Sat, 11 Apr 2026 02:41:22 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%5]) with mapi id 15.20.9769.020; Sat, 11 Apr 2026 02:41:22 +0000 From: John Hubbard To: Danilo Krummrich , Alexandre Courbot Cc: Joel Fernandes , Timur Tabi , Alistair Popple , Eliot Courtney , Shashank Sharma , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v6 1/2] gpu: nova-core: use SizeConstants trait for u64 size constants Date: Fri, 10 Apr 2026 19:41:17 -0700 Message-ID: <20260411024118.471294-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411024118.471294-1-jhubbard@nvidia.com> References: <20260411024118.471294-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0222.namprd03.prod.outlook.com (2603:10b6:a03:39f::17) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|PH0PR12MB8775:EE_ X-MS-Office365-Filtering-Correlation-Id: 7423bc7d-fd5b-4e8f-2438-08de9773d165 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: hOwpn34ak5iQiM8X+m09VWvnBHx1FMKiuKBoVL6x8v5aRq7nxOnaycwoChTXHON5g/v1WaDWXnAVV8yhBpA3ZOLlZueu1VU4gCbqiH8eUa9E6B/ySr8rPvmcPD1fai8uJE0xqs2MoUysJnCbnqWSFmx5Q22jiYRXtwWG+rYIyvA98VW4VlcK13lq7w6uPgRVjefZPX60xUkEdOAISKVAtnnMMmJYcqs3zRePN11F5mCSPPNQ14YZxJWIgZrUDdMVlvccLxYh8qXH/hTwkdzn/qHWrA8xB3iexzHC5KD2ie2jyMA1do3EN57CkvfkRh5aLkjl4hI+UtQ2rn1tm87xZMYKLTARDFzHOjDG9dhcI0PGzQN5/KK10jfPif6M0CaPldnOhfF8XiS6ardeTihk4stuIalrWejaiYvRsaxjkAYGL5gr9cfObI/Y7uBeio+bcbO3+EKEEBtR0L6YqI+AUesPB3oMInr7z9pDCIQzBJMS8DOLislN4XMFVuW9oydXGHut3zdIIlQVJRskTkrV1blPH65wD+Y9tGJva1LXPOYYNCv6pEt9WPMFP196d6tKqb1PRWZ5XMN4lHzzQjAMVBqK6pbwcsLsdsDebf/UjBqNLduMZJoMWUXDWMW17Q7Z+3I0XcGgo8Za5VuZcR+0TEmqhgplHu4lUm3WyZQU9ih+FA8o/Lxu68NcQCOuzzKKwcH9K3jrFGCtXDqKJBH2NXxYndQcIM89si3lnuo1ZM4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kmz17/xcQuP19Uiru5lS/QhJZFGGFZgKW+CBNnkf5ME87guoPl0M77x1ubWH?= =?us-ascii?Q?XK5qEJHoAEtrBNSOTA7a9rFQ0i9sUFVqGQpBMezvWn5DfEMDfIU5EUzoQ5nq?= =?us-ascii?Q?7UQexTb30oGnKw2zWkE8BtJCpfzmBaKrqi1FmsLJuu96nouzbXKR80tLlju9?= =?us-ascii?Q?wBTqJ8DcEE8QcsjvOM+iIkFwOyRCheGywSAPt6jgJAUAVmCWbbv74BGdHnc9?= =?us-ascii?Q?Zm7sAt72GHKaQ3uLvvQ+++tXHAJzkUqay+1xOmwZX8rOqNj9+YePPjCEvOPA?= =?us-ascii?Q?AI4Exg4N0ZTdk80WyTfwBCE1KcpVplJBF8VacxhkEpqOj6xJHCurtRc5mSh+?= =?us-ascii?Q?tMe59y359c2l6VlNMMDamb5Ud5yAzVp8Ky8f3+WdqEojijzCNHR2/usTKWXs?= =?us-ascii?Q?zXQY9JZja+SRlvzTVYFojtIe+9ZiDxLxM2/X+sb2b6hn6qnZL7cz8DmaNXmw?= =?us-ascii?Q?76C6v+7hAoa45mwJj7NcmYtGaDrRGhJf9SmM65QsW3Oa6TMdreL68DrEBpxJ?= =?us-ascii?Q?vgmpbH0ZB3gtkPmV+1bnDTPfko3fkouyoR/gs3n1k7Pe3PHTSdfP8NJfGrFJ?= =?us-ascii?Q?79YUPnj+Y/fUrfuVrEab/BizgRL62aLsBupytcZ4C72kdNYzgFWzrdIZEV2d?= =?us-ascii?Q?/AveELYhnZEwzXn3JAKAkFmjxH2a0DgtdYhzzp7QkCurwLeGpktgi3AauafJ?= =?us-ascii?Q?Y3YUQjNy63yAduPTRzEbDv0tB63m6Mpji/Kk72OoOtN2N+BGpuJRpinjdB7c?= =?us-ascii?Q?+KlKW6FVA8wLiD3mQ7WIG6PPFfEF7/O6ZwfNCd8s7/NdNDb+NNUmCCiafjBj?= =?us-ascii?Q?ucg8GCXZTED3p0ldxbMgDW8c6KNsodecDgKnv2IQksw08oZrhDxj8Dntow9M?= =?us-ascii?Q?7Dx5cGvPBh1Edq1fl+aAwQfiPt0M6VWW/pSwe3ajtSYk/RN1Iq5dUxzABppW?= =?us-ascii?Q?Y1GgrHtAU4KQt/uqy7lsIRcqpQ4qh6l0Tjbwve09an11pEOj38OAt4m1XLDi?= =?us-ascii?Q?9qWPU6ukAdPUXM/8zur71AfWKKkUEEa/Nu9eK1iSyofciREVvl5PDg86Q7Tz?= =?us-ascii?Q?54OMs/CIxiyjPZaQUPRmO5FZfxbnVv5x1OvDGI9nPDSU84OVAbyvOUEGewQC?= =?us-ascii?Q?Vmqyr1klGaCFYUA1bedVN9klw5u2fqDjr3x5nSbaxLgKlaN8EcvM5YtZnpo1?= =?us-ascii?Q?D4EilxsWokWWoqcZiy9hVRFgGoSwAfuGDKpBIv84y3P1k8m65Xyc9u0F/QYR?= =?us-ascii?Q?wvdim0kWQTXT4CtXnMMaye90P7Qg/Y2QPWw2/UBLLTenBf3QBbmV3cSTGE/x?= =?us-ascii?Q?5ALHSFUW6s11vQn0/Wu69Z/tPFLRxeF0rHNXvbJIyWL9X/16x+yY4LSYTCoY?= =?us-ascii?Q?RVtdwFR2UVwAKHhrZ79UWaJfBIMmr57WBtaplLUzJgoXzwCtplarSJTSwjNi?= =?us-ascii?Q?AOdUytBmMO5KwAixz3w2LyXzzJBXqWbIYyLt09VrR8mkn/E1hTqTtMyWWhyM?= =?us-ascii?Q?GBbPZzFtb/Yr7/oX7hcxovq6SYFFp+0OgDbnunNze2zz8AGxAMicS+l14bSu?= =?us-ascii?Q?48vxXP19nhgUuVPbXuLx9Khhsrj77VuDC0OmsepelfnGPUuRPHvKWURomWDO?= =?us-ascii?Q?+dSMaHWP9bl6QiCjueEl9SwOi3L7R5lgDLhJDT2WrTjS8KOYu3EwAX7dxcUx?= =?us-ascii?Q?wbVpczLrCw2bTPjBgmmt9w8dz2B8snXON6cWmMivniz7cFSqAt+UCnvYtcmg?= =?us-ascii?Q?vrk7XvKmRQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7423bc7d-fd5b-4e8f-2438-08de9773d165 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2026 02:41:22.4987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pdO1A4y/ed+UtIn5/+GStTFQMkS7A/dF05WiN1ojsOl1zjjv2sl3w1MD002soAJmnMj4nQaR+9YQPdDqMBNmkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8775 Content-Type: text/plain; charset="utf-8" Replace manual usize-to-u64 conversions of SZ_* constants with the SizeConstants trait's associated constants on u64. With the SizeConstants trait in scope, u64::SZ_1M replaces usize_as_u64(SZ_1M) and similar. This removes several now-unused imports: usize_as_u64, FromSafeCast, and individual SZ_* type-level constants. Reviewed-by: Eliot Courtney Reviewed-by: Joel Fernandes Acked-by: Gary Guo Signed-off-by: John Hubbard --- drivers/gpu/nova-core/fb.rs | 21 +++++++++------------ drivers/gpu/nova-core/gsp/fw.rs | 15 +++++++-------- drivers/gpu/nova-core/regs.rs | 7 +++---- 3 files changed, 19 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs index f357fb28b22c..35899e9b2560 100644 --- a/drivers/gpu/nova-core/fb.rs +++ b/drivers/gpu/nova-core/fb.rs @@ -24,11 +24,8 @@ firmware::gsp::GspFirmware, gpu::Chipset, gsp, - num::{ - usize_as_u64, - FromSafeCast, // - }, - regs, + num::FromSafeCast, + regs, // }; =20 mod hal; @@ -127,8 +124,8 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resul= t { if f.alternate() { let size =3D self.len(); =20 - if size < usize_as_u64(SZ_1M) { - let size_kib =3D size / usize_as_u64(SZ_1K); + if size < u64::SZ_1M { + let size_kib =3D size / u64::SZ_1K; f.write_fmt(fmt!( "{:#x}..{:#x} ({} KiB)", self.0.start, @@ -136,7 +133,7 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resul= t { size_kib )) } else { - let size_mib =3D size / usize_as_u64(SZ_1M); + let size_mib =3D size / u64::SZ_1M; f.write_fmt(fmt!( "{:#x}..{:#x} ({} MiB)", self.0.start, @@ -186,7 +183,7 @@ pub(crate) fn new(chipset: Chipset, bar: &Bar0, gsp_fw:= &GspFirmware) -> Result< =20 let vga_workspace =3D { let vga_base =3D { - const NV_PRAMIN_SIZE: u64 =3D usize_as_u64(SZ_1M); + const NV_PRAMIN_SIZE: u64 =3D u64::SZ_1M; let base =3D fb.end - NV_PRAMIN_SIZE; =20 if hal.supports_display(bar) { @@ -196,7 +193,7 @@ pub(crate) fn new(chipset: Chipset, bar: &Bar0, gsp_fw:= &GspFirmware) -> Result< { Some(addr) =3D> { if addr < base { - const VBIOS_WORKSPACE_SIZE: u64 =3D usize_= as_u64(SZ_128K); + const VBIOS_WORKSPACE_SIZE: u64 =3D u64::S= Z_128K; =20 // Point workspace address to end of frame= buffer. fb.end - VBIOS_WORKSPACE_SIZE @@ -216,7 +213,7 @@ pub(crate) fn new(chipset: Chipset, bar: &Bar0, gsp_fw:= &GspFirmware) -> Result< =20 let frts =3D { const FRTS_DOWN_ALIGN: Alignment =3D Alignment::new::= (); - const FRTS_SIZE: u64 =3D usize_as_u64(SZ_1M); + const FRTS_SIZE: u64 =3D u64::SZ_1M; let frts_base =3D vga_workspace.start.align_down(FRTS_DOWN_ALI= GN) - FRTS_SIZE; =20 FbRange(frts_base..frts_base + FRTS_SIZE) @@ -256,7 +253,7 @@ pub(crate) fn new(chipset: Chipset, bar: &Bar0, gsp_fw:= &GspFirmware) -> Result< }; =20 let heap =3D { - const HEAP_SIZE: u64 =3D usize_as_u64(SZ_1M); + const HEAP_SIZE: u64 =3D u64::SZ_1M; =20 FbRange(wpr2.start - HEAP_SIZE..wpr2.start) }; diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 5e109eb90164..3245793bbe42 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -17,8 +17,8 @@ KnownSize, // }, sizes::{ - SZ_128K, - SZ_1M, // + SizeConstants, + SZ_128K, // }, transmute::{ AsBytes, @@ -123,7 +123,7 @@ fn client_alloc_size() -> u64 { /// Returns the amount of memory to reserve for management purposes fo= r a framebuffer of size /// `fb_size`. fn management_overhead(fb_size: u64) -> Result { - let fb_size_gb =3D fb_size.div_ceil(u64::from_safe_cast(kernel::si= zes::SZ_1G)); + let fb_size_gb =3D fb_size.div_ceil(u64::SZ_1G); =20 u64::from(bindings::GSP_FW_HEAP_PARAM_SIZE_PER_GB_FB) .checked_mul(fb_size_gb) @@ -146,9 +146,8 @@ impl LibosParams { const LIBOS2: LibosParams =3D LibosParams { carveout_size: num::u32_as_u64(bindings::GSP_FW_HEAP_PARAM_OS_SIZE= _LIBOS2), allowed_heap_size: num::u32_as_u64(bindings::GSP_FW_HEAP_SIZE_OVER= RIDE_LIBOS2_MIN_MB) - * num::usize_as_u64(SZ_1M) - ..num::u32_as_u64(bindings::GSP_FW_HEAP_SIZE_OVERRIDE_LIBOS2_M= AX_MB) - * num::usize_as_u64(SZ_1M), + * u64::SZ_1M + ..num::u32_as_u64(bindings::GSP_FW_HEAP_SIZE_OVERRIDE_LIBOS2_M= AX_MB) * u64::SZ_1M, }; =20 /// Version 3 of the GSP LIBOS (GA102+) @@ -156,9 +155,9 @@ impl LibosParams { carveout_size: num::u32_as_u64(bindings::GSP_FW_HEAP_PARAM_OS_SIZE= _LIBOS3_BAREMETAL), allowed_heap_size: num::u32_as_u64( bindings::GSP_FW_HEAP_SIZE_OVERRIDE_LIBOS3_BAREMETAL_MIN_MB, - ) * num::usize_as_u64(SZ_1M) + ) * u64::SZ_1M ..num::u32_as_u64(bindings::GSP_FW_HEAP_SIZE_OVERRIDE_LIBOS3_B= AREMETAL_MAX_MB) - * num::usize_as_u64(SZ_1M), + * u64::SZ_1M, }; =20 /// Returns the libos parameters corresponding to `chipset`. diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 2f171a4ff9ba..6faeed73901d 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -7,6 +7,7 @@ Io, // }, prelude::*, + sizes::SizeConstants, time, // }; =20 @@ -30,7 +31,6 @@ Architecture, Chipset, // }, - num::FromSafeCast, }; =20 // PMC @@ -150,8 +150,7 @@ fn fmt(&self, f: &mut kernel::fmt::Formatter<'_>) -> ke= rnel::fmt::Result { impl NV_PFB_PRI_MMU_LOCAL_MEMORY_RANGE { /// Returns the usable framebuffer size, in bytes. pub(crate) fn usable_fb_size(self) -> u64 { - let size =3D (u64::from(self.lower_mag()) << u64::from(self.lower_= scale())) - * u64::from_safe_cast(kernel::sizes::SZ_1M); + let size =3D (u64::from(self.lower_mag()) << u64::from(self.lower_= scale())) * u64::SZ_1M; =20 if self.ecc_mode_enabled() { // Remove the amount of memory reserved for ECC (one per 16 un= its). @@ -241,7 +240,7 @@ pub(crate) fn completed(self) -> bool { impl NV_USABLE_FB_SIZE_IN_MB { /// Returns the usable framebuffer size, in bytes. pub(crate) fn usable_fb_size(self) -> u64 { - u64::from(self.value()) * u64::from_safe_cast(kernel::sizes::SZ_1M) + u64::from(self.value()) * u64::SZ_1M } } =20 --=20 2.53.0 From nobody Sun Jun 14 17:21:05 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011066.outbound.protection.outlook.com [40.107.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2837D2980A8; Sat, 11 Apr 2026 02:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775875290; cv=fail; b=s/hzDXx2eoMpu0gOjW7Ya60ZLNSw2jdpo9AsfvBuZN8FNScCTx5OIOHM5D/nG6zTsjckdG4HQHSinoH1guxdJXjax41afFKlW/KL5OQFEJHa6RAZJqd/tqmAtZJGvDRXOkBgO1LkVdP9jDKQr8pfmtajuPx0I8e4JmjQsVD1+oQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775875290; c=relaxed/simple; bh=p0PS25zabj/bq4C5tIIX2U1aVXEscon7qY9nYct2SrY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=DNUbC7wAixh+At0Y6n+AW9fCY1Wl4ZbNTQMcUe5Z9C1jSaBetG9G6xfmYTUwuB/MtKvUxJZz1ggmqq1P01JmohUUEcbniAOI+LybJpTSyN6NnFScoiV3as/tJstUnq9RUm6TRIYhkf6fp/G30S7ap4pVNxobZMF5x3ta+oSYF7E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=rt4+CO4r; arc=fail smtp.client-ip=40.107.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="rt4+CO4r" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mJ42VuuDu65SUKEIxGtfVbZVNG6zBbahhMaIRk5dbg72pljjZYC/5J3FYXpBjbnsAvD5Cu5Z0betOf5l/no7Lw4oAqMwj/3XMX/XTY64NKxy4COBOTygJX9kCYEf1ep0PC76VD+J0j39DVkp3F31qSXoOWbQg56PotyfiZqCacYIFkHXA54ClAzDTEkQP6upS/dRr3oJ8eEQAy7ruUYRnbBI+CUxwCvicyZ518w8qu+U0iJw1dQsr6yQFt1y6gjAD3F6RS4bAOPZY1lnVXncfxUIfj6m8zu/sOawHQAJWy1+L7XE/XZrtVOMSQBmAc3vHKq9qUOJLbPJjO3g+O1nBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f6oNjrBL4+Denvc/CvrCeGZS8/cpdlSthnL4I0VkrpE=; b=NwpLI2j7hVbI2rZjpcm/TSvM8FojQTegGbsxIqer1v3ndVZFsjxLeZzLLkWa2C4b/2PdIcUI5KspcBZ1wwrdPgLYslt2x8GuQr/uL0AqBcytojiqpe5tfEG1KJH8G48h/ntcr1F21BG5ZI/lfwZNYyqtEL478VTQuz+jDlbsIpd5twJFzvoDW6P9pkg/WQdF+GuLhou3pMl5yqtCbhKZIvpi6x2YMn7GxghwpCHcF1V+HQBN7prHuq8G8ms4KrQJN+i5Csyw+WQYxqJIIWG3AmbRLxyqcjmSrAjGVWW4EJzRpPq3u0/MJ4zaP+PBI2l3RWYPVLEy2XRdYxp2ZtYDzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f6oNjrBL4+Denvc/CvrCeGZS8/cpdlSthnL4I0VkrpE=; b=rt4+CO4rjmlhr18sWGQ+sZdULyfa/GXGfmJHs6I7mAfbPn4h4kXoMxfZpofUZS45CZ3u0ZDMEa0sf6wngbdAB7yY7FTWLlgrbogNHj+M7EfbG2cj9+wV5BkLG8+FsjB5B2wa/3D6rvrkDUCIzxIZLgI00XzhIX0qirjqRlYJUPLLD2qZQjLrgxNsUFiz5NMHERZb0kafJkHxUb5f+SRD+PEGKYW0TaBP39gNPvTfcdaZyidSIJOzj1rshAiin3/rqhtoKHhaqaAMoF0nsnB7xPwCcv1AgZXD0O8jhWw5E+yzQ/eLUjJA3Rh8z9bUdQ8TretRGmAt3ScjfGmIx6xXMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by PH0PR12MB8775.namprd12.prod.outlook.com (2603:10b6:510:28e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.46; Sat, 11 Apr 2026 02:41:24 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::8cdd:504c:7d2a:59c8%5]) with mapi id 15.20.9769.020; Sat, 11 Apr 2026 02:41:23 +0000 From: John Hubbard To: Danilo Krummrich , Alexandre Courbot Cc: Joel Fernandes , Timur Tabi , Alistair Popple , Eliot Courtney , Shashank Sharma , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v6 2/2] gpu: nova-core: add task for device address type wrappers Date: Fri, 10 Apr 2026 19:41:18 -0700 Message-ID: <20260411024118.471294-3-jhubbard@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411024118.471294-1-jhubbard@nvidia.com> References: <20260411024118.471294-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0240.namprd03.prod.outlook.com (2603:10b6:a03:39f::35) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|PH0PR12MB8775:EE_ X-MS-Office365-Filtering-Correlation-Id: a07c539d-4587-486f-1e67-08de9773d22b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: d4o+zHh9nTd6k4GQNPtlQPF69Nxkcyfir+Jnrx+o06RYFuhqwyOgcLioadez7knF+slimXd7lsa7vnLBAD4O2xT7lsmpwO5aXY5PbwCwqBbPOpUl1+USBaW8CIdVktr1zZyYURw12xTHv1Hg23qHSbD/uU3yTd9odhiI+pq5p5pjjdS8/UasNpaB5cJ8/4UWvnJ0h26aW/1awmE7gis9kVJoooLChOcsJPKndsxXr1GN1WggxyWIWWvmtZE99TTizami+2etB55iQUpuAwlUCJpv0+VuNiZlLkvaRDoIOsZBXWn50U9+rPzTx0LGNJ5QkWoh/wUZP67EWw5KK8BTSqR0DyqNNHerodFScmHmIldlx8g9io0CGHlfruT0PzvZhVSZxuhg8XZ4f8jhmZvtnIhnChhtrQ+usrvWs7uucpHbLnVnE4mA8vKNtGt6FVnMYXCmgS2KET6yRwqOP1mRREIP8p4t87hYOXz+F0+ZPlPQSFhY2jJHpLXFSdAycH7T7EMhVxVhept4g1jFe2bvJRtVmwVRJK9fvrJeaxSnuTolaydtQCiGIuwBoVhxMbi+Y7q68vJQKobpR203b2+k37WgJRIrGFw+nIBOiNjMuTBHnxWAhv61sBS6Gxx44uULiPUN9nOLF1q3I3alpkzUYIaiO37nGgL/gwCoCTUzp3pMCRYSdViSlWTUTFD1Ll/CBXrq0yJRdIJeSBqkvzWgLKKz/0sqgutJnR8QG5kcYFI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K8r3PNFsgSimpCAxE6buzLpuyIcbMhtwvBstF7Zml21dSuVCbnc3XvqLizjx?= =?us-ascii?Q?mL+BvcmIM9CgTST9EcVf+GqZBbpIREmCVDoY0+gHQXGEAUhhui/bf8GUL4sE?= =?us-ascii?Q?wGPpcmtMjX3OllSLDPRyedO4I9pqbTfvENtH42oWZ3zoonNTOxudLnYBVBcJ?= =?us-ascii?Q?l+WJd2jy9AbKxDbJF89473rMY5CjmUtG6QTyl68MyjK+78opW0aaAySDruHi?= =?us-ascii?Q?ajkzOJSrW12uWnALO+2xActXRn5Y7WQjkv6nxdlytMTfKfHFvEY8MvXld4WI?= =?us-ascii?Q?J8kQ5vx2VdmjZJqva0XgJpLoLr92ved2rIc2Ym3UHNX55tAm06m4hv31Im1W?= =?us-ascii?Q?bRd0Ox4EgapYvZhSffumiujbTjeD+jD9icyuTOv2KCstNtqrisxi32bdBXq9?= =?us-ascii?Q?v9y93H677TcTMLhzMJmdLMtytT1M2b8Kx7anFWvlJfyIY51O9C+/HCp8iW4B?= =?us-ascii?Q?BuVTldbU/WGoQEhCw9m6WGIMx5QxndPUJ6gC9d0wcnXZhq1csD9xZ32qpjqG?= =?us-ascii?Q?ntiQwI4u03WnOqJT/gclb1nlEteHiduD5rSfA3V5PQU5mRlOT95u6OEF21jo?= =?us-ascii?Q?35ne5d4EWnAorHXDSLuewnq/G3D7xDI7pyQvc9fc0FcpZjodLnYNqVfSmmsp?= =?us-ascii?Q?Kf+lp3upb/ex817/Dc+9GGJNKx/zxsTnDjBFtq+3rIvI61ZxP5Jmc/VGUEsA?= =?us-ascii?Q?GBCN/H1fKBBn7B85zg93ys6VzetzKSc4/C1gPvHvmqVw0bpUG+iNVucAPljM?= =?us-ascii?Q?G1dWbQS/pwOfyHwKcaqSSO+iotNgIB3L4P0Z8+4HEs35QjkmhW8RqP5qhp78?= =?us-ascii?Q?TKp+rAgGJYTyELIodMUbIKeciyArVRFpYDTF+wCDwcSgQFDTPlaw8lr5BC9B?= =?us-ascii?Q?/D8pq7CLKMpTnirhZNnMCxoXY0ztmiZRzBUvFJgIDqAxIKRVTXLyv0V0haLZ?= =?us-ascii?Q?zhAJkc3XXeQ0ZTVXvqiWF4hRSGSEtlqPi52S0nMzh66pmXKq8+7Loo+wfuTp?= =?us-ascii?Q?M2Iv2zHDznKa/WY8U2Nv6tk93TYGxoUBsG45gKYlEl2I/FpB5cYGQXaSKQgf?= =?us-ascii?Q?r5IdKedXUfdDV749WuhURwPY9NFNJ4e/hI9oxl8XZE5i5ShvjfL5v6/HN6mp?= =?us-ascii?Q?UHLLjfkwlvg+hwpzTaO6BeRCknPcYviCTaHojTO/x+ydl0ui3gi0g3rG5Q2e?= =?us-ascii?Q?q3uBmJ8hFfOGxLVI3z/aLIxCBc7RsXqu6bqeIMSAqFFt3bOyquNzC3Ac2asV?= =?us-ascii?Q?jg4uynUabWUG5y7YUsp9jsUMPVAXm50fQP1wXFIJxRClHggdS6jGcQrTbxru?= =?us-ascii?Q?L/rL6mfsdUkO1YX5DpT3S7qmt/cbjAa9/g2U0uM2xvjdTLG8pUpoLzcmXGoP?= =?us-ascii?Q?K+oQSQg46QXLiUSszk8xtYXEw0zOSx22Ymk+ce2lMOEjzBjB5ytVWKTjYPeA?= =?us-ascii?Q?42r40HQUTCv7/dQusAWySBojpdihQQRonNvV5RITQsNAR6Zjw6F4gs/AIhot?= =?us-ascii?Q?q5px9EmnOUdIeZoe2YXkChiAwVJPh617P+lZ2y0mDRRJGKmqYQrfQ4OcZA3q?= =?us-ascii?Q?+wnwHYtUOpsmALhquiPU5SPsKtmXxqZTC4myj258YpVsufBCj4eBiVifiGs4?= =?us-ascii?Q?/TQCquH9G4bbbKJA/IMv3qNueepnBnzfk6prSIjCbhwVpi3Qr37w+CXi8PGO?= =?us-ascii?Q?K9T8ZiOR6Lath9u1G3XIE9nhQgBNpBpLF8TTolTSOs2tBNs8CDF6yqxQC1ot?= =?us-ascii?Q?MIo3pexowQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a07c539d-4587-486f-1e67-08de9773d22b X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2026 02:41:23.7775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q+WWyYiHEooM/xFA+ieh8wqUL1aYIWOcQZiOM42Nst8TYg7e9PL+QL1I6U6EpMNSYqFAJqx9otCTjjFTHO8OvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8775 Content-Type: text/plain; charset="utf-8" Add a todo.rst entry for creating newtype wrappers around integer types for device addresses and sizes, with a marker trait that generic DRM APIs can use as a bound. Suggested-by: Danilo Krummrich Signed-off-by: John Hubbard --- Documentation/gpu/nova/core/todo.rst | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/gpu/nova/core/todo.rst b/Documentation/gpu/nova/= core/todo.rst index d5130b2b08fb..595a94e9ee2e 100644 --- a/Documentation/gpu/nova/core/todo.rst +++ b/Documentation/gpu/nova/core/todo.rst @@ -88,6 +88,20 @@ SR-IOV [1] is work in progress. | Complexity: Beginner | Link: https://lore.kernel.org/all/20251119-rust-pci-sriov-v1-0-883a94599= a97@redhat.com/ [1] =20 +Device address type wrappers +---------------------------- + +The ``SizeConstants`` trait provides ``SZ_*`` constants as associated cons= tants +on ``u32``, ``u64``, and ``usize``. Device-centric APIs such as GPU VM +management and buddy allocators could benefit from newtype wrappers around= these +integer types to represent device addresses and sizes. A separate marker t= rait +could then serve as a generic bound for those wrappers. + +| Complexity: Intermediate +| Link: https://lore.kernel.org/all/DHJJJNP5T5FZ.2HWBMOEEKH9ZR@kernel.org/ +| Contact: Danilo Krummrich + + GPU (general) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.53.0