From nobody Mon Jun 15 15:08:02 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5DA723EAA3 for ; Sat, 11 Apr 2026 01:07:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775869631; cv=none; b=Ky1W0+Z96W1rXJN4tbipWGO+Mt46bkT46VOYE3NmphIa8h/ZRQHVfGm+HGfKICEyVShVgjbREUmu5rN+9LAxZAcHaRngwHJ/ah6/OTkbP32bLrnVF+opskw2AWF8vFZAiaHoNkqxzLxf7gHy3kgDdfUH79ltz57rS3gAL+Bc0e8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775869631; c=relaxed/simple; bh=Lkf6pJKbVlEnLqcmDhxURhl6NyGJpH/DUeXkEO3vlQQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TmHAQIWBHFR7RgcILqOFphrNU3IvodtojR0IY9QXD35aCi8MauGG34BXC7NCFyyRuSEB3FNq3DAg10BCHhKCOOeCelYN09TlwPnNB8+WRPLWPrSfR5X6h8VgIxFLYtt73vfWdgqAUL9NYXgUnCkc10cYBdYUGcTipRQvnzEfXJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FHeWgTrF; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FHeWgTrF" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-483487335c2so27921045e9.2 for ; Fri, 10 Apr 2026 18:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775869628; x=1776474428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VXgKZw4TerZdjUCdZpd91YopqLadLVyAhvrKe3AYvDs=; b=FHeWgTrFRseewzx6bIShYHOg54b/fKE2xfrmvlo3xlwDq532qsGeD327bm9SxhI8jS yg1gGHetySFgRtkPhKJOVpcbtK7YtZJ1aX0jTEzaPUCTxVobQ+eu6ohpEEzNCGaU8ujX 5nYJ8UiuM4GX+GiO8ycqK0n8Z3RfZgv1Xg9MVIMfmowixFOtrTq9vh/MGKeiQi0+rQpx CmOszIuu3oRSYhPHLecXXUxvKKbfeQ6bj/2bowglW4CaaSJz4IWQ3Tod4VAyO50UZD2b LcLt56VGKD4PAZ4KU0ril2ch5E4Hyf+kA8Vb6nUeM2kRZvjauYd6r3lpIld11VHdXluB 6aFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775869628; x=1776474428; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VXgKZw4TerZdjUCdZpd91YopqLadLVyAhvrKe3AYvDs=; b=cVNEy028qNDLo2pLkmghi+ItenR0QadBK7r6IvoaiODALhoC9DyWfZCnd1wmpdpROM rMTPH/cxODH4+MsI5uJnxOyZDLPZIJi6+i5DIu3SAohUFQyVKSBwJll/H1zWRZ+iX6Tf 0yNj9DB6bQKMY5+dev6+hvxjRarbyERkRyL2ZJ/y8N7wV2ihuapH4TK+drJ86h2GwsK5 YEZ/TPuQglzbG2i79nFmuS5+WrjdHLhV+HN7yxewkiC0CGRQaeBh2WHH0Qq0MIv3m0/H p0zbYYUcmVXXs/JorrxyHbKf8qpgtT1m5mXeN8kmhNu3EdbUP3z8Opyrck3KIy/nRJsQ TLUA== X-Forwarded-Encrypted: i=1; AJvYcCXqJpFL5xV+ZCkwKm6FUFdAkajhVq6ZISgONFSa5dxp5+eKofbYkWz2iA7fGrZFtYY/K/ySxVlE3a2YR5A=@vger.kernel.org X-Gm-Message-State: AOJu0YyA79Yg2UJxsKpvJXnPQw1q4WBR0BzmrBfjkgtXaavywgpLlsFi MW37iXBoegwmrOsViQhScBWVOAf4gga3vyKs9Xpsq9xdwvJwkRhaVmaB X-Gm-Gg: AeBDievZnlq8ls5vDGm7xYZoHDD888vtZ0P9JtYPF6PrtxkE0+3s9kZ4AhgkJasAE+A TMXU5k0GD9f9yP/C/fljqzFqKb5xLGvB7VFKT2IR/QT4H8f30qFk4e+7ayO7JqFcwHdMnvbs3O4 2xMUGJFS71Za5dpOgBhWOX7TnlLwPk97b5EbU/pIw3ySONbeojC/IjzihLsqltBAF3KhyE0/oQn I+JnMjfpn54NEUgjOWcsKOpPF41AF93hhkdQ6tdGq1DyBtd8E8JAc4/gGe6MV998sAerdCsJAYG GWXS5PmkQX/uYL6F3M4IgUKRZRSdiWeyAoOpAunJacKTUu/ZAoZtTyzSvlSYiGErJhasehuOAQ2 YXh5uApCBkvOH1bD1/t7rNEmDZWSq82OklI+HqRKDmpga0DlWgozn7Z6dp6wyW/EtoAl+IzLq+B T8D+icQYB9qRZy3r1dvP5a2XLFOkYw1wE6BUqnR58adXfxxK5LcQ7ZVGJ7tSmOAnxYnmnQ X-Received: by 2002:a05:600c:800f:b0:47e:e2eb:bc22 with SMTP id 5b1f17b1804b1-488d67b8d81mr68725315e9.5.1775869628136; Fri, 10 Apr 2026 18:07:08 -0700 (PDT) Received: from localhost.localdomain ([2a02:6b60:60:a500::100f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5b3d4dbsm108662525e9.14.2026.04.10.18.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 18:07:07 -0700 (PDT) From: Hussain Qadri To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hussain Qadri Subject: [PATCH] drm/bridge: tc358762: Use mipi_dsi_generic_write_multi() Date: Sat, 11 Apr 2026 02:06:48 +0100 Message-ID: <20260411010648.39585-1-hussain.bqadri@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver-local error accumulation around mipi_dsi_generic_write() with mipi_dsi_generic_write_multi() and struct mipi_dsi_multi_context. Signed-off-by: Hussain Qadri --- drivers/gpu/drm/bridge/tc358762.c | 46 +++++++++++-------------------- 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc3= 58762.c index 98df3e667d4a..0630c4078987 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -76,25 +76,12 @@ struct tc358762 { struct gpio_desc *reset_gpio; struct drm_display_mode mode; bool pre_enabled; - int error; }; =20 -static int tc358762_clear_error(struct tc358762 *ctx) +static void tc358762_write(struct mipi_dsi_multi_context *dsi_ctx, u16 add= r, u32 val) { - int ret =3D ctx->error; - - ctx->error =3D 0; - return ret; -} - -static void tc358762_write(struct tc358762 *ctx, u16 addr, u32 val) -{ - struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev); - ssize_t ret; u8 data[6]; =20 - if (ctx->error) - return; =20 data[0] =3D addr; data[1] =3D addr >> 8; @@ -103,9 +90,7 @@ static void tc358762_write(struct tc358762 *ctx, u16 add= r, u32 val) data[4] =3D val >> 16; data[5] =3D val >> 24; =20 - ret =3D mipi_dsi_generic_write(dsi, data, sizeof(data)); - if (ret < 0) - ctx->error =3D ret; + mipi_dsi_generic_write_multi(dsi_ctx, data, sizeof(data)); } =20 static inline struct tc358762 *bridge_to_tc358762(struct drm_bridge *bridg= e) @@ -115,17 +100,19 @@ static inline struct tc358762 *bridge_to_tc358762(str= uct drm_bridge *bridge) =20 static int tc358762_init(struct tc358762 *ctx) { + struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; u32 lcdctrl; =20 - tc358762_write(ctx, DSI_LANEENABLE, + tc358762_write(&dsi_ctx, DSI_LANEENABLE, LANEENABLE_L0EN | LANEENABLE_CLEN); - tc358762_write(ctx, PPI_D0S_CLRSIPOCOUNT, 5); - tc358762_write(ctx, PPI_D1S_CLRSIPOCOUNT, 5); - tc358762_write(ctx, PPI_D0S_ATMR, 0); - tc358762_write(ctx, PPI_D1S_ATMR, 0); - tc358762_write(ctx, PPI_LPTXTIMECNT, LPX_PERIOD); + tc358762_write(&dsi_ctx, PPI_D0S_CLRSIPOCOUNT, 5); + tc358762_write(&dsi_ctx, PPI_D1S_CLRSIPOCOUNT, 5); + tc358762_write(&dsi_ctx, PPI_D0S_ATMR, 0); + tc358762_write(&dsi_ctx, PPI_D1S_ATMR, 0); + tc358762_write(&dsi_ctx, PPI_LPTXTIMECNT, LPX_PERIOD); =20 - tc358762_write(ctx, SPICMR, 0x00); + tc358762_write(&dsi_ctx, SPICMR, 0x00); =20 lcdctrl =3D LCDCTRL_VSDELAY(1) | LCDCTRL_RGB888 | LCDCTRL_UNK6 | LCDCTRL_VTGEN; @@ -136,17 +123,16 @@ static int tc358762_init(struct tc358762 *ctx) if (ctx->mode.flags & DRM_MODE_FLAG_NVSYNC) lcdctrl |=3D LCDCTRL_VSPOL; =20 - tc358762_write(ctx, LCDCTRL, lcdctrl); + tc358762_write(&dsi_ctx, LCDCTRL, lcdctrl); =20 - tc358762_write(ctx, SYSCTRL, 0x040f); + tc358762_write(&dsi_ctx, SYSCTRL, 0x040f); msleep(100); =20 - tc358762_write(ctx, PPI_STARTPPI, PPI_START_FUNCTION); - tc358762_write(ctx, DSI_STARTDSI, DSI_RX_START); + tc358762_write(&dsi_ctx, PPI_STARTPPI, PPI_START_FUNCTION); + tc358762_write(&dsi_ctx, DSI_STARTDSI, DSI_RX_START); =20 msleep(100); - - return tc358762_clear_error(ctx); + return dsi_ctx.accum_err; } =20 static void tc358762_post_disable(struct drm_bridge *bridge, --=20 2.53.0