From nobody Sat Jun 20 19:58:42 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 244AE3A6F19 for ; Fri, 10 Apr 2026 21:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775857303; cv=none; b=LZJ0MT40pD88WEuVpyVGsjaFaXoXFtd+OXc1LlMKsI34W/Qs5OWPwHjgv7KP6MQxpOvtZWeb9jYACfs1w7MCaFpFK+O+maGihpcLPHXLUbMaqfSZ/ouIoHbvduhhPogBf10djAdkdlpcs1EnqixCiq80lOZKxtZbYTGsxBFSSvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775857303; c=relaxed/simple; bh=oUdIv2n/8Ehvb2lnbhg+EcMTh8GtWfsgCktZOCe4DD0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ELxTCn+GZjUoqzZdzONQMie3G+DNDRAlYDMTCDJjttNbIKUhzSl9BGmv7MXZWEoiUhfVulBlLrQj/MZkQVDiuscHFsp+F4LBA3sH5lViC7bN70j3OKAzzJ36kh+VGkmSxXOl0d7u+N4ccwFquXVG8zABYzCe6iFuqAL9yiL5vZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rJGgaZdj; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rJGgaZdj" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82d0b68837aso1519444b3a.2 for ; Fri, 10 Apr 2026 14:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775857301; x=1776462101; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5XoHxj2nRC4e86b/a0jiAov3b8pnJ0NILSyDTneQ2a0=; b=rJGgaZdj3eik82s4VR53sO41goccLJU2nn6NMYZ1pPmwsYOORoAg3giWeTK8q/I0ju H9Zp7Pw3hgmkE42nzKwsHxU+RvtPi6FKxvpgcUNc7K+vXKyFgTdo2hTwdZ5ZJt4lILru APDwy6AdQWjdP28KCnHOiWkPBWmoyYUdGWobgCb0t0W5w8O55JF01nqoroC370euRJqe AYOrd4wwsR8mZ/F26GNzpf8hak8Uz4llzeJ9y9BVJqg/irEDol3MQVFWAxe61P9n3noG BbGlHE9vMm5uitNFN/mlW3MX68uXmjw4T+kOa3xdgJApGh/gylJv0divl2S+E1pasl+C bYCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775857301; x=1776462101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5XoHxj2nRC4e86b/a0jiAov3b8pnJ0NILSyDTneQ2a0=; b=ex286RHOIjOiF2R8vIpaPns5UW8sgnCd9c4AQqighSeUlhxTccv3M7gDmgSqHti0Bw Cj1bdAGuk2wMqd/LIyssJjQZZbR/LC5CoVHlI9XTC0P8J0fdc2wm2UfgaPZXGbTsnysk nUNNzP3879NgF7MWKJG8pw8uzpOFd2itWDJIK2WEtAsgeYJmOqyvvI+z95kounTwKOJ6 gWmWhijQqs98KqtxVLGkVrXPuGT4SvXrZY/f4Hwso3RtloS5tNLMwlrunrlkIfFibkK/ NG9lKEA4bLo1/4WsFuanzzFUYcE35maPoAK1dTQRvBqCeZD4zueUyWu5qcbJwA7tF0jr Pefg== X-Forwarded-Encrypted: i=1; AJvYcCX9JeDhe3dlpF1dk+yGgLXmPSovhnTUdlSaiv/lRvoy9JrxCn+t5G13CgbfW1PS0SPiYDKEyVSlGAjNQiA=@vger.kernel.org X-Gm-Message-State: AOJu0YyZgFjGT7Qx7krizcZamSRoz3pBUDi6dj/PSenVzAUY7eq+aQAw Ag1vxo0FF3xdfBLvUDuG3DaKj3fjfIJk2l+BXVwsrPl4NJBdtblNG5fc X-Gm-Gg: AeBDievFAUo6Ovn51mTTZi0QRWPKSi9ALo301fuDnn0X3iVxKGnszZv+FvVgrY9nucs iwhm3lmod1MNPV07pd6x1+BHbb7PBwMbadVlXqmWpv27qAzXKL2znGWyIv/7DohBZmHvotJ1mss CC/rUCj7+3x1qnRCv5wbsmyPUKxypBCueyywha3zpUofUBXw+pP+LGbqv7kO8NB2cSrcTyeYO/F 2pLNiqFD621BKFuNWoAhDnlNxMohso8Eh8IWmTTzj6sgAwnpnkao1vkIKR0bYZp6DB/JwXc80GE bzOFPwrwQT1OpburGl/RLw2yOp/d0Yp0bpkI9mMyIL05h6dHQMj8xGJ4a3eSQTKSDtS7VciXEb3 AQ39wi0Ns6tpcoK2OxOgzXOcBe3pEkqFoxkJP8F4YLLXwCBklQ3FuRceVOQzBva+vEc55nmO3Rw Pkwj7xfof9vwD1pOWgbeXUw6h998/BE1fUI5ghfWu1ah32114TzN7S7kqJgCY7cAxJqv7neewA8 B3UOMzhyJmVPSHiboTqey4Gvev6MHO/ayBA1zYZ X-Received: by 2002:a05:6a00:330d:b0:82d:99d:5a39 with SMTP id d2e1a72fcca58-82f0c3649eemr5879362b3a.50.1775857301521; Fri, 10 Apr 2026 14:41:41 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.. ([2405:201:31:d01f:a107:5c92:b303:910a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c338dafsm4210533b3a.17.2026.04.10.14.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 14:41:38 -0700 (PDT) From: Piyush Patle To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Daniel Lezcano , Alexandru-Catalin Ionita , Felix Gu , linux-kernel@vger.kernel.org Subject: [PATCH v2] iio: adc: nxp-sar-adc: use field_get() for EOC bit check Date: Sat, 11 Apr 2026 03:11:25 +0530 Message-ID: <20260410214130.188694-1-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use field_get() here now that runtime-mask support exists, and drop the obsolete TODO. Since NXP_SAR_ADC_EOC_CH(c) is BIT(c), the resulting !-test is semantically identical. No functional change. Reviewed-by: David Lechner Signed-off-by: Piyush Patle Acked-by: Daniel Lezcano --- drivers/iio/adc/nxp-sar-adc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c index 58103bf16aff..d6c2a0d50bb4 100644 --- a/drivers/iio/adc/nxp-sar-adc.c +++ b/drivers/iio/adc/nxp-sar-adc.c @@ -316,11 +316,7 @@ static int nxp_sar_adc_read_data(struct nxp_sar_adc *i= nfo, unsigned int chan) =20 ceocfr =3D readl(NXP_SAR_ADC_CEOCFR0(info->regs)); =20 - /* - * FIELD_GET() can not be used here because EOC_CH is not constant. - * TODO: Switch to field_get() when it will be available. - */ - if (!(NXP_SAR_ADC_EOC_CH(chan) & ceocfr)) + if (!field_get(NXP_SAR_ADC_EOC_CH(chan), ceocfr)) return -EIO; =20 cdr =3D readl(NXP_SAR_ADC_CDR(info->regs, chan)); --=20 2.43.0