From nobody Sat Jun 20 19:58:34 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334633A7598 for ; Fri, 10 Apr 2026 21:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775855621; cv=none; b=CIcW6XX2QAL6diktoV+hOB2VNEvR7bAkFdipz4JJiMCO06HdPGoGUCmZ8czj7YKe4alr5qKMlfuPN4Fp09mFq5W6AR/emxAE4NQjAVIR+AZJDFonBBsUYDSvp/579KP4zSfWIdnhf7XVX1uWRV9oan6+rRlbB0775zVSpIjVU+E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775855621; c=relaxed/simple; bh=RAozP+VbHyQFKYgEz45qjCh1Ow7iRHc6sS2QirPeX6k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NdmHjc3mjkF6syHiKQi6HitL9jzXgHe1GL6T5OU5AiFdNhrl725DAAcNnOf3JtpQmIzLdC9QH0cvtED5oEcozY68datbymNloDi8KipJQGfkxNY8C4E01AFFZYMVst6o2kGZtxq/oz+BOA5a/TDgzi1ejMa2WPeMHAaRAgSB37s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bpy1eBNx; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bpy1eBNx" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35c238f1063so1833917a91.1 for ; Fri, 10 Apr 2026 14:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775855619; x=1776460419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Oa7RWE7GfngIzdmApNxMxE+R7EIFKob9N3wDr4D9W60=; b=Bpy1eBNxfC0IKIYGwYGLYenMjS9XC2URwEY+oOWKg0tutMKAo9dkPXn9lcH++bl3bn R8Pi7+wuCcNQWpuNoDC84FUVsls3rjNxDb85SVG2rkZQOfLXLSPwNzM6El3j1o2bXmgN 7rocMDB1ATitoAP5IrYMKjI09b4OFNG8ljHPkT5/hLCmF+b5VGEwV476+DxTsEuYVgnp 0Eo/Op1ebLhOLACWBF7Ny9srn3a4u6fM/miK2s7mwudyolgBUUYpL8TNs+qWQM9/gd5g ufDhqxipVQp07xbgE80GXWNY5f7B9egGL51hn3oT0Jui0jHeZ0MP3xgXcJO1/BZ4sz70 W5og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775855619; x=1776460419; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Oa7RWE7GfngIzdmApNxMxE+R7EIFKob9N3wDr4D9W60=; b=MYHzo1zQTkmZ1bxgl5Np4yIUuml9ZOHVaBYCsizVwYJSvp0rB5eFAsbYPCATVVoE18 YV9VSZ9kcWfBuYRHbuqEpcDDVJOyPn+5bbe14wCfpHgUNLM4evjp3qmfxcP15P6Uul4z XGN7Z00lNfdgiE56Ztrymo0VUONoKtLZnco4BZVzGPescB6idFQSov1blnmF9qHxrPb7 AL+MNYzr+XCjMomi3MBdEPdKS0QCN3BQTWeZElMwV7yexv+t4jDymIHjzoVzpYZ/H/nY ur9FPiN0eBtRbEoKqw/0Fm1TtpN3gycqZBoDxPaSTLzsHugJVfsYFeYfJfqUJk67SwfY Lcuw== X-Forwarded-Encrypted: i=1; AJvYcCVvLXFq1x1C2GEEabFjvI2u3zFMXZ4+448Ev72iYRzrVNFFKXM6MAzYOINOgsrod1/0EVJiNogSol/qvn4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz58MkNKq2bkYilCehJ9BamCmVwBXdxCk7Bzt6EFAOoUjnUY1Ra V/TIw4D2BZpyBQVHNNz19RXGnhz9iXSQ2KiSRYZO/qAat7WR0lqUkrcs X-Gm-Gg: AeBDievyBYeuedN8mUBoxWCMdrYg0ldBNTO8uBpk4ZoZwVzwcYTu7L2dhRwTtTPOPpY uO4oBsykwrLYexHW5SXmRcEk0kRbWx1+H8Tcgj+86Mqw8GwK2ab49Ni7cqdGIB/qlvd86bJArQa Rvxg3fbMhZMpW0LCjS9x1x2iXhzgan/Ar0ByrkMiBaw6paoDQ5exbdygQYrHrdStFLGDDmZk0+7 9A9qHOF/nD8xdgumnoo8K6maYSRyN2zO/MJ9QQjD7QBx6Liki1yZlOWE5IFasu01aZjCnJWLkpY Wee3Eerikye7XDV9QvR4ELW66u5IcM0fnRa26dPih8IJgCWMun8KF8jOg8PGnd6V+Fc3FBvJF8I uxObqqJm6LFk6q4qh6+nAdkHGyUPNjWAz1VZMYvLye9KEcA1zp71o3XqI9pxyKfoQdbuyiP/x20 GE2tJ/Y+cMTTSpqgl3tsi0xXZ1Sgq2TgCNgessZL9Iwx5dcpPBd76rXZCbIQhfOA727h3B3qW0l ckazc1vBGYeUn4NFGJlBrxEAyFMECyQzYClFzPs01wjMBnxU14= X-Received: by 2002:a17:90b:2c88:b0:35b:b907:370 with SMTP id 98e67ed59e1d1-35e423fc9f7mr5274097a91.0.1775855619461; Fri, 10 Apr 2026 14:13:39 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.. ([2405:201:31:d01f:a107:5c92:b303:910a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e35178460sm7684743a91.16.2026.04.10.14.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 14:13:37 -0700 (PDT) From: Piyush Patle To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Daniel Lezcano , Alexandru-Catalin Ionita , Felix Gu , linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: nxp-sar-adc: use field_get() for EOC bit check Date: Sat, 11 Apr 2026 02:43:24 +0530 Message-ID: <20260410211329.185147-1-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver uses FIELD_GET() for constant-mask fields but falls back to a raw bit test for the per-channel EOC bit, as the mask depends on the runtime channel index. A TODO notes that this should switch to field_get() when available. Use field_get() here now that runtime-mask support exists, and drop the obsolete TODO. Since NXP_SAR_ADC_EOC_CH(c) is BIT(c), the resulting !-test is semantically identical. No functional change. Signed-off-by: Piyush Patle Reviewed-by: David Lechner --- drivers/iio/adc/nxp-sar-adc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c index 58103bf16aff..d6c2a0d50bb4 100644 --- a/drivers/iio/adc/nxp-sar-adc.c +++ b/drivers/iio/adc/nxp-sar-adc.c @@ -316,11 +316,7 @@ static int nxp_sar_adc_read_data(struct nxp_sar_adc *i= nfo, unsigned int chan) =20 ceocfr =3D readl(NXP_SAR_ADC_CEOCFR0(info->regs)); =20 - /* - * FIELD_GET() can not be used here because EOC_CH is not constant. - * TODO: Switch to field_get() when it will be available. - */ - if (!(NXP_SAR_ADC_EOC_CH(chan) & ceocfr)) + if (!field_get(NXP_SAR_ADC_EOC_CH(chan), ceocfr)) return -EIO; =20 cdr =3D readl(NXP_SAR_ADC_CDR(info->regs, chan)); --=20 2.43.0