From nobody Sat Jun 20 19:58:31 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A129369970 for ; Fri, 10 Apr 2026 19:42:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775850146; cv=none; b=s3aQORk9xMkdGv0aXKif3QM+aCR+x7wN0xfJyDz7zNEw4OB+oTySiduaW3uX0vokzkUXLqTtm/wDL02s9x/HxkAvIFs5YNfV54nke5u63ssPgBWFDlcHo4KByHh4yhz++h6Yu2x6IFNvocIDPoichlJghcVfWajA8C2AajvkAO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775850146; c=relaxed/simple; bh=Rx+pCPJ+cSid1cDNZQQQVCOa/p789u2gx5Zf3Jl57oQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qNcdqSDiCkNmFLW7KTE+6q6vO2Vh4Ltbl+BZH7y6hTN9DTbfspYYNWw5VTcuq2IlWwsd+9u1gTQfj4otufe3q3PPsSOVTyyyGYAtIH8+Mld6GckbGGIu6bA+oWa35agNRBlR/bgCwo/nXkdcSZchc7TpDRXfQtQiItiNXxUu0sU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Isu5pa2Z; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Isu5pa2Z" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4889e045bc6so25982065e9.2 for ; Fri, 10 Apr 2026 12:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775850143; x=1776454943; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pKFmylcZHwINDUdrqzoRnUP/ALqk61OT4L3P94CMUZY=; b=Isu5pa2ZBwwxz7Riw3RmSay75wSiMVf6C/+76zF7WMentovWTvu5MDgAVqtNBSpq8d EKDeoymAnK1iltbxPPZoiddzjTQWi2n07trIUSk5qAwuuDfTOsbuU1tAk8ZPtb2KpvlQ SEKUgMfdSOSsyhHRc7qWKEDdBF0R+g2+NG04eDGjdyUNLYea7uwBPihoHbPKgSYg5A17 LL2phisdL03Iy0rCEGsSXjq96HBU8Au871zkJTlDfV1jzeIyVaq8eTFxJ8KSnaNG0LLF JYgs8VeL8uOR49TPIJRd5lFBwGdja/fZaA+7qHSgJpU7h+VUSNahwTCH3Lt5Cr8TzaBG 1Nsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775850143; x=1776454943; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pKFmylcZHwINDUdrqzoRnUP/ALqk61OT4L3P94CMUZY=; b=KODBo2X9U+Sl2/7ZWAFRN5uELBPsTcEw7X0d53V8rAuJKE8SUmSuMAkrEhIS81VQKV MUcTdKBY40UoTRysK56btJWllZj1/7yzB9eah7j1EP3hi6/RQ9ETKQ8JT+j+WnGA7tWb wvqBSofjRwh6y0+tn4D/Md/PPyUMUufhl742ovszRGRobweLOa3EBfJlTcZTs/prTusq HUO9SInfKZWPku/QUjZPO864EACGESmr39OMSt1PVyMFrTo4MHJEWRaxPFaHc7XdCv6K ManHKuiFxMxp/lczoethiTTDru8DA+ANPRiP0TjrfqOvgwhMW7ZaSFx220li6w5MoEli E/LQ== X-Forwarded-Encrypted: i=1; AJvYcCUdXE9Oy6eTNAgD6zf6ag0spWTI8ENMVGNAinah1qF9u1c1E9guHlOwSe2KEeO1BjyUv+MfN1Xv2QVF7/0=@vger.kernel.org X-Gm-Message-State: AOJu0YwAc57XIGzHNxe/GWbgvsAn3xvao4hARNILp+IiCaq5FENqmbol eKh3MrRLS7w3l8DvzEEd9UHVZNhiHM7XwNvE0+sfFoMEJu2wXDtj8Wpm X-Gm-Gg: AeBDiet+edJWJ8ka5iAL/vm4BsI+sitccbKJz0iVomQfxwTliGl5C6BQruxXGSNdOpI 30RRG3IQnW2jexMfQ4k1wasXYzV5VK1uWLK2A2cOeFKU4ieCCPUq7/JoWHBTk1klQtcLE/W5UWK KmnzohGaJZ+ZMcbjMSg/+c5jbxH6DIGWnhtQ6za1tbnpjBkw7aDjTLWANa6TfjemJJqa+++7xia nmBCOZMnQrPGiaJeTu2N4NoANzYvLdSDRjVK2CRuldDovcnpcgBY4Aazrb2aokAYQq0aJeXLDOn z670Y7qN/9YxaJrWPA4OpF7Sft/U/aq/FvZV1/H2QCzqmfaZ5zqGmJb3X6a+wtORp2jQs3qeQwM AhncgFiPRGmczYgJd6iObwjZTEqAN4eIzCwvUQabOdWGaolR8FuPgUylJ2JvXgvoPXGRpsdgAOS rZPDONArgSk3NhNyVJUGopSyj5+ZKuMzvMFUr/MNBCKAN5jo3rV5AWY9oP2hBlbb7HJ8FGwA== X-Received: by 2002:a05:600c:46d0:b0:485:40c6:f507 with SMTP id 5b1f17b1804b1-488d689dbfcmr57099565e9.30.1775850142814; Fri, 10 Apr 2026 12:42:22 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:d356:742:cb75:6153]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d538c03esm95714015e9.13.2026.04.10.12.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 12:42:22 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Alain Volmat , Raphael Gallais-Pou , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] drm/sti: hdmi: remove bridge when component_add fails Date: Fri, 10 Apr 2026 21:41:40 +0200 Message-ID: <20260410194141.275998-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" when component_add fails in sti_hdmi_probe remove the drm bridge and put i2c adapter before return Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/sti/sti_hdmi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f8222e60b1e0..839c80a7d954 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -1460,8 +1460,13 @@ static int sti_hdmi_probe(struct platform_device *pd= ev) platform_set_drvdata(pdev, hdmi); =20 drm_bridge_add(&hdmi->bridge); - return component_add(&pdev->dev, &sti_hdmi_ops); + ret =3D component_add(&pdev->dev, &sti_hdmi_ops); + if (ret) + goto remove_bridge; + return 0; =20 + remove_bridge: + drm_bridge_remove(&hdmi->bridge); release_adapter: i2c_put_adapter(hdmi->ddc_adapt); =20 --=20 2.43.0