From nobody Mon Jun 15 13:57:17 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 421EC212B2F for ; Fri, 10 Apr 2026 12:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775825266; cv=none; b=acHKGnRmiiQG8RVx5LNDhUx3T3Lh8MsSlNvLJbZ4D7pjgbdFLYIu7eR53Na+TCVHvm4P1UV+OG1TDwKMZYMkl92bOhh81iQawXysbMKwougBzqWpxaWBaX/ExwmZezK+EEHGbTrfZYWnv9TDgojEGaA9ynYzE7poU4e0Nbe9iLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775825266; c=relaxed/simple; bh=BTYqMuV+pUhcaJcdyMduMX4riHMFdcRbhpnNNW77Ong=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ocDgQODZ4MhlXUXyDE8pkJWc27EC18hAlQPFxAUDqeqbUIgxQIfXsCFcakW1Na85x3Sx9Lq80JbeqaqN2ihw3EDjObBzzugBTwE1l3fdaRWKpActAdGY1tp1A+7yiVktNW3qEQbZsAgUIc8+EeVvUJtFc3sk9NmiuGb6OdnwSi0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lK7H144k; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lK7H144k" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b2469e5117so10369275ad.1 for ; Fri, 10 Apr 2026 05:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775825262; x=1776430062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KoX3WbY7wSPwBwc2j2U0W0uZOmyQY8MWh9rOIhaU/PY=; b=lK7H144kTCi5OtKKo4vbeK630JnmkPxvJGtzurCKrJwwJITtf5ilNRkVPn6tssA9sT LP2qJer75qhEM2jRwsgw6vfhGhOtCgAKToDanbHTLyCjF8Etsz2x5dHAeJNjr00Y+7hb ZOlB1QcAjfhkyC3t0iSvc4rSLxL6mohTmje71tuU1YUIyg9iRYcOzAQEfJd5KIf0RFxP Ct5Hp505jDsH6NCEXXFAmNGizd5fh+MMvbzkDKpu33fzsWqSkzudA5dJz99gmAIYtN2k SjY3Bz/eylips5gW5z6NnDM/m1TmdSGgQA6Piyg/etoqlaiEV7iFZAjrOTXHZQanlNd9 nWYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775825262; x=1776430062; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KoX3WbY7wSPwBwc2j2U0W0uZOmyQY8MWh9rOIhaU/PY=; b=TH8F0rY6ih0rxg0sYTXg423jQYkMNENz6qYKNijjsT+91walz4DcOCNua/mWlaTePq ZRvVCg/gmdDemqCKyr6e+0n2Jm191EsgYiX7d6gKg04HvWuD/GFJwK+3zFD3tzzlIAYD 172IK32URj/ivifrpYYAEXvx9+T5ufpN6S1JimScmLfVUwBrRBgjrpQQf+XQzc5fHOnB 5TWwsvNBwcHWyDEGjucr/95XRmc6+wTPVi6Mvwjd5RvTTiJrOikJEp2H8oJVxLk054YJ WooU65r+EmMjiSAQ8eiWdMrue4ZgW09KltcGJRNS8d3nYTjIBDqPJITSrG/oQcj6g+U3 DYSw== X-Forwarded-Encrypted: i=1; AJvYcCV/qNqXJzyBkprtfWufR52wt1QbAHCtRpoXNeyDJcJMDNPtNcxxMSacw2UfZLpTVxncA0xG5FkxzD6H5D8=@vger.kernel.org X-Gm-Message-State: AOJu0YxbnqD1vP2jMk6oqFyJ2PKMuqk/Y96rpn/Xd2WJmmFCnI2mWXLn Mru7qGPRX7DUtDOIYNLKPU0y8R+GsmrNu/i2nsB5JPHkcL49SRkrP7bH0fWl5pYaV4dXQA== X-Gm-Gg: AeBDiesfQgs2PuXUJ8YjZoqHFvdKK8s0O4j8Ty6+I4cSxVHMeg7l3ya9iNjSP5ENDEJ wsgYmmS0VSa0SyTKzFCRcZXMV7tB+bWR7PW4qUeggxm8AjbgOYiXijnTl+orr73s1Gx7x1W/Jka Poo9LcWBI2O6sZfmKrZxXg5YFeineyI2GVEV41U9OoCtA99aOFEE/9zgSCzv7Tqu0OvrlDv7zr1 3/T0cmsCz9y3L0rdeQ0vNCuNSO/KUmFlKQDgfIIQhDBzBtz+graP5rn+/A0HKu9n445msMQ1C9D jKDyponjdA6RxuoQ4uU1NMoBBetMaXvrKTmGZN8G79SyAJlODRdodWtKY2fJO7D5nfCZj79cCk/ /kjuevGu/KSnbA7ZI0sZ6AU68wndYiB+SDRvkBVOEFQmx9tyb50OydNVpnhdgNqCkGj2rMEfREF qhXfxIxMtr/itPMOR5ewqWsg== X-Received: by 2002:a17:902:c152:b0:2aa:e47d:e3b with SMTP id d9443c01a7336-2b2c711e5efmr51316945ad.0.1775825261969; Fri, 10 Apr 2026 05:47:41 -0700 (PDT) Received: from lgs.. ([112.224.67.108]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4c9dd5fsm27554365ad.0.2026.04.10.05.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 05:47:41 -0700 (PDT) From: Guangshuo Li To: Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] f2fs: fix uninitialized kobject put in f2fs_init_sysfs() Date: Fri, 10 Apr 2026 20:47:26 +0800 Message-ID: <20260410124726.2035729-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In f2fs_init_sysfs(), all failure paths after kset_register() jump to put_kobject, which unconditionally releases both f2fs_tune and f2fs_feat. If kobject_init_and_add(&f2fs_feat, ...) fails, f2fs_tune has not been initialized yet, so calling kobject_put(&f2fs_tune) is invalid. Fix this by splitting the unwind path so each error path only releases objects that were successfully initialized. Fixes: a907f3a68ee26ba4 ("f2fs: add a sysfs entry to reclaim POSIX_FADV_NOR= EUSE pages") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Chao Yu --- fs/f2fs/sysfs.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index c42f4f979d13..4df0de9ccb00 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -1893,24 +1893,26 @@ int __init f2fs_init_sysfs(void) ret =3D kobject_init_and_add(&f2fs_feat, &f2fs_feat_ktype, NULL, "features"); if (ret) - goto put_kobject; + goto unregister_kset; =20 ret =3D kobject_init_and_add(&f2fs_tune, &f2fs_tune_ktype, NULL, "tuning"); if (ret) - goto put_kobject; + goto put_feat; =20 f2fs_proc_root =3D proc_mkdir("fs/f2fs", NULL); if (!f2fs_proc_root) { ret =3D -ENOMEM; - goto put_kobject; + goto put_tune; } =20 return 0; =20 -put_kobject: +put_tune: kobject_put(&f2fs_tune); +put_feat: kobject_put(&f2fs_feat); +unregister_kset: kset_unregister(&f2fs_kset); return ret; } --=20 2.43.0