From nobody Sat Jun 20 20:53:36 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B331D33260F for ; Fri, 10 Apr 2026 04:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775797165; cv=none; b=PhTBvT8+UMbdwTOWORr7X1Dqx+IAMeorm9lZe3Ys1KFbcXXrRDR7twVW4cpIFjoZOONJ05PCOOKukPmiYyRlGIWUWs18Unkf4GueuU2OqBU/tvuG9II3bbxSfZoCHySaiySx/0Q9K6qixR2/gCew7N6EWjfCnIs0je4moM16RZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775797165; c=relaxed/simple; bh=H+oGYEs5fchtX3azG4HOYAIJ+1ETOf5iY3TXTfGXYE8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cY1DDJBfvNehvLl5TZjs95ved4ORvHshx1+CXnq4HucWHe4UfcSLmSAFzF7A+APdEuugKP8ZtlWdWI0+wYB/VJp6KMFqLO6gA1/NTREjVSF11bJU1gbYVn49io7BYRpwvdt3iPnoSrKK17zJoT+ntGpH1Yd9j5lOplJrqeKmBa4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FZvzEtel; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FZvzEtel" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b2589c26e3so14871145ad.1 for ; Thu, 09 Apr 2026 21:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775797164; x=1776401964; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4+ccZUVsgwP9j2EfpM2Pvt6St6Icoqel5xtWnUPnC3w=; b=FZvzEtelhytr4ZFllvCfAddtReGWJ7kkeaXF49aV9jCvgYnoPZgWiJaHNnCppJ5W2i FdPIzNtE2Z0pmjTO7JU4oHOHrwPUnK9p2Nujfclb5jE6YNhWhm+AnI+Jr7rCTKM5Iv16 +gZjTTPwicrLJFQ8AzeJo70ExjPztxr5HsAFGSBbSFiWcC354GV9g7QGkEWSsV5LduPm Dc4LLMgCwHe6eF/WE0LEEaL54PcRduH9bJi1EubaS6csdf6ehFpF5y93lenagpKG7tFb NJT0/Xt+d4fdTQBmcBAjEF8YTrL6+ZhV8DE+XMn/IkegoySwRATaT5t+JFdu1/6GT1vp Xg7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775797164; x=1776401964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4+ccZUVsgwP9j2EfpM2Pvt6St6Icoqel5xtWnUPnC3w=; b=BCmftVbLW8fcjN+Fkw0Gt4ypJylqXbqL1Bblo410hfyBahwk3Sf2CjxLt5TLlKq6/u D/Wp+ylLLtQO9hL64ZHPzSFNvwYcAZlrb/BvvJOUUH0YbrXXmlorsFZQZ8EerCLeK+6L Pgr9MEAyKhbOxrjftDIKcMPkm0Zdoszp8ET+dF+58Zxr1gNp3BEimHmxWtx+HeX7cjjL BnzvoGVgRdvH57Q8INOLHxIKBTs3nPpaKzXPEj7DZz2t80unRmL8+v3z0iuJmjwgOv7k 3qo/N+LuW8X2WGCa/0HRb/ZpsOuoiD3XMeTts/6kwm/ohcTsMLrdACFZEfPQMGtovhgL UVsQ== X-Forwarded-Encrypted: i=1; AJvYcCWVZ3HBQKk5GANYcnGvjBq3oMBDv6Q6FvnDmIu1jIBwzMfNxdKEYcsSGdyD3LHjqFza/LmELZ2wGtWT6CA=@vger.kernel.org X-Gm-Message-State: AOJu0YyxXaAhIF77BKvISXXmZ84mq7lrDfl4pqHpIGquGV6lVZiIsuBb 4XsJTq8rAS/fhKWa7qsy9cnrE9Z+IpSqij6yttfHt1OJQXpwUAuksu3Z X-Gm-Gg: AeBDievYDz9/XlH1h4Vqexkbhs9B2638lW//igGAO1fj+wd1rnuVr5jQLh+O6Zu93Hd 3EneeJx0+2n7LIQcVapPxXbCwrJmRt/l0zOpfyeemqBa+Q7Hyn4xmerYLN+uoMtzAqBzv5fhJvG kVb36h1PWV6MLMRlP5jJ4EJ56VVcOQq+GOcHAzni2TfPTUFNJbkVR9lzMRBcAVm2XYyJ1vzBbyH tgBH5+fFVwSNE8CMk95iHwI0zt4vCfVStK/sZonvd3nSnJI4HaoctNx3MZROAVe8H3/JFlS+Feg kygGQUV+v86U6TCv81y2CTIv8hRtk1hyeD89uCdBf3+bZG2lVK6X6ozQeeiocyFA5BB1KhGMW0p AaLfzU2cwu8UwhsSGFchkTGlWhMgXheeiwHJ2ROKS+b39TrfkeVPTJ7IdvRbBKL2YF8UFto68ho T2v8dWppy9ePtbTgYYaB//bz7jOWJ+zKqtwGVtIi1IvGz8T8ppPnq1uvFRK5vLby5wJ8oPuomuF /08f0OzIcUZNEImpfqU1/MQEm0mhOKycw== X-Received: by 2002:a17:902:be03:b0:2b2:71b4:a3cf with SMTP id d9443c01a7336-2b2d59d398emr13488835ad.19.1775797163940; Thu, 09 Apr 2026 21:59:23 -0700 (PDT) Received: from localhost.localdomain (59-190-207-251f1.hyg2.eonet.ne.jp. [59.190.207.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f2af90sm13532835ad.64.2026.04.09.21.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 21:59:23 -0700 (PDT) From: Berk Cem Goksel To: Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Berk Cem Goksel , stable@vger.kernel.org Subject: [PATCH 1/2] ALSA: caiaq: fix use-after-free and double-free in setup_card() Date: Fri, 10 Apr 2026 07:59:03 +0300 Message-Id: <20260410045904.1064020-2-berkcgoksel@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260410045904.1064020-1-berkcgoksel@gmail.com> References: <20260410045904.1064020-1-berkcgoksel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When snd_card_register() fails in setup_card(), snd_card_free() is called on the card, but there is no return statement afterwards. Execution falls through to snd_usb_caiaq_control_init(cdev), which dereferences members of the just-freed card, resulting in a use-after-free. setup_card() is void and init_card() still returns 0 on this path, so snd_probe() leaves the freed card pointer in the USB interface's private data via usb_set_intfdata(). When the device is later disconnected, snd_usb_caiaq_disconnect() calls snd_card_free_when_closed() on that same pointer, producing a double-free and slab corruption. Add the missing return so a failed snd_card_register() cleanly aborts setup without touching freed memory. The issue is reachable by any caiaq-compatible USB device whose descriptors cause snd_card_register() to fail. It was reproduced with raw-gadget + dummy_hcd on 7.0.0-rc5 (arm64, KASAN). Fixes: 523f1dce7096 ("ALSA: snd-usb-caiaq: add support for NI Audio Kontrol= 1") Cc: stable@vger.kernel.org Cc: Andrey Konovalov Signed-off-by: Berk Cem Goksel --- sound/usb/caiaq/device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c @@ -369,6 +369,7 @@ if (ret < 0) { dev_err(dev, "snd_card_register() returned %d\n", ret); snd_card_free(cdev->chip.card); + return; } ret =3D snd_usb_caiaq_control_init(cdev); From nobody Sat Jun 20 20:53:36 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDFC3290B6 for ; Fri, 10 Apr 2026 05:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775797225; cv=none; b=NafMeUFwrUBsVHbS+l/Ooq9cVofLD5yk1q8956WPoss1YBPIylpDcHSx3E8DuEzc2rWr+9+aeydC7MhlG79NW3mc2XMZDjY2t5gOteAnle0VFfMlfN56BF6llQga0mBHLkrhNLLBvXsHeM4GaHCrZrAhUiPCHeKS+H1Bn2S8mxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775797225; c=relaxed/simple; bh=BwLOMX36Z3otAQNyGKjCXVwDWH8R7e6eiQH3yP3tVug=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kOkiivM3DgYyGnTAaXPKs+L3f4lBOL4TO8ywq+F6+fGWpcQCD1F3rYfYijqeFtyltRE2ijov9waaZ9Le0pGpByCCcWRZtwBJB1rSP83w7Ydeo+OQGcKDhvSc5ivqOAGfd1SUy15ks3uqcmzoDQXpykzZ14zO/Gvb2Y2ko2YXSDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N9pJ5ri2; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N9pJ5ri2" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35dac556bb2so1111128a91.1 for ; Thu, 09 Apr 2026 22:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775797224; x=1776402024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UJaSDl2asy+QBwHUG5HTFQEuT3Wu+LftRP1raa/0B04=; b=N9pJ5ri2YadLpc115nVcok5/wMU9CCT3bsGHiCIE8f2kkH4ryCoruu8WLOo2L4XA3e m9w+3FcVJQkUaQZuiYkr+unb2wkK7qKEMlXGCZICbrLzV1Ml7Zmqc+VVM9PieRLkRkif oLVj5ue94mI33YWcAm1hnp2KljRXWBjDpiDNnhVExrDy9VYDdDHQCz9J9DvdRY4SrZCi U3RuBym6LTzKdX1Pr7SRiS2I37knd18VBC0QwzC8fW2i6FgEfUnOdCPh6gjATVPeI1+P RgW16XN3OOjlA+H+tIeaSYiceaWNxaVFoK++X/DQJ7C6TexoJXR8uZ1yCSOkCtgiYHPC H85A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775797224; x=1776402024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UJaSDl2asy+QBwHUG5HTFQEuT3Wu+LftRP1raa/0B04=; b=Y4964ibND7GjA/eK+WhNIBIiThr3hZyIkoZKhFk+gvNEoE1nA2bhddGsl+nwMORb0F Ent2shqKvu4C/kK7d7V58SNbLmqMvVdu0s9aALtWqmyNLlJim3RXN4kttuC8fxRdLNyL b0SDDWtoixfR7SPK2gjEITmN8FaDnAmS2AlmvkWOcN4Hc98I+oMSKKD/g1zkhDcdOrx+ wofu5Ii9HlcetpRyX+LvUZ5WvysSuqFM3R0VPMMi6ITuFzFETafmPPnj7dA64TMuluhl BEDqNV0dC1Mq8VhKrgsVLyHIsC+Ue7siBYrdJuwDA+5qmxiSFAin0XcQrf9VtLfeVLbY /afg== X-Forwarded-Encrypted: i=1; AJvYcCVc0qzj2CuwCGdSYtfZrG1J+d49sk/KzDUaB3gnlk3IpRd90b+xSp5PXoTH52zlLGsRh2bbZNJbWS7U8Lc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmge0Kwigqu6NP3KN0vAUQC3859t6dulsm8CKiPwQdnmm/bEte E0LD37R/ToNgRqIHTOrQjoXDU04wgKAor0DtDphT3AwXB1cLcUJw6mlE X-Gm-Gg: AeBDies7zLM9Cv/6kwgZ0eLUAKNFTx0WGUx2T2VuOi3R1UPJ2qzQvbUhwmkH6CPxqmG TdUG6JFjSuM79FP99VP+H/tiINGlS2YsQHNCUyergMXNHjqJWfpqqqCXr4R2vQYSO2lPNY/HHtD GztSA6qqPcw9T/8T7t8oVYQ9jVyy0xNpLKy4rBvgUmRvyFpkMR9B2txJFjH+/WJTzV3WzQwnrB8 Wdv5aAlDj+jq/SFe2jmNLK0j0yc5qufa6HE1XOss+COBVvolUDQWEkwR7JNdL08do5o4wSfkcw6 dy7UKMjSqijj/oA1YQN2YxucMDKgsvzrt/7ZsJuVT7R/yDROWNEOXRwlJDeYOBYk2BfNhRQg6Mx Qse8Nqtl6f4Wuz5IRn86rcE9Be9bKEatbJIdnMVLXVg6qyfdWmsg1aYbGlfeFyNqDPFQmT5G9ns Lt9FPUZFgI1/Iqb/gnLY+EScsQov3zlZoTdPD/DjNId3GJ0gxRCpOfnYgSE99Ns6JyNj+OjhF2G BkFwnScteIqf9SDFxhEUn5bnmMP2aw7bQ== X-Received: by 2002:a17:90b:28c8:b0:35d:9dc8:7191 with SMTP id 98e67ed59e1d1-35e4280cc32mr1907336a91.14.1775797223872; Thu, 09 Apr 2026 22:00:23 -0700 (PDT) Received: from localhost.localdomain (59-190-207-251f1.hyg2.eonet.ne.jp. [59.190.207.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2d4f2af90sm13532835ad.64.2026.04.09.22.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 22:00:23 -0700 (PDT) From: Berk Cem Goksel To: Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Berk Cem Goksel , stable@vger.kernel.org Subject: [PATCH 2/2] ALSA: caiaq: take a reference on the USB device in create_card() Date: Fri, 10 Apr 2026 07:59:04 +0300 Message-Id: <20260410045904.1064020-3-berkcgoksel@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260410045904.1064020-1-berkcgoksel@gmail.com> References: <20260410045904.1064020-1-berkcgoksel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The caiaq driver stores a pointer to the parent USB device in cdev->chip.dev but never takes a reference on it. The card's private_free callback, snd_usb_caiaq_card_free(), can run asynchronously via snd_card_free_when_closed() after the USB device has already been disconnected and freed, so any access to cdev->chip.dev in that path dereferences a freed usb_device. On top of the refcounting issue, the current card_free implementation calls usb_reset_device(cdev->chip.dev). A reset in a free callback is inappropriate: the device is going away, the call takes the device lock in a teardown context, and the reset races with the disconnect path that the callback is already cleaning up after. Take a reference on the USB device in create_card() with usb_get_dev(), drop it with usb_put_dev() in the free callback, and remove the usb_reset_device() call. Fixes: 523f1dce7096 ("ALSA: snd-usb-caiaq: add support for NI Audio Kontrol= 1") Cc: stable@vger.kernel.org Cc: Andrey Konovalov Signed-off-by: Berk Cem Goksel --- sound/usb/caiaq/device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/usb/caiaq/device.c b/sound/usb/caiaq/device.c --- a/sound/usb/caiaq/device.c +++ b/sound/usb/caiaq/device.c @@ -385,7 +385,8 @@ snd_usb_caiaq_input_free(cdev); #endif snd_usb_caiaq_audio_free(cdev); - usb_reset_device(cdev->chip.dev); + if (cdev->chip.dev) + usb_put_dev(cdev->chip.dev); } static int create_card(struct usb_device *usb_dev, @@ -411,7 +412,7 @@ return err; cdev =3D caiaqdev(card); - cdev->chip.dev =3D usb_dev; + cdev->chip.dev =3D usb_get_dev(usb_dev); cdev->chip.card =3D card; cdev->chip.usb_id =3D USB_ID(le16_to_cpu(usb_dev->descriptor.idVendor), le16_to_cpu(usb_dev->descriptor.idProduct));