From nobody Mon Jun 15 13:55:49 2026 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54E13C870C for ; Fri, 10 Apr 2026 13:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775829431; cv=none; b=u0neCgO7M4ZXPI6Mm6HMBQn8xR97QHYtwX/LnchmOmXc4C8d3Oq6LwLJTwFS340N5b5g4F2M5xqfwBpVh1CodHScnDiOU1Vg1Y25Ad2Uqa//j0XAuujUhjPZbfhRkFE6NczjRMrD5ElgjOvUwkKUqIXic/hzw/NoszGrIPtjVk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775829431; c=relaxed/simple; bh=5krFrZc2j2nQUa+LXsB2gtCPXXyFJolWkY9QS8kGw2s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=arfcSSDgWge56p2jMMAttiI5xoDm6AYjde0baT2y2aBxSW9DWmvs/Me1ywN6IXhFBT0pI4hcR4YyQIpfQVwkCFmmJ6yS7TpZlmssWEYI/eY7hsRpsrRnES70OFDf0oPgryX9GXEak9yuhn7BMYp6V9uPjNwLLnU2aRSEmlzmSX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kp7lskRo; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kp7lskRo" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-1273349c56bso2797687c88.0 for ; Fri, 10 Apr 2026 06:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775829429; x=1776434229; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=Xsdmh34jdW7d8HN4ibrkIXX29On17rToZw+rgRkjNVQ=; b=kp7lskRoVTevxio71ihwPkmCJPtqiUNhDDuWG6IkmOY7Fto6LM9U7ikb3w8VsEWgXc IJYXepj/WRHwpZetlnETx1ulP+UBZFF61I/pp/vqTzC0GzUpPw/owuQVShN0ZSOX7LfX JCChL4AGchfKWI6ivtB40XVFOeVabG1+hbjg+xViAlArrYcs20b041f1FLIQX1XD3frJ g9z+3eH4Kf7Jyf5D5BLEQ2djNk6mlFci/1DuvmquuHYAQocmnVI+GmXFB8n8O23anUB3 DvpKce/AIx9/0AbYHSAJqQ7NFAKUixTO6v6ly3eh30Y+Oxm9r6pP6z0l7ARtZ/iapxeN ErzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775829429; x=1776434229; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xsdmh34jdW7d8HN4ibrkIXX29On17rToZw+rgRkjNVQ=; b=NdpahM9zp/S7uoMFRgwC/s8dFO7mSBiLym8hG3TlrwgItjvFzxAIoPD/rk49L/v2rN M18VRGjeoluppBdxgO5V42W34PVZhVeU7y21N7T8JhzWubS++ZwGTy5aOyFfJrPNbmH+ jDzwOiHwCzl91DrGztrmSy/gYdcZQr7cssDpfbkWR+DhtRJ1RD1auC/ynELniu7ZBLA9 ohyT7FNmSkPIHCN+H7g1ySe41w1hWYaBPrkF44V8fbB20dAXG7aifJXzuNTlnhr4Wsya yscIo75TedTlEKDKXapqntQuz0dLtmSz6J8G2+HXkysxJ3dYWZsSsg/bjkE1qKKGtGhN BzEg== X-Forwarded-Encrypted: i=1; AJvYcCWCkhSPrm6wXjmzx7TD38XD58ESPERIvzeKjMvZFaXUXJjY/q2joozjVhjP+juSTEYIqGFz1S6Gma5S8EQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwazGK+UKXuRXgzeLG44vg/OqI9HyJe3NnvyBJYyPCuuNedk4GA mFxHuxR3xOozCzcIzT8XrtiIxE+17IckgdXnLiX9gLVlRnvG1KjfPB3mYpqq3Uz7rMA= X-Gm-Gg: AeBDietfujm7/I90dplKPm6/F5ER/exyCL3/+WMVOfhdX87Y9X64zJ/8qEB2guWahl0 zbDfOjCbBauCsz8LBAbwObrJGWYN2UV+8TD8yTPDfOrDT40ELqcSE0o9qxDnqVVxxyyAeWrdPYN fJuovf/bIM/v6InGKsO+HZxDsjNin7yWCz7o705oK5Cy2IwnKDOjE+3idlLXQ7sqaVZaEpXcWc2 nsEcY+qEQoCBJaMfNE6fyCpj0kvLQp/nbB42AW6fjK61xM1bi38KH6xM/5V1uiJDrbiTy7LTIH2 WTBkbNKgf2t/0fEqjWm6tC7QsZbCS1jsp1ykUF4uA4HRJkfpVlDBkmSte/q+Mxt3g3xbnYyi3Wb RIuQ1/ma/w3rppGaqUvTpVieieKWbMVYn42ou8j8w5eRArrK33OAO6I4oq5OXVhXcwXpm8+e/qm KkI1f/Yq1YsBGYLCoc0PgVy0PNeLH96MYO+J0A5fCXUJf7hB2PuiAQ8Rb+lkquS5sJU3QB9kCvM mnF X-Received: by 2002:a05:7022:f92:b0:128:bae0:e043 with SMTP id a92af1059eb24-12c34f14057mr1938968c88.31.1775829428427; Fri, 10 Apr 2026 06:57:08 -0700 (PDT) Received: from [192.168.1.18] (177-4-160-195.user3p.v-tal.net.br. [177.4.160.195]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c345a96f0sm3405159c88.5.2026.04.10.06.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 06:57:07 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Fri, 10 Apr 2026 10:56:52 -0300 Subject: [PATCH] ALSA: interwave: guard PM-only restore helpers with CONFIG_PM Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260410-alsa-interwave-pm-warning-fix-v1-1-434d14c9c262@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQ6CQAxA0auQrm0yA4wxXsW4qEPFGq2kRSAh3 N1Rl+8v/grOJuxwrFYwnsTlpQVxV0G+kfaM0hVDHep9aGNAejih6Mg208Q4PHEmU9Eer7Jgpia lLh5SkxnKYzAu+fc/nf/29+XOefxOYds+GQeHAYEAAAA= X-Change-ID: 20260410-alsa-interwave-pm-warning-fix-ca355d1853ce To: Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3731; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=5krFrZc2j2nQUa+LXsB2gtCPXXyFJolWkY9QS8kGw2s=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJk3GVclOzX/4k+NESwKls2Ndgw4Y5jh2R7+qmxXvNzj3 XHBmR4dpSwMYlwMsmKKLKuTFlnu6XpwtT5uhQfMHFYmkCEMXJwCMBGPV4wM36QTsv8JzTjk+cNH UripOFSwJ06yu/L6GT5fPZNIvdZ0RoZPM6q0E07HVHh0BX8+F8WcGsHpuNHRvOzMOW+VnZFiOrw A X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 The InterWave PM patch added snd_interwave_restore_regs() and snd_interwave_restore_memory() as static helpers, but both are used only from the resume path under CONFIG_PM. On configurations without CONFIG_PM, such as alpha allyesconfig, this leaves both helpers unused and triggers -Wunused-function warnings with W=3D1. Move the PM-only helpers into the existing CONFIG_PM section. Keep __snd_interwave_restore_regs() outside the guard because it is also used during probe-time initialization. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202604101958.x16oNkfo-lkp@int= el.com/ Signed-off-by: C=C3=A1ssio Gabriel --- sound/isa/gus/interwave.c | 76 +++++++++++++++++++++++--------------------= ---- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c index 616c11e51a2f..6c3a2977dcb3 100644 --- a/sound/isa/gus/interwave.c +++ b/sound/isa/gus/interwave.c @@ -480,44 +480,6 @@ static void __snd_interwave_restore_regs(struct snd_gu= s_card *gus) snd_gf1_write8(gus, SNDRV_GF1_GB_EMULATION_IRQ, 0x00); } =20 -static void snd_interwave_restore_regs(struct snd_gus_card *gus) -{ - scoped_guard(spinlock_irqsave, &gus->reg_lock) - __snd_interwave_restore_regs(gus); -} - -static void snd_interwave_restore_memory(struct snd_gus_card *gus) -{ - unsigned short mem_cfg; - unsigned int lmct =3D 0; - int i, lmc_cfg; - - if (!gus->gf1.memory) - return; - - for (i =3D 0; i < 4; i++) - lmct |=3D (gus->gf1.mem_alloc.banks_16[i].size >> 18) << (i * 8); - - lmc_cfg =3D snd_interwave_find_memory_config(lmct); - if (lmc_cfg < 0) { - if (!gus->gf1.enh_mode) { - lmc_cfg =3D 2; - } else { - dev_warn(gus->card->dev, - "cannot restore InterWave memory layout 0x%08x\n", - lmct); - return; - } - } - - scoped_guard(spinlock_irqsave, &gus->reg_lock) { - mem_cfg =3D snd_gf1_look16(gus, SNDRV_GF1_GW_MEMORY_CONFIG); - mem_cfg =3D (mem_cfg & 0xfff0) | lmc_cfg; - mem_cfg =3D (mem_cfg & 0xff1f) | (4 << 5); - snd_gf1_write16(gus, SNDRV_GF1_GW_MEMORY_CONFIG, mem_cfg); - } -} - static void snd_interwave_init(int dev, struct snd_gus_card *gus) { /* Probe-time setup also clears the timer control register. */ @@ -888,6 +850,44 @@ static int snd_interwave_isa_probe(struct device *pdev, } =20 #ifdef CONFIG_PM +static void snd_interwave_restore_regs(struct snd_gus_card *gus) +{ + scoped_guard(spinlock_irqsave, &gus->reg_lock) + __snd_interwave_restore_regs(gus); +} + +static void snd_interwave_restore_memory(struct snd_gus_card *gus) +{ + unsigned short mem_cfg; + unsigned int lmct =3D 0; + int i, lmc_cfg; + + if (!gus->gf1.memory) + return; + + for (i =3D 0; i < 4; i++) + lmct |=3D (gus->gf1.mem_alloc.banks_16[i].size >> 18) << (i * 8); + + lmc_cfg =3D snd_interwave_find_memory_config(lmct); + if (lmc_cfg < 0) { + if (!gus->gf1.enh_mode) { + lmc_cfg =3D 2; + } else { + dev_warn(gus->card->dev, + "cannot restore InterWave memory layout 0x%08x\n", + lmct); + return; + } + } + + scoped_guard(spinlock_irqsave, &gus->reg_lock) { + mem_cfg =3D snd_gf1_look16(gus, SNDRV_GF1_GW_MEMORY_CONFIG); + mem_cfg =3D (mem_cfg & 0xfff0) | lmc_cfg; + mem_cfg =3D (mem_cfg & 0xff1f) | (4 << 5); + snd_gf1_write16(gus, SNDRV_GF1_GW_MEMORY_CONFIG, mem_cfg); + } +} + static int snd_interwave_card_suspend(struct snd_card *card) { struct snd_interwave *iwcard =3D card->private_data; --- base-commit: 80cdbd09760cdfe3c643ef43c1ff2d798babb28a change-id: 20260410-alsa-interwave-pm-warning-fix-ca355d1853ce Best regards, -- =20 C=C3=A1ssio Gabriel