From nobody Mon Jun 15 10:45:16 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23A6A40855 for ; Thu, 9 Apr 2026 21:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775770942; cv=none; b=Dp2eMwWeNxSASBO1L9XoGh+h1a8mNcILTym8Y0zFd20W+pTG95YFKvKLVPmcEwu2fp15QhaIOOylU7SUukYjB0LeJhTUkDQPWXR+NQkBNbdJoqB/k+1bFxtTqCX3LCWKS+SeINBpNzkT5RsfoysKtH1XzsmEuA9Xp03iRegHouQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775770942; c=relaxed/simple; bh=b07lhGhDVK50WNDJbuRFqLpuGn6W7XK//YTTs0ila64=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QOX8JYkGRiDoAEyBtptWbi2dnQtgBnZJf+ZLqUdERKwoBd3SEob3cjxs/8V7Bln2whxWuP0TdlLeLd+yWckMGbInxtRvSd4NQ0WwivJyq3v198X0t781bSfSQuz9kP27nK/oHM6gjem22/zZnKXgc+Nj9XYxd//QcHIfDYX7aYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ok1P8Oic; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ok1P8Oic" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so19802695e9.2 for ; Thu, 09 Apr 2026 14:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775770939; x=1776375739; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=swSed9MUGsB0gPy7tBfpl1IlkUtjnf0/4lv9+O0gYWg=; b=Ok1P8Oic3N8EHWj1yv+w9damO+CxMAWLGG8kejM6UcHWQG3RJqCzXTolof+8fNpZT0 cq6YFMp0ODlQEG/d+Epoq8QEZ83eIhZ3jmi9Yk3B48odV65eDOsrbNW2fOFbuKYoqPZN tk3BzlUfcDsVFlZSkTq+6oJxldnqC6NO0ugZxI2gEqTPUrcPMcwzv5oK7NCtI/GrG7Rs VEYVGBS6kj6Cku6Dm0c7n8xyRrbd9EmG9syUwPMreP79a6FU/gg9nY7Rhvg0wM1Uor/h IYjaMudhnxrEVZ2Wan0HC3SZ/2IHe89zXoG0zdTaqafez1G9xKEJBSj2zXItDlXXP+Z4 /FEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775770939; x=1776375739; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=swSed9MUGsB0gPy7tBfpl1IlkUtjnf0/4lv9+O0gYWg=; b=iPEhAs2A3bw3hvdTUgxq1j/mhgsAWsoFUBu+rZCXEa+mgeDqY0cac+dM/d4RmK2NFj UZL7L4c+X+UTc/B2tc0sWw5ppgTvf3pC1rsTr2otMHuABHMNN/w/OZlJix1TrLmxBk8m 6M/VzR01hd1LErAf6LSly3OzipYsFcFwfU8g4PDVOMyAI4gE0ErsnW+uWZ1lCHDSp6Bp 4MPyWZM460QqdRAhUuftyPE0/it9Do4jfODUAxgEUDuu/eAw4bNfBLSdj0U4WahBTJze axu/YqRfre1SS0wjEnyvDfidOf6qNGMrO2aDgVoFEuhvsKZnj7zWh0raBeqRjq+csMRK JQ+A== X-Forwarded-Encrypted: i=1; AJvYcCUnpuh84Vmk1XD/6s/wIDgu6rdIytPagOPJmPpAa4a5YV1gC0JFCHXYTRngaiasPISgf13BYF0kULV9B/U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9yT19mJyniVmd6DWTcU8qe+03LlIXPPPCBcJil9qSZhqHObWK ciuhxs+rcOxAsHGm7vtyTfjzsjfAy2cks7TcXrO1jueTc5A4dNMX+uQe X-Gm-Gg: AeBDiesAZOzYGKPO/R1ZAOXIrpVU0YwzCwzXP8mF6gVM8RTl9PMYpynpZB3IyfLSExA wqgNedrBZPHaWrWPagCpqilSau2H0L2eYHFQ7vO6+66/p5NyGHcV41OYhbizu0D1if3avsMBd/M f4Zo0AAZvlPER+gOHcDeJyD2If1yzo/q8gxYtFJb5g5+lhIDAdMwG7F1z7vPd1XHi6tfrJ1Yb+s GW/ebGl2hKPnemU53gwF3xhCLVEwfKJaDbTW0Q5kcUJ5287L17h8vqO/pjswSuZXLJPFVdFFqMG d6HkDOeFDoER4A9AdvYfawWWUzCqF3avCSxcBSRc/cErx7ROgy1gnLzFil7JStS/enQlPnY2w1i +UfhoDRBMTKu6TZP7jv0qkZalDbZlCXe8rJyGJgialh6YdhLmz5m+btqp7oYU2o1GiOo2+9TpNb GqXR7HM+2iOQCQu3jsrAw88x+8g1o= X-Received: by 2002:a05:6000:2383:b0:43d:855:f161 with SMTP id ffacd0b85a97d-43d6424c218mr928785f8f.11.1775770939347; Thu, 09 Apr 2026 14:42:19 -0700 (PDT) Received: from DESKTOP-D4E07GJ.localdomain ([94.187.23.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63e5c981sm1745525f8f.33.2026.04.09.14.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 14:42:18 -0700 (PDT) From: Mohamed El Harake To: hansg@kernel.org Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, andy@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mohamad El Harake Subject: [PATCH] media: atomisp: avoid ACPI package count underflow in gmin_cfg_get_dsm Date: Fri, 10 Apr 2026 00:41:58 +0300 Message-ID: <20260409214158.3248-1-mohamedharake2006@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohamad El Harake gmin_cfg_get_dsm() iterates over ACPI _DSM package elements as key/value pairs using obj->package.count - 1 as the loop bound. If package.count is 0, the subtraction underflows and may lead to out-of-bounds access. Use i + 1 < obj->package.count instead. Signed-off-by: Mohamad El Harake Reviewed-by: Hans de Goede --- drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c b/driv= ers/staging/media/atomisp/pci/atomisp_csi2_bridge.c index ba61cc28fac1..cca91c6d71a5 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c +++ b/drivers/staging/media/atomisp/pci/atomisp_csi2_bridge.c @@ -113,7 +113,7 @@ static char *gmin_cfg_get_dsm(struct acpi_device *adev,= const char *key) if (!obj) return NULL; =20 - for (i =3D 0; i < obj->package.count - 1; i +=3D 2) { + for (i =3D 0; i + 1 < obj->package.count; i +=3D 2) { key_el =3D &obj->package.elements[i + 0]; val_el =3D &obj->package.elements[i + 1]; =20 --=20 2.43.0