From nobody Mon Jun 15 10:47:19 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 908E23BADAB for ; Thu, 9 Apr 2026 15:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775746940; cv=none; b=gVKM2/2DOUCWyAZitXIlwS0U2p8R37PFrw5le9T8ba4s6TtWd4bkJW9JFANxredqQhfA6SbCSXVUWDuy1Tg94Ds2aoqahOjuSSjVJg62gI+6OPyd8fvUko/rnfHUHNO2zYhzht5vQowtF1sRkM7DNUgaSvVM2vIE07QIRLCeQaY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775746940; c=relaxed/simple; bh=TioiTsieB6K47rtqg3bei/df2tvUdqrSUuARGufw4CM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MEZOHAXUYyFtKl3Q23CiHPHc3rlo/RpiMgrQ9MTuPfkPV61cNn09sxw/gorEg38eh8TBHUHshPsMXUQZaiU+B5RfSLV6AGgd61w4AFhlSBH2Ae7IDttNIkFqnf3LUYT8hXuIpQnUO8qFPeiTX08AhI7ZzwbawtGsP9XjKOOy0Hc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J9X7ETMZ; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J9X7ETMZ" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-66bf6aa4858so1760689a12.2 for ; Thu, 09 Apr 2026 08:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775746936; x=1776351736; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2OO2D65S435p/l6hJEnAV5AOSC4Rv4PPYimpN3sA5FI=; b=J9X7ETMZArXaSAY9ywJgBHRG8SA1sQAc+t6kAnKPpHMoyMb8TaJL34NRyxZE5YbyHW GgJtAPq4agcoMkjJKE1GSbHvKqdl2OfxGM3ZdgoW90qqrnKIcFJUM4cnyUphM61n1NO2 H04Dq+D201E1wRg/VThkfmLXRP0Wl/R3fzm/wi6yTdpJxs7Lkz7ZgpEApELQSsna8VCs Pv1aWreYQJeTtr02NIVkf168yY2r9B6H8VNevEzHJqu4+OfWdweqJH5rwpvNZaVWh+lT V/u63AqbTWCn4I8NR5+FhJoP3k588L8XJ4vcHg0a8W4BXJSApxotdCoHz0d8J0OiFR+n o8kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775746936; x=1776351736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2OO2D65S435p/l6hJEnAV5AOSC4Rv4PPYimpN3sA5FI=; b=WpH+ERz61SXAxXree2hcCTL3uqjUankgCNFiBU9qXIezSbEj0MljYWirANVtqr+Spy 5fSuTiConknf5ytmVtczcdEjsVKNPnfTNzSp2U5alYGAXy/exZ5e8WgZaSHmSqv5xjbk eMQFWgxVxWdyee6qfAtVw/zoMyO9fBU9PtZnDiOiL1+swPbVRcb5KcllcthCCz0oNDM3 YrX5Xl+C+ADE8nSQaQwF3y7DXDqLHlX2nsd9kvvKMAjqccvtHgrZiRLl46j3PFJ2U9Y4 IjS+NEyD/w4xGP3ZPln4WQ7Fy/b43/vioeHdg7hjel/r/zwtTMOgx1EphNeQdhG6BiJu VHqw== X-Forwarded-Encrypted: i=1; AJvYcCUNuBpMDGJJM9QLdrIcQWb8eX6cSr8PeowlReDcjPr+ZHKsEiVtQD41InMh6lH4uc069h9fX7d715jjyTg=@vger.kernel.org X-Gm-Message-State: AOJu0YzRins67mbZLIsMl+RmAGd/56cHxeKoqEyNEpdP/Fqt+byEahpT 2E0hCKCRkHo+7frg75XBno8AqVQsv2PNCxX2VUa3qhodB63fEDcIw4UP X-Gm-Gg: AeBDievgu7KX7Ec7jwWyN5uv+XcgsNKwLxb0VrL8gJhzpmUPgb72rnm+UHuNcGrNFeq bnulXuDhv+kEjnVMPLTCN5Vr06tVWXmoy31Qc8VSpkfASh+gkZ3j0+u0zTYd7LDh5wgHDc35+GW VUyj9arlBZYLuIAIuQ9RoLDM8b87H2yPY/yal0sGnfMxLXJTiAevs31CBN64AYWIsYCAiaXUKYw Djv5Z9wwM66crwaffh/hEUEINzAl9nz8xEc7M7ZG2yb6ZcIa7cwnrPeD8yEIMi8uRY7g+GMPObR QfDCBll2UprdN4F5r3KMr5gxFv5y5eJNx0sdiOQ7/VmTdZ8lZqT2gR4jAi6P3i6NJvTZraQfylO i+N9k3XH+eR7+C0FJXqLhbtCFNq/eTaMJgb/RusJnZzvCevaMQtN0cjE8Uw8TBxUiwBsLiKSGju KKsxntGXNGqLXsWckeey7nDhprddFKtYXXr2wmJZg0lPu3EWuOckPqJFHNmzxnZjAMbqg7n9yAH imlZpwDJ3yRf8rb8Oaeu0P6EQbOxd1GemDHE5kCYRptsHqdmAyRteLY3+sf8MEQFFrlhJCgIDmo D4ry60TNjMW97WTLkcFEGP8I4GqBoAp3LbAfJU/2HWUJX6TqQQqTIbou+iT4bKyvNvEiCDGz+/N 4FDHz6GIMYKb9Dq2p X-Received: by 2002:a05:6402:43c6:b0:670:4445:c326 with SMTP id 4fb4d7f45d1cf-6704445c4b7mr1148491a12.7.1775746936105; Thu, 09 Apr 2026 08:02:16 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-a.c.od237066db22328bb-tp.internal (78.182.158.34.bc.googleusercontent.com. [34.158.182.78]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66e033ba245sm5754662a12.20.2026.04.09.08.02.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 08:02:15 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Joshua Crofts Subject: [PATCH v2] iio: frequency: ad983x: replace do_div() with div64_ul(). Date: Thu, 9 Apr 2026 15:01:57 +0000 Message-ID: <20260409150157.1300-1-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2026040913-spherical-slacks-bc5b@gregkh> References: <2026040913-spherical-slacks-bc5b@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coccinelle reported the following in both ad983x drivers: do_div() does a 64-by-32 division, please consider using div64_ul instead. Fix this by replacing do_div() with div64_ul(), which safely handles 64-bit dividends and unsigned long divisors across all architectures. Signed-off-by: Joshua Crofts --- v2: - resent email with corrected addresses drivers/staging/iio/frequency/ad9832.c | 3 ++- drivers/staging/iio/frequency/ad9834.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index b87ea1781b..61ee93263a 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -115,7 +116,7 @@ static unsigned long ad9832_calc_freqreg(unsigned long = mclk, unsigned long fout) { unsigned long long freqreg =3D (u64)fout * (u64)((u64)1L << AD9832_FREQ_BITS); - do_div(freqreg, mclk); + freqreg =3D div64_ul(freqreg, mclk); return freqreg; } =20 diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index d339d5e8e0..83d0e1360c 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -101,7 +102,7 @@ static unsigned int ad9834_calc_freqreg(unsigned long m= clk, unsigned long fout) { unsigned long long freqreg =3D (u64)fout * (u64)BIT(AD9834_FREQ_BITS); =20 - do_div(freqreg, mclk); + freqreg =3D div64_ul(freqreg, mclk); return freqreg; } =20 --=20 2.47.3