From nobody Sat Jun 20 23:06:15 2026 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174953DE425 for ; Thu, 9 Apr 2026 14:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775745716; cv=none; b=R4tW4Aou9TlDerigP4iHVtNMcC9DcPcUqk9B+/Njz7r9Gidgk7dBAFOe5xU3Pg2Xrnx4vDUO8n0aBqm2rmE4UZ7plJvZak6KUrunvb1MuCt/DWyy0YPaPzq/NGKgosPHULXxdDHl6aGpFWvdXI2WrNAQxSEBDb0BqWczozrWbCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775745716; c=relaxed/simple; bh=+vHcx9lI7yya0W7s1XmjAsO9BEU7Hgjmcx7FM3fwsWw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=h6xZFXkX1Bgc9pYtfDEmLQp5slg4ENpCXBIlTXeA8WubedNZqPpjvuA2wxPkj6aMQPupT+hCfMp/EBQD+hNNhhy4Ch1KZzNmW9Hm2ZPs5m7HdtUDtZLPkbPLo1UT4GMvph+38fCOk+uvGPDi4rhJCZ6I1TuRdBzQOwzwmvYwQIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ptaV7+lV; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ptaV7+lV" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-1271257ae53so8021861c88.1 for ; Thu, 09 Apr 2026 07:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775745714; x=1776350514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ynn/Tv7vt536YLRzFScHBlkRRyfwxHMbDNUUOzExOGQ=; b=ptaV7+lVaOPFrmQlgWW2RICSmM+Hj2KIMdQ2kcVUjed9FSiIGY/Jt+L0fc9/XrgHa+ emLpFncsasZT/BCNNrVlGRgH8g5BFHLJ25Ku44H/22oSHQA09oRhzpOfGecGpT3M97TL pk2UzNqwqvwxSlwh3Aww1fLdPzBxY4LPewoAab8lfIwEcqHPiudftHegQMCG2iFXqdLz p41+hfsWgW/ooFlAknPYouWXaE4PgDHoMJOpAMYLTPnzIOumOd/WAumcdA6nF9Ki2aap qtvrtSZ7NqlkTLIWjsykojQnWw/1r8z7olJ+ccqzy0FypLUjIlc5GwgH0BcpSmTimwg9 9PnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775745714; x=1776350514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ynn/Tv7vt536YLRzFScHBlkRRyfwxHMbDNUUOzExOGQ=; b=g5srC+MXnt4Jm/s7fIg4S95nihMqoh1knGctnu7Bvtzs/fEfVX2hny6r6ABx0HVzGh HbnvWLUF15Bb7P01UAmJ4ZNiT2R2xoyJOTpfNzyTkr2e8N4hq2GDC53DZIZJGLdMf7I+ BEjdZgzZGBw2+h/UCzZdJhQFbNVJEkzVIHcoDWcbkkZq0AT6mM7azF5u9TXckbr6C/Np yKFdf0rrfCyppEBU7TsYWGtQyuZeJpXRvI9EsYpZejAoj65pVkbZ+eXa++jU1FEsMjUE QeZJWo8Xl9WIj0UBQnlV5fqdxvPvrj3k5O7VTGCc+QyvVCxcr3x9QYYzgM+q/zmqYJZD Gw8g== X-Forwarded-Encrypted: i=1; AJvYcCWX1Ocx5tcLadmzxbLwhBu80byWipg1dYtvJaasFDnOs20IFsH0X1SuPNGriYAur6DAE2kapPYCHkuh80U=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk9IRrL2V9Tfpor6B6u8k04omRkPS9vwI9D5rRWtDBw8XmU/ye ZmGOXLqByTCE8/Nlv8FCVqO9nB0ayB4UgK6txc6hQgCkfrkWBYChcuCQ X-Gm-Gg: AeBDievvrDWHrxN1e/ipU94EIAJpvNG5yNwtXl8PJy3udoNz642MDhYj9qbOEOs9m8I YjKeUjjeJQojW8EQ+ejRZduqR+A+LmGbUO00afzMkZ33fnOd6dlhbp0q4ceB5k0dBldC7k5cGLq EmiJPI5UN0T+aw4qL6yCJQeB3NEffvRF1i0koCPqni+yr9sZ+Hf2hfKvEL/U2aokltONzMg1qsu ubLl4c4cmhFggMbupj/i5R+DQgovlhY7m2Aq0csjeK7gR1dMzn1O/GLPBSOVgwJ982LHmRhbDey nT33YuMKS7lHhEk4Ze2NejgKCDNpGsSlOfUC6ZCYpdQVdBxHx+uVN8y9Mpkz8gSp5i+427mz6kE YjmYDyC+4Bpdor2fT0AuFe13LWreUdpL14XWsiOEgazNawnK3E+KSRxDlFd/bNCoPgN0oKQOTuB ev9B0n2RpUjBFU+SAf3fZVT0QXAmWud5Jy0OEotKuV3PIynuOqM8TkjLLsO+G0YbM8TA== X-Received: by 2002:a05:7022:ec17:b0:128:ccb7:7fa3 with SMTP id a92af1059eb24-12bfb76edb5mr13072445c88.34.1775745713994; Thu, 09 Apr 2026 07:41:53 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c07a8703esm20363284c88.8.2026.04.09.07.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 07:41:52 -0700 (PDT) From: Hungyu Lin To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/2] staging: sm750fb: return -ETIMEDOUT on timeout in de_wait functions Date: Thu, 9 Apr 2026 14:41:18 +0000 Message-Id: <20260409144119.21500-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409144119.21500-1-dennylin0707@gmail.com> References: <20260409144119.21500-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The hw_sm750le_de_wait() and hw_sm750_de_wait() functions return -1 when a timeout occurs. Replace these with -ETIMEDOUT to use a proper errno value and better describe the error condition. All callers check the return value as non-zero, so this change does not alter existing behavior. Signed-off-by: Hungyu Lin --- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index a2798d428663..3809401baa3a 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -502,7 +502,7 @@ int hw_sm750le_de_wait(void) return 0; } /* timeout error */ - return -1; + return -ETIMEDOUT; } =20 int hw_sm750_de_wait(void) @@ -520,7 +520,7 @@ int hw_sm750_de_wait(void) return 0; } /* timeout error */ - return -1; + return -ETIMEDOUT; } =20 int hw_sm750_pan_display(struct lynxfb_crtc *crtc, --=20 2.34.1 From nobody Sat Jun 20 23:06:15 2026 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606073DDDCD for ; Thu, 9 Apr 2026 14:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775745717; cv=none; b=PWWzMX/vYkXmlwISgLEjO8vKKN4Jw8HfNuP94Hrdh40fWTNfqfLpZqsyRK3ydhxMQhOEaw/2kLlf/by0Wvfzryb/IaBHPQkd4KFgdHDLSQ2u8Ajfd0XwtwDItUE4ylRJTDaIo0/a8uyz4PA1HjMJRAmk+yxiptME2UFAiyMWWKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775745717; c=relaxed/simple; bh=/3dzbTa2yCGGWKMPTi/jtaZM33hFKM0i5biBd97LBEw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Tl5oMAC/Jt3ytlZ6yTVMMetbTmix6cgNUlJ9Sgv6oLiIaq+++e7slOausAVGyYUXxVKWBBhTCiQJQLZlW0ffj4a5wIS4DJ4hYUQFXU4qhTed8pGqKgnY/t9Hfbb09xKMxmY//3PfhdzfGxCXDzghW8c46Z2dQOT4dOZw8PYGeY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENgVUY9C; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENgVUY9C" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-12c1fcce8f8so4676478c88.1 for ; Thu, 09 Apr 2026 07:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775745716; x=1776350516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cIq2KvgyVuLp71772xYiI9sgjjf9n0iRtxnyZ0QmOTY=; b=ENgVUY9CEoAPdkN+nq3QQUs+YzFel32dEk9a56UX7Yjlb+8teBdDzZgZ1/hf4yuouK hnJ0n99URewNJIxdBKd6zwZtKJ5CXgow/R+Ey8OKulIdwCreKZj4YNs77ZMHJFzhfsI7 ebXLFt0bDbZdII6XsCQV/oGRWHIcef9l70GG9JS9LVMp/cKAqmbKrJGcCHM8HSpct9fE pfpg70pJiBTtbjWQvrznTezQAk18L0eh0GNJlRGK5YLFnTqNJtR3pRupSDzYA5CBEXMg zUQLBTgHk2ajGwDVCnc7RjVOQzGMW0er944p5LOFN9bd5YP8ckxK7jw6z1fK82LZSkq4 Rexg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775745716; x=1776350516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cIq2KvgyVuLp71772xYiI9sgjjf9n0iRtxnyZ0QmOTY=; b=c9nhbptOrT/fFphhd1KOifDKTF4UgHibuQHua4eCxaU4nFLMvqHpyAtuJ7P9a+99Rz UTBfCBNJNtKq8NIg05X9r97tKi4LZji0i9qtXzQBoRgkGL5fpUIlfbMrcSp36NJ+IHnj WaynhXN/tAOh8C/nRmMOEdU9TxbxmrLOOevdRydRqjNj3jp6n+NEAQx3HY5QN8SDPqod aPZYERBfgNiiXTfqfwGNRmuct8ifl/twKyDXnGRNeV2vr3Qqa1iuRkWivkCktLJVNxmb E0CHKPbtICgWZBgmoubWJD2t3h8sUkjNHKSBG9K0KoXGh3hDh5mr4V3qytSlFeBsZa7W IRvQ== X-Forwarded-Encrypted: i=1; AJvYcCUVjfu81x4QVemKV+/BvZEw8JSN28Jnz8oRk2gktYeleE6NtXMy9fIpXOCVH0zYJ4oGzSBxtlxSiOsSiok=@vger.kernel.org X-Gm-Message-State: AOJu0YxJlblS6wgdi+gtHCQNZogA8VOWRudSNNneJU1XM0rksrcJFyEz eST3PlZRxN37foG9GO+DmSWcYc+Ro02ytQcxKBwB+yK/vkmxPr1l3JbKQ++2ySfv X-Gm-Gg: AeBDievd70Dc42SbCDJ5KPzxLV54+hfTurTe4jXT15Hhg5rFQKH2T1mUw/EnOw89qFv YO9bLtZTT5ZUbqPIu3xc5utO+dS3nVNztAxVR0YyYtMnBBPwTePH6N8EFp+76p+42ip35Bw01dH MdsxEbz8qZN6A/bNl47YaImD82y+1cwS9/yTXySdItHSPz6stbwF54R8Q90NrKzLktu125g/Pd6 0lwGAzaFzDYn4VdiPwDRYDN2T0Zmu5iW/x3p4tXbB7hO4wIklVtbKFLfIqO4QxzLKVYbvlPUYUI 1TjiLxL8HAKIiEi3gXC1HzPkTiDaLk4GbAT80BlHgaHp2eRQQWhOgB8GxcFKa9dxltk68+jT01G Ti58IJN+xK+3iKrT8i8C8Sb309XkBmknYvUwnAJh9y4heYbBlLOiD3DxngT9Qz+R4wYZbTYymnA WISe4hLv0EeRRvreDlScQC8uMAhWc69tkW6FQeR+8WeG5mVzLBTiFKPCN1SOUpinGqzA== X-Received: by 2002:a05:7022:ec14:b0:128:bae0:e03c with SMTP id a92af1059eb24-12bfb765c2emr15325531c88.30.1775745715490; Thu, 09 Apr 2026 07:41:55 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c07a8703esm20363284c88.8.2026.04.09.07.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 07:41:54 -0700 (PDT) From: Hungyu Lin To: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 2/2] staging: sm750fb: propagate error codes from de_wait() Date: Thu, 9 Apr 2026 14:41:19 +0000 Message-Id: <20260409144119.21500-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409144119.21500-1-dennylin0707@gmail.com> References: <20260409144119.21500-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The sm750 acceleration functions currently return -1 when de_wait() fails, discarding the original error code. Since de_wait() now returns proper errno values, propagate the error code instead of returning -1. Signed-off-by: Hungyu Lin --- drivers/staging/sm750fb/sm750_accel.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index 0f94d859e91c..891d12a5e2cc 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -90,14 +90,12 @@ int sm750_hw_fillrect(struct lynx_accel *accel, u32 color, u32 rop) { u32 de_ctrl; + int ret; =20 - if (accel->de_wait() !=3D 0) { - /* - * int time wait and always busy,seems hardware - * got something error - */ + ret =3D accel->de_wait(); + if (ret) { pr_debug("De engine always busy\n"); - return -1; + return ret; } =20 write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ @@ -154,6 +152,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int rop2) { unsigned int direction, de_ctrl; + int ret; =20 direction =3D LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 =3D Left to Right, (-1) =3D Right to Le= ft */ @@ -263,8 +262,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, DE_WINDOW_WIDTH_DST_MASK) | (source_pitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ =20 - if (accel->de_wait() !=3D 0) - return -1; + ret =3D accel->de_wait(); + if (ret) + return ret; =20 write_dpr(accel, DE_SOURCE, ((sx << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MASK) | @@ -326,14 +326,16 @@ int sm750_hw_imageblit(struct lynx_accel *accel, cons= t char *src_buf, unsigned int de_ctrl =3D 0; unsigned char remain[4]; int i, j; + int ret; =20 start_bit &=3D 7; /* Just make sure the start bit is within legal range */ bytes_per_scan =3D (width + start_bit + 7) / 8; words_per_scan =3D bytes_per_scan & ~3; bytes_remain =3D bytes_per_scan & 3; =20 - if (accel->de_wait() !=3D 0) - return -1; + ret =3D accel->de_wait(); + if (ret) + return ret; =20 /* * 2D Source Base. --=20 2.34.1