From nobody Sat Jun 20 23:06:44 2026 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C7A3D3491 for ; Thu, 9 Apr 2026 13:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775740731; cv=none; b=OWk7nKdwJeCfqyDNPz6nLFgrvnbvVzZ3r7InXQit6uKLZRamYPGMrynIftZ5V/apACCzkJaWHoLmRNpULYGsuR9LA0NzrgVRPzzBzGL5tocIpvj+AO+hXTgrm5qBWGOG/ltr/2/jzEz3R2c8LzEdvj+p4M0z+400RMD9Xnyzl1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775740731; c=relaxed/simple; bh=49U36clM8e2e3gJFrrWjkzxZ2BnblqIUI3dhDn43VBw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UdHFfl9HmsO3/TMhjUhjrlfWIbgrNX5oTbIl9VUM3Shx/EEhmKq352R4bDBZwGZbXRS7kpeob0PW2gSlGZun8uDRWWKdWi/XlRzUu5xXn1k99pnryF+Iu/N3Pjy7pbYFOskZ25t84FM+zMUasW0ne2o8p2e0GgThizpU0r1DF5Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lIYSM/pY; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lIYSM/pY" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-65c0891f4e9so1445964a12.1 for ; Thu, 09 Apr 2026 06:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775740728; x=1776345528; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3bs7q6ZU0OTgcG9cFYmFS2g5VXGrBq6p5ZmpGmndRSk=; b=lIYSM/pYqOujLIs4i4pQEFtfIqwgeS2wZRLuSDciVbzEI3hO4QwYqQyEB7TETdFQOT 2PbRNNrhV/LuoSVFKyijaq/X/SdaN2Xd3S0YF0DuCBiPKi2yqzGFpm68LDYlSTF0sE5v bIL/F7kIodvO9pVZg0CfwMpy2diFJdxDRCsSpjm9GgZ0U2GqQ0s4KfnMy4ZDGxBfv93U pqxt8PnzU+kyaKIgMmiIgFykengSdZqLry83G8TdioiXENzgIPqvg6ePvefq87DXyL94 mr7v4/R6ALjVdBe2qfMFLheYZR9t81akecZC4JEHCnxg4zVYLmWPLg0p1lpeTLUgtdo9 h0Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775740728; x=1776345528; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3bs7q6ZU0OTgcG9cFYmFS2g5VXGrBq6p5ZmpGmndRSk=; b=har6EyU3dF6vvoISJdZoQvjCmoJb5s6hV8/hqjCxJn5IsAIJRwpMbVfCN84lj9hZv3 +FZGHxN3yPVoS5GNfqF+RO5aNl3zr40sVRSPuhDKV0aOoQIlsK6OK0798QIp1RoEiXgy EX604NOHYi+z8lXxRXcc7TUUqMqfRHuMuWL8FRVeM+8V7HGehUiuidxBHx/e+N+l73Vd OsiEBkza9N3o16ucsJX58tCJUR0hDit2oROK9hzyeuVlfH0nlBTAo4EjBxZL/A226ukM jBl3oPoe7N40Xf6t8U59292NuHs7eELSYUHx5aUD6iA4UA4FpPlgLyA3XS5AqFH4Q+CK Iong== X-Forwarded-Encrypted: i=1; AJvYcCUOwabGiB1b/EcNRvFASr1lvcblgwKIjhqzYwjFfZJ4aE8ngVfIk36U6GAX1a0kT47uzUyKAu6SDvGL+QY=@vger.kernel.org X-Gm-Message-State: AOJu0YxYXpLQBhoxzduSaxrtvo6dvf+Lh9EUJYy+yWbO+TP3dbW82qPk cjcR9FuKcu9ska+thWKfY3xfVoHu/ms/ia2Ux9KxB/5cfSEljjIgu5Wd X-Gm-Gg: AeBDiesumz2zyIVqgjWFsGXhwSZprD1ZL5t34nVhKDcATJWVFEahBf+A0m1/GVk927h dRrKgVa/lkhK+HbOZ2Nn79uyEZ64Tewu4sAOHAPLK1dh/fff5D7Bi7bL6X3SzPtk/L0qucxaYbG lrNdxG1rOXO5/tAItlWMZCPqGKPYAHQtJcxrP6ou58VrDbm+rVQPqi0xCdDQX/xbaaVJ+5vKa2r oLOEh6bjcwW8x/QNMR/DEYyNoT+4o9mcQON17hjn/MjWsK8YyP8EwP5c6MdW/nAcwog7ywoP5Vc 4hQn8Q823g5XqqqxkPjMeM2fOVNzdnGafT9AafQ+aC8OkWs6X9fHgHyitY2UHWwGDcHxvd6uBVY hdYZPy734rWwWBLhY2CfV8p0y+OYqPErO1drrrd68xC4KKg6rhJsaBoWyS5SnChZUK51+kY/KGp fIEvYqYmin1trGvFuFscDluo6oN/X6iOrRskwDabbPPt684XFgx/Y5qi+CrrYn71F13xp2oPZTr MK48FhNlEP4g2r+yJiQi4vT+vqsaY8pHC0ZpGFnwdF1paRrT8LxX2x2OZXxWbJ3qJEhhB+OtkqL NT5qz103o1ifnIW7jc82Ab+/Bb4vnNew6ThdZ5kAVjdxGdW6b8+Szf3Ld9wWyqvWE6FeubKp91+ FQRZITr/hhTHoEA== X-Received: by 2002:a05:6402:910:b0:670:3c8d:1b6b with SMTP id 4fb4d7f45d1cf-6703c8d1cd4mr943734a12.7.1775740727985; Thu, 09 Apr 2026 06:18:47 -0700 (PDT) Received: from cs-280612103108-default.europe-west4-b.c.od237066db22328bb-tp.internal (137.44.90.34.bc.googleusercontent.com. [34.90.44.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66e02d37620sm5679424a12.2.2026.04.09.06.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 06:18:47 -0700 (PDT) From: Joshua Crofts To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, greghk@linuxfoundation.org Cc: dlechner@baylibre.com, nono.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Joshua Crofts Subject: [PATCH] iio: frequency: ad983x: replace do_div() with div64_ul(). Date: Thu, 9 Apr 2026 13:18:23 +0000 Message-ID: <20260409131823.1289-1-joshua.crofts1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Coccinelle reported the following in both ad983x drivers: do_div() does a 64-by-32 division, please consider using div64_ul instead. Fix this by replacing do_div() with div64_ul(), which safely handles 64-bit dividends and unsigned long divisors across all architectures. Signed-off-by: Joshua Crofts --- drivers/staging/iio/frequency/ad9832.c | 3 ++- drivers/staging/iio/frequency/ad9834.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index b87ea1781b..61ee93263a 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -115,7 +116,7 @@ static unsigned long ad9832_calc_freqreg(unsigned long = mclk, unsigned long fout) { unsigned long long freqreg =3D (u64)fout * (u64)((u64)1L << AD9832_FREQ_BITS); - do_div(freqreg, mclk); + freqreg =3D div64_ul(freqreg, mclk); return freqreg; } =20 diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/f= requency/ad9834.c index d339d5e8e0..83d0e1360c 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -101,7 +102,7 @@ static unsigned int ad9834_calc_freqreg(unsigned long m= clk, unsigned long fout) { unsigned long long freqreg =3D (u64)fout * (u64)BIT(AD9834_FREQ_BITS); =20 - do_div(freqreg, mclk); + freqreg =3D div64_ul(freqreg, mclk); return freqreg; } =20 --=20 2.47.3