From nobody Sun Jun 21 00:14:16 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AAC8220F49 for ; Thu, 9 Apr 2026 05:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711100; cv=none; b=RvLz7FTkmgy03VSNlfBzJ82jdIoMQR6mymHHflV/T/lvt5eRg5otuJ5vrgbiRaKlmAEvl5RuZ7Juk4YiG4U2VEdHHPmG1fQWBbcgPfY3kqILWIdxI/RZRCcvh6Xgz6Z9yHX1BU0l7spiLwFCtSuWX91A4eaLbQIN3PPkAZdXCC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711100; c=relaxed/simple; bh=d1yUUwZxSMTH4Mhr1vdB7tMvupSoxWq48gto3tesvWo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pNCtRzT0mopwwdsFvn0GMeGh1nPbLT0b8LTOOzwk/g7Lq+mYubH05xITN+Fs/3MZ8iht1Ui8F1Tk95nqQV47SVQAZSzX5MXpKSkFfMw2XJGBEAyoUuGQyJ2F/dW6d2mX7csACm46DWg88noG4jtColGIuH+JsHPO0w2wV8ejffM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mA/qiPbI; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mA/qiPbI" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2b24fcc2b5dso3720515ad.1 for ; Wed, 08 Apr 2026 22:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775711098; x=1776315898; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TnlvJQe4yhPb84lvxXeuW/a2CDGHMe2shk7LZ1M+Eo4=; b=mA/qiPbIp1zJWkA9bpOCYgShWxU0ulOA9gE5fvMdYTX1nzyeJ3AdaS6xjsoOhVMusx uNFLGVbePo3GjwCLveWRczaQCX40sTnPvJydDNo3AnoNdOybu+kwvcQfFafjNEhv91kF kyo17l4s2F3EGSLAkZ53bqwFY5J/aei1gXR7WyJoqq/cp0jM4ZzHDlyRntAzuAhAc9Ks KoZqiaKv76+pyGrcjKk0rdBm5ihl8LUwcaKV2om2P++HfxfpNhPua9UfINitphhZocEW W5EQvjf6int9VqQ9s3xxiBfZH8f6/wjPlT95qssSsH2UssKInnrO3sVGwbJkbKPuJgoU NyNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775711098; x=1776315898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TnlvJQe4yhPb84lvxXeuW/a2CDGHMe2shk7LZ1M+Eo4=; b=bBNFfYL/m8oIc9Obmzw7/rHW1W+u9SdB4NyyOS3ASwMino+lLa21bChQd6khjo75MN w4TIg1hoqKnhRTnRzrFPrTFpxxRVtikQICsKo8LVs9hrtweuUXK+Qz9pGaalxoaJ+ZQC RRECvwougsSevPYI2KOh26x9NUKlrdxuXDMJgW1RDU2Qb7lwQm63MMfh/RFY/jC+P8mX Mb40YxtzU2xBQ800n7eyo2DIDiMDCmNylpR2crfARP6zHcSuMzK9N87yNdcyPyfaMCIc zwcpeiC6evvhj/oe8eY1MxeuOYV/tcck0GUWrmcGdW/NEVG9FUzJYJ4TFYtIL+nJw6na czLA== X-Forwarded-Encrypted: i=1; AJvYcCUfkNOq/v/yyUe+XKHJNiukU+kQBxtJzuZwuIuYJkX27gnumyhthHQjR1wOrgN4G59t/e+nIX8znRp32tU=@vger.kernel.org X-Gm-Message-State: AOJu0YyJFMRnG6Ne3LH3amjtnG7SmngJ8YjZuqb6Qa47zpwER/2j1Jno Vgc1UBM9g+lGX69I+fgikrI+Jk+mZbOZyrEi92eL35sRrN6RGiX2A2xQ X-Gm-Gg: AeBDieuWsbnsVw5hHlkkHVh5d17ogYMZ0yrq62IzES0jkhJPm2twBFq6In8UneftYmi t+OS6DMJNIOLpexMq3CI8GCkYidGZwEonevNucKSr7crujtMRt2clj1K8kNCwnNmVF4NT8cGj+O DyJp8KgVY/tbACjMkwRNa8Ih/L3VsQEnd07D8dpo2pdlhvuiyl41qbd6zDmtPTw/s0EYHhO9/zQ uts3sHJWCeQd5ztNJk/kNcytdONZdPdtPPzGY6kT628CWkblwl/rKdNnxAbvNv9Oc1cm5apAC/e QO/WJ0isJGEj7AXvx0wPujyde4iRqSvUs8F48BT/XRRaKSi3F4nxbVRL3E34NvUyzHFk9hnECPb MnDd2sgXXIhLuzKatotB9bfajzJKq+F1WqQ++PcXW3xRiIny+t9BFPZvP8HMIY2/SvBhJmTBRng I+pL5yhBou7EgDEo/jeTk2k7Ck57Baq33hSB05aJI+7ygQ9C7equ1AMg== X-Received: by 2002:a17:903:22c6:b0:2ae:3b9b:db34 with SMTP id d9443c01a7336-2b28188da6amr250662535ad.42.1775711098419; Wed, 08 Apr 2026 22:04:58 -0700 (PDT) Received: from localhost (as040201.dynamic.ppp.asahi-net.or.jp. [150.9.40.201]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2b2a488caa2sm135280875ad.14.2026.04.08.22.04.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 22:04:58 -0700 (PDT) From: osjin83@gmail.com To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, osjin83@gmail.com Subject: [PATCH v2 1/4] staging: rtl8723bs: fix spacing around operators in rtl8723b_phycfg.c Date: Thu, 9 Apr 2026 14:04:49 +0900 Message-ID: <20260409050452.97774-2-osjin83@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409050452.97774-1-osjin83@gmail.com> References: <20260409050452.97774-1-osjin83@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jinemon Tama Fix various spacing issues reported by checkpatch.pl to improve code readability and conform to the Linux kernel coding style. These changes are purely cosmetic and do not alter the functional behavior of the driver. Signed-off-by: Jinemon Tama --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 7fac1c2ba8e0..cfa00775341b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -19,7 +19,7 @@ static u32 phy_CalculateBitShift(u32 BitMask) u32 i; =20 for (i =3D 0; i <=3D 31; i++) { - if (((BitMask>>i) & 0x1) =3D=3D 1) + if (((BitMask >> i) & 0x1) =3D=3D 1) break; } return i; @@ -109,18 +109,18 @@ static u32 phy_RFSerialRead_8723B( NewOffset =3D Offset; =20 if (eRFPath =3D=3D RF_PATH_A) { - tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhy= Set, bMaskDWord); - tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIR= eadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord= , tmplong2&(~bLSSIReadEdge)); + tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforP= hySet, bMaskDWord); + tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSS= IReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWo= rd, tmplong2 & (~bLSSIReadEdge)); } else { - tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhy= Set, bMaskDWord); - tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset<<23) | bLSSIR= eadEdge; /* T65 RF */ - PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2|MaskforPhySet, bMaskDWord= , tmplong2&(~bLSSIReadEdge)); + tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforP= hySet, bMaskDWord); + tmplong2 =3D (tmplong2 & (~bLSSIReadAddress)) | (NewOffset << 23) | bLSS= IReadEdge; /* T65 RF */ + PHY_SetBBReg(Adapter, rFPGA0_XB_HSSIParameter2 | MaskforPhySet, bMaskDWo= rd, tmplong2 & (~bLSSIReadEdge)); } =20 - tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhyS= et, bMaskDWord); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord,= tmplong2 & (~bLSSIReadEdge)); - PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2|MaskforPhySet, bMaskDWord,= tmplong2 | bLSSIReadEdge); + tmplong2 =3D PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPh= ySet, bMaskDWord); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWor= d, tmplong2 & (~bLSSIReadEdge)); + PHY_SetBBReg(Adapter, rFPGA0_XA_HSSIParameter2 | MaskforPhySet, bMaskDWor= d, tmplong2 | bLSSIReadEdge); =20 udelay(10); =20 @@ -129,16 +129,16 @@ static u32 phy_RFSerialRead_8723B( udelay(10); =20 if (eRFPath =3D=3D RF_PATH_A) - RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1|Mask= forPhySet, BIT8); + RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XA_HSSIParameter1 | Ma= skforPhySet, BIT8); else if (eRFPath =3D=3D RF_PATH_B) - RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1|Mask= forPhySet, BIT8); + RfPiEnable =3D (u8)PHY_QueryBBReg(Adapter, rFPGA0_XB_HSSIParameter1 | Ma= skforPhySet, BIT8); =20 if (RfPiEnable) { /* Read from BBreg8b8, 12 bits for 8190, 20bits for T65 RF */ - retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi|MaskforPh= ySet, bLSSIReadBackData); + retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBackPi | Maskfor= PhySet, bLSSIReadBackData); } else { /* Read from BBreg8a0, 12 bits for 8190, 20 bits for T65 RF */ - retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack|MaskforPhyS= et, bLSSIReadBackData); + retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPh= ySet, bLSSIReadBackData); } return retValue; =20 @@ -203,7 +203,7 @@ static void phy_RFSerialWrite_8723B( /* */ /* Put write addr in [5:0] and write data in [31:16] */ /* */ - DataAndAddr =3D ((NewOffset<<20) | (Data&0x000fffff)) & 0x0fffffff; /* T= 65 RF */ + DataAndAddr =3D ((NewOffset << 20) | (Data & 0x000fffff)) & 0x0fffffff; /= * T65 RF */ /* */ /* Write Operation */ /* */ @@ -266,7 +266,7 @@ void PHY_SetRFReg_8723B( if (BitMask !=3D bRFRegOffsetMask) { Original_Value =3D phy_RFSerialRead_8723B(Adapter, eRFPath, RegAddr); BitShift =3D phy_CalculateBitShift(BitMask); - Data =3D ((Original_Value & (~BitMask)) | (Data<nCur40MhzPr= imeSC>>1)); + PHY_SetBBReg(Adapter, rCCK0_System, bCCKSideBand, (pHalData->nCur40MhzPr= imeSC >> 1)); =20 PHY_SetBBReg(Adapter, rOFDM1_LSTF, 0xC00, pHalData->nCur40MhzPrimeSC); =20 - PHY_SetBBReg(Adapter, 0x818, (BIT26|BIT27), (pHalData->nCur40MhzPrimeSC = =3D=3D HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); + PHY_SetBBReg(Adapter, 0x818, (BIT26 | BIT27), (pHalData->nCur40MhzPrimeS= C =3D=3D HAL_PRIME_CHNL_OFFSET_LOWER) ? 2 : 1); break; default: break; --=20 2.53.0 From nobody Sun Jun 21 00:14:16 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35F7E243367 for ; Thu, 9 Apr 2026 05:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711104; cv=none; b=hyRvSa8w3pBLARkvwBCKmfTIlYhVRVqwaeoGhjTV/lNVu3sDSbx8DEb9z3LlRYFIyjrnhzZMzhFxmY4rUzdGh3WsX4fdyz9oKNXWoc3T/7IsZnT+SWYfD04JsSWFLKsvoH+TYdtx6Wc+P/iPMtMM4LCzSO2BBK7UoHL+CgeOPoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711104; c=relaxed/simple; bh=mQzK9jcZz828yrR4TkUosfzwRW+IuxNhui1V13o9NnA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i7u25RWH1lqHt6G1jAuvmaYKzk/efwpzCB86Bj/fPwgBHfAhqXLWv+ufuizRoaytbggOqi8eaP+7qrq+S0zt22Os+JPAM8YwsMfmmrdqVvA82oJ0B85urXPshYE0fVq2YJWWh3GnDufTGHpip42Hjv/vLmhIE9e/tX5d7pvTcH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qvF8uTJG; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qvF8uTJG" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ad21f437eeso2374525ad.0 for ; Wed, 08 Apr 2026 22:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775711102; x=1776315902; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4btcIHGygDjuRmL9zvSKQuZ0W6zk7fWotRKDDiRyMFo=; b=qvF8uTJGUwW3NE28EmsPIB0YeDCLKed9EbowntunP6mFKHIF0vHJ58UlStUX1OL9bc cS90L2sjIgYnOwS89TGhkjy2dfCQNdSvXC9VUvTkDQ5wlMiETfX7PqrSsxcFQcBF8VQS x4K0DkmGXX5y5nayqoPMQcsIpJj7sN7zvzAUqPXx8Iu8h8htKA8tMbLHUArhsF4e+Mj4 pN81kTi5eiDtrQmHv1wicVwxqs70SUc7U4QQCaWO+FDbPNQIf87QoKlmRDqAkZDwseNY tQgdXcxZSzAcNXkQzQczWSxyuR/O5oh+vkdVyKkxg/A1Dyf19YE6RrzjMd5g3ablpWm2 xa9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775711102; x=1776315902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4btcIHGygDjuRmL9zvSKQuZ0W6zk7fWotRKDDiRyMFo=; b=I9xXkHtQ7HKhziKhUAnm3mhx7FzCEsnDLIuXOUBRqM55qb0YYBN0rARxPSU527tWOg DxheEZpS6+JeAXUxgVci8jBA6bzWSjdBoc10HUsdLxkTrlcvbpkSecDqaMa5iOd8U8ZH DAmbrKfIsVMXsXQbxRhsMu80xrSVzmLXWJ7/PrD3KkXvk/MV70PDGWaNPGnWU0psiBVr ODibVTU1w7ao6vMHJPeIm7spjN8xRlEhonRzwSNSkO6qgqzSe8xZxYuBdaQykocsna2S gg3iVYyL0P9fWzhPW/XiJEwaHuA5eS2DNlsFOohC5Nl/Kkx3hbA23B676IL5+LjwE3xO WpHA== X-Forwarded-Encrypted: i=1; AJvYcCXnkYc3HhFTQdOFfzdkTY43dCMFoBAjfIUyQ5BmO2aiMJlfahhlMnKfcTDZkVFXKF8Ub+4Pnl/jrYSDztU=@vger.kernel.org X-Gm-Message-State: AOJu0YzRDB9bptcMnAC267xYHBKWwU5wQo0LDmdhbgobV3XBaFBrslGF +ta2iUODU2X/lO7JETt347eRFnJGmW8sTS7i924VB8/GYrGSNr5xQu49 X-Gm-Gg: AeBDievKtifTWlAc3srQLK8Xwc3pVWFIF/ABbl5nF0UsIy0O02rXWBxXt5ohEjArBMJ DKuodqCeQCw9R/3aWsuCwT9BMxml5aEh4MxvHaly7ybQpPvPlGghJnzDGq1YGsWqqg6YSA+akbm /pT0dmSF4KpDNeZZ4NqGSuXYGw05sP0hY7EzgpzUHBxE8kCEgMPnTeLdkh30vWYJg9+zVmu/2JH tW4013t7crD45sdfSdReZmNxGzuuVWqdjw+KEmmwqe8vYg8IS8pIu64oaAjrECYaakNCzg8wk+B XiMKI1vVkQg94swWXa+L1faYinSRDmLpwL0NsrFPrlam4iG1rQ8eic0phQg2A+mfuJPkip4Ua2d RRlc/ZcoH1SXcc2Gp0JyoRAQE9j0MA2pzQlC74XbeXt5rebh3I2m2REvlaZ+4+jYMJHcmS02l+2 nB0ojE29vxT0CfsqwuLNHiMjlYQMjgFC6gqTTCa2iBcZyQGD1xexqBgATXu+eYgSWR X-Received: by 2002:a17:903:3848:b0:2b2:9a84:e870 with SMTP id d9443c01a7336-2b2c72d51d9mr18853365ad.8.1775711102149; Wed, 08 Apr 2026 22:05:02 -0700 (PDT) Received: from localhost (as040201.dynamic.ppp.asahi-net.or.jp. [150.9.40.201]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2b27472d233sm229004565ad.2.2026.04.08.22.05.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 22:05:01 -0700 (PDT) From: osjin83@gmail.com To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, osjin83@gmail.com Subject: [PATCH v2 2/4] staging: rtl8723bs: remove space after type cast Date: Thu, 9 Apr 2026 14:04:50 +0900 Message-ID: <20260409050452.97774-3-osjin83@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409050452.97774-1-osjin83@gmail.com> References: <20260409050452.97774-1-osjin83@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jinemon Tama Remove the unnecessary space between a type cast and the variable as reported by checkpatch.pl. This improves code consistency and conforms to the Linux kernel coding style. Signed-off-by: Jinemon Tama --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index cfa00775341b..01e1595fb46f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -531,7 +531,7 @@ u8 PHY_GetTxPowerIndex( struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); s8 txPower =3D 0, powerDiffByRate =3D 0, limit =3D 0; =20 - txPower =3D (s8) PHY_GetTxPowerIndexBase(padapter, RFPath, Rate, BandWidt= h, Channel); + txPower =3D (s8)PHY_GetTxPowerIndexBase(padapter, RFPath, Rate, BandWidth= , Channel); powerDiffByRate =3D PHY_GetTxPowerByRate(padapter, RF_PATH_A, Rate); =20 limit =3D phy_get_tx_pwr_lmt( @@ -551,7 +551,7 @@ u8 PHY_GetTxPowerIndex( if (txPower > MAX_POWER_INDEX) txPower =3D MAX_POWER_INDEX; =20 - return (u8) txPower; + return (u8)txPower; } =20 void PHY_SetTxPowerLevel8723B(struct adapter *Adapter, u8 Channel) --=20 2.53.0 From nobody Sun Jun 21 00:14:16 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 019C9274FE9 for ; Thu, 9 Apr 2026 05:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711108; cv=none; b=lW/24kBU2K1SiKe0n4qFaUSfcY4OW5FvEjbsiFBJ0lBWhajf226ov2W0SYUFmRXDILwecqv/S9xNJtEk1KzzmtZzgcYSs5dUO7uYtyZD3FsXK04Qy2YrTXL2FUPq7nHVT5//9lmrW/rDIMMHTlvhAWZB+rsawPs9HLhr7qVA7go= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711108; c=relaxed/simple; bh=XWjPDTurlilNrw2XfAYgXsGsKIto7kFmaDCVrc+qjhw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rcqHVHhVpZ6A9E58WR+tZ90kh9syefdcJ6Eli1rBXGhpe4FLQAhqOLwC+SHZY7Xers6LR7zb2ul3Q8ThC+Cvay3KJo16mYj2wyg9kFoGDhWYyz6Xq/UHC6ehiQRzyK1R8q6cd8Pmm8X2gG7Ozdr18ZRFbItDgFJF0V33Eut2dGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rGs53yan; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rGs53yan" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35d971fb6f1so496335a91.0 for ; Wed, 08 Apr 2026 22:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775711106; x=1776315906; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=16bGWKMKr2xPT0xophpJ4YNa094trd/4O3HW1FIquVU=; b=rGs53yanl6inmDoDn2qoYTXJXe4jTP5MGPXSOPwidJYfA/73D3mO4ZYm0neAAC6K1P Fwj2LLqsvDO/VLxMGA5Y7wiIOqDpnIbVVxRsv7C3L8amEnS8QTqeD47ZnPFHT2KBX3Bf MkHXe/Jv7KVMuZ4Yr4dSIEjmabg0nSpdbmeroKatgyIj2BZnzzq8fGzktlLBE7lY4rnU a6512JN8qWMdulvvza+58Q774IGB7qjVBloEBhKX6dHqxVvtl5o4LXg2OWJgTeXbyIUT 52bQlfodC7Pil1jSdZcqbxJcca+qtXbtZFViuAQeMh0hn/LuWK2RjizGrqo4kDHdZKuW C4hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775711106; x=1776315906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=16bGWKMKr2xPT0xophpJ4YNa094trd/4O3HW1FIquVU=; b=icVt88y9xgU9VIPs7bTvGEXjsShxThodKuVlcJ9tnFeJpngjrbUCmIX+TKeyeXQEde EduYDxESjEhNzEBh2yxRyp49P5tItAMYw37Zfp8RxEXfp2BenBUUiXRCC81+uPlo1hLY lKwZ8M+ltZrNRPGmIVyVasRw4TCHVg00F3sF5h5vqEUUh/glIhRxvK8zZ4uWbMs1jp3a u/fekUeLDdnkgPX9lLvN8b8P0O3XDiRfRGOL9z6wo4wvj/5R/NiYHIPC0XLHgv0/je1t XGcwoGj2J9n4V/2KvwZdsSpjnUz2oWsQSMOfKg9sM6CwyoGCjsX82OQuC0cB5oBI2icj Y/sQ== X-Forwarded-Encrypted: i=1; AJvYcCX7wTgejRmaU67oVjyYWIOcUQHYdSAaO+HjWevT86xpG8OaEhVsUN4Ibs7nfo00xRWGyHwTMvPcSnib8Xg=@vger.kernel.org X-Gm-Message-State: AOJu0YygibhaaFH7NoQ+m9O17GUHbq+6LZA6r1c9Gkq91ZTezJo/Lf9R 9ZrAHyJZp8HF+sjl+M3PX+8BxHyQQuTAub1jDWSewoFjS1nYOVkUJpCH4NWKsw== X-Gm-Gg: AeBDieukHTUAJlOY0byeAfp5M5FlYMDdH9ZfY7IvBxrmS4RJdiIuSh9FZTuOqIpaqE1 7yh+lVCd7n95MCdpEpyxicoXlV+PiFfBhF71hKLrN7apFakara0ZVEmREWsTkA8HuPchDz/n17J iETQdv9nLoj3oSwSdkH7UXg2PQ/52BV0MHpM7g8r3ckZA6hnR1715kLojZGL2eyTnQMcpeSe1dq yqhJ9bS6Y/Lgk1IDO/lrGicivWZxPpDQpBthXTss62TVGgYSZoQQiy3/lyR2Y7qFeVnC5forMz7 cAUAat4V5dClBXXFbHlVrA7z/+h71r9mnHG0rGdxWbGRqnAI2LAqXSgbqxwN0VlHOhe+0Xf0cYP ir8340+xyB3plshNnkZph3GSW4vUILicM2HaSTmCI/+BgOLaIWWhD0dnrGHf9rihQAbimdkucAR grgroDsobnxTfu/2gG9VEO9Rlo0qfjZuWXN0Jk8Y+XOTsmDohYw7lIBQ== X-Received: by 2002:a17:90b:1c0d:b0:35d:95eb:879a with SMTP id 98e67ed59e1d1-35e35969f38mr2277060a91.13.1775711106339; Wed, 08 Apr 2026 22:05:06 -0700 (PDT) Received: from localhost (as040201.dynamic.ppp.asahi-net.or.jp. [150.9.40.201]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-35e34fd30bbsm1428540a91.5.2026.04.08.22.05.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 22:05:06 -0700 (PDT) From: osjin83@gmail.com To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, osjin83@gmail.com Subject: [PATCH v2 3/4] staging: rtl8723bs: wrap long lines in rtl8723b_phycfg.c Date: Thu, 9 Apr 2026 14:04:51 +0900 Message-ID: <20260409050452.97774-4-osjin83@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409050452.97774-1-osjin83@gmail.com> References: <20260409050452.97774-1-osjin83@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jinemon Tama Wrap lines that exceed the 100-column limit in rtl8723b_phycfg.c to resolve checkpatch.pl warnings. Arguments are aligned with the open parenthesis where appropriate to maintain readability. Signed-off-by: Jinemon Tama --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 01e1595fb46f..498f7b25a2b5 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -395,7 +395,8 @@ int PHY_BBConfig8723B(struct adapter *Adapter) =20 PHY_SetRFReg(Adapter, RF_PATH_A, 0x1, 0xfffff, 0x780); =20 - rtw_write8(Adapter, REG_SYS_FUNC_EN, FEN_PPLL|FEN_PCIEA|FEN_DIO_PCIE|FEN_= BB_GLB_RSTn|FEN_BBRSTB); + rtw_write8(Adapter, REG_SYS_FUNC_EN, + FEN_PPLL | FEN_PCIEA | FEN_DIO_PCIE | FEN_BB_GLB_RSTn | FEN_BBRSTB); =20 rtw_write8(Adapter, REG_AFE_XTAL_CTRL + 1, 0x80); =20 --=20 2.53.0 From nobody Sun Jun 21 00:14:16 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A733220F49 for ; Thu, 9 Apr 2026 05:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711117; cv=none; b=Hh4RdN3LOukT02a8IQ1T1tH57O/9R6CRAiylU0QDXzJ340rWDVKM65rjvgqyNj9CnvBH/s5JbwfM4+dHGC0UkgzZuEjHUpM+63U0jZQdVdnxfxgtSv9j8ArkbgZf8BlkJVf4mNgItrrfnPs9OXSXTB6QbMPRlYftn6+alAtaECE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775711117; c=relaxed/simple; bh=annGl22vFOZOXryQXSU/FF+34KB6wi5iW2Ym7lBkIjA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qcAQYr5ikFBtBvlJ0g8HFyaAC6opaasiG5HuWAGUoN9ucb3RUSij09z1XRtlNtv2ozAHr/deXX5lNDGFrUt57A5W51XipmCNr32or99H0WvPqymh+j63N4fnUXSb3keKHOHoeEfrcHUHLN1SXnjPJx63cOLvYk1SAZYwM1hQHbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WE4HrEqV; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WE4HrEqV" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3590042fa8eso465950a91.1 for ; Wed, 08 Apr 2026 22:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775711115; x=1776315915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zfjkkath6l6jnzMysZ75mtqAFvV8Lu5hwVyhifLJIOQ=; b=WE4HrEqVI8IGgd+ZuWJ0SwB+plcBBGRbwHEXdIPnRP4KA/7AgfFKkiWUhAq6rbD2T2 Ju3QQ/KiFhmc7lUQqhVgUqPH9zOl8iLbwIRgvcnFDDVQtEOY0zmqwmRX+7wPpv4Kptlp 1oaAHawm8NYLeiGNL5qylwYJrMq+lq1qnbkPQ++U34yhi/CPljMq0YObOXqosPLgYGjx TbucVLR8BmrfgTYPtn82G7SN/BPzXC+FHqxc/pcGxy91djzHyMQk/CsM18B0SDGKYXB+ RN1dM2F5CXOIKbetyOxLou+bELsUWzKCVX9tyWI6FUlD07nRmmVZyJEHasHxI8CZ9u7i ifvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775711115; x=1776315915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zfjkkath6l6jnzMysZ75mtqAFvV8Lu5hwVyhifLJIOQ=; b=V1XBlKJgXeqR/TAEYT1pT8W1MeHtPJzeU/gvErzhmfS6SVqhbt5H50OBYAcr5DG9Vl UAKO9rBYjaqw9gV1ZtZKXReoaDmKiAGWScR3mz27qGMMOHc+8/kYx/FqhbrNNP56fhOp BLHcQObDxkm5/x3zMkEG7vja6RkQjFGSDtRXx4/LQZON1gYrTD82jrwTSdavkDEUZ6ps g0XAZaxJ2M889Djcp2SORn7azbgZMjjhpVLDpvARxuXf06x2zLAdWbnZ0Sns3Bj6kqoO xd1VHKwBv07n9NEijOnL5DwgJMv6kakUBkGX/h2Oddz9WRiSytLKjF7rO5m13dftx0I7 RAOQ== X-Forwarded-Encrypted: i=1; AJvYcCVYij1Uma81PKkJe7riH1HJ6oK4BspJdB7qxOi8ka2gZe8BoH1/iWaX9/wHoFol6eVPpPCWOV3HmKkOI4w=@vger.kernel.org X-Gm-Message-State: AOJu0YwtS1Y7RwYtr3Xhr6laEIwCgvAezf9jh5pKChaPT3oLiYJS/s5r 39epwlfDE539QSwHS1xiLBgwJL68Q5Hb0WAmXJ7KOOqXsD/yUJgkvqpf X-Gm-Gg: AeBDiev6dfyfJPgYQWdp0OShWH+LU/hjJ5zY9QgWlsjXVRilWvdLP8ZBccioHoxMtua 7YNe8Ba7kPbrA0rB/eLElOiCTGfkk40AFGTNHdIfp7rkerUmio0+6JRqAxtiQp16fhj2uzMs2/Z NI5iAhN2SZZ2h6Pb9XCYjt1M+nriu8+c46R6KL+Ksxq0psi1riIN4A5FXqeaSnwE+bm6krZvoCX OBjsNtusBCip14d8Cl1Ra5lc1ZtSlAbB7He68LfanwFqG+DaMr5H9LuMeIiei/9m8LYFY2lUJ1H vrA1SntJ6SkCSyrAZqyu73CqefrmOz9WEZS3Ts6+Rsnp1f1z7YEzVGwbAhbGWX33otRt+w3QcNN zOblC7qekbO1Q4Cj7X7bno2BlBVzXAXbovkii6HmRiUb8OCCzIXabk/5C6VZ/HuopFGqArSJ8un rhtJ5zdZHduvGNbSoXct8ILmrigDC/k2LDXFIzC6UFD9bVgh09AbHYGg== X-Received: by 2002:a17:90b:3a0f:b0:35d:9c32:6219 with SMTP id 98e67ed59e1d1-35de68632f5mr22180355a91.9.1775711115497; Wed, 08 Apr 2026 22:05:15 -0700 (PDT) Received: from localhost (as040201.dynamic.ppp.asahi-net.or.jp. [150.9.40.201]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-35e34fdc4bcsm1499905a91.7.2026.04.08.22.05.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 22:05:15 -0700 (PDT) From: osjin83@gmail.com To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, osjin83@gmail.com Subject: [PATCH v2 4/4] staging: rtl8723bs: remove unnecessary blank lines in rtl8723b_phycfg.c Date: Thu, 9 Apr 2026 14:04:52 +0900 Message-ID: <20260409050452.97774-5-osjin83@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260409050452.97774-1-osjin83@gmail.com> References: <20260409050452.97774-1-osjin83@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jinemon Tama Remove unnecessary blank lines throughout rtl8723b_phycfg.c to clean up the code and adhere to the Linux kernel coding style. Signed-off-by: Jinemon Tama --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/stag= ing/rtl8723bs/hal/rtl8723b_phycfg.c index 498f7b25a2b5..10eb96105f83 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c @@ -25,7 +25,6 @@ static u32 phy_CalculateBitShift(u32 BitMask) return i; } =20 - /** * PHY_QueryBBReg_8723B - Read "specific bits" from BB register. * @Adapter: @@ -46,10 +45,8 @@ u32 PHY_QueryBBReg_8723B(struct adapter *Adapter, u32 Re= gAddr, u32 BitMask) BitShift =3D phy_CalculateBitShift(BitMask); =20 return (OriginalValue & BitMask) >> BitShift; - } =20 - /** * PHY_SetBBReg_8723B - Write "Specific bits" to BB register (page 8~). * @Adapter: @@ -80,10 +77,8 @@ void PHY_SetBBReg_8723B( } =20 rtw_write32(Adapter, RegAddr, Data); - } =20 - /* */ /* 2. RF register R/W API */ /* */ @@ -141,7 +136,6 @@ static u32 phy_RFSerialRead_8723B( retValue =3D PHY_QueryBBReg(Adapter, pPhyReg->rfLSSIReadBack | MaskforPh= ySet, bLSSIReadBackData); } return retValue; - } =20 /** @@ -210,7 +204,6 @@ static void phy_RFSerialWrite_8723B( PHY_SetBBReg(Adapter, pPhyReg->rf3wireOffset, bMaskDWord, DataAndAddr); } =20 - /** * PHY_QueryRFReg_8723B - Query "Specific bits" to RF register (page 8~). * @Adapter: @@ -272,12 +265,10 @@ void PHY_SetRFReg_8723B( phy_RFSerialWrite_8723B(Adapter, eRFPath, RegAddr, Data); } =20 - /* */ /* 3. Initial MAC/BB/RF config by reading MAC/BB/RF txt. */ /* */ =20 - /*------------------------------------------------------------------------= ----- * PHY_MACConfig8192C - Config MAC by header file or parameter file. * @@ -329,7 +320,6 @@ static void phy_InitBBRFRegisterDefinition(struct adapt= er *Adapter) pHalData->PHYRegDef[RF_PATH_B].rfLSSIReadBack =3D rFPGA0_XB_LSSIReadBack; pHalData->PHYRegDef[RF_PATH_A].rfLSSIReadBackPi =3D TransceiverA_HSPI_Rea= dback; pHalData->PHYRegDef[RF_PATH_B].rfLSSIReadBackPi =3D TransceiverB_HSPI_Rea= dback; - } =20 static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter) @@ -373,7 +363,6 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *= Adapter) return _SUCCESS; } =20 - int PHY_BBConfig8723B(struct adapter *Adapter) { int rtStatus =3D _SUCCESS; @@ -614,7 +603,6 @@ static void phy_PostSetBwMode8723B(struct adapter *Adap= ter) u8 SubChnlNum =3D 0; struct hal_com_data *pHalData =3D GET_HAL_DATA(Adapter); =20 - /* 3 Set Reg668 Reg440 BW */ phy_SetRegBW_8723B(Adapter, pHalData->CurrentChannelBW); =20 @@ -725,13 +713,11 @@ static void PHY_HandleSwChnlAndSetBW8723B( if (!pHalData->bSetChnlBW && !pHalData->bSwChnl) return; =20 - if (pHalData->bSwChnl) { pHalData->CurrentChannel =3D ChannelNum; pHalData->CurrentCenterFrequencyIndex1 =3D ChannelNum; } =20 - if (pHalData->bSetChnlBW) { pHalData->CurrentChannelBW =3D ChnlWidth; pHalData->nCur40MhzPrimeSC =3D ExtChnlOffsetOf40MHz; --=20 2.53.0