From nobody Mon Jun 15 09:37:12 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5951C3BFE3C for ; Thu, 9 Apr 2026 11:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775733276; cv=none; b=ofW6EAK7s+PAHth0i5QZw8UooWIDGmzo8UXy0txMKxpDFdAxpvtUz4/c3TQaeRuxi5LSFWSJGsdb/VnRFGRAwotjjeH8fGgAOELgt1ytyTMFlrs61FHkF6sfpJqumuJpv/gqAoLlIgea22EQQ/yQKkY/U8ieyIV7Yw77jmOGqpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775733276; c=relaxed/simple; bh=bejrTeQRjiPAotuIgByVMSAt54/UheMAZfkq9JrHkAo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=TqiwmFlle7K27r7edMNyYvim3gSS7KY+GzNeai/MwqgZNuJO22LPZ3Ks/v0Zu2BFifqHG7J4YI1YoFF7Ppx/ZJSK05rdR2L3myaNirqk8FWFu13nt1STtYkvcLi5oEY3B0rz+Y1qM43oPqpvMnPR/my8Op05/bwTewlSy9XTAcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ZOkcvAfK; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=AYVm7CQ+; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ZOkcvAfK"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="AYVm7CQ+" From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1775733273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RKVtmtTjNBPpX08TpDFxoZ0QGu1zUZK8m0hyilt4oq4=; b=ZOkcvAfKs6XE/FbNku8pcO4MyYpOseWQPJbm+zZoAOiIGwjQmHFcNKODdp6D+eseeykRVo sZyeGtS98l2gY8hLXS8oHJNSohz73kp3D3hOXrJW3MSMunJETahr5YDeS0kpRBKluXOEc5 a93B0sQ8ZYpL28ojQa6Hl6+is03fPPDPw1/PqZ5BKFjFRxRThGoN68gxguDQ7VOLLhi6tg VE9OuJ+Zqm+etDPjEXN+plptZQ6iEBQ3dvuIMDBRHgGol8/4y1REkXRycz6qXgysv91TzY 8vYirJEcBsQxBkIoM3q8fjJu5Y9dx5QMplyTipyauniKDW1dNNQQjLsjN86How== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1775733273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RKVtmtTjNBPpX08TpDFxoZ0QGu1zUZK8m0hyilt4oq4=; b=AYVm7CQ+v5A4vNVeBO4iY9XvXAP0CzD2rwKcPlU0vtIWLuJ6sWEovU68PIJV8+tPI6zyEp bidOBYOapm/2ruAw== Date: Thu, 09 Apr 2026 13:14:05 +0200 Subject: [PATCH] vdso/datastore: Zero out newly allocated datastore pages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-vdso-datastore-zero-v1-1-e7b64a7c54b5@linutronix.de> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MPQqAMAxA4atIZgO1SP25ijgUEzWLlUREFO9uc fyG9x4wVmGDvnhA+RSTtGVUZQHTGreFUSgbvPPB1a7DkywhxSPakZTxZk3YNrMjT3XrKUAud+V Zrv86jO/7ATUNwy1lAAAA X-Change-ID: 20260409-vdso-datastore-zero-87f0d2d482d6 To: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , "Christophe Leroy (CS GROUP)" Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Developer-Signature: v=1; a=ed25519-sha256; t=1775733272; l=1511; i=thomas.weissschuh@linutronix.de; s=20240209; h=from:subject:message-id; bh=bejrTeQRjiPAotuIgByVMSAt54/UheMAZfkq9JrHkAo=; b=XszG6BDCI8r4asEbpR6J/34xd2WVGvydvCJLEpwQ4y8mJo/4nmXUt7wYweanbLPM/KcCJD3Ng PsAtif3WmvaCQ3WTrOcNzwy2zSnixMODa20UbXzBWB6wKuobpxUJQxb X-Developer-Key: i=thomas.weissschuh@linutronix.de; a=ed25519; pk=pfvxvpFUDJV2h2nY0FidLUml22uGLSjByFbM6aqQQws= The data pages need to be zeroed initially, as garbage data can break the vDSO userspace logic. Fixes: 05988dba1179 ("vdso/datastore: Allocate data pages dynamically") Link: https://lore.kernel.org/lkml/aQjJNmwniQwwjeBR@finisterre.sirena.org.u= k/ Signed-off-by: Thomas Wei=C3=9Fschuh --- I messed up and dropped __GFP_ZERO again when switching from folio_alloc() = to alloc_pages() in v6 of "sparc64: vdso: Switch to the generic vDSO library" Previously the missing __GFP_ZERO triggered boot-failures in -next, but apparently with alloc_pages() we got "lucky" so far. This could also be merged into the originally broken commit. --- lib/vdso/datastore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vdso/datastore.c b/lib/vdso/datastore.c index cf5d784a4a5a..55f1654624e0 100644 --- a/lib/vdso/datastore.c +++ b/lib/vdso/datastore.c @@ -42,7 +42,7 @@ void __init vdso_setup_data_pages(void) * Do not use folios. In time namespaces the pages are mapped in a differ= ent order * to userspace, which is not handled by the folio optimizations in finis= h_fault(). */ - pages =3D alloc_pages(GFP_KERNEL, order); + pages =3D alloc_pages(GFP_KERNEL | __GFP_ZERO, order); if (!pages) panic("Unable to allocate VDSO storage pages"); =20 --- base-commit: 7138a8698a39e81eb153e05500823fff76d5b3bd change-id: 20260409-vdso-datastore-zero-87f0d2d482d6 Best regards, -- =20 Thomas Wei=C3=9Fschuh