From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39543314C3; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=PwBCkT5TPK7Ro7v6dm2uOjLI5832t8UgtuzQQG8dDoj4pZJJR9nVVM1rT26MMUyl91/5v7apI27G2ecpul+ekwr+OFUAZ3iuiOJPFBikeTXBxyRBpqBP9fnsS+YgZC2lT8teBbI0q2Dm/hAhmg7SZ4/BWzlOZfFrtqhrlaXPfHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=qd97gSvYOsCinrKqjfSpyQyyC3+0l1mQqK8cxyagYwE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oLHRc4AFqLip6Aexo0EBgK8qMhvcOQRmIEABRRWRcwNwZydfYRc7kt92b89IJPzp4P0WW8txyGPdQd8GbKEK9tIqDlaVPs35SNshz8kJUYWv4lM61t4SAoeezU+GfUbxqx0ao0AN4K8lWpVSFENu/sRf/y04io0GEcAMDlo5/3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R+DqiOCS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R+DqiOCS" Received: by smtp.kernel.org (Postfix) with ESMTPS id AAD25C2BC9E; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686550; bh=qd97gSvYOsCinrKqjfSpyQyyC3+0l1mQqK8cxyagYwE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=R+DqiOCSf/aujk+/xbB+PZWiT9ZtmXyhrGmTI4F61VWOZGE7VZjJVXcjpydhKEd0D FSLTkselCkhjq7lzKIwFgqd5CiAJIu7gGpdo+1EVTI8BvvHp37HFMtEUXFWvgiUOp3 VqG5dIqLdQt8/4PyiI7R32P2G9iaVEGBD53noNcQJQtvdtzskzHnijw4trNfOs4Dp1 8Sc7swjiRZyguUUvPXSaJ2WOo+RQbJcyHVLsy0sWcEs27ZCuSYgGGZLgjiTFYo7GB1 wsoETo9MCIw+PICPnfSHRKQ9n4gyTnS9jeDo96pGtqwFc/yQVHhXGmbBeIRWiRwl2N 96BvZaXVUrdWA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9761C10FC459; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:44 +0200 Subject: [PATCH v4 01/11] Input: stmfts - Fix the MODULE_LICENSE() string Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-1-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1002; i=david@ixit.cz; h=from:subject:message-id; bh=QDQEyb6yQN5WPWE8pVdtCQECptdn8p6xNSQzeqr7Q2U=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tORTVIWUARSt+X8PEgpRWebBk61lkEJPfSUe Qn5hhASu4WJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkQAKCRBgAj/E00kg cpLTEACo06/04dYc2te03+Sy7fTTeUeGNPVohJ8IYXHmRlzwNqxLbH3zEffYQo4ogIp4AzNTrdQ PQMBbB9CZKT8OJSWPojgGhodpGdwTQLAxShW6fr0vY14adVsuUUie7qLGvopPQRm1tYaA+uqxe9 mr2M+ylz9qrFPPrJaogMehFSipIUAdMFb5MnqDFWA0NjEqZp1uGbHC4T1F65w+49RlzaBu7z1AC zDrENGQ3dmQS8uNxV5xr08qCHSJq9U3PqSR3fc5jsrqTzxoLA48AGBGsbBEsFUrvpI6kCt/XXFO UdGalj2w2HB2KHwaYeneO4KFu/mD3Fe2Ylme65GClsUAjmxyoWfTPgOltIpUXgdBV1il1iS/+22 ixalfRz2aHIDZv6t2lGFPM8eNxL/RgaRygUjSu4kvSIXJnodGhIXXs/VsIX0bVPccnbOSL2Afwh pzurDOVnmHN1gJitTqPEbmY17fl4llN1pEpYqDCB09ZjMdg99pYvhQqgxDxq+mc+NuGeGvOMt8n KjRzDRDXQy02HnXXjyKPdVEBnt1oWpHNdvS/dDaZXkoXHbbVLrTLtD7iQnuT2DulPtl/Sxp9+r1 RXOiG/xINI+Hwj/2Azta5YpuTyxQOfNwpZyr6Lt5fLSnNJOkVVt5xvrzx/cs1tiCsYIXjRdvM8k wl7YY81E8PSVRWA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Replace the bogus "GPL v2" with "GPL" as MODULE_LICNSE() string. The value does not declare the module's exact license, but only lets the module loader test whether the module is Free Software or not. See commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") in the details of the issue. The fix is to use "GPL" for all modules under any variant of the GPL. Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 8af87d0b6eb64..def6bd0c8e059 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -807,4 +807,4 @@ module_i2c_driver(stmfts_driver); =20 MODULE_AUTHOR("Andi Shyti "); MODULE_DESCRIPTION("STMicroelectronics FTS Touch Screen"); -MODULE_LICENSE("GPL v2"); +MODULE_LICENSE("GPL"); --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3A34337689; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=XKmivci2IyTZ4uu7GWJKvJUsI/tNOSS/I+4lyyNCXg99DUztZg5AkGtTjmVuHAmZqK4WREsUl6xvQlQqtfyy/SQ0VZyLMsP7Zq9XC8EZyYmC6VWp9OjYSfXOOtbrVCSblOnjuPSq09zLcJu7yUt5aWALlrvGPrLwgkqbOIYeElg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=denZNa2pe33zmfsBlt78CCTctUT565Jw4aDwOLwwftk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mQUjWNGOn2gK58pKndudWuRkOBbivNar/LQuh1SZ1dRJXWBO98Z4DmcjsyADClWRrYFOq8OL2Jx+06TlyyZ+3Jl1/4JE79nH5ygEJxepjKHBT28vD63jRsJsTP07vlBuVRqyVS/4nkdjwRxJDueA39M2wNhx3VzxEJkU2TlgxXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JfXedMLV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JfXedMLV" Received: by smtp.kernel.org (Postfix) with ESMTPS id B6AADC2BCB2; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686550; bh=denZNa2pe33zmfsBlt78CCTctUT565Jw4aDwOLwwftk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=JfXedMLV3fuzCYxrDPksStrohsokhB/Tr797VNHnv6XBYDyHVWTPS/8MHInzYXf3M ecobb3dA78fvkZZTUBv5hwRTz1csSFOpjymceL7v2TJF7Ym4KntBha6C+0YWdknraA YzW0skASp3LxMwLZTn+mPhT444CEY9/bOw2S1dK7j6Oo66a9a6val5t+DXE+lgODZq Pk3aPrOH55F+uKL5H2Nw/rocGpo2PmD1fUIqCJS28CIMxy+hgvZ+GkrsGZLL7+DPeS WDwLh24PIvSxMAqlQztcdlItmnoodHaStx29KmVspghrHxogOSKg9fm5Q3huy+BO8P JUJurVUD0sf5A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E8A10FC456; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:45 +0200 Subject: [PATCH v4 02/11] Input: stmfts - Use dev struct directly Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-2-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3250; i=david@ixit.cz; h=from:subject:message-id; bh=tDcuGFSTfadOXIkwoSMoRncuEwaVSpDmbusBAFubYco=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSOL84fbWTOyFbndLfcvZdqyMiF4XrwH37Z iGw/ob+K3qJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cn24D/9In+35mgtiyFLuVeCbOYXr6G9vhfHM3/pB0mLOouiItk0OvQe29Awps6whdhLiVs/lmB2 Sw9h0uSPjoJd/uZDCymi1GfHxtiKI5M4ICLr6eA221VmOLq78Jt8QCPAF06E2mc3awd/Co6BtKC 6XEb7/xeGZpLjuZSjzxI59JKIDzC6aI7ux2VSNW290azRPHinn2B6JsQ1r3sm1xh+oTKEikqhDv YeDsluoU07szD8X6u+PT5/OmghbOYe3HCB0jZt6OicqRDZDbNJtyPoIdwki7ziIjybMddYa0SNx vSIlITGxNs1Ls0A5eUdvo9aSyTo/4QQ61iHU+rEJRBKRb9Azv4lGvz6Rd5BEL4GJHEa6JzFAhXf BZ3uztdTgZVHz+QdHf4kHpmrl2uPFsln/tVIZd65FCZIZwJVbPPIA4EYIx929XPaDvfIUw3w6XG D6Tt8CnoUaIBh/Jr+DSQvMqe7JgeqtazZfvmBnxVT/4sBNJMweavOWmIyQY0CT1VBswxwM4XJhx TLrCRW3kjDFU2BNbCN0Qded06OItwUANzv4kY+qAtoUqOUkB+8N2x0lyxM36eL6Lv0hA27GabVN f339RV0iqw7IU+Nofl5tVx3Jvkbuu8PrTR26siXMZ1Nkf1ypQcBxDgmCbMil/zQczO0IooSJDnf xVMrRpjQrtUcQwg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Makes the code better readable and noticably shorter. Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index def6bd0c8e059..7b1e975a85668 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -619,6 +619,7 @@ static int stmfts_enable_led(struct stmfts_data *sdata) =20 static int stmfts_probe(struct i2c_client *client) { + struct device *dev =3D &client->dev; int err; struct stmfts_data *sdata; =20 @@ -627,7 +628,7 @@ static int stmfts_probe(struct i2c_client *client) I2C_FUNC_SMBUS_I2C_BLOCK)) return -ENODEV; =20 - sdata =3D devm_kzalloc(&client->dev, sizeof(*sdata), GFP_KERNEL); + sdata =3D devm_kzalloc(dev, sizeof(*sdata), GFP_KERNEL); if (!sdata) return -ENOMEM; =20 @@ -639,13 +640,13 @@ static int stmfts_probe(struct i2c_client *client) =20 sdata->regulators[STMFTS_REGULATOR_VDD].supply =3D "vdd"; sdata->regulators[STMFTS_REGULATOR_AVDD].supply =3D "avdd"; - err =3D devm_regulator_bulk_get(&client->dev, + err =3D devm_regulator_bulk_get(dev, ARRAY_SIZE(sdata->regulators), sdata->regulators); if (err) return err; =20 - sdata->input =3D devm_input_allocate_device(&client->dev); + sdata->input =3D devm_input_allocate_device(dev); if (!sdata->input) return -ENOMEM; =20 @@ -664,7 +665,7 @@ static int stmfts_probe(struct i2c_client *client) input_set_abs_params(sdata->input, ABS_MT_PRESSURE, 0, 255, 0, 0); input_set_abs_params(sdata->input, ABS_DISTANCE, 0, 255, 0, 0); =20 - sdata->use_key =3D device_property_read_bool(&client->dev, + sdata->use_key =3D device_property_read_bool(dev, "touch-key-connected"); if (sdata->use_key) { input_set_capability(sdata->input, EV_KEY, KEY_MENU); @@ -685,20 +686,20 @@ static int stmfts_probe(struct i2c_client *client) * interrupts. To be on the safe side it's better to not enable * the interrupts during their request. */ - err =3D devm_request_threaded_irq(&client->dev, client->irq, + err =3D devm_request_threaded_irq(dev, client->irq, NULL, stmfts_irq_handler, IRQF_ONESHOT | IRQF_NO_AUTOEN, "stmfts_irq", sdata); if (err) return err; =20 - dev_dbg(&client->dev, "initializing ST-Microelectronics FTS...\n"); + dev_dbg(dev, "initializing ST-Microelectronics FTS...\n"); =20 err =3D stmfts_power_on(sdata); if (err) return err; =20 - err =3D devm_add_action_or_reset(&client->dev, stmfts_power_off, sdata); + err =3D devm_add_action_or_reset(dev, stmfts_power_off, sdata); if (err) return err; =20 @@ -715,13 +716,13 @@ static int stmfts_probe(struct i2c_client *client) * without LEDs. The ledvdd regulator pointer will be * used as a flag. */ - dev_warn(&client->dev, "unable to use touchkey leds\n"); + dev_warn(dev, "unable to use touchkey leds\n"); sdata->ledvdd =3D NULL; } } =20 - pm_runtime_enable(&client->dev); - device_enable_async_suspend(&client->dev); + pm_runtime_enable(dev); + device_enable_async_suspend(dev); =20 return 0; } --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 312AB3A0B2D; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=SNTXR6cNkhExnL5pWHdUGWBGBGXXeI0sEcQxSEWbuNCOJLppVsBCNutffSdesF8SajIAUjJlHNjJV3lD0J84u7SumOmVg6bbvyhxMII6HCcwp6DjgfQ+Hja3i5B96pS/0Qbb1h8S2XdbmI58MwKu9o7edSFqOHRCG8geSMmVmIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=VugrxAEpcoaq9VvpeVHYFFo4mzyAFJTTi30xWQb6Pkw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rf6tXPHLpOPs1Ey3RW0WITZW6t7gCgjXBhdXvWIesjs05NnHojn5GHFpQkT6dP9sQ9LVPLR6EyLrYr/RzEeE4vxMjAZpdxEKyD12o3IeJWp3QxICYUXyP+qtGK9dFTG7+trQjc9/glJU4J31T5B/GysGMAxyUx1Q19tQj6O+3QE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aQPzF6Vn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aQPzF6Vn" Received: by smtp.kernel.org (Postfix) with ESMTPS id C97B1C2BCB1; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686550; bh=VugrxAEpcoaq9VvpeVHYFFo4mzyAFJTTi30xWQb6Pkw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=aQPzF6Vn67pewcIXCtxfCI8bXpJvqQJ5JQxAxBOb3hbSRy5i5h6kwpHbL5hsVR9tC wWC29n9wAz75QquVv2X/qzPGCCxowEKDBVUiYpYPtODWwSlsRKsYlOotwpu4C7AG/a 58GxY8/68QdM0MMYCCM0MI7qZfzrfLi7EyVuoDS+aGVHJLziwsnu5ZIMxSx+GXZ+5A 8o5Nn325CPBgDsB4w5I2mGDPwP+EGCs/OfEWRHIFOQA/gaIa8x8W8gaL19xntR+y2F EgTBRi4fa4VUtvOBuB1uV0hRen2fHWPn67jawmQQuVs66ovSkEivDR0tPtRdbyRHGl dhphH8YYpA9uw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B814910FC45C; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:46 +0200 Subject: [PATCH v4 03/11] Input: stmfts - Switch to devm_regulator_bulk_get_const Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-3-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2336; i=david@ixit.cz; h=from:subject:message-id; bh=FK/zsREY/XInSNUuszAKmQ33vgOOISGuAWF3OsBIumA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOS/t9Q5M2mBMugd7+B1QN2+hFxl8CFpy5AT r9wo8bBUf6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cskbEADD0uywNEE0C4Qby+S4+XcDg8r/GbAfO73ZJ/s7X57qvmjMTkGGfXcMP19sgrxkJcxhY2z zrrYel32XiQtz+OCps0jAH+zm/p3d4UUrKBOybWVORZnRSG399kFlnZcOItbNnHNPfEy+NFfqFS Jel//UoxSwOzXV3vdHyc/ts2NkKN+D83pJGXDhBMEeddrtlqySPhJfPNzYSotEGXac1ZLAccZln gxvoL5opp2EAq47kAQE7L12qzzqxGLxW8g8zxGmyGamabjlGjqDQe05fi7x4t9UsyDGEE5cPzko 7zbjOk+YJ4JngzfvrKYbXU5iWxz0BDJxwnjXDDNIH2urZhM1C0e2BWMFxIYqFiW1JIsrGsAAgZg b8VdNdMtBxaO710QM5TjtJzUpHekWBtTQwl5ueJeQzXdmUurfzaNPW7M5ViP7BI7qUSV4k1VYA6 plOTN0DmqnBmOivHy3lCfFqFWMODLtZ28gJcYPQB5EvO1BFcoa6YU396qSbRIa2ftw5aD4+KXfX FBw/qmyyZ2iBn2u+5VYO+7vf7aqDXjW1wVNNJwqGqeEB9ivdFJSU2KyhSt4qZ0S0FxwT9KeBoWX kXx06/kok7uLh7RiD62AwdGAmxepAhN5Q1NqsK+RXRMLoGyslXwQN1k33nqxlXYLcu67w0xXan7 Ib7gBUWLHXj/tdA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Switch to devm_regulator_bulk_get_const() to stop setting the supplies list in probe(), and move the regulator_bulk_data struct in static const. Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 7b1e975a85668..ff884e04ad4c8 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -69,9 +69,9 @@ #define STMFTS_MAX_FINGERS 10 #define STMFTS_DEV_NAME "stmfts" =20 -enum stmfts_regulators { - STMFTS_REGULATOR_VDD, - STMFTS_REGULATOR_AVDD, +static const struct regulator_bulk_data stmfts_supplies[] =3D { + { .supply =3D "vdd" }, + { .supply =3D "avdd" }, }; =20 struct stmfts_data { @@ -82,7 +82,7 @@ struct stmfts_data { =20 struct touchscreen_properties prop; =20 - struct regulator_bulk_data regulators[2]; + struct regulator_bulk_data *supplies; =20 /* * Presence of ledvdd will be used also to check @@ -523,8 +523,8 @@ static int stmfts_power_on(struct stmfts_data *sdata) int err; u8 reg[8]; =20 - err =3D regulator_bulk_enable(ARRAY_SIZE(sdata->regulators), - sdata->regulators); + err =3D regulator_bulk_enable(ARRAY_SIZE(stmfts_supplies), + sdata->supplies); if (err) return err; =20 @@ -589,8 +589,8 @@ static void stmfts_power_off(void *data) struct stmfts_data *sdata =3D data; =20 disable_irq(sdata->client->irq); - regulator_bulk_disable(ARRAY_SIZE(sdata->regulators), - sdata->regulators); + regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), + sdata->supplies); } =20 static int stmfts_enable_led(struct stmfts_data *sdata) @@ -638,11 +638,10 @@ static int stmfts_probe(struct i2c_client *client) mutex_init(&sdata->mutex); init_completion(&sdata->cmd_done); =20 - sdata->regulators[STMFTS_REGULATOR_VDD].supply =3D "vdd"; - sdata->regulators[STMFTS_REGULATOR_AVDD].supply =3D "avdd"; - err =3D devm_regulator_bulk_get(dev, - ARRAY_SIZE(sdata->regulators), - sdata->regulators); + err =3D devm_regulator_bulk_get_const(dev, + ARRAY_SIZE(stmfts_supplies), + stmfts_supplies, + &sdata->supplies); if (err) return err; =20 --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4538C3A3806; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=dEi4Z0iBAW2ygPyEKdk+2jpKM6NmNbw5DosYykbY9AGWbSCMUXmcxO7eNLdxP4fx1yA6tAlIiX7gSlrjnX524KmhBEHPcPPg57QuCpb7H/klmCndkO3KnoIVNxPZwhnySrB1yvEnGyhFgc3Usc+1ymdxHA0ZfRFKSamQ/xVMD7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=3YxUzY2Fah3UfJvijShkLXUQPt/K+SOukUffoWVie/8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OJc8oeyoccJoBtl9uphvRDKqdtIML/W7U3l1MTwBcOKl4ZMpsro9djkmycNO1OUaKwRnlFFSLTqCNnwinaF4SkM7SX0nck6MvInqRajWNXLNi9JSbTroGJfeqPbEfJEDZ/nnU5vIjMaV9gFaAO1JFVC3T4G+JzLDCzeRoCrQa9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LFtLkyc5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LFtLkyc5" Received: by smtp.kernel.org (Postfix) with ESMTPS id D56B6C4AF11; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686550; bh=3YxUzY2Fah3UfJvijShkLXUQPt/K+SOukUffoWVie/8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=LFtLkyc5y3Y4zaUhkX9mFib8lqm3w0H6It8p0Uoeeu3JR6kSzM2i5Z/upk5ejlGd0 508BKqA2F7BXJRPfKKkHMTUYr/Rq36NWJCEdgp/mAX11VM2lWiEueRuaz9VfLUjL0N QeB++/1sewqYrEzN5peujgE4KeL7o1E+mbCM8tls4tECiK8PkhN8qfMaAwadPYR8v7 7D0FaMooXP8h3QZzbPejjFvmyLTK2sSehKFyoGvc53PLZSeUYmJmOFRZZdshPiTgFY imz4txeF2iXgc18fJ+q+qXMQJzmidZrPgw/ZPabcIp3HwpebTPMVgVNdXZwR3JzaHR N/g7heHDojI6Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C688E10FC453; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:47 +0200 Subject: [PATCH v4 04/11] Input: stmfts - abstract reading information from the firmware Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-4-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1821; i=david@ixit.cz; h=from:subject:message-id; bh=MRRMNTeMVS8qh5Y3wcBKjF6ySEKPpTml4To4kFWgqxE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSDBefFkQ6pmg/ESv1rmphll3moGBi4877/ AdaIOG9cUOJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg ci2eEADECFzczHHY3Pw3nIE/rotnNSqUwkRYNMEFGe9E4VNC5iFgbpJXPFfYNTTC4gXdevtmLO1 7QJz6f+uU0/a3G2yD3nPkQS83GYu4J7uDTFtkuQsDQ18s53YPBE8qSYkQXoJPPpd2DHPbdq5YKe 0jIKBqpffX5dmbgcc2eRxHV5gV97Sw7cgl9VKNxanE9NWpZr3NV5fc7MsrcKWSwaljGS43jDCIY KEf9IyFIfwtdSymkLbG3JTHR6JfQYoTpeXAbG6pjARjAclR/w1o8Vz79Ywj757eGg6Eg+MyQjPk sg5GdSWX2qjTaxMaiUjXoXjG/ZHqp8Y5RbH+wGxA6wYgq4Y7/4D/QqG2tWSqVzSCrY4feS7/6s0 JGAdBH5Yz6UslhhAmjf5WM99L7LfvmCzoXdTu3XZupZ2G+VXs8C4NxsYMjEdcDjJaabDo7P0xfd Zzl/UgcHiMIgvEiYrYJOX9LdVyplaOE4sHSKD4nfallEMxdDX+XeMIYEAtFMDjCbVk5X+j+Vz41 X7BSz4YcnVUuenHs66nZRHYyIl3RH8oyAnoIeeHg2jK9gjV3PuxDzCQ5ADe6rgC8KSW/SI340vc AWWcgF7gyLrOQVjwJadnY1XIvwgrAkfOZMPD3HQ5mtlmbLawInYnA+Aq1p4tBv3NGyfahtAAu6N WampsCjGPsTGc0A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Improves readability and makes splitting power on function in following commit easier. Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 36 ++++++++++++++++++++++++----------= -- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index ff884e04ad4c8..71d9b747ccfc5 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -518,22 +518,11 @@ static struct attribute *stmfts_sysfs_attrs[] =3D { }; ATTRIBUTE_GROUPS(stmfts_sysfs); =20 -static int stmfts_power_on(struct stmfts_data *sdata) +static int stmfts_read_system_info(struct stmfts_data *sdata) { int err; u8 reg[8]; =20 - err =3D regulator_bulk_enable(ARRAY_SIZE(stmfts_supplies), - sdata->supplies); - if (err) - return err; - - /* - * The datasheet does not specify the power on time, but considering - * that the reset time is < 10ms, I sleep 20ms to be sure - */ - msleep(20); - err =3D i2c_smbus_read_i2c_block_data(sdata->client, STMFTS_READ_INFO, sizeof(reg), reg); if (err < 0) @@ -547,6 +536,29 @@ static int stmfts_power_on(struct stmfts_data *sdata) sdata->config_id =3D reg[4]; sdata->config_ver =3D reg[5]; =20 + return 0; +} + +static int stmfts_power_on(struct stmfts_data *sdata) +{ + int err; + + err =3D regulator_bulk_enable(ARRAY_SIZE(stmfts_supplies), + sdata->supplies); + if (err) + return err; + + /* + * The datasheet does not specify the power on time, but considering + * that the reset time is < 10ms, I sleep 20ms to be sure + */ + msleep(20); + + + err =3D stmfts_read_system_info(sdata); + if (err) + return err; + enable_irq(sdata->client->irq); =20 msleep(50); --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41FBE3A254E; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=kOTarVN8vjFvI0zZUwCHGVb+xL0Hu+2nnPH8aUb0FFzB481zGLvWlMePKHUDwb0JrAjVSzMl0trS6asW6FsH++c5nNbqV3Mdn7PUKOeHbSv1HmJTPNDmLecaP0q4au4tQK1EVMj03zIOJI0fe7R12k2jlzYSpdZqVxOHDTxEE1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=bqHJlgvFMDOO/lnNU/fWghkOHQbJPVEBKj2oKZvCSNA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lsK6qvBfuYJQrqumSgSIzA3LrvYjK3VDdABkzFQ4dnqS9mLi5b2aerQI+g0jfP10sm0XFMYQQ51OP8F088X30QzlsHMJa1X6msbbWTfBjO+QX0IZN1XjJ7LeL4x2P+WrdU/5Q6lYfVkeoayIgxD5/Nplwfoh9cE0qg3mcY+J1a4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ANjq9x/u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ANjq9x/u" Received: by smtp.kernel.org (Postfix) with ESMTPS id DDA38C2BCC6; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686550; bh=bqHJlgvFMDOO/lnNU/fWghkOHQbJPVEBKj2oKZvCSNA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ANjq9x/uvYB8wOkN1F5FOWVCAzVzYlW8w3sY4HH8Gxg3xXBY2br3EbI1cgMDhLRwZ t4oOXJFdrFN8uHtods2lCUE7X5+TJZizqdUUv1PJn4869YNjqCNoyaafC2c3Ej0ygh nm4LJeuzA9loKSltfg4BNfs6fMxWctY8dTOM6ij/xerOmzCY/gw2vugr+MWaOvg6lH ydrHyuTV90ekDGuwukxenYAgjXzPvWmFsl2qn2rqMAJlWkaavaghzetOEENVp2u6u9 Yy8hL2uxm+NDKuBeg6OfsAzq4qzaiLDE/2uemNlLgGGb2Ax9HsMzRVL+Zc/yS5S210 voGsDZ9JclZLg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D570A10FC45A; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:48 +0200 Subject: [PATCH v4 05/11] Input: stmfts - disable regulators when power on fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-5-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1834; i=david@ixit.cz; h=from:subject:message-id; bh=otDxlvvUy+vHqWnlpecsigv9uo2JKsE9RKwSL0jKxqM=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSqxbb22SJazyTsOITYMHjjDrzpzJN7VpNu 4ltZ1OQGniJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cmzrD/4tZ0pmiTNrRcm3Y2eAc1o7V/ba3zu0DiVu8JqUrJ1yR3ITurB98GgXril/pT5MbPi9Z/C 29ddmYiNjNewyip5qQD7oGYtlKx9peclhWk37mV1OsbrGScrmFPMbayNpwtXJY827ep2dfVZIlK 8I4GyUUgZyTP8IDJ2g7oeudDLZVXV8vSMX5s4+6qMHecpp3/U3Kj49/LL88Xc9CvNc1aPzY87lZ Xm3hwBHlvRj7sEhxUv4sTgQWT/8YohJkA+srZfOJlAxhK1SBVlKATd1X100W3cNHaoakVtxDivh l/uTAX1FW5BxVxdzXhgWvbrqvwpGeGZUmlti/gbjpmL+ysz3ANWaW8gUNEFVYHbMS6jOzzj3d9S KQQbLDAREvM/D7c6XoA29y7dCjNjoYyyMPubUi9RgBhSX3DRKGtMif5WyUhl2h+3kSC6hSEIkn5 Uqgk45GsgTtEdB2syjwbLPkaYGY/LXw9wsc5ONduLLTd2q3m52FThLf0LyxdK+7tNsz9qYKsLEc pZtK9QG+DfIJaFnY2GtewcKK+6TyZ+/ySIVMmxQo3O0vpafq1OYLi75OkEEJQ4lTlqOJ7jUqG2X bleIhh88KpQVs2DBplB5bMLJWyitMYGasnl7c0NY/mvy/mDIdiMQC/En//3ubLhHTxW2ppuEtm0 ePllMuTArMZK1xw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg We must power off regulators after failing at power on phase. Create stmfts_configure function, so we don't have to use goto. Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 37 ++++++++++++++++++++++++----------= --- 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 71d9b747ccfc5..290511dd69437 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -539,22 +539,10 @@ static int stmfts_read_system_info(struct stmfts_data= *sdata) return 0; } =20 -static int stmfts_power_on(struct stmfts_data *sdata) +static int stmfts_configure(struct stmfts_data *sdata) { int err; =20 - err =3D regulator_bulk_enable(ARRAY_SIZE(stmfts_supplies), - sdata->supplies); - if (err) - return err; - - /* - * The datasheet does not specify the power on time, but considering - * that the reset time is < 10ms, I sleep 20ms to be sure - */ - msleep(20); - - err =3D stmfts_read_system_info(sdata); if (err) return err; @@ -596,6 +584,29 @@ static int stmfts_power_on(struct stmfts_data *sdata) return 0; } =20 +static int stmfts_power_on(struct stmfts_data *sdata) +{ + int err; + + err =3D regulator_bulk_enable(ARRAY_SIZE(stmfts_supplies), + sdata->supplies); + if (err) + return err; + + /* + * The datasheet does not specify the power on time, but considering + * that the reset time is < 10ms, I sleep 20ms to be sure + */ + msleep(20); + + err =3D stmfts_configure(sdata); + if (err) + regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), + sdata->supplies); + + return err; +} + static void stmfts_power_off(void *data) { struct stmfts_data *sdata =3D data; --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4385C3A2577; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=CdXaTkAg/BfQsVCFvKMxEQKQjuHafci0jeJN3QqqGl83oSiufqBGEHPysVh/LcreS6vuz9cF75rQOuUIx83HKhFkNbknTc2gbsFBZ+4IdjTYGHHw+21nLa6q5yHYLxC07DIMvn7Lcz9cZa+wIloP6NYAHTqp5akhDOPybC2a0QA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=ZLkarQW8/Az8rauhmR2HAn+rZrJRg5Nvg4DuBB8fGyg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JG4cndDE9A4J0iidCqnf+WQZTw+/nmxvdINnUVW6FrK2ZZ6ctImEaRAqi7j2fj6LvJMD1KxVwm3XXbzgBVDiClaxGOw5XGYjF9ak9arqsA/Ea/IiMii+oCF5bzA3CGLPh0pEN09NBjOPPun7bAo1ES1k6iWodun6Fv6hwLEQCPc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R4RCEQfR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R4RCEQfR" Received: by smtp.kernel.org (Postfix) with ESMTPS id EEF17C2BCC7; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686551; bh=ZLkarQW8/Az8rauhmR2HAn+rZrJRg5Nvg4DuBB8fGyg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=R4RCEQfRBQG3Jocz4jTbcIGP9WAfz5heuJgd5C57LX/dV9t0iZy5YJYZ+BHNnLNjI vtOd7CmFnNBpRMtw6yaMZsRZZhqoFmO6I/UC9PKvwQGk93F3p5sHoBikw8puZ86dN8 SeB5c3LhesPxoN1XhJGPaeJke6UnMvO8c5HzKo6m3usZk6T2925Ox7+GALpn8JFp0j qqG2Z2MVBfS5wyv6V+gVdZ2bVvtjqms1uZGMqIDx5/1nH+VwUdC69UiXUKeUVwcoWk wk2fuITpB4+77KqAYxUhrgfN375O7Zw9uYkeoIUUX40gSj9vFdkRXtb1d2mLUEGNK/ bCOjZ4n0Zadzw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E567A10FC456; Wed, 8 Apr 2026 22:15:50 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:49 +0200 Subject: [PATCH v4 06/11] Input: stmfts - use client to make future code cleaner Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-6-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=999; i=david@ixit.cz; h=from:subject:message-id; bh=b/jklM1zbCQq0LgFU9O2NrDUidLzNIiCSesKs846UrE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSX/8wXIcBMj7wQU9sHsMyexCIa9bif82F+ jn4O1E6y7uJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cqcjEACw7KJL1B4IeGb5Y5BLhFGgrkasV9+ayx/oBWguyFHfkrIFB+xMFBltOu2p09IDBo1J4+p 4qTRCWcb6YWbnDCLB9ROTbkJHB6FqnyqD0qHhzhCj6oe6bBX8VtwihwshYUqCMOiqYTPTfyZdYA zSPIchO03UcluHlUbSNzns5DBC8wz7OuPjcumDzo4Ookxf5SkDVFbL1jOsWIQaf9EV8NDTp0kYv Qd8zrfrmVJyd7TGsfqwYgEreMlu829h7AQSzyXM01kObdBqce32QrmXVCZvDMjTIXxkjy1YbmAJ gkWpCMn40rVe07LKoU1qu/Eur0SmHWQhrUqYTQP0NeUH9PpeQTOn7QqiY6cA2gGkzLLnt2KjDr3 xlghMrox8RCtiMLMLcRJnJ26jJoDdxG+Omr8AE22F4bzHTUGQhZbBR/etFEzUAKKxXAxIu4By1X iReyQ06qNMqe2ZarSxS8YemKaFQa+TJ4kfHhjx/3k0v213zjyLkoRRBZxBy09lgIqJDCf9HsOpe fMArxmvZS0rqEKK82VhfTkuPnAPzTPV7FVjxCijX6gsJnS/DFfaqcIXXGWdnGAYnjby7VipMIz/ lPcTzlVlCUbfVXC6WuirJsGcmE5Q+6v5jMgd1eq3D/gIEjipqbxu6SHj47+2DJ5T7zDrBW6FHh0 a4CNzCUEFCnoVyQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina Make code cleaner, compiler will optimize it away anyway. Preparation for FTM5 support, where more steps are needed. Signed-off-by: Petr Hodina Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 290511dd69437..b61a19e954296 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -769,9 +769,10 @@ static int stmfts_runtime_suspend(struct device *dev) static int stmfts_runtime_resume(struct device *dev) { struct stmfts_data *sdata =3D dev_get_drvdata(dev); + struct i2c_client *client =3D sdata->client; int ret; =20 - ret =3D i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_OUT); + ret =3D i2c_smbus_write_byte(client, STMFTS_SLEEP_OUT); if (ret) dev_err(dev, "failed to resume device: %d\n", ret); =20 --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B81B3A383F; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=PYSTjFv3stmp97EkcdhVzq+J6SOss+iHscZpLYUqGvnzVNNhUI+72Br3+REYulzFc8udwYwQYqfGHDpnj0XrBOZo6t8M/kWy+FDJUJcH57/qVyduEyM+VVoo6Q8I1cwiqKvq0GQnHP0WDHid90aQZSGOxzHQyH4f8BPooD3qzwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=mWau+z9gzfl+tuHR+lGcgDHqPCc2l27GPvMVfJPudmg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WQQIcm9jyWmnLYMPF6OoGdHgoJYQ28bUkm32cFua866pe+YsOtA/UwX9GeYcOd9h6wlbzFCFhoPFhO3dQ0pdYFkF5tBS33fZS/mVPeXjs9xqTr1mB73JkY3nG8tfzHaaFOI6QThafMpA4X79sX0ag5feo0LNk2grJA5nzhwEIrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OvVPmU0s; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OvVPmU0s" Received: by smtp.kernel.org (Postfix) with ESMTPS id 09F50C19424; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686551; bh=mWau+z9gzfl+tuHR+lGcgDHqPCc2l27GPvMVfJPudmg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OvVPmU0sOx9UheEeMlhva0qkdxI4ZiTjaSG9XNByx3cr3yZnZLrqyCRbnsWH6EM1q Iv8iT7gfPpVFZVAsKRv3d6SoXRQAcvjQiLeD/867RNqUhf6L6QORbflBqA7WOZwyJN vCXjAlQvr53AfqjM4VV2x6Exh5DO+EjW9nuBra/kcM6DjGD2IE5+L+n6qTMR4gs5qj IKgwDQKTJETdOb4HsjEFLbmUIK8G0Lnag+fi8qMdnTFNQraE/1SQmOqb1TzBoDl+GV ZaikM9VNne7gjBsu+f6bbg0OIhrJmecEB/pkneJ5Eu2Dz5wK8/jrXFSq+/Nbyb04pf 2F4vtKJM7N9uw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0107810FC45C; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:50 +0200 Subject: [PATCH v4 07/11] dt-bindings: input: touchscreen: st,stmfts: Introduce reset GPIO Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-7-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=774; i=david@ixit.cz; h=from:subject:message-id; bh=B9kCQKy2FHl0reom6sgNtirncPHLOm+2NoyBOxtDRYc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSJUHdlj3O0LPhM1jaiJv/ALPX+SD6InEhO o/IffCvj2GJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg csyXD/9/mTo3zD8m6fYZQtO0bvVO2xJ+E9/paboBT2bTq30RkJAtPxJMH+l5LwJAAMOz+RlfBDs a9GEsQj0fEeU33q4F7tDgH2l1jX7wvOzes41WGBRRTThMvbrpq5/UfNcqGtoHrLG5pQQ85keYID YtbgeV1EyDkV6h6oGWHNduo2e7IOsX8PMjXcgkWGniJTjeuMM/t1VlBsb02WDj5vCnnBnzLJzWk Q2YO4Jr024nHqEQ8OeRXu4RZrrbGLyzHvMK+6Zaz06VndUFlKelFCb0H2nxBJr38simrrDsn+AZ TduQwSLEtpXvnGmLr35o112ZfG45NyHteCGGvmrVnEfWdOJZk+3J8DTnJaaYMWhAiU37NfflkhR Bdbwxt2jwx0twBZ15uVW9C8tDJM39mDXiEEWjXOB+31qJ5LJ9bRSI5dEaPalnfk+qJvAiojLPQa rQJkoysMbAyJqiYgJaOkFoHG6K3eFSkla9+K1DC+JQSkQnqGl20Xc9CgPFJbioU8lNfm2nFsmYO RTLoXFzxS9S83/AYR22zQI1GjnTsqslGGVzzSv0Ybe4MMOFIKkqZMcR6HpkFQv4TuGbE8jAt01/ HKdGaSAZrw8vEyoMRqcSW2wQyt9k2Lnyn+F+fvFGV6Rn+cHhfGmng6sbgVbXrUsyG7/oAOYLOd2 AatmeUfB27sCQyg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg FTS has associated reset GPIO, document it. Signed-off-by: David Heidelberg Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.= yaml b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml index 12256ae7df90d..64c4f24ea3dd0 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml @@ -40,6 +40,10 @@ properties: vdd-supply: description: Power supply =20 + reset-gpios: + description: Reset GPIO (active-low) + maxItems: 1 + required: - compatible - reg --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5070A3A3E70; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=CcuucfmTZDTciZe19wicu4QqxTKdOKXjjq1blywfRbyoogu5/fnwvAYATxuzRfZv3LCfu/vahSv6+bX0NrtlEI9MbQr+DdTELTHlWBra9opwIdMmgZ5xDJmrKrDguWsA5hnaEkD9NTtyNbV99eN1JJYcTlALCyzuwrlYFCtFGfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=7t/V64Z+l0jfwO+WO/MM+kjGDPqnSGczz1lucqZyGuI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hIUcJ2dj+B0ikdT05B285myB5fM32mkAnpGf8xtUNqqyANzZ4K5Y7ijHwjeC7a77x1vmoYEoHn0n7j7az2tgc4HOjdGThQ7bsOhQ0FueETRLNe0rnt+YeO95JZKm8tf3mlBIt1lQaJtzIljxmvROhGWtk3sDwGAz797jYPV+/N0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P8Jz0gk6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P8Jz0gk6" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1D3FEC2BCB6; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686551; bh=7t/V64Z+l0jfwO+WO/MM+kjGDPqnSGczz1lucqZyGuI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=P8Jz0gk6Jg1XTEapnqS4d9L5ywthTdgsegiux9/6LdwiNl90NpgzJ/M673P1Ozp12 ve8qpgFp6dDrlBbkrSIFKjj9q8wGM+Ms3U5uT0TTbGKPO/PGRDDRk1lBimaW6jEPoQ Jvh+vygbWp6elAEvJh+GgWZbbwIm+jL3r+JNkU1tNaZ0PKooPxCR6LpVwFC+f80s9i TDUsn3E9uqQtivIQ1NOBEV9tq9lusT8DjIqoe96IPagKWMWXKT0+fk+c6lfE1W0u3Q rogeQhh0p8kjFTuSSjfZ5gvE7pVjzmVIE3NWIEaG9OxUwGUEnmwOaPqHt/ueA/+Wfl mwax4lui6BRew== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 100AF10FC453; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:51 +0200 Subject: [PATCH v4 08/11] Input: stmfts - add optional reset GPIO support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-8-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2312; i=david@ixit.cz; h=from:subject:message-id; bh=Oxezv3LVWvcy2a3O5okAfGZrVzhTs38AJC0Tf+JxgKo=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOS1d0dXj0iC1bnB2PUOAopZm69S/9Tys0l2 OabmP/9zpiJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cq4tD/9UxMKbKC9JdKOG/RwoIBh3Vxa1qrGkKMKNGVETPPjVe0qRqV9CZrtO5PUA2/wMgWabwqv 9gCKoiUUNMtQeU1OQ2KMrE1dC5970Sqc6Bos4Z5fYXgWRRYAgsmb+TjUy1eVi7yaH5PWLPdSp3p cFRkmNnw9HcN8WF7hO2Gdnja0JZW7suYSRkmI2U+OYXzg2zPF7jcZ4oLmsWligdKOD96CM4hTlg HrD58ZCyJGR3ldncKB80ez/jAGud3LhSzsdehGDeSVqIHljSdcMI8smlpeRn4l34wCEzlgJlsRQ s37y00Hoi8gTYrAUHQt+q45pWUIe6NsMrWphr/dBt+snDeizP0Y91uXeeNJmDnp0F29rz13FQQG 1o6RO3JW7kvveZrrZhjB54fFWtIMHlLdXnEqQxLxBB738pvbNOEww38g3ra5pfXXtCxgvowIL0a DQZPXsv4MG6PicmdS9r0RLeH0WHHqrwFYsVrehRO4Nd5mMJ7LnEtVSpTof8mvvpmPMm1UVc7Yhf KsY9xWEsG5eohoFg9XpUQJfFoj0NNNe8fiokWDt6jYswtnaA1D6ZyvmE2jtoOiGFh2zhsiQ4g+7 KTcwakKTqhp8k9dKjzpQ4BeoU7FbrVcQBcZzveCKEHVh3YDjbzkvkAJj4x8qyK1v42Y6QxIPvrG jcUSG7Pr1w3fsxA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina Add support for an optional "reset-gpios" property. If present, the driver drives the reset line high at probe time and releases it during power-on, after the regulators have been enabled. Signed-off-by: Petr Hodina Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index b61a19e954296..1e6d9a287cd0c 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -77,6 +77,7 @@ static const struct regulator_bulk_data stmfts_supplies[]= =3D { struct stmfts_data { struct i2c_client *client; struct input_dev *input; + struct gpio_desc *reset_gpio; struct led_classdev led_cdev; struct mutex mutex; =20 @@ -539,6 +540,15 @@ static int stmfts_read_system_info(struct stmfts_data = *sdata) return 0; } =20 +static void stmfts_reset(struct stmfts_data *sdata) +{ + gpiod_set_value_cansleep(sdata->reset_gpio, 1); + msleep(20); + + gpiod_set_value_cansleep(sdata->reset_gpio, 0); + msleep(50); +} + static int stmfts_configure(struct stmfts_data *sdata) { int err; @@ -599,6 +609,9 @@ static int stmfts_power_on(struct stmfts_data *sdata) */ msleep(20); =20 + if (sdata->reset_gpio) + stmfts_reset(sdata); + err =3D stmfts_configure(sdata); if (err) regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), @@ -612,6 +625,10 @@ static void stmfts_power_off(void *data) struct stmfts_data *sdata =3D data; =20 disable_irq(sdata->client->irq); + + if (sdata->reset_gpio) + gpiod_set_value_cansleep(sdata->reset_gpio, 1); + regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), sdata->supplies); } @@ -668,6 +685,12 @@ static int stmfts_probe(struct i2c_client *client) if (err) return err; =20 + sdata->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", + GPIOD_OUT_HIGH); + if (IS_ERR(sdata->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(sdata->reset_gpio), + "Failed to get GPIO 'reset'\n"); + sdata->input =3D devm_input_allocate_device(dev); if (!sdata->input) return -ENOMEM; --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 587963A3E81; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=pZw3QEGrHYzIHq+fptBbLVQBPhBvN1vWkeMNfNEsB6P0+LYJGnjJEnv6C/seJfgjzhIC2tg4X3EH17ExOrWkwujVmP7pNK/RPtZX4ix9js5kJqbg1rWfN8LR1bN/CI8nK/K8xujkaWB694+wV7kv9Rpcyvxz2mUti67kVmd6irE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=htLSa/pFYIGLX2V/bgi6ZPOMIyGWL50VFCX7LC8EdCc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TF+5wiplOHLXA6mDOdJ8RjX4uEWgBGlwKoWoxBmU+Q33YOMP9P5jp/z6g3a5d6g/xdtN7uaZL2CNj9BFjqEv+p4L9Qg46aLkilb3isxJlmR15W9Nm0+R5aUhVNnGpSFSsfGjB4nUNbybmOFuxyfxNNSE/Xr55eVQMz+T5Utvk6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AsoKgq3l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AsoKgq3l" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2B7DCC2BCB0; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686551; bh=htLSa/pFYIGLX2V/bgi6ZPOMIyGWL50VFCX7LC8EdCc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=AsoKgq3l4qG2R9BpXaj8Ed0eyWn5uFLGOWCXpzxxJqEcRmBgPazn3Tdyr0qgYxdzu 1abMDWTUowTlv2E+nnQIeX6xOQIA/H3AtAjk5veNqWW4sy6SrlYKX7x9WxzljhaLuu SGAN3Gplt1KC6NKmwxEqaAeQmSZYS30y95QN5xOWXY0SYQbntN7zay2XM5/GvaKaFz +fPzh8O2uLMNwIx+yxydg0ykNDloMrzRlW8zjAeafZOhhcHpzqvpi+qhSpZAnQ5I9i hlzEGXaflEwhVz7jGh6pQAkHi49fEg4l4ZRd7IT6I1ROjRrKJlkdJ758Ea+RbbpDRX 5ZD5Xc2qX5N+Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D2410FC45A; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:52 +0200 Subject: [PATCH v4 09/11] dt-bindings: input: touchscreen: st,stmfts: Introduce STM FTS5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-9-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1224; i=david@ixit.cz; h=from:subject:message-id; bh=ghceD3FEXE+XcrRARnEBBTznzq4UXU11eu6mo0R07f4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSgCz7jjy058wzeL7LEkYevCLbVWdEmzY1J Rkf7VMNi46JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cpX5D/oCsqGXfeV1fdW/6kPezRfYNu5hhWyw2cIJv2dQySwVh3VIq/lGZPocjSySj/ZqaaOV+c+ QJTF4ztbrpockeRkdSjn1jAiitpI6pRMmmZrgFooZXmWRW4nbnKeU/KduTJESeV+/87YHWAAhZW J/3BBXIoNOz8UJWO74AtUzniMZLLg3d6UEyuHq6SoWAHvk+mcD0L0To0/V2/CjY4Focrw0b7MdW kVezi/67hyObLSWoAb17K0Y5YHlKSac3hN8qZfdVxJrIelIDV7yVmI2zfBIvfyTOxFv3eQW2q6A ujJ0o3qvv/2w+Q6STHp/UEn2+bUHxn/rrCQt79Ey9NvIDTp+gwzYxBpglNAYo9NJjgd/ioxTSd6 ukaEOGEq97o5BV8DbYRLH5ZH2PHpWm/dfKjEiFdjCzGV5XnhY58+6yx8YxyGebQpJMadkGByr5Q oZvXvM0JEQcdmW0rcNpyvZBiYARyDo3wuwevv1EF+1NBF3vgiWnrm/2BRYVSh3H4lzOiPOO2tdd ZKbIc3XhChBKg90OO2g35xjLR7p8+Yl9ykvdAvH30xxEWZmqx28jXrW33XHYEsoe2EE9H3u6XHq Vrcp+m10PE00u0oVk8dwKd+hIzWNRuhU79eKzTcapUzO5fUBIddcmrG1TU870LA6t7Kzxevfvdl A3sh9vK8HMeppZw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg Introduce more recent STM FTS5 touchscreen support. Signed-off-by: David Heidelberg --- .../devicetree/bindings/input/touchscreen/st,stmfts.yaml | 15 +++++++++++= +++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.= yaml b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml index 64c4f24ea3dd0..441fc92b9a4ed 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml @@ -16,10 +16,19 @@ description: =20 allOf: - $ref: touchscreen.yaml# + - if: + properties: + compatible: + const: st,stmfts5 + then: + required: + - mode-switch-gpios =20 properties: compatible: - const: st,stmfts + enum: + - st,stmfts + - st,stmfts5 =20 reg: maxItems: 1 @@ -40,6 +49,10 @@ properties: vdd-supply: description: Power supply =20 + mode-switch-gpios: + description: Switch between touchscreen SLPI and AP mode. + maxItems: 1 + reset-gpios: description: Reset GPIO (active-low) maxItems: 1 --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A833A4502; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=IhPvjxKu7sgPu0V5EW4QOi/KlUo2XqfiMBK/cqH/oqLcyhZ3+uCvj4GPxfEllUVwTNL4TyM9njp5qHOkcH0y1lkT3ptFTJ/8NGwqEhE1L1vcaHj9rn9kcMl2XRKtcaeTO1wEfOdUoJMO5+wb+iypZpimLg30VTY6B01krCWyr28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=tIGlpaZemR7d9jsS6ALEP2ty9nV53WoTZhmA6w5EOzQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=usmz9RS5aFs0k6IE5SOi+mFtrkr60tE2dnVly1UGeC5bolNTr/6x4WL/d7QdU2GUEcp8FwyUiDTXgVlPgfayeji3haMZTYd9VT9nX80jGXG8mqMfU0IOErpRdarLr7Yw4J0Kq6t+0/kdQNb22rLPzs3ZYLsMPSLQECjjpXtyq38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qnKl805a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qnKl805a" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3D9D3C4AF17; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686551; bh=tIGlpaZemR7d9jsS6ALEP2ty9nV53WoTZhmA6w5EOzQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qnKl805arHr4X5girAsiPFn7ExGc8CeYFX5TK1GoWVe28nSxtJHjiPCjYcNHgSkSK SetpRadQqhzdpj5Jn4Y70uIqspqzs0LVdY7fwTnCXWtz9Pobl5motCkIBWxuFJItuN Xj4g0zfjazqOLBJxQZ+86X5RSbZhIV2j80BSZabvv1uU5wzN9RnlJHDwUm9Ycmq0kn y9LjMgvJBZvebtjeWsbjLgoxaOEEIIwQsy6yq31TzatrG2Ms/4hB11cBPpAW7/OF5O yuA3rSBkgVIeq2UbFlIGvoVSlZ/2Pirzv8kvZmlYkqbXMoikhXUHrsIzmiUzEdSG8T 1CpdBsslo7ZUQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349B810FC456; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:53 +0200 Subject: [PATCH v4 10/11] Input: stmfts - support FTS5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-10-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=21867; i=david@ixit.cz; h=from:subject:message-id; bh=4yzi3sZ1WrcyDdT4cObbylaxzviewGT13ZUpejt5KwA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSSQM9ZDers0D6ZkQAIQXvNfJedWUP7/rgB k887jbKQuaJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg cqK7D/9YjFVLv7Ejxnlo7Rhy39Q/dFeezgFbdzdYChffYIkOPb5ap+7e9ttYoxZ51BadkGzUzvR S273+WKq6AF4DVtFuWF7RglKoDMyVdLeKbXYU3Rkt45RySeoFDyRR7OJaeGOIcqRuWNyFMwrd6p Z0pDO3oNQYwNrBqDcKpqeHmYlth1nI8zWzqERDk1ypVdmDvjbyGmHV9kSlA/grCabaBoBhSXMH7 5yTMxBvKQa096SAxJxVvP9SGVfRShniO5SOsKN3svyGsWy8bORgsnO9biOHXD2PbDOPrlrRLAiT l2zQ/nNxEqYbdOkwi4E15zFFuWm9kG7zoolqeDP5T0ZwAdFFZJvrGUr+YYrFKb8Fs7bN4LcC6w/ zoVO5HUVk4/ujKj/RSkBwlCxOc4yAQDL+4x7qgcILdEgXtidiOyVPYoDtKIOYnufsmRnmSqBjab UP354RDvwFRx37y7KKid/9UmpT1L/2scsL+k8vuL4rbWuiqh2kVQyOyq2szCDD1gzxXBR1gNo5C 1PrbsYsvmDo3lXzp66wrVEbSC4OYvjUGnmTPjOmg87RZUdL/vv+vwO4Me7Ss5Js/BKCAogJr0yY FrIfNnRmxY6NVkYnTtDnS8v/aFuPxjidMO/EBPqi3F2bQuZebbIrsMbiAwIjqMsJ14QgnV22a7t OX4jtW5W2wM04bA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina FTS support SLPI and AP mode, introduce mode-switch GPIO to switch between those two. Currently we can handle only full power AP mode, so we just keep the AP on. Useful for devices like Pixel 3 (blueline) and many others. Signed-off-by: Petr Hodina Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 494 +++++++++++++++++++++++++++++++++= +--- 1 file changed, 466 insertions(+), 28 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 1e6d9a287cd0c..e613299e37557 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -1,8 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 -// STMicroelectronics FTS Touchscreen device driver -// -// Copyright (c) 2017 Samsung Electronics Co., Ltd. -// Copyright (c) 2017 Andi Shyti +/* STMicroelectronics FTS Touchscreen device driver + * + * Copyright 2017 Samsung Electronics Co., Ltd. + * Copyright 2017 Andi Shyti + * Copyright David Heidelberg + * Copyright Petr Hodina + */ =20 #include #include @@ -12,6 +15,7 @@ #include #include #include +#include #include #include =20 @@ -34,6 +38,7 @@ #define STMFTS_FULL_FORCE_CALIBRATION 0xa2 #define STMFTS_MS_CX_TUNING 0xa3 #define STMFTS_SS_CX_TUNING 0xa4 +#define STMFTS5_SET_SCAN_MODE 0xa0 =20 /* events */ #define STMFTS_EV_NO_EVENT 0x00 @@ -51,12 +56,32 @@ #define STMFTS_EV_STATUS 0x16 #define STMFTS_EV_DEBUG 0xdb =20 +/* events FTS5 */ +#define STMFTS5_EV_CONTROLLER_READY 0x03 +/* FTM5 event IDs (full byte, not masked) */ +#define STMFTS5_EV_MULTI_TOUCH_ENTER 0x13 +#define STMFTS5_EV_MULTI_TOUCH_MOTION 0x23 +#define STMFTS5_EV_MULTI_TOUCH_LEAVE 0x33 +#define STMFTS5_EV_STATUS_UPDATE 0x43 +#define STMFTS5_EV_USER_REPORT 0x53 +#define STMFTS5_EV_DEBUG 0xe3 +#define STMFTS5_EV_ERROR 0xf3 + /* multi touch related event masks */ #define STMFTS_MASK_EVENT_ID 0x0f #define STMFTS_MASK_TOUCH_ID 0xf0 #define STMFTS_MASK_LEFT_EVENT 0x0f #define STMFTS_MASK_X_MSB 0x0f #define STMFTS_MASK_Y_LSB 0xf0 +#define STMFTS5_MASK_TOUCH_TYPE 0x0f + +/* touch type classifications */ +#define STMFTS_TOUCH_TYPE_INVALID 0x00 +#define STMFTS_TOUCH_TYPE_FINGER 0x01 +#define STMFTS_TOUCH_TYPE_GLOVE 0x02 +#define STMFTS_TOUCH_TYPE_STYLUS 0x03 +#define STMFTS_TOUCH_TYPE_PALM 0x04 +#define STMFTS_TOUCH_TYPE_HOVER 0x05 =20 /* key related event masks */ #define STMFTS_MASK_KEY_NO_TOUCH 0x00 @@ -75,9 +100,12 @@ static const struct regulator_bulk_data stmfts_supplies= [] =3D { }; =20 struct stmfts_data { + const struct stmfts_chip_ops *ops; + struct i2c_client *client; struct input_dev *input; struct gpio_desc *reset_gpio; + struct gpio_desc *mode_switch_gpio; struct led_classdev led_cdev; struct mutex mutex; =20 @@ -101,12 +129,27 @@ struct stmfts_data { =20 struct completion cmd_done; =20 + unsigned long touch_id; + unsigned long stylus_id; + bool use_key; bool led_status; bool hover_enabled; + bool stylus_enabled; bool running; }; =20 +struct stmfts_chip_ops { + int (*configure)(struct stmfts_data *sdata); + void (*power_off)(struct stmfts_data *sdata); + int (*setup_input)(struct stmfts_data *sdata); + int (*input_open)(struct input_dev *dev); + void (*input_close)(struct input_dev *dev); + void (*parse_events)(struct stmfts_data *sdata); + int (*set_hover)(struct stmfts_data *sdata, bool enable); + int (*runtime_resume)(struct stmfts_data *sdata); +}; + static int stmfts_brightness_set(struct led_classdev *led_cdev, enum led_brightness value) { @@ -169,6 +212,7 @@ static int stmfts_read_events(struct stmfts_data *sdata) return ret =3D=3D ARRAY_SIZE(msgs) ? 0 : -EIO; } =20 +/* FTS4 event handling functions */ static void stmfts_report_contact_event(struct stmfts_data *sdata, const u8 event[]) { @@ -204,6 +248,157 @@ static void stmfts_report_contact_release(struct stmf= ts_data *sdata, input_sync(sdata->input); } =20 +/* FTS5 event handling functions */ +static void stmfts5_report_contact_event(struct stmfts_data *sdata, + const u8 event[]) +{ + u8 area; + u8 maj; + u8 min; + /* FTM5 event format: + * event[0] =3D event ID (0x13/0x23) + * event[1] =3D touch type (low 4 bits) | touch ID (high 4 bits) + * event[2] =3D X LSB + * event[3] =3D X MSB (low 4 bits) | Y MSB (high 4 bits) + * event[4] =3D Y LSB + * event[5] =3D pressure + * event[6] =3D major (low 4 bits) | minor (high 4 bits) + * event[7] =3D minor (high 2 bits) + */ + u8 touch_id =3D (event[1] & STMFTS_MASK_TOUCH_ID) >> 4; + u8 touch_type =3D event[1] & STMFTS5_MASK_TOUCH_TYPE; + int x, y, distance; + unsigned int tool =3D MT_TOOL_FINGER; + bool touch_condition =3D true; + + /* Parse coordinates with better precision */ + x =3D (((int)event[3] & STMFTS_MASK_X_MSB) << 8) | event[2]; + y =3D ((int)event[4] << 4) | ((event[3] & STMFTS_MASK_Y_LSB) >> 4); + + /* Parse pressure - ensure non-zero for active touch */ + area =3D event[5]; + if (area <=3D 0 && touch_type !=3D STMFTS_TOUCH_TYPE_HOVER) { + /* Should not happen for contact events. Set minimum pressure + * to prevent touch from being dropped + */ + dev_warn_once(&sdata->client->dev, + "zero pressure on contact event, slot %d\n", touch_id); + area =3D 1; + } + + /* Parse touch area with improved bit extraction */ + maj =3D (((event[0] & 0x0C) << 2) | ((event[6] & 0xF0) >> 4)); + min =3D (((event[7] & 0xC0) >> 2) | (event[6] & 0x0F)); + + /* Distance is 0 for touching, max for hovering */ + distance =3D 0; + + /* Classify touch type and set appropriate tool and parameters */ + switch (touch_type) { + case STMFTS_TOUCH_TYPE_STYLUS: + if (sdata->stylus_enabled) { + tool =3D MT_TOOL_PEN; + __set_bit(touch_id, &sdata->stylus_id); + __clear_bit(touch_id, &sdata->touch_id); + break; + } + fallthrough; /* Report as finger if stylus not enabled */ + + case STMFTS_TOUCH_TYPE_FINGER: + case STMFTS_TOUCH_TYPE_GLOVE: + tool =3D MT_TOOL_FINGER; + __set_bit(touch_id, &sdata->touch_id); + __clear_bit(touch_id, &sdata->stylus_id); + break; + + case STMFTS_TOUCH_TYPE_PALM: + /* Palm touch - report but can be filtered by userspace */ + tool =3D MT_TOOL_PALM; + __set_bit(touch_id, &sdata->touch_id); + __clear_bit(touch_id, &sdata->stylus_id); + break; + + case STMFTS_TOUCH_TYPE_HOVER: + tool =3D MT_TOOL_FINGER; + touch_condition =3D false; + area =3D 0; + distance =3D 255; + __set_bit(touch_id, &sdata->touch_id); + __clear_bit(touch_id, &sdata->stylus_id); + break; + + case STMFTS_TOUCH_TYPE_INVALID: + default: + dev_warn(&sdata->client->dev, + "invalid touch type %d for slot %d\n", + touch_type, touch_id); + return; + } + + /* Boundary check - some devices report max value, adjust */ + if (x >=3D sdata->prop.max_x) + x =3D sdata->prop.max_x - 1; + if (y >=3D sdata->prop.max_y) + y =3D sdata->prop.max_y - 1; + + input_mt_slot(sdata->input, touch_id); + input_report_key(sdata->input, BTN_TOUCH, touch_condition); + input_mt_report_slot_state(sdata->input, tool, true); + + input_report_abs(sdata->input, ABS_MT_POSITION_X, x); + input_report_abs(sdata->input, ABS_MT_POSITION_Y, y); + input_report_abs(sdata->input, ABS_MT_TOUCH_MAJOR, maj); + input_report_abs(sdata->input, ABS_MT_TOUCH_MINOR, min); + input_report_abs(sdata->input, ABS_MT_PRESSURE, area); + input_report_abs(sdata->input, ABS_MT_DISTANCE, distance); + + input_sync(sdata->input); +} + +static void stmfts5_report_contact_release(struct stmfts_data *sdata, + const u8 event[]) +{ + /* FTM5 format: touch ID is in high 4 bits of event[1] */ + u8 touch_id =3D (event[1] & STMFTS_MASK_TOUCH_ID) >> 4; + u8 touch_type =3D event[1] & STMFTS5_MASK_TOUCH_TYPE; + unsigned int tool =3D MT_TOOL_FINGER; + + /* Determine tool type based on touch classification */ + switch (touch_type) { + case STMFTS_TOUCH_TYPE_STYLUS: + if (sdata->stylus_enabled) { + tool =3D MT_TOOL_PEN; + __clear_bit(touch_id, &sdata->stylus_id); + } else { + __clear_bit(touch_id, &sdata->touch_id); + } + break; + + case STMFTS_TOUCH_TYPE_PALM: + tool =3D MT_TOOL_PALM; + __clear_bit(touch_id, &sdata->touch_id); + break; + + case STMFTS_TOUCH_TYPE_FINGER: + case STMFTS_TOUCH_TYPE_GLOVE: + case STMFTS_TOUCH_TYPE_HOVER: + default: + tool =3D MT_TOOL_FINGER; + __clear_bit(touch_id, &sdata->touch_id); + break; + } + + input_mt_slot(sdata->input, touch_id); + input_report_abs(sdata->input, ABS_MT_PRESSURE, 0); + input_mt_report_slot_state(sdata->input, tool, false); + + /* Report BTN_TOUCH only if no touches remain */ + if (!sdata->touch_id && !sdata->stylus_id) + input_report_key(sdata->input, BTN_TOUCH, 0); + + input_sync(sdata->input); +} + static void stmfts_report_hover_event(struct stmfts_data *sdata, const u8 event[]) { @@ -251,7 +446,6 @@ static void stmfts_parse_events(struct stmfts_data *sda= ta) u8 *event =3D &sdata->data[i * STMFTS_EVENT_SIZE]; =20 switch (event[0]) { - case STMFTS_EV_CONTROLLER_READY: case STMFTS_EV_SLEEP_OUT_CONTROLLER_READY: case STMFTS_EV_STATUS: @@ -264,7 +458,6 @@ static void stmfts_parse_events(struct stmfts_data *sda= ta) } =20 switch (event[0] & STMFTS_MASK_EVENT_ID) { - case STMFTS_EV_MULTI_TOUCH_ENTER: case STMFTS_EV_MULTI_TOUCH_MOTION: stmfts_report_contact_event(sdata, event); @@ -298,6 +491,45 @@ static void stmfts_parse_events(struct stmfts_data *sd= ata) } } =20 +static void stmfts5_parse_events(struct stmfts_data *sdata) +{ + for (int i =3D 0; i < STMFTS_STACK_DEPTH; i++) { + u8 *event =3D &sdata->data[i * STMFTS_EVENT_SIZE]; + + switch (event[0]) { + case STMFTS5_EV_CONTROLLER_READY: + complete(&sdata->cmd_done); + fallthrough; + + case STMFTS_EV_NO_EVENT: + case STMFTS5_EV_STATUS_UPDATE: + case STMFTS5_EV_USER_REPORT: + case STMFTS5_EV_DEBUG: + return; + + case STMFTS5_EV_MULTI_TOUCH_ENTER: + case STMFTS5_EV_MULTI_TOUCH_MOTION: + stmfts5_report_contact_event(sdata, event); + break; + + case STMFTS5_EV_MULTI_TOUCH_LEAVE: + stmfts5_report_contact_release(sdata, event); + break; + + case STMFTS5_EV_ERROR: + dev_warn(&sdata->client->dev, + "error code: 0x%x%x%x%x%x%x", + event[6], event[5], event[4], + event[3], event[2], event[1]); + break; + + default: + dev_err(&sdata->client->dev, + "unknown FTS5 event %#02x\n", event[0]); + } + } +} + static irqreturn_t stmfts_irq_handler(int irq, void *dev) { struct stmfts_data *sdata =3D dev; @@ -310,7 +542,7 @@ static irqreturn_t stmfts_irq_handler(int irq, void *de= v) dev_err(&sdata->client->dev, "failed to read events: %d\n", err); else - stmfts_parse_events(sdata); + sdata->ops->parse_events(sdata); =20 return IRQ_HANDLED; } @@ -332,6 +564,25 @@ static int stmfts_command(struct stmfts_data *sdata, c= onst u8 cmd) return 0; } =20 +static int stmfts5_set_scan_mode(struct stmfts_data *sdata, const u8 val) +{ + int err; + + u8 scan_mode_cmd[3] =3D { STMFTS5_SET_SCAN_MODE, 0x00, val }; + struct i2c_msg msg =3D { + .addr =3D sdata->client->addr, + .len =3D sizeof(scan_mode_cmd), + .buf =3D scan_mode_cmd, + }; + + err =3D i2c_transfer(sdata->client->adapter, &msg, 1); + if (err !=3D 1) + return err < 0 ? err : -EIO; + + return 0; + +} + static int stmfts_input_open(struct input_dev *dev) { struct stmfts_data *sdata =3D input_get_drvdata(dev); @@ -371,6 +622,28 @@ static int stmfts_input_open(struct input_dev *dev) return 0; } =20 +static int stmfts5_input_open(struct input_dev *dev) +{ + struct stmfts_data *sdata =3D input_get_drvdata(dev); + int err; + + err =3D pm_runtime_resume_and_get(&sdata->client->dev); + if (err) + return err; + + mutex_lock(&sdata->mutex); + sdata->running =3D true; + mutex_unlock(&sdata->mutex); + + err =3D stmfts5_set_scan_mode(sdata, 0xff); + if (err) { + pm_runtime_put_sync(&sdata->client->dev); + return err; + } + + return 0; +} + static void stmfts_input_close(struct input_dev *dev) { struct stmfts_data *sdata =3D input_get_drvdata(dev); @@ -404,6 +677,23 @@ static void stmfts_input_close(struct input_dev *dev) pm_runtime_put_sync(&sdata->client->dev); } =20 +static void stmfts5_input_close(struct input_dev *dev) +{ + struct stmfts_data *sdata =3D input_get_drvdata(dev); + int err; + + err =3D stmfts5_set_scan_mode(sdata, 0x00); + if (err) + dev_warn(&sdata->client->dev, + "failed to disable touchscreen: %d\n", err); + + mutex_lock(&sdata->mutex); + sdata->running =3D false; + mutex_unlock(&sdata->mutex); + + pm_runtime_put_sync(&sdata->client->dev); +} + static ssize_t stmfts_sysfs_chip_id(struct device *dev, struct device_attribute *attr, char *buf) { @@ -484,10 +774,8 @@ static ssize_t stmfts_sysfs_hover_enable_write(struct = device *dev, guard(mutex)(&sdata->mutex); =20 if (hover !=3D sdata->hover_enabled) { - if (sdata->running) { - err =3D i2c_smbus_write_byte(sdata->client, - value ? STMFTS_SS_HOVER_SENSE_ON : - STMFTS_SS_HOVER_SENSE_OFF); + if (sdata->running && sdata->ops->set_hover) { + err =3D sdata->ops->set_hover(sdata, hover); if (err) return err; } @@ -612,7 +900,7 @@ static int stmfts_power_on(struct stmfts_data *sdata) if (sdata->reset_gpio) stmfts_reset(sdata); =20 - err =3D stmfts_configure(sdata); + err =3D sdata->ops->configure(sdata); if (err) regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), sdata->supplies); @@ -620,6 +908,29 @@ static int stmfts_power_on(struct stmfts_data *sdata) return err; } =20 +static int stmfts5_configure(struct stmfts_data *sdata) +{ + u8 event[STMFTS_EVENT_SIZE]; + int ret; + + /* Verify I2C communication */ + ret =3D i2c_smbus_read_i2c_block_data(sdata->client, + STMFTS_READ_ALL_EVENT, + sizeof(event), event); + if (ret < 0) + return ret; + + enable_irq(sdata->client->irq); + + return 0; +} + +static void stmfts5_chip_power_off(struct stmfts_data *sdata) +{ + i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_IN); + msleep(20); +} + static void stmfts_power_off(void *data) { struct stmfts_data *sdata =3D data; @@ -629,10 +940,73 @@ static void stmfts_power_off(void *data) if (sdata->reset_gpio) gpiod_set_value_cansleep(sdata->reset_gpio, 1); =20 + if (sdata->ops->power_off) + sdata->ops->power_off(sdata); + regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies), sdata->supplies); } =20 +static int stmfts_setup_input(struct stmfts_data *sdata) +{ + struct device *dev =3D &sdata->client->dev; + + input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0); + input_set_abs_params(sdata->input, ABS_DISTANCE, 0, 255, 0, 0); + + sdata->use_key =3D device_property_read_bool(dev, "touch-key-connected"); + if (sdata->use_key) { + input_set_capability(sdata->input, EV_KEY, KEY_MENU); + input_set_capability(sdata->input, EV_KEY, KEY_BACK); + } + + return input_mt_init_slots(sdata->input, STMFTS_MAX_FINGERS, + INPUT_MT_DIRECT); +} + +static int stmfts5_setup_input(struct stmfts_data *sdata) +{ + struct device *dev =3D &sdata->client->dev; + + sdata->mode_switch_gpio =3D devm_gpiod_get_optional(dev, "mode-switch", + GPIOD_OUT_HIGH); + if (IS_ERR(sdata->mode_switch_gpio)) + return dev_err_probe(dev, PTR_ERR(sdata->mode_switch_gpio), + "Failed to get GPIO 'switch'\n"); + + /* Mark as direct input device for calibration support */ + __set_bit(INPUT_PROP_DIRECT, sdata->input->propbit); + + /* Set up basic touch capabilities */ + input_set_capability(sdata->input, EV_KEY, BTN_TOUCH); + + /* Set resolution for accurate calibration */ + if (!input_abs_get_res(sdata->input, ABS_MT_POSITION_X)) { + input_abs_set_res(sdata->input, ABS_MT_POSITION_X, 10); + input_abs_set_res(sdata->input, ABS_MT_POSITION_Y, 10); + } + + input_set_abs_params(sdata->input, ABS_MT_DISTANCE, 0, 255, 0, 0); + + /* Enable stylus support if requested */ + sdata->stylus_enabled =3D device_property_read_bool(dev, "stylus-enabled"= ); + + /* Initialize touch tracking bitmaps */ + sdata->touch_id =3D 0; + sdata->stylus_id =3D 0; + + /* Initialize MT slots with support for pen tool type */ + return input_mt_init_slots(sdata->input, STMFTS_MAX_FINGERS, + INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); +} + +static int stmfts_set_hover(struct stmfts_data *sdata, bool enable) +{ + return i2c_smbus_write_byte(sdata->client, + enable ? STMFTS_SS_HOVER_SENSE_ON : + STMFTS_SS_HOVER_SENSE_OFF); +} + static int stmfts_enable_led(struct stmfts_data *sdata) { int err; @@ -678,6 +1052,8 @@ static int stmfts_probe(struct i2c_client *client) mutex_init(&sdata->mutex); init_completion(&sdata->cmd_done); =20 + sdata->ops =3D of_device_get_match_data(dev); + err =3D devm_regulator_bulk_get_const(dev, ARRAY_SIZE(stmfts_supplies), stmfts_supplies, @@ -697,8 +1073,8 @@ static int stmfts_probe(struct i2c_client *client) =20 sdata->input->name =3D STMFTS_DEV_NAME; sdata->input->id.bustype =3D BUS_I2C; - sdata->input->open =3D stmfts_input_open; - sdata->input->close =3D stmfts_input_close; + sdata->input->open =3D sdata->ops->input_open; + sdata->input->close =3D sdata->ops->input_close; =20 input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_X); input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_Y); @@ -706,19 +1082,9 @@ static int stmfts_probe(struct i2c_client *client) =20 input_set_abs_params(sdata->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0); input_set_abs_params(sdata->input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0); - input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0); input_set_abs_params(sdata->input, ABS_MT_PRESSURE, 0, 255, 0, 0); - input_set_abs_params(sdata->input, ABS_DISTANCE, 0, 255, 0, 0); - - sdata->use_key =3D device_property_read_bool(dev, - "touch-key-connected"); - if (sdata->use_key) { - input_set_capability(sdata->input, EV_KEY, KEY_MENU); - input_set_capability(sdata->input, EV_KEY, KEY_BACK); - } =20 - err =3D input_mt_init_slots(sdata->input, - STMFTS_MAX_FINGERS, INPUT_MT_DIRECT); + err =3D sdata->ops->setup_input(sdata); if (err) return err; =20 @@ -789,13 +1155,62 @@ static int stmfts_runtime_suspend(struct device *dev) return ret; } =20 -static int stmfts_runtime_resume(struct device *dev) +static int stmfts_chip_runtime_resume(struct stmfts_data *sdata) +{ + return i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_OUT); +} + +static int stmfts5_chip_runtime_resume(struct stmfts_data *sdata) { - struct stmfts_data *sdata =3D dev_get_drvdata(dev); struct i2c_client *client =3D sdata->client; + struct device *dev =3D &client->dev; + u8 int_enable_cmd[4] =3D {0xB6, 0x00, 0x2C, 0x01}; + struct i2c_msg msg =3D { + .addr =3D client->addr, + .len =3D sizeof(int_enable_cmd), + .buf =3D int_enable_cmd, + }; int ret; =20 ret =3D i2c_smbus_write_byte(client, STMFTS_SLEEP_OUT); + if (ret) + return ret; + + msleep(20); + + /* Perform capacitance tuning after wakeup */ + ret =3D i2c_smbus_write_byte(client, STMFTS_MS_CX_TUNING); + if (ret) + dev_warn(dev, "MS_CX_TUNING failed: %d\n", ret); + msleep(20); + + ret =3D i2c_smbus_write_byte(client, STMFTS_SS_CX_TUNING); + if (ret) + dev_warn(dev, "SS_CX_TUNING failed: %d\n", ret); + msleep(20); + + /* Force calibration */ + ret =3D i2c_smbus_write_byte(client, STMFTS_FULL_FORCE_CALIBRATION); + if (ret) + dev_warn(dev, "FORCE_CALIBRATION failed: %d\n", ret); + msleep(50); + + /* Enable controller interrupts */ + ret =3D i2c_transfer(client->adapter, &msg, 1); + if (ret !=3D 1) + return ret < 0 ? ret : -EIO; + + msleep(20); + + return 0; +} + +static int stmfts_runtime_resume(struct device *dev) +{ + struct stmfts_data *sdata =3D dev_get_drvdata(dev); + int ret; + + ret =3D sdata->ops->runtime_resume(sdata); if (ret) dev_err(dev, "failed to resume device: %d\n", ret); =20 @@ -824,8 +1239,29 @@ static const struct dev_pm_ops stmfts_pm_ops =3D { }; =20 #ifdef CONFIG_OF +static const struct stmfts_chip_ops stmfts4_ops =3D { + .configure =3D stmfts_configure, + .setup_input =3D stmfts_setup_input, + .input_open =3D stmfts_input_open, + .input_close =3D stmfts_input_close, + .parse_events =3D stmfts_parse_events, + .set_hover =3D stmfts_set_hover, + .runtime_resume =3D stmfts_chip_runtime_resume, +}; + +static const struct stmfts_chip_ops stmfts5_ops =3D { + .configure =3D stmfts5_configure, + .power_off =3D stmfts5_chip_power_off, + .setup_input =3D stmfts5_setup_input, + .input_open =3D stmfts5_input_open, + .input_close =3D stmfts5_input_close, + .parse_events =3D stmfts5_parse_events, + .runtime_resume =3D stmfts5_chip_runtime_resume, +}; + static const struct of_device_id stmfts_of_match[] =3D { - { .compatible =3D "st,stmfts", }, + { .compatible =3D "st,stmfts", .data =3D &stmfts4_ops }, + { .compatible =3D "st,stmfts5", .data =3D &stmfts5_ops }, { }, }; MODULE_DEVICE_TABLE(of, stmfts_of_match); @@ -853,5 +1289,7 @@ static struct i2c_driver stmfts_driver =3D { module_i2c_driver(stmfts_driver); =20 MODULE_AUTHOR("Andi Shyti "); +MODULE_AUTHOR("David Heidelberg "); +MODULE_AUTHOR("Petr Hodina "); MODULE_DESCRIPTION("STMicroelectronics FTS Touch Screen"); MODULE_LICENSE("GPL"); --=20 2.53.0 From nobody Thu Apr 16 08:25:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750F33A4524; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; cv=none; b=YnEsDMjs+zRBuMaDs2nqP/ShB5XreLc9IscqsNGtoMrkE1Yczk7Z43n1RsA7IC4+/1jgp3Ar3Bium0Kapb35w3UgRpLlEAXoCdfU6jtS8g0KjC7ONA9h8ZCPcwgkJ9J/cCp3eavZvC0vKMCpUFLh/tjx4G7mPPR+mf47/k7Kd3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775686551; c=relaxed/simple; bh=kHakWtc7I/4KMZNxyXdf4ZZNQ6CPJJ3HAz/w/Rhm82s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eOSj4vGk8xXHqxdMRD40LoTRLaos0D2Sq00YW/ZoH7SjXtlkM2/oJ0dKMKBEm92bm6bRBAZ632qDKG9hU0GuFigiRQJs336g08H1bYXwsKKsHFOp/X+eOlOXHiIQdPVUJndIxIIWEfWgrDCX0+sGViY2sdIJJJUUsTLzGT/xgGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kiS7skWT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kiS7skWT" Received: by smtp.kernel.org (Postfix) with ESMTPS id 50842C19421; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775686551; bh=kHakWtc7I/4KMZNxyXdf4ZZNQ6CPJJ3HAz/w/Rhm82s=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=kiS7skWTNXTLnFDt5YrRaai+6DODIhvjR5X7zhUCsOePFByb0p8CQrwuJ0X3qUUhE rb0XwpCbi/avsNQ3hCv4HW7CmdWM2QokjMnIRyKTfK//S2kqoWqh8uSvlI//SgvbNt Ui6keRgohDd/3pd2QDPTyC70ZtICYR/yhjuFtc4Kh0JDA4/aEYRtudVMPsWGIVeElS STWW+Zkpy115UsYLfHzlsKrHaxXOjWJ3sEk5ayitbQb23/J1kwYB83st1YQDn0lXuQ RISAMdzNhdWdLNUKk8qQCJLDE7dA74PZ0kaLpFHym5odD1GZ1sRoTaadhHCfWHs8ql 0OdUwDB7reFRA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4525510FC45F; Wed, 8 Apr 2026 22:15:51 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Thu, 09 Apr 2026 00:15:54 +0200 Subject: [PATCH v4 11/11] arm64: dts: qcom: sdm845-google: Add STM FTS touchscreen support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-stmfts5-v4-11-64fe62027db5@ixit.cz> References: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> In-Reply-To: <20260409-stmfts5-v4-0-64fe62027db5@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1856; i=david@ixit.cz; h=from:subject:message-id; bh=7SvlmHIP51I6dk+k6+tvNP3/MABqkfu3zdnv9py6gtI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBp1tOSbkFU6aEYu1WSXcSny3Bib98zFWA+1DYun thcrml6diuJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCadbTkgAKCRBgAj/E00kg coutD/0XMKWSj++FRSkStRFByRa+K5bf/KenIGUw9yS6Emc+5dhSrjiUP+MpBY961IreoJ7GvfA 2vv1TiTcJsZ65jxJpzQ0Dz0w4G9hoWi8V1iEGA6t7yFRB89rDaFcn4n7ORsObw2oPZz0tn59Gjy ayEx4qzSg2gXL6/h0DP1uUGrt+jgj0CWgd+wk0sRhgK1igWwfNwndn3Om+ZUClgSJPyAStUHSvS vCT0K3LrxFviAxkQXgNEVhg0WizdwahTXTwcSicUqPHBlXncNhhY2tvBFZb3xyRL+5zo4/XUkdf wZS6EBXa67Y7GnaUdBBbQNyDwsFryaOZQbWr6g17LR5z/igz1xeDIu5Fal6KQW5hDiM4XoWD2bT EtTpeSWcSGQc9zB/mroFJkiO0HiMWA06AmRYFR/6uUdUstqeaxoa18VTfps7musntig5wbFXYN2 2VWIWJAxALeJV+3HC/x5qWlG8dpret/2INQuh/DwxaLunH4DidZOUwRPlfiTtxxTwgoIH7YnXIq B1FKqjLUQn2b0VwY6t3G7Coj7i2FmbcNGK8Svd4EGsdS8mTf/SK4vYqGQFTE0q2AoD/2x978zi7 4s5zM8RcB2+W0VAnaOJaWVLV4eQhZIQ1meN7PGjQKlH7oDtcpkX+FcJOtG0wjoMbtrs4izGXKLm zqjJzSVm9qTBp5g== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina Basic touchscreen connected to second i2c bus. Signed-off-by: Petr Hodina Reviewed-by: Konrad Dybcio Co-developed-by: David Heidelberg Signed-off-by: David Heidelberg Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts | 19 +++++++++++++++++= +- arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 2 +- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts b/arch/arm= 64/boot/dts/qcom/sdm845-google-blueline.dts index fa89be500fb85..8fb988130b551 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts @@ -26,7 +26,24 @@ &i2c2 { =20 status =3D "okay"; =20 - /* ST,FTS @ 49 */ + touchscreen@49 { + compatible =3D "st,stmfts5"; + reg =3D <0x49>; + + pinctrl-0 =3D <&touchscreen_irq_n>, <&touchscreen_reset>; + pinctrl-names =3D "default"; + + interrupts-extended =3D <&tlmm 125 IRQ_TYPE_LEVEL_LOW>; + + mode-switch-gpios =3D <&tlmm 136 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&tlmm 99 GPIO_ACTIVE_LOW>; + + avdd-supply =3D <&vreg_l14a_1p8>; + vdd-supply =3D <&vreg_l19a_3p3>; + + touchscreen-size-x =3D <1080>; + touchscreen-size-y =3D <2160>; + }; }; =20 &mdss_dsi0 { diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm6= 4/boot/dts/qcom/sdm845-google-common.dtsi index 6930066857768..4653c63ec26d2 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi @@ -466,7 +466,7 @@ touchscreen_reset: ts-reset-state { bias-pull-up; }; =20 - touchscreen_pins: ts-pins-gpio-state { + touchscreen_irq_n: ts-irq-n-gpio-state { pins =3D "gpio125"; function =3D "gpio"; drive-strength =3D <2>; --=20 2.53.0