From nobody Mon Jun 15 09:41:21 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAEFE39DBEF for ; Thu, 9 Apr 2026 08:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722419; cv=none; b=odMCyL5cfS8DBLXD8myl+yjqkE+fjyPWiBDAzA8KSCfHiVMqUjX7Z97fOflyIRvDaG5qEKbT1xs4oDK6g1cfZiAwsaa4ctu50JIYrGxmuh3tWCTnOpp3yADoR0YgfK9U66btTMLKaXEu9di0GQ4yr6FSqWLT319jev9sq/OgUqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722419; c=relaxed/simple; bh=wamlg7cG4onOyAvlIExCjVjWIJuPxmnTcceFW3Erxjk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Es67+LUQ6Ayfh5aqJqKdYy+fClG9ZLuyeOvR83GqZzR1XM7iIta8+AIU/r0Pc9kcDIa4IjlgyEVXzC6a7tY6eT+9NMgYvSd6+jl+FuKEAGCDHoAVW2t0i5+KRUlDJ60TIm8qrJpif2fOJWqPHEK6u6KOFE3O/uf/kQ/UnpRMc5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=cutfWxTf; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="cutfWxTf" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-66ba9dfe83bso746465a12.3 for ; Thu, 09 Apr 2026 01:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1775722416; x=1776327216; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GJTqTg29y4fyyCQIM/Qide/ZIGLKp0SbPQP2kYlNUwo=; b=cutfWxTfiQP1lUJE92zdljC1M49hCuOiMfT76lg7gUReZkQ3ZF0h+1T33TeftsJITd hVYbWKaFpvB+xD/S5NM1sZyVcHXkFd3B9xVnLxp3lXF0MmojPWjHYo68VidKT8vL2GRu 0znqA1bgnvaaD5kh9u1+wUA+1PrjFa5Hbwwq668R3uRcLxOgDNq5VGLJfL9RLYWeB/Mi awpplN8dqPO/OdByS8E8f8IXSUsW5kD5JET6roJwPshM07iVF8Oe1qY4EpjWK4edH6xU nMb3Vij+7ofATzFXOI11EHicMyG2HHBbaFIEEoLD6SJlmbJSshtI6If9laZ/Qx8HtwtT 1R+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775722416; x=1776327216; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GJTqTg29y4fyyCQIM/Qide/ZIGLKp0SbPQP2kYlNUwo=; b=WPSUNGyAgZffwrYoc9WZpVcD5pegmRTC5XP6We5elnRDBL6vHS+ARwosj85aMYmKl0 4SWXJvJHd9Vwzm89rGeV25wKGDZEMp945CwHPHC2SOVp00veCQ7qqOa6BJnePhIVP7n7 HUpv+wA2vLGuELE2qjg/nqXjdnHWKwdPiSSOcTGIuVTwm9cE4hr3a9s4SzEfSCOQwYRN 57ECXmxRWijW85yQYE7yDWe53Tjvsm6olN4n+czv2t1wuW2cD9DB2hLVIzkfTDMr1OoD GTsguAzNbv9+S4hNHxKzB11Z3m0g6C0ez1iAf44BTE1SBY51PIwT4L0nf1w/6Boij2lJ yoAw== X-Forwarded-Encrypted: i=1; AJvYcCUYQ06ok7ylv9M/B8zVnSpWqFiAPTqv0XlQNC5W+IVzLXep9jVxnY8Te+nIFi4BGuuAkSBmZiHwqkg3Lmk=@vger.kernel.org X-Gm-Message-State: AOJu0YxnoNNwlKOpTTzdKOkhI/4G7cS3q11PVBZUifnmpZ3PeaZkVDhb eq+fkMtA0KbQDxF9f8u+ZxC5wWJze+6wGpl6KY2XKrtkPzbvupln+iXimHsa2bG9Ls8= X-Gm-Gg: AeBDieu4fc20Ud5LvCsrXM0fps6gg/6tK9paOtZsvxn+ZUFHuRE3Qk5ISdRff/L56GX Fz/iHZ4FVjD8G1Vq8Kv3z5W2zpD1m3lacBH9ZBl6zijE8BU3r/GPRZ9YAcOBJHzEqCYttiHM92H 4cchBbcZvK+H4c6yYuz/L4+TLkAjkohCeeiHtmUTUtUWTtmUPiYC1nTadudoBd24tL8G0kajqmj dwROnKaPYDWBKCd5ySqiRFIwVY464FXMKUHag+hYUUOdnoshYcUyqGqt4aHdaj1tzWlmQbKDx4g vgQAm3JgnrxwwtrhXeYDxM6jNtOYR/AcL3d00hLXZnemrTXgCKeI+UGeymFbQiYBAD7UVfGnkGc cbTDp6zfLHHgq92yVbAd3hEGESNIvgE76NxDaYVI5GhCx6vl9T/jVD6413F1ql+fXi5PDbSjxtZ YAE8/C+AO8pgaDdi/SSKeAMUX7bMglNanLzYOpSye0rn0MF7Y85DzP2QXbbewZP7Sz7RXNXOsU1 cuPBw== X-Received: by 2002:a17:907:3c85:b0:b98:286a:e2c2 with SMTP id a640c23a62f3a-b9d476ac76amr120880466b.38.1775722415821; Thu, 09 Apr 2026 01:13:35 -0700 (PDT) Received: from [172.16.220.101] (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cec6f20sm709846066b.38.2026.04.09.01.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 01:13:35 -0700 (PDT) From: Luca Weiss Date: Thu, 09 Apr 2026 10:13:31 +0200 Subject: [PATCH net 1/2] net: ipa: Fix programming of QTIME_TIMESTAMP_CFG Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-ipa-fixes-v1-1-a817c30678ac@fairphone.com> References: <20260409-ipa-fixes-v1-0-a817c30678ac@fairphone.com> In-Reply-To: <20260409-ipa-fixes-v1-0-a817c30678ac@fairphone.com> To: Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775722413; l=1436; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=wamlg7cG4onOyAvlIExCjVjWIJuPxmnTcceFW3Erxjk=; b=XZUulr8BhdYKcjjF8UzgaLp8pFwenn1sWPeLayNoINHm02FB77AyoV17swCL4CwNvDNSccWeg ea0YmdRC+XKDrAalkWmGOiQnYrsAI0HM7+Hk4KsUAtNMY6UyJ6Uq1q6 X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= The 'val' variable gets overwritten multiple times, discarding previous values. Looking at the git log shows these should be combined with |=3D instead. Fixes: 9265a4f0f0b4 ("net: ipa: define even more IPA register fields") Link: https://sashiko.dev/#/patchset/20260403-milos-ipa-v1-0-01e9e4e03d3e%4= 0fairphone.com?part=3D4 Signed-off-by: Luca Weiss Reviewed-by: Konrad Dybcio --- drivers/net/ipa/ipa_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index edead9c48d1f..216506eeef1f 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -361,7 +361,7 @@ static void ipa_qtime_config(struct ipa *ipa) { const struct reg *reg; u32 offset; - u32 val; + u32 val =3D 0; =20 /* Timer clock divider must be disabled when we change the rate */ reg =3D ipa_reg(ipa, TIMERS_XO_CLK_DIV_CFG); @@ -374,8 +374,8 @@ static void ipa_qtime_config(struct ipa *ipa) val |=3D reg_bit(reg, DPL_TIMESTAMP_SEL); } /* Configure tag and NAT Qtime timestamp resolution as well */ - val =3D reg_encode(reg, TAG_TIMESTAMP_LSB, TAG_TIMESTAMP_SHIFT); - val =3D reg_encode(reg, NAT_TIMESTAMP_LSB, NAT_TIMESTAMP_SHIFT); + val |=3D reg_encode(reg, TAG_TIMESTAMP_LSB, TAG_TIMESTAMP_SHIFT); + val |=3D reg_encode(reg, NAT_TIMESTAMP_LSB, NAT_TIMESTAMP_SHIFT); =20 iowrite32(val, ipa->reg_virt + reg_offset(reg)); =20 --=20 2.53.0 From nobody Mon Jun 15 09:41:21 2026 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA6A039DBF9 for ; Thu, 9 Apr 2026 08:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722420; cv=none; b=BG3J8rbR5EaJvVQatJIM0WKQ1+BbmRCmAsdaEL7zLZmtC1iM6NtEeG4sMzLtcbd6rLgoHLHimcm0o58FbCzdAkJAh9JTR/HT2SRuuF/6ZLXJKW/Jr0jRVs49B2DxmTDc2SothUDLFkK/tiazKE0lmEUhEQOm51zUvIQhkAEmtls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775722420; c=relaxed/simple; bh=zVpeYCI0Fp2z5aqjv7cM/PPua39ANpiE2GE9IcuZhfs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bRrK29S+apnXuObYJnd1XB+IZnzSFq0YMPrOvpbYPeimPsc5pw3ImVbEezxaeridGcGXqBJvnnuehe6lIsS35WMoI8z3U3hqIE54ru6kYG6GEYPN/jSP7yZMA1kQlNYFjfvJd9TvSOZ52wZ0siJJbI2LKd95u0FWqvSJ4+cz8mA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=ai5YDOxS; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="ai5YDOxS" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b941762394aso56105566b.1 for ; Thu, 09 Apr 2026 01:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1775722417; x=1776327217; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xLl5gC/5dARZUSktr9tifAs18EiDAxNQou2h9Hd7lWo=; b=ai5YDOxSESAibjjoqzj6vwacxgrGcmaoMS+m6WTTP3fBMt1V6SUwKsX/VYPRX1DSgh klERBGmCt7CbrW31GnumjfHp7x289kiwrHAl2k/gBu3ZcTpGXpN48gp3kOElQ4KmuGmD S2s66IQ+3qNSUD33WG4dX6VX9vfpDy3YfnM1gfxN62mprd5JL7jKLLGmYnFpyVKhNIun fuC2e69sFBUxBCERLQ0btgVfSyWlPin+SC+X8IWDqd2HeRjC+B5JCwiEhDQta3WQ2zlI Te2KgpXWb+AvY3Fu01ytcrHqxPiiTZiyhuaGbf3HdcfM8Q9pFxKCYXstMDI60kGj+O5Z 1yDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775722417; x=1776327217; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xLl5gC/5dARZUSktr9tifAs18EiDAxNQou2h9Hd7lWo=; b=GJ/UKImlzo5Bx9P/Q6zSXBeL40Lbj4JX/76QF6k3wvfBzNfl3G6x5jWlKuNongcVOx y2My+4qCFDtDCXn9WK/Rqx8vFGetlx1YSNvQ4ofYDwh7W22dTUYKLIoGyrTMWW8QRYBO CRE8U9v8QFseO6x6XxPbtEnlsyLB+7GERirDJQlmiLps8Fhv4TWmkTra+N2mwYlzWECY CkwTIS9P3EYxYVI2SW6FZWyATehHC8ZNFAKGFRM/9sUl+/1w1tR4swrpjilSkyE6r6uD fZDCgPigh/bNKgCqT0f8uSdPMK3ZAo0slb6O0pCPWELM8VD7dxQ7C9zjhBpQPxZjUNuU Tgfw== X-Forwarded-Encrypted: i=1; AJvYcCWZEU/aPr2UL8FbS1LejTosg+LM7c1CPFLPwvAKh+CJcR++096PFQSDMn9drbjuoSQ4SBt3WOnBrPXrQ7M=@vger.kernel.org X-Gm-Message-State: AOJu0YyO45aUvZ7riMBzKvnGzUKr2nmML6cB+aoVGmUf+u8gKcslZWl9 cZFaxKbL/dQTNwg/z2iJEDgdcVzOZQYehc3ndFijDCM0zTdQz5wkmuQ9UQDYKx+nJzw= X-Gm-Gg: AeBDieudGHTo781+idt2v3hYO7MCCKnZeY91rhjSEa3sDVf32qFa8HW18CSwis9UZDM uZHeetcdTcXfJFzXYaH96fPZnCzHSWdVISDqKf6Ne2Wa/nVk289ithXR+lIwMXoeU2XaVozqIHG JU64avnvrkI9iHumjbJ1kl94eQc9F3Irsb4XegTcMBaMSGs6zsRusnoW/GILgYI0fr+Z8VDhZnk p0xCCTCqaOpfXAfxRe7LTXXupe8043Ag+9wsiGITahuVgV6j6YHGYqDsPdkcGsa7akf62Gj8A5J nCHeOwu5v1YRxrRIfGfGIp2fqs7rzMKGXuTfr4VU2ewlnApDcuxih2W8NiyTEVHwmjkSjyxhZBj s/S6B0nIIW+i2SYIM80Owgxrbl1VqQ9kIJ+5croOih5emoD+fqmf0YH462b2Lxrbyoc79Plmc1E ALj3ueso5UWvZyFrRPDqGmgl1V8nWUhU10EgnqqCN18Qn3+z6C8AN1+3GtS8PzYbU5+IhumglTb Lqf5ZH0pp8dJsZz X-Received: by 2002:a17:907:2d9f:b0:b9c:b3b5:bbf0 with SMTP id a640c23a62f3a-b9cb3b5bc8fmr892722766b.6.1775722416882; Thu, 09 Apr 2026 01:13:36 -0700 (PDT) Received: from [172.16.220.101] (144-178-202-139.static.ef-service.nl. [144.178.202.139]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cec6f20sm709846066b.38.2026.04.09.01.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 01:13:36 -0700 (PDT) From: Luca Weiss Date: Thu, 09 Apr 2026 10:13:32 +0200 Subject: [PATCH net 2/2] net: ipa: Fix decoding EV_PER_EE for IPA v5.0+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260409-ipa-fixes-v1-2-a817c30678ac@fairphone.com> References: <20260409-ipa-fixes-v1-0-a817c30678ac@fairphone.com> In-Reply-To: <20260409-ipa-fixes-v1-0-a817c30678ac@fairphone.com> To: Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775722413; l=1045; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=zVpeYCI0Fp2z5aqjv7cM/PPua39ANpiE2GE9IcuZhfs=; b=CHEi445KZvoC0I15KF5hTJRWv53wWRXSGHOTpa7orG3qMHl0QrFrlARJUij2VbYkde8+d0wyF KqVSQMVHMVbCXXj8FH5xKxVlPcmaajmNdmK1qmTVgdje8Gkloqxakwv X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Initially 'reg' and 'val' are assigned from HW_PARAM_2. But since IPA v5.0+ takes EV_PER_EE from HW_PARAM_4 (instead of NUM_EV_PER_EE from HW_PARAM_2), we not only need to re-assign 'reg' but also read the register value of that register into 'val' so that reg_decode() works on the correct value. Fixes: f651334e1ef5 ("net: ipa: add HW_PARAM_4 GSI register") Link: https://sashiko.dev/#/patchset/20260403-milos-ipa-v1-0-01e9e4e03d3e%4= 0fairphone.com?part=3D2 Signed-off-by: Luca Weiss Reviewed-by: Konrad Dybcio --- drivers/net/ipa/gsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 4c3227e77898..624649484d62 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -2044,6 +2044,7 @@ static int gsi_ring_setup(struct gsi *gsi) count =3D reg_decode(reg, NUM_EV_PER_EE, val); } else { reg =3D gsi_reg(gsi, HW_PARAM_4); + val =3D ioread32(gsi->virt + reg_offset(reg)); count =3D reg_decode(reg, EV_PER_EE, val); } if (!count) { --=20 2.53.0