From nobody Thu Apr 9 06:46:29 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489CC3A3E82 for ; Wed, 8 Apr 2026 23:06:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775689580; cv=none; b=o+VoCXfxg4MCyRjYIwE4cxMqOTUQNVJYPXAJQvZ8pT3kmE4sT3mYCrGMek3b3bxC3EnR84ahj4kUstvZq3JCUNySU8kbB0sqigIZZSsttgeAnBpLrxW7OWOX2OaOl2QaPgEJVTidUlkvQ2340t3v7Bz/U47umr8lwFd2FIUTjGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775689580; c=relaxed/simple; bh=QNzOKPdiy8cSJfr1mCdxlpDpX0PCIjFpk/12ymL9Mjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rzWybe6VzLdAckihHkLLxjFMDfGxfLR1oe4w2OoFHlL1GI7jp/5YCoXM20aHJPFkkrsYoWvPBm+18TxpXn3vehdqPbRLCNYdSlOczLLJ0FIXt0nSXuZ3eJL+ssQYrYGo8ESiUdzdj3qy4q0eIpSZ9vCuRAPDxnhEOSbjTdUK1JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=Yu4GHqHx; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="Yu4GHqHx" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b23fcf90b2so3077885ad.3 for ; Wed, 08 Apr 2026 16:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775689579; x=1776294379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zg+/QcI8r5Qwsw6nUEc3qwhDPUQV4lyYXGZbebKcjco=; b=Yu4GHqHxwec14DKmN/vD3ZDMghhh3b8/fpdhJW3CzVn2/ZZynrjyffrP9qS/qyt6bt cCyrxKMTCHlUV4bpGlxoadz7xiA6MQ92YHDlnJ1BrYBEGfC8FBj/I6hLUVlkh7LUx/bM IctFAKFeGb6yI3ba9TaSVnf5uP0jnDN288G6lMypytDnLUtoQQ1aBDjkFJJdbpJSC4Cv K/DS4qad+nWlnnzCDNvSNyQlZogULfB10/q9KLS38dwGxbRJCxKs4Q63H7bJYiuFrv9A YpX03turW7SXUmMXIkkeKfDXRFkrgAsqDmOzcBl23G9dDMMgn/SFxIi5t8hrDgN/DP5x /oIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775689579; x=1776294379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zg+/QcI8r5Qwsw6nUEc3qwhDPUQV4lyYXGZbebKcjco=; b=mm4Tg9Za/bbC5CxZImjvRMjF+/HVGLIpVdtzJLvKTtrVHOgTYCwCJRIcV47DE4+yyo 4r6PLrEnAOhfs/USbdTvFco6q9R3zK4DyO1bTIzTBXNc7iNZ50oFTJbUVFqnA4f/mNDN 6CpucvfkcWmuyA68Tcdp/AjZ0wdIb+Fe0NliSPPUZIUCiwvLVriu++zjxRNUrFeSg2KV Nt73BRxLiduqNdK9oyht6IUmTS+eQmz4T8YySdfpnVe9Y6gmMNsnMixvAf1p2bAc6AFy yJf2KIOCkEt32osLKI7/F9URkmNF8oKNfw5kkZrMGcJgbxRI+PcYc6TlCZLAZysliZcx eJFg== X-Forwarded-Encrypted: i=1; AJvYcCUM4ysnNa7UmdlNfVjXTGysrQ7rJOJa8HuPsFmpitGkP6LsHXtffVaqaw0KR8+2i+eLr8lHinp4147oy5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzMeKCr95KtyKL9OhUtKb+qPCIABAkFvGChX2O8pBMhXHpsTyvo 6shDctv7HeXkyryXvp1GWBlE4l9v2MAG/wQ/vRivWfAV21hoeunZlprjfjwJUnOQzSg= X-Gm-Gg: AeBDieuH8TGPuRCAVvE0WhobQUN8EaOTgwoLImzhbeVUSbGah5QP5qQA88e/911m1qe VddLI6+3CZ41xTH90TMx+IeQ/MsTnUqLxcxuzu4WCQfC5O8cvk//IOVsZgI5Xm1XpKNM3676OC8 sFr9lZ46PqhyrXxrJx181aSMV7KDobwTwPLtp8B5pVw2iBISITaoydqA0s1b/naXaT9r2d7bQEY PyDjbyJU+Lm5qukcPMkLdJmaeQUBFKATAzBl+NHFg35XjDqadVTPdCf8NhIc2yRkwWQPMYBGnvU zwi2TH1Ja7R+eNBXXNN/lcGuD6N+jQCi6MOt8Qg8DeSCNmCdep1/8UoiTAN3vinYjCeGl+G+/HP BkkXThZoEnQiCwRi2AIV4LqPT8SU5mjaSiHgHkmFOSbEWiv9MOl4BB5OHzBDPJseHANdt5xBmJL baHjOk X-Received: by 2002:a17:902:cec3:b0:2b2:42da:25cd with SMTP id d9443c01a7336-2b2c73b7809mr11898445ad.45.1775689578634; Wed, 08 Apr 2026 16:06:18 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:43::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2ae05991bsm67534355ad.70.2026.04.08.16.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 16:06:18 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v10 03/10] net: bnxt: Add a helper for tx_bd_ext Date: Wed, 8 Apr 2026 16:05:52 -0700 Message-ID: <20260408230607.2019402-4-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260408230607.2019402-1-joe@dama.to> References: <20260408230607.2019402-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v4: - Added Pavan's Reviewed-by tag. No functional changes. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index d4288c458576..d1f0969b781c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 2b40a5bd57af..83b4136ccd31 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2836,6 +2836,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0