From nobody Mon Jun 15 07:34:00 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279FD391501 for ; Wed, 8 Apr 2026 20:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775679848; cv=none; b=LwWh45ndO731TPKcufxKXmoBj34kWyciXz4suXupH7LtvjlHJJ6t0EGNLn5XtHy+XHiEyCg3kTY/8/gPtHXEmHoitbtrahbSQ6Uu3oudDhORq2gCszSuJW5gEjjPTMwA6PY9JiDO1YjZ4EWpq/1IREcURr3eLozscTYl3zwyGAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775679848; c=relaxed/simple; bh=M/LjiKecfzVTG8HRl4m3JA7iq2zgvUsjbNQ4AnBHvSQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YssnG8BkI++5kfVaoTn4pGp3y8QT4VwDp6sV1ih4M6ATZt0piwUE2ihJRZ0O7nznL70WV40jMpFp6aVIk4nY4m+NtTNYyXRa7s4mVThf98zRPtwHQfcEbCCiSoEiAm6rBPXiBH8nlIRxZjZoH0I9F28qalX6QlOzV74HZVOpHPU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=flbmwE/K; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="flbmwE/K" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so189526a91.1 for ; Wed, 08 Apr 2026 13:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775679846; x=1776284646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UthiWrjG1Hwt/0nbiWEQ1KZeqkoIURhsJh3Eb3JdJ/8=; b=flbmwE/Kaz/ysnc/p7I3LFzNeBn0PhsXsyUeICI3DU2yymftWFnoMS54OlI/gh3kZq 1nPTRmysaQh9e2NhImBXEDN31GXW/o83HpUwoGLm9feJjcrupoECWC6nnQfMGhKjRNE7 We7X9uC2sdUjPZ+6UaRzJgyA8RjGC255wjqau1LB0q3rFqlg7vqUpMp98Q6XRC/um4Il bZHr6ia1SmLTDY9Go/69nRXnkStv3L+KzmB4lO/YPJ/FS8H42ZpFL4Vqe4I1FHWnv9la twUCJxE/bQW7CpPf0vpoaI0c9tUMJONVdV4rPUJ8BHGdONVZ6Z24LeWLgeQGpbAcMH4J 5d3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775679846; x=1776284646; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UthiWrjG1Hwt/0nbiWEQ1KZeqkoIURhsJh3Eb3JdJ/8=; b=tRH96HaCE4R/D1x02nmEItS5ThJ6kzPlq8d2MDVYXJvAFX74+21gspJlJ3Z8hMLIVh HbmYPLB+Tgh+SQR04aL6bY8eUfo+eEaMSx5IxOkhgxa6i4+p14aPQmq8D4Qs2/C0AArs qEosDNlYzkU/6rP/vNZkN63dqAnew9w2orWHoyRiHReCmkYZbgsqB8vKs72NrWXEzgFj RmyRWQzvBsX6zDcYr6W/KVOSzp3QAQ9NQ0oPTf09N1EvHqyLzBKJ2SB/l3Us0NwKecE3 7PwstHqy4CuqEFYZBEgqCp/7eUuBT9nnKS4F+VOlGLrpyB5yAnuvEzsvCR/8nQRt4BEK XD8w== X-Forwarded-Encrypted: i=1; AJvYcCWf30HpU9kWlpSO5b90GqYkvlKAInrthgfKxigfaBkRrycdrgzzq85NxkcnJeUhSfdAG20kjQIPvWjdHYA=@vger.kernel.org X-Gm-Message-State: AOJu0YyXXCPXiHB7Ib7bah+FYmjNzdJtHpg582ypB1rpU6SjkaIEqUfR 5VhuQYDKsghnlP6a5mi44eCEJIaYUNCBhpNsx4zQA+FmVttl+nH4k5jx X-Gm-Gg: AeBDiet7bst74gwmo9afjEr1x1McdtMXCnOqfcRiyFVABYYew89PEIG7nJccv7Hv6d7 YAX9ifslwL/K7ZAjS9HyGuAm2hXY4kf1HUXr84boX2b99CTwdx4v+l3tcleGTl9h1Uee7vUISip XL4qVYFLbScroI01xQDyxgw6VlZrEg/+rTg7wE6Z8+OLZbU1bMY/rAa48obObjPBt+lsT6yqlcV jaUh6vUI4rImCDpcpl1EuH9iKsXKRjoyNYSC8wtJDZ1I2/w2B3G6nrSl6Vo8U/Ccm8ib01xGUjW tDndUrzeB6y8BjzYk7/RtP/cXnTFqpVHje3PePR+LsStEGaIKnMmko0Mqn4Y7tD4GeeUorzceQJ nv6uizGktyb3Plj6Vi7gooYEJXWwDnGiuKzCnGJfHrys8vg6sPJBRq4dH3orKQHGnqc7jpMfaTL vc+eg9SxMxKDbqNVgd2nnmSBVSpi0Lr5KmQ0g07VvmyBHqlz7zkEdF4U+DQs5e1GAh68ePoTRro TJ792pkcAdXfjg= X-Received: by 2002:a17:90b:5583:b0:35a:329:73d8 with SMTP id 98e67ed59e1d1-35de67a0817mr21268988a91.4.1775679846102; Wed, 08 Apr 2026 13:24:06 -0700 (PDT) Received: from localhost.localdomain ([103.10.31.106]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e34fd383dsm704288a91.6.2026.04.08.13.24.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Apr 2026 13:24:05 -0700 (PDT) From: Shuvam Pandey To: Steven Rostedt , Andrew Morton Cc: Masami Hiramatsu , Mathieu Desnoyers , David Gow , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, shuvampandey1@gmail.com Subject: [PATCH v3] seq_buf: Export seq_buf_putmem_hex() and add KUnit tests Date: Thu, 9 Apr 2026 02:08:51 +0545 Message-ID: <20260408202351.21829-1-shuvampandey1@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" seq_buf: Export seq_buf_putmem_hex() and add KUnit tests The seq_buf KUnit suite does not exercise seq_buf_putmem_hex(). Add one test for the len > 8 chunking path and one overflow test where a later chunk no longer fits in the buffer. Export seq_buf_putmem_hex() as well so SEQ_BUF_KUNIT_TEST=3Dm links cleanly. Without the export, modpost reports seq_buf_putmem_hex as undefined when seq_buf_kunit is built as a module. Acked-by: Steven Rostedt (Google) Signed-off-by: Shuvam Pandey --- Changes since v1: https://lore.kernel.org/all/20260406033728.25998-1-shuvam= pandey1@gmail.com/ - export seq_buf_putmem_hex() so SEQ_BUF_KUNIT_TEST=3Dm links cleanly - validate with a fresh arm64 build using CONFIG_KUNIT=3Dy and CONFIG_SEQ_B= UF_KUNIT_TEST=3Dm - send as a new thread - capitalize the subject for seq_buf/tracing style lib/seq_buf.c | 1 + lib/tests/seq_buf_kunit.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/lib/seq_buf.c b/lib/seq_buf.c index f3f3436d60a9403eae5b1ef9b091b027881f14fb..b59488fa8135cdb0340fbeb43d8= d74db8ae13146 100644 --- a/lib/seq_buf.c +++ b/lib/seq_buf.c @@ -298,6 +298,7 @@ int seq_buf_putmem_hex(struct seq_buf *s, const void *m= em, } return 0; } +EXPORT_SYMBOL_GPL(seq_buf_putmem_hex); =20 /** * seq_buf_path - copy a path into the sequence buffer diff --git a/lib/tests/seq_buf_kunit.c b/lib/tests/seq_buf_kunit.c index 8a01579a978e655cd09024d0ea9c4c9cd095263f..eb466386bbefb1c81773cdae65a= 8ac3df91cd8ea 100644 --- a/lib/tests/seq_buf_kunit.c +++ b/lib/tests/seq_buf_kunit.c @@ -184,6 +184,38 @@ static void seq_buf_get_buf_commit_test(struct kunit *= test) KUNIT_EXPECT_TRUE(test, seq_buf_has_overflowed(&s)); } =20 +static void seq_buf_putmem_hex_test(struct kunit *test) +{ + DECLARE_SEQ_BUF(s, 24); + const u8 data[] =3D { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 }; +#ifdef __BIG_ENDIAN + const char *expected =3D "0001020304050607 0809 "; +#else + const char *expected =3D "0706050403020100 0908 "; +#endif + + KUNIT_EXPECT_EQ(test, seq_buf_putmem_hex(&s, data, sizeof(data)), 0); + KUNIT_EXPECT_FALSE(test, seq_buf_has_overflowed(&s)); + KUNIT_EXPECT_EQ(test, seq_buf_used(&s), strlen(expected)); + KUNIT_EXPECT_STREQ(test, seq_buf_str(&s), expected); +} + +static void seq_buf_putmem_hex_overflow_test(struct kunit *test) +{ + DECLARE_SEQ_BUF(s, 20); + const u8 data[] =3D { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 }; +#ifdef __BIG_ENDIAN + const char *expected =3D "0001020304050607 "; +#else + const char *expected =3D "0706050403020100 "; +#endif + + KUNIT_EXPECT_EQ(test, seq_buf_putmem_hex(&s, data, sizeof(data)), -1); + KUNIT_EXPECT_TRUE(test, seq_buf_has_overflowed(&s)); + KUNIT_EXPECT_EQ(test, seq_buf_used(&s), 20); + KUNIT_EXPECT_STREQ(test, seq_buf_str(&s), expected); +} + static struct kunit_case seq_buf_test_cases[] =3D { KUNIT_CASE(seq_buf_init_test), KUNIT_CASE(seq_buf_declare_test), @@ -194,6 +226,8 @@ static struct kunit_case seq_buf_test_cases[] =3D { KUNIT_CASE(seq_buf_printf_test), KUNIT_CASE(seq_buf_printf_overflow_test), KUNIT_CASE(seq_buf_get_buf_commit_test), + KUNIT_CASE(seq_buf_putmem_hex_test), + KUNIT_CASE(seq_buf_putmem_hex_overflow_test), {} };