From nobody Mon Jun 15 03:04:24 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F1573B19A8; Wed, 8 Apr 2026 16:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665897; cv=fail; b=ma5ZBtJfABp/GzmGZwj1+mwZkGGFP5d3VB5vJ5EDBz5qUtvoVx7UYg8UFPs0mVwOOkwvUTD2XFwJh+IT0V9iYYAeLckLHjBfdcfE7Vp/eFcTqsnR1l1Fw/vF8HoerL4kZlvXGXqQb6Eai5ZeMYowg4kvNIaEC1lHZ4Ou5tqNM9E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665897; c=relaxed/simple; bh=4qRCZLxo6jwXv2fJHR0nPcB5tRsMNlHtk6VPITQr2ME=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=NOP2Y4KeAjEhKYy3vcDyfeIKmzO1ZKWnD5PthKxeclBZH+XnRkJ51Mtiiyes3kT8I1rx5HmqSE5QKYFBOFU974oX3wj0JoCMixvX+btEbkT4CXKeO2TMGB7T3OzyuKW8XV7tn6FHJM5NSmv7C0JdbRFWzZt4qNI2yLE4DWt/ZPY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=UI+RFxTk; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="UI+RFxTk" Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 638G6JdX4025229; Wed, 8 Apr 2026 16:31:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=g2 j2fm/v79ZECaagvcZYh+ZbDTH/2WUE6tdwI+2tz68=; b=UI+RFxTkSY91QVOcLA 1O+KwuJCsHXtDGQUaLrGGYzOPtdbKJRQKZOel/9y9yaH5xyG+erIxRCs/1FEbn+W +hZfQSSSzsXJyurM2Oo/m1nl5pOriuTEIERwYLHrCsSqLUWPAFtLWp2cLhd7Oia7 v354phe89e+fDEmK6H2lSbwU7/5/D4ElHvcJtVINB9Lh8mT4MNDWw5wGiLgEwRSr czkXYyZdsoYyl0ql+dJRgsCyVifAasb0OYcmC5JZpPrLyxf/qxhYfgsPm2kiEIAa rsQB0Q+2tC2BaYIIw3UIT8f5xhWI/1r6hiImIx/j/XpaTeEZ9lPbuOvK2V1fVXFR ywuQ== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4ddnv2c12r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 08 Apr 2026 16:31:10 +0000 (GMT) Received: from p1wg14926.americas.hpqcorp.net (unknown [10.119.18.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id 6D35880170D; Wed, 8 Apr 2026 16:31:09 +0000 (UTC) Received: from p1wg14925.americas.hpqcorp.net (10.119.18.114) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 04:31:05 -1200 Received: from P1WG14918.americas.hpqcorp.net (16.230.19.121) by p1wg14925.americas.hpqcorp.net (10.119.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Wed, 8 Apr 2026 04:31:05 -1200 Received: from DM2PR0701CU001.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 16:31:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DEBye1PjoPLkdGHaMRgz0qWpIDBoSJarT82GfIk8/u6J07ZrjebQBMvHEwNA20x/MmC/tJxQAdzR2gLjjun1CzzxxwTXTuM7aKldVUDW87kyqi1LcLB2AQ8qn1h3vr6ZTMyWbcu3C7gbYnEEcTJuyGQ4/k4PQps//0AW82dZUwi1wMGnThPrtHUSbzjYaKDZt93Vz/mJE0M6XlAkNVAI6KIumId0TeWJ+Ko79L+X+CPP1jgcqEP/lNM52FYEwG0+ZxhzDflST3ES2dsrm9OvWr7YZR0GR4n0Y5fNVM88eDW3NqUjDG1ZfHwWZ+bKynaHRK0kc8s4GHC6KBbgSxZCzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2j2fm/v79ZECaagvcZYh+ZbDTH/2WUE6tdwI+2tz68=; b=Sur9wqcrgpZJhMrlZNucSJMY9xq8BgPRdrmuW0Hr2cNj0SvQk85A5H3qyR507mQgIfWDHY2SSBuJzM1jHMtxaVMusWA8pzgvSCm3xWJJWXqsQ3cIbMy5LjSujPJ+gnQmfJXur/4vXCYkA1Su5kc9nFsdOQr+jg+3GM4OAJqkoVE5KmxZ0tFMmlAlnhHpRmKJKFx6eWPYRnlySpEB7kG5bGTo7Gfs19lhTBEwkM3AFeMp6n55EeisdQqWaKHw7Vns5F8H6ca1iRUVJTxuxbOdS5k8sVeBH90b596qQUPByfv69ATD+zHJH46gSLdzODW8ZNN2mDlL0nRvi/qQUw9dAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3528.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:218::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 8 Apr 2026 16:31:03 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9769.020; Wed, 8 Apr 2026 16:31:03 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "linux@weissschuh.net" , "cosmo.chou@quantatw.com" , "mail@carsten-spiess.de" , "linux-kernel@vger.kernel.org" , "david.laight.linux@gmail.com" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH v3 1/3] hwmon: (pt5161l) Fix bugs in pt5161l_read_block_data() Thread-Topic: [PATCH v3 1/3] hwmon: (pt5161l) Fix bugs in pt5161l_read_block_data() Thread-Index: AQHcx3UXpqFH/jPqO0CU/2nuRJrWLg== Date: Wed, 8 Apr 2026 16:31:03 +0000 Message-ID: <20260408163029.353777-2-sanman.pradhan@hpe.com> References: <20260408163029.353777-1-sanman.pradhan@hpe.com> In-Reply-To: <20260408163029.353777-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3528:EE_ x-ms-office365-filtering-correlation-id: 7052cd61-948e-4685-6c42-08de958c3a16 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|56012099003|38070700021|18002099003|22082099003; x-microsoft-antispam-message-info: owbtoyReQtDz0VsUBsnHaY2cMffajkpL7dx2tE+oH5G+7QkqiZBcllcbC6C8+BeglnJ66RvkwYvhZsKtXusJJYNX7GOAeYZTZRfUVYdeozXCOytVpOm0EaQm0HSco7Ufi7M+P+30npGy+kOtqGYBsW4ooFTbJwKaG3JV1WQeVqu49HJw7llIt+C6b5wVNN80kUiE7CPELiu4Jy0wUHmnzwHqbHf+GX+0Hdw8g1m8aLfP7SwrbLTXoGZESMoqRAcT+A7rGiDij9WrSMpCyTusGnEh/01f5fRGOEeeIkNuH9g+JDLl7uO6mqxEErQ7hOPe+N9imyX0kdTM52lUgY+vWej9l7P43/JEmasoRkyjfhgrhzfRkPweddsLxfW41VaRsixkEYDkaJl6d5bnqaREyMYlGtaFHdIKxxqhKNU/k/YHLUatg3gC2FN7LiHIWy3r4kUCl0ygr5DEypeVyTjfmgmDHG5Y5cENByJwXcAQ1J9LxpbbXoehuWtyKFItXB2xwBmhx2sSalooXMQTSnR1Ws7E+OO6lbKCJSyonKX/VIDXRfsjuKpOP8SaIFyduFK3eLnkOxX1qQE4Ofuz/oDNyOBK71rmM1DaSQKLxF2xd+Kx0PnHw7HgoZ6zeZ4bjQxahLFy1caprNdin6MOk4jRvj/Fr3RA8+D3QRtuO7K42zI+p3mriCEEuJ3Chcbyp7mIHR1LadveG/ObfrKiMlz7jVDwTNP758BQX6oI70O1IbtXATEJeqvWW7GON51EDtwrXSwZkDx4491KV2TWpPaU01h/+L71EzjQKf4mIbwRf+8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(56012099003)(38070700021)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KA4GuUS6ERInc4XdDR3QVoRaUAxSvQJLLjk9wlfMmNr9Oqrbi6g/Ixb22k?= =?iso-8859-1?Q?6NWZq9KZIrvoR0Gnx25FIFiC85AsE9qfqb6S6/9bhb3o4+CfHMEKPaRbcf?= =?iso-8859-1?Q?SCspnqzl2KDNmRHi3SupLPoeXAYV4w4QpaqLZ7B61fhIRmGqR3IsXHVZGZ?= =?iso-8859-1?Q?8+ZB1L0CPsyMCy+sJK9d4mlRB1xHzx84ZQoIRwaK7RnOCAxADwwRcgzsEQ?= =?iso-8859-1?Q?Af7Vrfe23EiJ3wsNK/Mispp5J+6eLEl94lQ/alYBLgvYgUwbr6wU5p0p78?= =?iso-8859-1?Q?DSincRCbS7PlYWva+vzpvq+4xtEHaBHQY7P3OjXlkpQQvKL3xNmALkpZGJ?= =?iso-8859-1?Q?6xlM2+5qas993hryxaJYKuPaYCkp2X7Lz3DOQc1WhlXrZGEnUQ0x1SfvXa?= =?iso-8859-1?Q?YaxBsi4OsU3Gfq1/xpVantqC0F/yYmIzdQqWT9m4YY2gtnTicunTSJecRx?= =?iso-8859-1?Q?GJHyU5cFRxwIEJbjwz48SXoRvJAFuiZIW+rMSZrsnfI52L+N8/w1LdKYW+?= =?iso-8859-1?Q?LhrifA0/jBOpPZXgCgdKNMv9feSxTIMQFs70s3wYbHxZ4m9+TQClWxafz1?= =?iso-8859-1?Q?X3tLUFK4s0DVAcQRAwYdtsi7YOY3mcRi7vTNhX2JyqLZqOxHl93EvTKgDx?= =?iso-8859-1?Q?5sSQAPQ2MsgGmGdLKPC0i1VPyHAj7/T/eIr1o9qOnRXQVaj61Noz3u+bpJ?= =?iso-8859-1?Q?aB2cP/gnjWFURu3dPOBijxR3/Wirl0rMuFYofiYMDO8cRg7if6gsXa+/ok?= =?iso-8859-1?Q?TVuVOPFO0v/dyKe+QqwghatB1y90oN9VJOwMmzrbmYtCaY0oih1kqge7Yd?= =?iso-8859-1?Q?Lh13GP8wspeHm59ySvq/fOhhq/xxYd4v0P2dTEQtDtK8EHhGbG3wuvSd89?= =?iso-8859-1?Q?8o14l41Hp4M2KBGZwlk9ygANVQc3f3iUJ9gm3+z1crhxQ0oIs6J3UOiGRf?= =?iso-8859-1?Q?yOQZVoMbQYsEfnTSOG1YNP5SiNlkvnR/0CsovDok/oTmGFtv/v9xVfqfy+?= =?iso-8859-1?Q?zZPG6OPQv2bwz+BcclLEowwYomydRFpHzlNCl72ZjSMSNj8wAeMHaeyBYw?= =?iso-8859-1?Q?M/i8dSwVWw+M94BC2ChE0QMKkpXoleZyAyguF3SLqhdboXs3pmdHasy2oO?= =?iso-8859-1?Q?/gYPjhaTW4Hqvvpk1ILaDavEPNCCR+VMy7GB7bw0eLrDEZ9ONxHBPc5YTS?= =?iso-8859-1?Q?e8sxJ8YDFn2vgPpn1r1ca2d+vDCBvtXqDY++zvQ9JJpdQ09vY/OqJYdN1w?= =?iso-8859-1?Q?FvPQHuB8XD4u32QIFEPlAcbCY1qPm1+3+5shimpaoLC0AxBWmXkbuw9AIN?= =?iso-8859-1?Q?xke4bMfhEfpudgjoRbwKiUjICxzWGG/OQ9EmXdFD88149UTvw24jLFcSzx?= =?iso-8859-1?Q?QC83jnfulv0KeBfYKp95C3ZUrM/u7ubz0fzH2Sctj0lkjk6FnvhE4zYIrO?= =?iso-8859-1?Q?HNRP3ammvYztQF16YsgaNHs0TbqVr1qpQPjhgRQVNmrySWR72YCxPM0XKd?= =?iso-8859-1?Q?a8A3J7J1AMc5mx3rrhlYVFW6gJRoLPXTCmqzBao/sNDNRCBEydBbtXzyoV?= =?iso-8859-1?Q?/CBgHEzfTDXWYPwG1OgvcFgTEry0hRjD9r7aHW6GjmDu4J2bejbcAranEA?= =?iso-8859-1?Q?0k1lvg5UrFCGEiPacy0SUn9sFA3ULSavjEs6SP7FhJF/Kjk8eYqcHs6Jus?= =?iso-8859-1?Q?EJ5vLy4ixlnRqli1NNgITriSSMxunKoENwXLZ59tWh89vCZr+6koW0WSkJ?= =?iso-8859-1?Q?Ve2vm7c8tIxo+0vJfb5p6avAPWKeBrE5aQLlKRqhNn6TZu9fmBmMBhd/JS?= =?iso-8859-1?Q?kdr67cX9rQ=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: YIaSsBb8UovuEknrZi7yfj0F3IpNXX/Xkpd6WsPOJ9bGjGAC+Hftihkx3kwbmGXptQAPdb0uMcklVJ83TMUiNHf/l3eJB0cdveASj2w1rrXToQK1C6zkp/rhuC1OdwGAj+Swv4Krj/FcO0rxWipT/iL7XBXMWnUT0RlDbbVcJP/VOlR0OuVmK1ZZ6GUNqYGI3DtgPZazs5M1op5eb/MLbKx8hTDITcIAX7QEZQOsDRgHBwP8eWkD+zNVNipqYtU2PlC4QJe9Ts7JdtW8UjPsc1NJSo/7/1fHnQVCw6e7lvSp/fuyZnIypAfEMn3dybBQYjDbFqtbsJzt223kSd0vdA== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 7052cd61-948e-4685-6c42-08de958c3a16 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2026 16:31:03.4604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6eoJBzkgJam1WmoW0mCUsJkSoC0RCv1RHTglPfhc39E3CboswQYFA4PTMWrW2VBPvG/qRmyjonF2cjoCvm/m/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3528 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=bIsm5v+Z c=1 sm=1 tr=0 ts=69d682ce cx=c_pps a=FAnPgvRYq/vnBSvlTDCQOQ==:117 a=FAnPgvRYq/vnBSvlTDCQOQ==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=NCWKwCw8Xy9Og0ibBRsL:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=2miM9txUn0MiwXLCYL0A:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-ORIG-GUID: 1I9hD9reyJFMqi7w7sobkYyE1jG0HJqA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDE1MyBTYWx0ZWRfX2ULlZL2xkZNh fIf0/nPSmu2CyYUbkNT/HgiBhvYHnc0hnk0pSXKiTjlJRM4QY/MOeFMSXg1oYlI0cmCqX34NwoP UfTNdT8sFaqzjAF+w9OwmN2vbU3iSJrK+dWIOurfhRGvEAHMuLblcVcLeqzXxGMluuQS0/BO5H/ akQwS3XU87jzMkfeIQ8L16J8royjgTZpVXLmIUQuVwepFAksj2r18djAa9RobYADq/QZ0VZ9PKX L7kbYz99Hgkr1WpXZ6Sr2Ec0DdTjwEgiSHS6XQwz7U+gGWHodyX5AHH1Tl2yW/NEoCnSkG8EBJs rb3yNfdeQh+JEwXCvSNpFqPD9Og/bT/uqpUhmu4czwqSInscVoF0lwfG/SkH+ziQg/8z2yY6hCX J01t/Oqs6WLQm+JvHXYcW8hayzjpUFMUHPA730hRs3IM0l2/v3RD8DQCKceBefIiATnUSbFFMlb rGoj6LCE+CYoottlHKw== X-Proofpoint-GUID: 1I9hD9reyJFMqi7w7sobkYyE1jG0HJqA X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_05,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080153 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan Fix two bugs in pt5161l_read_block_data(): 1. Buffer overrun: The local buffer rbuf is declared as u8 rbuf[24], but i2c_smbus_read_block_data() can return up to I2C_SMBUS_BLOCK_MAX (32) bytes. The i2c-core copies the data into the caller's buffer before the return value can be checked, so the post-read length validation does not prevent a stack overrun if a device returns more than 24 bytes. Resize the buffer to I2C_SMBUS_BLOCK_MAX. 2. Unexpected positive return on length mismatch: When all three retries are exhausted because the device returns data with an unexpected length, i2c_smbus_read_block_data() returns a positive byte count. The function returns this directly, and callers treat any non-negative return as success, processing stale or incomplete buffer contents. Return -EIO when retries are exhausted with a positive return value, preserving the negative error code on I2C failure. Fixes: 1b2ca93cd0592 ("hwmon: Add driver for Astera Labs PT5161L retimer") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- v3: - No changes v2: - Also fix unexpected positive return when retries are exhausted due to length mismatch drivers/hwmon/pt5161l.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/pt5161l.c b/drivers/hwmon/pt5161l.c index 20e3cfa625f1..89d4da8aa4c0 100644 --- a/drivers/hwmon/pt5161l.c +++ b/drivers/hwmon/pt5161l.c @@ -121,7 +121,7 @@ static int pt5161l_read_block_data(struct pt5161l_data = *data, u32 address, int ret, tries; u8 remain_len =3D len; u8 curr_len; - u8 wbuf[16], rbuf[24]; + u8 wbuf[16], rbuf[I2C_SMBUS_BLOCK_MAX]; u8 cmd =3D 0x08; /* [7]:pec_en, [4:2]:func, [1]:start, [0]:end */ u8 config =3D 0x00; /* [6]:cfg_type, [4:1]:burst_len, [0]:address bit16 */ =20 @@ -151,7 +151,7 @@ static int pt5161l_read_block_data(struct pt5161l_data = *data, u32 address, break; } if (tries >=3D 3) - return ret; + return ret < 0 ? ret : -EIO; =20 memcpy(val, rbuf, curr_len); val +=3D curr_len; --=20 2.34.1 From nobody Mon Jun 15 03:04:24 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F392D27EFE9; Wed, 8 Apr 2026 16:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665910; cv=fail; b=qhzZGM7I1U5/TQOqUoMr4nMWL/b8JIoTodG+tBqVCYtbV8T7hPP16pcAt279DJK9HxI+ezKmxcfyxnRAAqQOHxY7QoGrmaiKiMkZv4mVZ38/qgcB/dubJgAtzu97s/GYu2aFK6v0BNPrGrlweax9jNO6AGMkCKnxGnXKZKUrdo4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665910; c=relaxed/simple; bh=xFVZ80iaHQKiVstOQAm88JboApvDwIzVMZj9FeRoH/g=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=AG9Ajn/VZZgcMnwU/JXBYA2MaY8cvW+HDCS64tpovp924vumt61tt02J5vTycHbt8nrrpOTa/B74MeWbcsMdK+PccWDYWHnnJkWQThDAyhGM4V9O9fRuQcbdXfeRX0C+4d0+OA+qSxx8k/osjyJJPCQ+736V40+Vm8hZicLDrp8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=Bg02+kQX; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="Bg02+kQX" Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 638G39vb1580619; Wed, 8 Apr 2026 16:31:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=po AhrdTIKYaqxWRBWLJStll6zaxfjxRWYtyC7iUC0Ns=; b=Bg02+kQXY4VWEEWCGO WRkDJzzNTeew5LJwrGCMOE9QmfJpZCSgr4XJ4ne8odfL6O4Bend7j5jrq6CCLIQC uGzE63zMkBm3uR0NcQwoyvRqQo7lD+4+UwddJBmSX907cHR2HH2TPmExqcLjquRk cauO6Jbfq2t3IBcotHJLv8m598yKyohKaFcxaOMn2+h6iX7JnXJqssqe/ZvIR0ed 3/QjRzjtHBWz9cdAacdBHf9JQF7G92npwE/mH3Nd51iTSnhwaEENEhcXSzPEIvJS EUG8p7eWGyugjYs+GdHBMCwZG1g5i0M5JlB9c3tqnO6c+azltqdob61vDYXqp99R d6EA== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4ddjtqpeba-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 08 Apr 2026 16:31:27 +0000 (GMT) Received: from p1wg14924.americas.hpqcorp.net (unknown [10.119.18.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id 4BBAB801709; Wed, 8 Apr 2026 16:31:27 +0000 (UTC) Received: from p1wg14927.americas.hpqcorp.net (10.119.18.117) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 04:31:19 -1200 Received: from p1wg14927.americas.hpqcorp.net (10.119.18.117) by p1wg14927.americas.hpqcorp.net (10.119.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 04:31:18 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14927.americas.hpqcorp.net (10.119.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Wed, 8 Apr 2026 04:31:18 -1200 Received: from DM2PR0701CU001.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 04:31:18 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LV9UlqDNDl4TP6pi8v3GlNJuyXbhh2mHOwzCuUcFmym0GgmT193TvLS/8AYIyytJSO2UOjEwIFjsUSUvyzNaYBzC2Eu2uKnHaVYTFs2jj7CYQ1UFfhNDC1l+/S705iovs5lGacifkuB0FPr0RKRzXqSU+yu2axjLcbHPNKyuQSpQIdTSW5DpB4YFtkB9fGeZmCBPQEXRBzFzKScklFyx5vJzxPijHYFH2eJX7jukvDP9oLPN7vAEL3YaI75uZkkLN8L79i8OP6BxgAZeXEhGevJGyf9A3IcO5xyHkmvus+TMWjE+OKyrMyxo+b1ehYD3x+xwNTYkLuclHCLUd5D9Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=poAhrdTIKYaqxWRBWLJStll6zaxfjxRWYtyC7iUC0Ns=; b=tF3lMREz+qiqCd7HIarX9nWDxGGF2vah/FcZ1zwURpGjtP3Q3nbGdlBQKKC2miKUZxsN7/atQDhsinE/0LxdSoxWMiHC/6ba5CEdcs0xOOGCW1vmaQolwNJhcVtyAUpc4BfaAGoTiHcqA2tB0PNp+8uhqaC0WsLKxjVWhMEGptpeM3P10tkHFo+1apt9+SLamI5B/eGx0LR2wzQXX0vODXHiR6OoVH48ixyFlSDKGh1lBACPuC1fv8bQEEAY0IQaO9DeRnLjYRH9SrcHjYkTECsa4P7gftB05sxo1IAFYeWHaZMUp8gVFLCCuQ5Vlm7rQiFIQYh0TbLod72tge9VZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3528.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:218::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 8 Apr 2026 16:31:16 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9769.020; Wed, 8 Apr 2026 16:31:16 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "linux@weissschuh.net" , "cosmo.chou@quantatw.com" , "mail@carsten-spiess.de" , "linux-kernel@vger.kernel.org" , "david.laight.linux@gmail.com" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH v3 2/3] hwmon: (isl28022) Fix integer overflow in power calculation on 32-bit Thread-Topic: [PATCH v3 2/3] hwmon: (isl28022) Fix integer overflow in power calculation on 32-bit Thread-Index: AQHcx3UfFTkQtKPOGkePRLU7GVTHFQ== Date: Wed, 8 Apr 2026 16:31:16 +0000 Message-ID: <20260408163029.353777-3-sanman.pradhan@hpe.com> References: <20260408163029.353777-1-sanman.pradhan@hpe.com> In-Reply-To: <20260408163029.353777-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3528:EE_ x-ms-office365-filtering-correlation-id: 5429282f-0749-4a22-07c5-08de958c41be x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|56012099003|38070700021|18002099003|22082099003; x-microsoft-antispam-message-info: WK9VcuFL7GisRc5ucpkM7eHT1Wx/mmLrz9BS8iKKrzNMfSK+yGaZ/v7ksWAsMrj9Jt7KqBk8pRjdl9+s/w4g17PlDzgGLDkRTbeOTLO74owACjLv6l41bYaEliMlokwfDjZEpXawj5eKJDvGa/OUrs0WcGk6fq6WFGLNgNbUuo4LvPnRmVrzh+HO2nmo8pegBPm8etLQWv7PtCPjoX0bNqCuKuWW+UWSwV3EvHNiw8YTXM1ic90mlhAQgCTcuKOeQ3s3cKuno1sIDXY7s6ifCmUnQcKbrp2LeAZSspTgNy9TOxRRZPzZ29zzRjy6VaymI9bFj5HgzeWiSjp2281L/sNKQcHxKJlDz2uo3Dffhzhpe0aD+NRnzoNbOxscZpQoassfo5DJHniXAsShE1FWmkrHsettxMdKdeyIOMm+YYvArYcnBchMsxM6KcXI+uRmIMk6caW01MofYlrR0cK9ZOs8+CNPJO8B1Au2vX9gIWb7xsD1m1j0RjN/gpKcxZiPUfc81ujNj1CVfe+Qln13QP5Dve8hSv++se7nJTUjb/PGOCSB+6LlEZuSeZpz9ZAIiN7Ezg6tgsCgKBDwwCZY2HtZ+ZDVwyyyCNH6YJaIQ/r2phM8+h09WHQ7HkzbvuIvT9Rm6e2zlESZiZRgr1FVmlHMeqUgxNyUZ9h7BQ6iidq2CoYqKnQEMR90VBmMzw+JE20RPHtrbfICPkVPJ5vYvPqvixkMv6Q8MHGUFdM73BygHHEN4iGEWpmflh36md2uIQUKHhqF75df97IxLNlVfLxEMXWYLTCasXiAxh7YdJA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(56012099003)(38070700021)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?j9dwOnzKdDFXR5fXHezFPGxKP+Cx5A0bK/uXxBYzZCO7ofdJSrjpE9jsxI?= =?iso-8859-1?Q?Cq7G4Blcr9kVomtmvKujXXLVEdVX+ylbzLO67tgVlcv4uucl9IUDm3d/M1?= =?iso-8859-1?Q?HA277XGtSkjPfDDvJGyvXojpfp5o/WgIBng8w0pYqbjZDyKdFrZE1vb+hy?= =?iso-8859-1?Q?oE1JsmP+X4ZtAHNWgbA/FLr/S9Qay1HBGY14Fe52wcD5K03MKv5c+BUFC1?= =?iso-8859-1?Q?iMKhY8wYnWqyr5aWmrAOkP/aO6AGexBg7O8fpU6wlJGDfnwPdyBu2UVtes?= =?iso-8859-1?Q?c97d+GbWqrE7tMvFHjfmzl2EF1SLcDMUttdmRTN3Jyyd9vExnpIHJ25GL2?= =?iso-8859-1?Q?VBImp6bcH8p39FpqUjgW4Fm3QXAIcqetm+ibYcisLWF3iKM6zNxftm/nxz?= =?iso-8859-1?Q?L16S/AeMR+G4T6VLrKwLjmQRaBhrEhv0yEu9Zmc+SbUfw+5TiXngQoeSLD?= =?iso-8859-1?Q?cHcxrwcS1W286YVMiW5U9opNksvm+ggosQhS2ViDso8TxLrQN8kjzfVKkS?= =?iso-8859-1?Q?+H3p2Vrg65MIMoeAxfIpGvrft/hUBfurB0EftEO8cbUptZpC8lb32uOrmG?= =?iso-8859-1?Q?u1G/Z6T42ycWpfcv8W1+9B1ncTKf9b4gCSz+GU933Lrg9eWuta9zNlsRKx?= =?iso-8859-1?Q?50QppNAaS2z6Q7WJQvOQfctIp+XCK+OtFdbMJclVkeaoNBjUJL3N136BOJ?= =?iso-8859-1?Q?868vq4jAw4yRdDjrMDsI6CHI767UDZgm78kdQIp/rewXEAjwGRdwIdK8hL?= =?iso-8859-1?Q?79nC7rT4tKp6kJoB6QtkaQdn4itMrj4eVfj6EimUKHO/ujAoqdtWib71xU?= =?iso-8859-1?Q?HoKJsrX7m41RZLVbboK7bQsJkFKhZjIEjzQtg1/wZZtFt2tHDgbCqP5e3L?= =?iso-8859-1?Q?1vtZu9I/mWFYELmSNRbP4mS5FuhWihlhqzAbpuwQqk8VgFg2F8Ci9OD9x3?= =?iso-8859-1?Q?x1ekjA32CjHLEd7Ll+7HyiaDWMOIk6Duk/I/xH6sCdLpq7tv3Q47vVVYMH?= =?iso-8859-1?Q?JboDJt/uNDbgJ83E9jCNjwIFDmpy5Ej5LEcrAy49Um4Nma6pw9SyYCUV+b?= =?iso-8859-1?Q?LltrJhS5nZJKVYy/AlYi97/QmAoiw4DjPTNl7GpQESj98cBCRGoJGPgtIh?= =?iso-8859-1?Q?nS9yr45nliIVzyR0M5dIBnRCMykRArF7iWD/gPnJDChtC4sgk0tBZ2VLMf?= =?iso-8859-1?Q?jY8vfzYZx+ZluEWSDLHkCkwMUJCgXC612w5NDaM6/ylnfr4IAKTgJO2cVa?= =?iso-8859-1?Q?AkgImwEBM9bQRZATp6iAlrCIf/q/Sm2GzlIxaipjrLHVAQ1626P7UUEwor?= =?iso-8859-1?Q?bl3R1LUgD50eipzMiMWVkhoTo2bgRlBj96A6n4CrdSlmkC4l/YjMCXBS5n?= =?iso-8859-1?Q?QfvY4RoJGBlWIidtn+M43DpYKXaZaMV116ETwXQa8IEuaKjYIvP5lYO8X7?= =?iso-8859-1?Q?RXU7Zprh7EBigqPau1/A9eKgkL+pdxNTHu53UYtdyhWY4D+SPzI3rEbbPD?= =?iso-8859-1?Q?FAmJ2EOM/7CYq9Jh9JVso6mCj+rWnNzHcdLW2vWwzhAqGMdUU8q7wY3Sgh?= =?iso-8859-1?Q?pklpCvxy5NBkyzpWnE1/ePvRerd9P/MBwbPdnmumJfhi51WkZ6EnkJPFyQ?= =?iso-8859-1?Q?bwGPVR6aK2g+F9LfVImu7yG+L0hAXR2h2lUvpINkZU1GldpAizdYrEncs2?= =?iso-8859-1?Q?rNH2Mz16NR+gvEXdxW8Yy4Bh1drr4MjGAnUMK0Rxrt2Tv4zyzdE8a7QRW4?= =?iso-8859-1?Q?xLKn0jRvuXugCov56Kh8pKE23F+B53hgmRpxqUoPtoxnxE9OyBj1BTPRS+?= =?iso-8859-1?Q?VtVs16YHgQ=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: oxfK2dPcFgv/3CKedTE15ZCAHJMji762rcLnPAbiNoQOcPD7JkoQVYwZRkTxFax8QkdptqzOihPt1rx51jZR4MYeQlxJzal1kROzxgv3Xg3k21JNjgkS25r9PgzRXgBoO5vVIEyu0eDJGOSHylcO+s0zJZDjSBCYU1h3YcKCZpDFfjDwEv7nVqJpGL41NVO+KJPpVyRyD+dE3xtPFjotXn5cpWQ5f8MdUwi4lTjDI8ryjY56rNPVety9nUp6aXjTDL4H/RRhmLcwnFkioqdEN3ptss+c0Q52Zw7YFXOTkUvytcvdx/y4Ul/vZ1lM/caf+ldYoPdwegxqq7pSVCavDw== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5429282f-0749-4a22-07c5-08de958c41be X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2026 16:31:16.4033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7P6ZKxJL3HNG6ONSiYTB7AjvDskrAkvDUzERLUVELeKkObzWtA0H7eBAL4JLJWdS06+g2p4FIspwk0FOjpCrvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3528 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=Ud9hjqSN c=1 sm=1 tr=0 ts=69d682df cx=c_pps a=FAnPgvRYq/vnBSvlTDCQOQ==:117 a=FAnPgvRYq/vnBSvlTDCQOQ==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=ZSrvDirOKP4VPF05hnFf:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=X0MvGafI_ScwdR0_kv0A:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-ORIG-GUID: DbEkgHZOZvWBdvwekBu5gFqNNOicAgpW X-Proofpoint-GUID: DbEkgHZOZvWBdvwekBu5gFqNNOicAgpW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDE1MyBTYWx0ZWRfX84SDjDwg4XOS RS4zd91ExsHQV9rp2D0n6J70Ib89X80hDoA5hnhuaBLEihLAwhud9cLiU5KR8Qm2zvw6WhxDPbE ZJt8kO8ERUTrj9lihOjzsEc2cXticfWlMHsP6Skvlme06Za0yhleMGti5GZu18zTUuA3A1LOHbg dcpcnNp6STaWcxD1kmZVOcgIxJ9CcWXviE+0fF6JoUfgXDwEbzvezlOIHVNb2gDuJPFNiyss7CH zi5Ifzse9mzOtYpnRocmn13xd02xFCufPMh5a+i13WvSPf5+2sHizSyns4V0q1oRuq6wNkhpRDu iYAapRjpPmmkkIMCjA10vJ89YXUTiPnDaqmPkUocMi4g3ZETJHOfDm/RJtYghS+G8cGyazvI9GR 25yPLwb/dl0SxaCcjf5LT1/mcH2J1FIIca/BwsG/jck6u77lTJCB30PTktKfF29lnKoaAL9HQqv gSVa59rh3/UkJ76K2cQ== X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_05,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080153 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan isl28022_read_power() computes: *val =3D ((51200000L * ((long)data->gain)) / (long)data->shunt) * (long)regval; On 32-bit platforms, 'long' is 32 bits. With gain=3D8 and shunt=3D10000 (the default configuration): (51200000 * 8) / 10000 =3D 40960 40960 * 65535 =3D 2,684,313,600 This exceeds LONG_MAX (2,147,483,647), resulting in signed integer overflow. Additionally, dividing before multiplying by regval loses precision unnecessarily. Use u64 arithmetic with div_u64() and multiply before dividing. The intermediate product cannot overflow u64 (worst case: 51200000 * 8 * 65535 =3D 26834432000000). Power is inherently non-negative, so unsigned types are the natural fit. Cap the result to LONG_MAX before returning it through the hwmon callback. Fixes: 39671a14df4f2 ("hwmon: (isl28022) new driver for ISL28022 power moni= tor") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- v3: - Use min()/div_u64() one-liner instead of clamp_val() + tmp variable, per review feedback - Add overflow justification to commit message v2: - Switch from s64/div_s64() to u64/div_u64() since power is inherently non-negative drivers/hwmon/isl28022.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/isl28022.c b/drivers/hwmon/isl28022.c index c2e559dde63f..c5a34ceedcdb 100644 --- a/drivers/hwmon/isl28022.c +++ b/drivers/hwmon/isl28022.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include =20 @@ -185,8 +186,8 @@ static int isl28022_read_power(struct device *dev, u32 = attr, long *val) ISL28022_REG_POWER, ®val); if (err < 0) return err; - *val =3D ((51200000L * ((long)data->gain)) / - (long)data->shunt) * (long)regval; + *val =3D min(div_u64(51200000ULL * data->gain * regval, + data->shunt), LONG_MAX); break; default: return -EOPNOTSUPP; --=20 2.34.1 From nobody Mon Jun 15 03:04:24 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD23539EF22; Wed, 8 Apr 2026 16:31:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665920; cv=fail; b=CvwWVaQvmVyzAjP9/J0ZebmBDqHe+lFsWAjfGubjZN//73gh9csGq74re12gd/bkSaS+BA4Z58i9A9M1c2BE4taGk7o1XWB/Pmfm3I8nn6AftyLwSKnq9pBVNxIoo0OWkzS2PnOLWdNHTg1haOAXsNuAnfvg9Y+K6nCeAFaoOD4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775665920; c=relaxed/simple; bh=3n/C9FGHYEyzOu92vqv9fd5xWyhnRn05dO0HH3Pgnxw=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=dGirOt8M8Ou0OK1tQ6cGw0fd5U2dl/uauBwDyHfBSzqNWJjxUHq8TDyvWMSYNHycZqpLIZUwQrkYPfg2Ilpr1XRqeAEeVzUNHPcqPFfNec75fzHkFtoT3CTxPFnPyGhEbumBqMJCQuXYxwS8cLcexLgFC81d3RCk497nUDYU2ok= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=P6nz9ni4; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="P6nz9ni4" Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 638Dtvwk1224631; Wed, 8 Apr 2026 16:31:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=qo 6xKbvtqLI2i6ruNRHXNC6J0gsCGk/R9bSrhKJX3u0=; b=P6nz9ni4bICnbh3iRJ E5i6CnaAAp/7qTdjUNguhcKpWHHBleD/n0ulzPR2kiy61M66umdh4rF1HLwgq9E/ MP1RKunq6SRPjXzMze6/e5vIj3m487fM0IaevoHBMa7nnfNrfJ1E9G80o8UpvKiO MTdJkaqJYIrzbrUMZmSkSovRpv7jIyzI7xzPwRVB4Dqc+yuaadi+UAHI/eiL31oz gRpfcey1t0Y9zgsgvtRog9eTIpMgMyQP5e5VbSqY+L2qSoyLoQWnoO+sNl4e6laa +a9tGTd5DwyYLd4+MpfbG6CRCzSk1f2b1gJadRCOvkBShrt2+NZX71qyBv3n7bKB DHUA== Received: from p1lg14878.it.hpe.com (p1lg14878.it.hpe.com [16.230.97.204]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4ddrb6t1jm-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 08 Apr 2026 16:31:38 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14878.it.hpe.com (Postfix) with ESMTPS id 65D6C2BAEE; Wed, 8 Apr 2026 16:31:37 +0000 (UTC) Received: from p1wg14925.americas.hpqcorp.net (10.119.18.114) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 04:31:31 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14925.americas.hpqcorp.net (10.119.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Wed, 8 Apr 2026 04:31:31 -1200 Received: from DM2PR0701CU001.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 8 Apr 2026 04:31:31 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oGxbp34sxSZ6pcfuPHMKIGTZIQao9wBVth5CtomQ8KobrE7mu2+ElzbpjQ71LG2in38O049gw2muxx9gKQKAlQsXook7QrPd/TU9qIvh8jwx2/hUayl4YlBrswQadR+7Cii10qbSJJdZ7le4l59YPH1dEjy/FzyupM8/a6Rbc+yIDWqmb9LQTSP1uHEcGc+oaKqTejTO71pfl6H66BwbV1aP/L0EWhSOgchdF64J8CUnem1HEVY407RR90Scvwsk9WhG2mPXryCZSovSj54o0xXSnkL2A8KjMiCNzhNMkQzbELZi43jj9X9FkD04RPtoZFcpYRViGPr2k4e/a2HTTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qo6xKbvtqLI2i6ruNRHXNC6J0gsCGk/R9bSrhKJX3u0=; b=AOQNP0SMwPbhKDToMCRMhJ1IFwqZXy9E4P8edtSyt9s8LsCOqp+fzphpY53CwYbM0ZhVuytphzC3PHCy9R7JFI7sMsQomFCxl4cqi2X1bqbtJT5uKNj7tPfRgSl2H/WaQatoml6WODanuqS2gaPPiFTCxEpB60wSsB6I0nMPx//nPFIDg+vVcIbP9c2R8N8WEHpoLE9KvPpBlh0yUNewmmdeqI/xlpKGVICCxDJd+EYXL8N6CotABg6Ld7DKMoQA/RsIsp9+0Xv/c0Cs84XvjZJYa395P0rtKj7Lm3gtL5L8t/ccMDpLl3qnOTXwjH+aM1eqaGoz8lONMjsLK0g16g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3528.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:218::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.17; Wed, 8 Apr 2026 16:31:29 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9769.020; Wed, 8 Apr 2026 16:31:29 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "linux@weissschuh.net" , "cosmo.chou@quantatw.com" , "mail@carsten-spiess.de" , "linux-kernel@vger.kernel.org" , "david.laight.linux@gmail.com" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH v3 3/3] hwmon: (powerz) Fix use-after-free and signal handling on USB disconnect Thread-Topic: [PATCH v3 3/3] hwmon: (powerz) Fix use-after-free and signal handling on USB disconnect Thread-Index: AQHcx3UnU57j69vQ5Ue3LSgtWHKflw== Date: Wed, 8 Apr 2026 16:31:29 +0000 Message-ID: <20260408163029.353777-4-sanman.pradhan@hpe.com> References: <20260408163029.353777-1-sanman.pradhan@hpe.com> In-Reply-To: <20260408163029.353777-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3528:EE_ x-ms-office365-filtering-correlation-id: dba92dd8-50b4-44bd-a278-08de958c4996 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|56012099003|38070700021|18002099003|22082099003; x-microsoft-antispam-message-info: g+NpqxGlScsCXlztUr2wPfPQ5wy8mdq5JK20SR7DFN2yORrd7BNLzrW+SUM/biPTY6nAbvpPKvUscqbv0tKnJ8hfXQT3dKLn7h++NneD37PkyXDtynRvXR93X1mSA3j2jdtZj/YEBhldxqarhvP1FMIatx3xr7gvfzNF0KyBZJ+QkHbghbvOoUXOHZvIJqFfFGhfZpE2tifY50qZv+xvOqMJbCk23MUuTd4BwHiwhFKeIFcbzcmuLe0NgOYoMepKjm6kKaZDhcjiMXUltL+d1rffg4+TLFKBfyLi9sDzCr9tyD9Z3lS+2hHMpFug50KMzX9tH41tc/gFbw2fP65x3FS1vwYPh7ruH9McL4c5eYx0C+rStoPuO4YfxFQUugMv2pru0jr9cRBSs+dOuRt2dO+lwdEupC8r+clFqnlAkGQouUMexxyZlLoxhsFL543uuRIyMSax9u/6kBHmcp82H5yRYFKKRc5/uQZ0RSGkf14l4p3LJnc3iNIEAh0+x8fd2KOBSpoiAJ6sBiKGupr5vg7fidGY1ClzFg7LoGjNR09PKkDvh+DYaQQK13JqAbeCkIOTFy+1qX+KHKlsmwtWxvHyG40L7BA3TdvGkJJmOCkXh/z+7bKo+ptDdxFUj3c8AEtrkJRSBnhlBRFwlEmkBkbh/UnW7UHRmHc4yaNjAmrGI49YnC8D198Ya3n+e8CqA/OGvgLZFl+i0lQ9blWKH3p1IWK+EK2x+zfHjhN7JmHNP/FLIKNPXtKYb5LWQ2CB6kiugx9umsLatpKim3SStNJ19Qs4Y5/daYwxjzkEBrQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(56012099003)(38070700021)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?nrx0ySBqsAZVHoBVYLe8AeUhwRujRCuztazVt1TNYG9HP1txPSsUq0jKjj?= =?iso-8859-1?Q?me2ccjaC2b+KL7c9e8TOzWG2JYk3Fq2htKx16/URlbVIwTh9Bie/Z5M3W+?= =?iso-8859-1?Q?FEcM/L5GhKl2gTztVIs5fAbC6DYSkgTlxXa9TKg7WTTJSxL7XRSKiRp3Ag?= =?iso-8859-1?Q?iEzeLLYREOT7HssjMvIEf+kBaIDL4hgiSKpuGyfbbwDmAzosQTMD72fMg2?= =?iso-8859-1?Q?+RPxhg5fMfXCgpx0Pb6wl7eFS6BUUCSlxLsIZg1/gGSxlyZvvIn9Nhn9W4?= =?iso-8859-1?Q?FGx+LL8o7IwAQWO+4rlGVKnEQvskSLDGKNCziFFOOjkZv6roFuYyPB3He8?= =?iso-8859-1?Q?y9dlRwfFwFuiel30SRabIPhXwLtk4f2Ppavl6bXeNhw8GeCJ4DeMOybYzq?= =?iso-8859-1?Q?Ulk+ryB9oxXJ4m4CUVL7rA6FDKLGrkmiP0Nd38p9NT00kVs1WtBefPoQR1?= =?iso-8859-1?Q?mXDcbD3hEbLyUD6mPWIZR03phpc+JinXNT14C0zakrcBwtAu9s13qy1n4l?= =?iso-8859-1?Q?z9qqsHRoVy7+UKVj8hjIX/1ta7PthILInWG15vtYl2C+CZjbkASjKVhhbf?= =?iso-8859-1?Q?wAokgck7VYnjr/J25KG2pCHbNmvO4qsa2QmgYO7Fy8tgK3aFG1O2ySp5hI?= =?iso-8859-1?Q?STEWl2C1I9dMMt1dLRdy5r04W4keRKsNgmvuSc9SCir13ocp/GBzzqOrGC?= =?iso-8859-1?Q?r7DG15fIyY0MzG+Uo9786VsmqUj1lxUid3u6mOBtRmC4rWhFMFyOriqAou?= =?iso-8859-1?Q?i1anjag2Nmw3A9QCqvCF3pPwL0ydNm7pbTtfQ60sMJDolIzRh7Kwl4OX93?= =?iso-8859-1?Q?iKewqTzlJk1UL/c4N8e7uPlBwhVLGRQpxS9FZeP5rmdJnm7QVGeDa4jR4n?= =?iso-8859-1?Q?EALjuLPOO+fSItzVpQo90u1zg+4DRMw6pbG0Cn7bzgL3FRw4cpv3lCmefe?= =?iso-8859-1?Q?G2rtCV0pqcEOeFjN5E7VYU16ylJWOvRvblCQPEujteyEhJgOiIg5ApEveY?= =?iso-8859-1?Q?eiwzDzcR2O1lrvcuFwzg3Ti9XGqA89035BbKGljC3b9AXqndS/vQn0wjvc?= =?iso-8859-1?Q?hm8Fx4vJd6SZgr0QKJAsWqNXlyilRzHrOSMR1/agZzfkydEBhiyTyHe66H?= =?iso-8859-1?Q?wfP7aOm0kp7mbUqKK0sEasx7uxZFeUC6XDSoAXbnAwdEBIxOxaHuLYnriY?= =?iso-8859-1?Q?UDjtzjfHznFbDYLOCv61Ir9JaBitfsVneJGTZbBN8SbicCPvUUAF7Rr8MJ?= =?iso-8859-1?Q?xiT64I/hVd/2mB8HU/5xO3G6EqXcvAidvEqBy+UFsQnoqwxSvriG1spDzj?= =?iso-8859-1?Q?xoiPzaYdG21rpUWQ7tBc5IYmrY0BU2bEhe6RJ4mPqB1x12uuxBptVs8U3y?= =?iso-8859-1?Q?s3tyBgjWfWKogCdvVa3sEDLfRskIIWcyd7/wjcX0I355fIK3mQszK0aJu+?= =?iso-8859-1?Q?s0dmzCS+Paf0WixFFqH3wL8pvgtE1erBpHKzPX9hYDAkcQXoECkDYP2khS?= =?iso-8859-1?Q?Fq36BLbFWzzAl/NMohLIPp7ppd2+bjPmY9RpJcEsVeH3b6PY7UqAmjlWW3?= =?iso-8859-1?Q?kYkBFSDstH134yhqtM6I/l5fYQ2iUktzbtsDbaJY27kWgIFX+Cjk7a/bMM?= =?iso-8859-1?Q?gCLKN/aPJ1aYJedEsMNs2728aPYCRNiTdSOhEZrGlJ3RP+rzB1yGH218zW?= =?iso-8859-1?Q?tmiFN8++bjaUVW7uHQ2ep7hgx2z3zCiQlQQ52ocMEYSC3yteGNyDz2Jncm?= =?iso-8859-1?Q?qgZFqXH1YSomw438pF2RAyNu6lM+bqQBPDpHE2XX/FTeesMwyUYSCUFBSa?= =?iso-8859-1?Q?fdL+8x3fmQ=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: mQTLqJzgxDPf464EsaEEISyCD5DVECSXLrJLc2/yh2FDi5ZLrL3+YJp+Ov/R5L7Ch5QtTxMXkq9o2kKRRCcinJQVMKqzQyoEBSIHWWiNtE9PXfJlYQRbGSpSKfBe2aDrBE16vH6IqSiRpFbx4YnJnHEnn/NVIUL7mEPapg0zemOjcXqr+p9ArnQ/4OUoRvqwlx0SJ4KqKFMxW9v35So3uJiFnOoXaVoozZpufDC7kGU11qjW+SwGJbUwN2g3pXxmt19vyaRURLENp/XyxhELSWdgNcfyoobt4I9T0skdyv+eD3Xs3SzA1Q/25dhOVGhN4d1bW3DxW0MXYt+StSYTGg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: dba92dd8-50b4-44bd-a278-08de958c4996 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2026 16:31:29.5567 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gFalrsRubcrQ7k2L8V2L/l77PDKolr1Nt/ZWZlh7ADJcCsb539Y7DFo2MkqL/CHAUEkimC6NYZd6V7GBTwMwjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3528 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=UMLt2ify c=1 sm=1 tr=0 ts=69d682eb cx=c_pps a=UObrlqRbTUrrdMEdGJ+KZA==:117 a=UObrlqRbTUrrdMEdGJ+KZA==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=g3u0LPWLDYfGfufhFw6-:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=BpGXxSgqvIGdrXJJSgAA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-GUID: 6g6qkVVLouPVTmwHUHubS4IXTntlQEYE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDE1MyBTYWx0ZWRfXxNliPQbWV5DR UTmfvhK/9nAkVgtzGQzlhWqT47zrUvqAoGXNDz/4GAs+tUgcD/OIKdoxAYpZ7f8j1xoRc5zRnzY MIy1SfLbGU0h1VnqKToGZkrwmfKeb8hltS23uheMfjrYs3nW9Dpb5qW4qhovzyCEWce1xiMe2hp fGIAReInxjS8UApl5PNuQdNwD83k/tdPFty3nlNxPeemf9e63w+VvhDD5JC7xqDYFoPIjHx9oXF RLABekldXcW1tdLv5lI0as7WJdNUrrEPv51Upfaj+bAGi+4i11wKwTm0nUWL/HOZFaC5AWxL3Oj haSVX6y8kMf0j3zOpyuti6GOG8SEVRt7NKTgIGwtcgDntnR+cumGHrratvBULxEU7JgBk9AKN0t j+H9c/TxSjqvMFZTTVEh19strYgGeBGuaHPSw/M6iFJUQts7M/ot9+9p8XU0+kKhHCOna2ajH1D SBS3NODU+wMuy9h/oMA== X-Proofpoint-ORIG-GUID: 6g6qkVVLouPVTmwHUHubS4IXTntlQEYE X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_05,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080153 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan Fix several issues in the powerz driver related to USB disconnect races and signal handling: 1. Use-after-free: When hwmon sysfs attributes are read concurrently with USB disconnect, powerz_read() obtains a pointer to the private data via usb_get_intfdata(), then powerz_disconnect() runs and frees the URB while powerz_read_data() may still reference it. Fix by: - Moving usb_set_intfdata() before hwmon registration so the disconnect handler can always find the priv pointer. - Clearing intfdata before taking the mutex and NULLing the URB pointer in disconnect. - Guarding powerz_read_data() with a !priv->urb check. 2. Signal handling: wait_for_completion_interruptible_timeout() returns -ERESTARTSYS on signal, 0 on timeout, or positive on completion. The original code tests !ret, which only catches timeout. On signal delivery (-ERESTARTSYS), !ret is false so the function skips usb_kill_urb() and falls through, accessing potentially stale URB data. Capture the return value and handle both the signal (negative) and timeout (zero) cases explicitly. Fixes: 4381a36abdf1c ("hwmon: add POWER-Z driver") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- v3: - No changes v2: - Also fix signal handling in wait_for_completion_interruptible_timeout() - Return -ENODEV instead of -EIO on disconnected device drivers/hwmon/powerz.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c index 4e663d5b4e33..0b38fdf42ddb 100644 --- a/drivers/hwmon/powerz.c +++ b/drivers/hwmon/powerz.c @@ -108,6 +108,9 @@ static int powerz_read_data(struct usb_device *udev, st= ruct powerz_priv *priv) { int ret; =20 + if (!priv->urb) + return -ENODEV; + priv->status =3D -ETIMEDOUT; reinit_completion(&priv->completion); =20 @@ -124,10 +127,11 @@ static int powerz_read_data(struct usb_device *udev, = struct powerz_priv *priv) if (ret) return ret; =20 - if (!wait_for_completion_interruptible_timeout - (&priv->completion, msecs_to_jiffies(5))) { + ret =3D wait_for_completion_interruptible_timeout(&priv->completion, + msecs_to_jiffies(5)); + if (ret <=3D 0) { usb_kill_urb(priv->urb); - return -EIO; + return ret ? ret : -EIO; } =20 if (priv->urb->actual_length < sizeof(struct powerz_sensor_data)) @@ -224,16 +228,17 @@ static int powerz_probe(struct usb_interface *intf, mutex_init(&priv->mutex); init_completion(&priv->completion); =20 + usb_set_intfdata(intf, priv); + hwmon_dev =3D devm_hwmon_device_register_with_info(parent, DRIVER_NAME, priv, &powerz_chip_info, NULL); if (IS_ERR(hwmon_dev)) { + usb_set_intfdata(intf, NULL); usb_free_urb(priv->urb); return PTR_ERR(hwmon_dev); } =20 - usb_set_intfdata(intf, priv); - return 0; } =20 @@ -241,9 +246,12 @@ static void powerz_disconnect(struct usb_interface *in= tf) { struct powerz_priv *priv =3D usb_get_intfdata(intf); =20 + usb_set_intfdata(intf, NULL); + mutex_lock(&priv->mutex); usb_kill_urb(priv->urb); usb_free_urb(priv->urb); + priv->urb =3D NULL; mutex_unlock(&priv->mutex); } =20 --=20 2.34.1