From nobody Mon Jun 15 03:52:32 2026 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C18E37F73B for ; Tue, 7 Apr 2026 22:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775600140; cv=none; b=P2/AzEoFa67/DJiSTiY34Cfvsa7yLcgy1/H7Eq8DaPIDy2i8Gy7umDW6ZZ8zlETFP3/JS6BcyxkQThQBz2mOXc6Bhx2Ztn+sxp7ImCfZWSjhUEflvDWuyTTahOXcFbC5Qt6gHzvDmOuO0DLW96RO/ALZ/a+lQR0Om0IS8yOaEKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775600140; c=relaxed/simple; bh=Brbd0a0BybC/brQQ4C85GAHNIG8AVtq/UF8mJOCDY64=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VpzSmby+G2pUJ4xWYLZAZgLra7WMEyZWmXsqQrBU0lxbUa90XMDhBnexWr82rxhPBVu8V7I3VYbk/mY7Obaf4uPhvBN1YOafW9kr2p7a091HjcrVwOBYh801k2X76V5WKBdwzhDCPJZsKfRxytRZ2Lk4xgLUoD55X/do2UwcXlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zio7D+me; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zio7D+me" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-505a1789a27so29791081cf.3 for ; Tue, 07 Apr 2026 15:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775600138; x=1776204938; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y+hmC6Or4+fAjdiMPYIn47F9W3NDLyREzEC4/7QicQE=; b=Zio7D+meHAb4XfBssU8FUYtiM89B99QQ4hbKCbVLx6vbREktHU4rRZ3sqKPJhDkJSh Uqe8Jg98g0K3TIOYdWwHeciQrzI8ChrGdFZvBjKtFh1F0DNbV9HUZgFjtAia7+RFeYcP o+tVth9gb3RvsGpFzvim8Ojubhj9cfO9KAhgeAdXNOR7ZE4kNO0BaUaPUB29PgkVzmww FXAIUQfIvsG+rMz9aU+z02IMV0S8N/G2pmVli98SkdPC20pLeBNIwNTrdD0l4+6sd/9s PugS/Kah+eAH4N7jna/c2pPzmzvyvRtnnOc08ML1v7KBIeBDsRgEnpzggXw35pFv3D8R L43g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775600138; x=1776204938; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y+hmC6Or4+fAjdiMPYIn47F9W3NDLyREzEC4/7QicQE=; b=DvLJLKYvBpFNw+h22Eo4m6SkRVLc38t1Ah4GyhvxU3RmchiqNYgsCUvssqieiXMpv3 WHL8BOKybooQfiE8oYxiL0B8lpKsQ9QQH5zJP9EpdWWVR0Ww6BJjFNZkgrXUnI+3LWd/ hCK069SEgpLebxrDoMgKFfaVcgqSL4EEmPFkpswi9nWhWtaNjUbfN0R5QYctuBoAF3k5 g+txcWeaDVX5G7hidTIYFFH79OGCnViZi9w1zzbCMEzWreAmH20OK+u/LKA2zZMxfOdw 7wB9bQ8ofzM6OOgz4yKJGNzObdLrUhXI49/2hWim09rn5F4RvLA2RKip88bVIZJOjNZa oOoA== X-Forwarded-Encrypted: i=1; AJvYcCVowovYtMoMEsUX6YXmIZa14k0yK8PQEupU/EwtjQdACE2O97+CIPY1J1zvaGSRCmxRb/xy7Xcz1n2Ud9o=@vger.kernel.org X-Gm-Message-State: AOJu0YwC90g7Zt+KWhNiy8K6ex2CchCNXSq+tSxdLGBvjo+APxzjKMT9 OGj3l5jdq5HV/j9+6gsj3brClqNud0STvRZP++tS2N5u7SNeTJATOpDu3hS2+g== X-Gm-Gg: AeBDieuzQCNDYOVcIbtgi0Cz3WVUzCe5y+sNRyomVPHQNHvDnpFwoaT77zT57F2I/jj mt2KBrWxtuxLpz6DcSc5xA2M0bqkzv2p59+DNusOsvVfezuYBOgdZXhnj0hRUQCEbStxZFmJbrl U5lcH0E5ZIqqeI4xHqioxe4nXzuXuqfzkm+N2i3wsibV0DsQI+l6SLLO6ewSk/v+27dRkKAEPIy grT3yKl3cYbZNiOa41usmSZotsoMWkcTA3Fawp7lfewIr8zL5xRzMXdo3ibuX4b7VaHry1nfPSi dE5GU9222NLb0S0Y2tBOMpH1odnpNSuDa2rBhxMcqXiCZnaaVxIMXi4YwS3fAPdwCL9eAVlxbxZ +2Nj8RgRwazdm0isjoPocB/JXrav/j81qpEXLioVGHGaZw7Hr52mX3pmQ6rkquvf72ljukw6A9c wjQlAnaT9+WCyZEf+H4aXDiFkMTaUc/eYZbyoSe27AYa1TUscrY0n5QjA= X-Received: by 2002:a05:622a:a9ce:20b0:50d:b084:588a with SMTP id d75a77b69052e-50db08458e6mr19280781cf.42.1775600137792; Tue, 07 Apr 2026 15:15:37 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50d4b73e7e5sm145380941cf.17.2026.04.07.15.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 15:15:37 -0700 (PDT) From: Rosen Penev To: linux-arm-msm@vger.kernel.org Cc: Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] soc: qcom: wcnss: fix leak of fw Date: Tue, 7 Apr 2026 15:15:19 -0700 Message-ID: <20260407221519.6824-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kzalloc_flex call needs to release it, not just blindly return. Also move kfree up as it is allocated after fw. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202604060902.awXdPsBh-lkp@intel.com/ Signed-off-by: Rosen Penev --- drivers/soc/qcom/wcnss_ctrl.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c index ffb31a049d4a..942e11feba65 100644 --- a/drivers/soc/qcom/wcnss_ctrl.c +++ b/drivers/soc/qcom/wcnss_ctrl.c @@ -221,8 +221,10 @@ static int wcnss_download_nv(struct wcnss_ctrl *wcnss,= bool *expect_cbc) left =3D fw->size; =20 req =3D kzalloc_flex(*req, fragment, NV_FRAGMENT_SIZE); - if (!req) - return -ENOMEM; + if (!req) { + ret =3D -ENOMEM; + goto release_fw; + } =20 req->frag_size =3D NV_FRAGMENT_SIZE; req->hdr.type =3D WCNSS_DOWNLOAD_NV_REQ; @@ -243,7 +245,7 @@ static int wcnss_download_nv(struct wcnss_ctrl *wcnss, = bool *expect_cbc) ret =3D rpmsg_send(wcnss->channel, req, req->hdr.len); if (ret < 0) { dev_err(dev, "failed to send smd packet\n"); - goto release_fw; + goto release_req; } =20 /* Increment for next fragment */ @@ -262,9 +264,10 @@ static int wcnss_download_nv(struct wcnss_ctrl *wcnss,= bool *expect_cbc) ret =3D 0; } =20 +release_req: + kfree(req); release_fw: release_firmware(fw); - kfree(req); =20 return ret; } --=20 2.53.0