From nobody Mon Jun 15 02:49:00 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CCB03B95F6 for ; Tue, 7 Apr 2026 15:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775575858; cv=none; b=rFPsZBhYqQIDBByHI0gJiWAUZfk9o/7Vnd/uSCvOO2eXEcty4X4eL+kCmhlPyYSt0QS1KONTRE7xvwn4gpd19B2YeI6rbSzOi9pM9QpNazD4JQhNqFMjRXZfjmDmWK4EVJ588en6x8VazbpTQXG09nXmAxR3VuNZbW28AnsJKWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775575858; c=relaxed/simple; bh=1Xp+62DiUcMfJqeOeh+oZYuohOQO3PU96P0xnZmJ9Vk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hjFdObswrUjj287RhtqZAkhoFqDK0+eUeN72S9RcgNEyCNYJRPa/j+iBRSQrEPq6wzx4hA2PpCdRLIkp00h9ZlDy8uiutArXmKgEO42zasYj9ntHB+sR8S0KUPrhrXE1YtsemugXSw01AFY0QtUx0ILgexSJABwGSGV/BC4Nmxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=stellman-greene.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r8LeU0kw; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=stellman-greene.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r8LeU0kw" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-8cbc593a67aso526383085a.2 for ; Tue, 07 Apr 2026 08:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775575842; x=1776180642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=xj1RMcD5P1v00Sk4zJQOR71jkNKkfRo/0356gp351HA=; b=r8LeU0kwYJrEuj1wy/sCEe/SqKjq0RuGGPUJaoX1szP2TCRWHAXmIR+ul2t2UtNSTZ 5llU5iKGTVDZ1sS7sgaV3zEcQxWAEZbdrcOBiEIfYMfv67xIltYRgl8f5n49xvheeDMS HtYKFmDpytqJkxMTcfwOYrnMiXp2hIsHZJ1zh8TOrTrCTWSPOw1RuTP5/47b1rnPVxtU uzrC8pVGqZeG0cYrOeQibL+I4zdGYCddWXCeGfjkhM5eBlNWkGcoa9u5tHs27LDKsz4K o242vHavI5F1x5TiV3r4QuX1uXzpYSarmdkRMKy4wM87Hc0fEHeeovg1KefOYLLX2JV7 KDIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775575842; x=1776180642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xj1RMcD5P1v00Sk4zJQOR71jkNKkfRo/0356gp351HA=; b=I7h3WN8k8uYWKlOqU+KrpGx457rZa5Rq6cOjGS7TscaxXluuQ8fdvpt6tnsNCJMo7N vTnbi4OPxsbtwX0fS5Op5Ho92KOSoooSXNv+ZYQmiOnchNCIEQ35sOHlt2j0YhMGaW5L PBMiMpNtkDJRMmKAU2JphwXX/29v12oN+PVTK8Dkp0TZH7pWBx27xNs+3gsvKUgvmMsz vsU21fDLDnsjNaJfCyWhvN1EnUry4WOkY32aKuG7RoEsoReUQkG3/mOHWvSQZ3KxZN4A VRoRDEe3n8PcsLI41V+vqeh713dmF0ESZPtmHF2m79wr+c9+YBv2fGR1Y3kMpcWhUMI/ burA== X-Gm-Message-State: AOJu0Yxqg8CgB51UNiEFoOH2UoSe6iSUGaSignGYhvYTiE4beWI8ukrP m5cdZvHsYgga5ABNWa72Ccj015UOeBk/ddvtijYYaNx/ZwgMrTnKu5HTpWavpA== X-Gm-Gg: AeBDiesIoprs6T8ZGGrqVpwcjATDrY56RV8UwCAyk6uttWJ23y1WbVyWX9RDLEd3kEo G1DuBPG7Dneu1dc6welJzAO6B1Mn1EPmu3E5LOLQwKmbakIDFcIy+p0sda8Kq71q1yyePWOu9LY edBrW8SvXyP6xU7Xs9YtXn2XFo8FyQoS0ZUSRJn3z/Y29isNhBdznVaE006eW6gRWx2bADLAnhl zRl/oL5tyQSd8CjqDZ2CfgjwlMBGMj3xzFab792oo4lEkDTSi0Oh5bQlmC6gEkFX9XL1/j3QOEY WGRTOUB0mpHfSx8ZobCt5WThTsxMmqhgfyxwpYxFtwvryZ1py4iNStK4Dwm1ukULmdxoLGkGfOI C4piAmYZHDpdtoEMb/NfjagW1Kj0VBIUXB0X/78BaUKEiIPYh45kZxRFZnLnZD2LhUT0ZpVidsB SIz25CUDGfKA0wzuZfL7Cl2aurb+VQWFUZ+dT3Gbx0R4MD+ouoxo3AzWUVJFNEQm4zFDjWjzKiw ouA+jtgJ/oZEkcSDnr9vqRcaxhuVpXdsqKXqCGALmRoVPooKhs6sY7iVpMobFnE+PkSy4lAQlav LGegwSCedfRJADGFtbKe X-Received: by 2002:a05:620a:370e:b0:8cd:97de:bb52 with SMTP id af79cd13be357-8d41c5a6f10mr2555418885a.22.1775575834410; Tue, 07 Apr 2026 08:30:34 -0700 (PDT) Received: from localhost.localdomain ([2600:4041:5c46:7000:d80b:4b87:c7c8:bd46]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d2a5392d28sm1257154585a.5.2026.04.07.08.30.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 07 Apr 2026 08:30:33 -0700 (PDT) Sender: Andrew Stellman From: Andrew Stellman To: senozhatsky@chromium.org, minchan@kernel.org Cc: linux-kernel@vger.kernel.org, Andrew Stellman Subject: [PATCH v2] zram: reject unrecognized type= values in recompress_store() Date: Tue, 7 Apr 2026 11:30:27 -0400 Message-ID: <20260407153027.42425-1-astellman@stellman-greene.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable recompress_store() parses the type=3D parameter with three if statements checking for "idle", "huge", and "huge_idle". An unrecognized value silently falls through with mode left at 0, causing the recompression pass to run with no slot filter =E2=80=94 processing all slots instead of t= he intended subset. Add a !mode check after the type parsing block to return -EINVAL for unrecognized values, consistent with the function's other parameter validation. Suggested-by: Sergey Senozhatsky Signed-off-by: Andrew Stellman Reviewed-by: Sergey Senozhatsky --- Changes in v2: - Use !mode check after the strcmp chain instead of restructuring into if/else if/else, as suggested by Sergey Senozhatsky. drivers/block/zram/zram_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 8ea2a12..67dea80 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -2552,6 +2552,9 @@ static ssize_t recompress_store(struct device *dev, if (!strcmp(val, "huge_idle")) mode =3D RECOMPRESS_IDLE | RECOMPRESS_HUGE; + if (!mode) + return -EINVAL; + continue; } -- 2.34.1