From nobody Mon Jun 15 00:11:48 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA83137F743 for ; Tue, 7 Apr 2026 06:16:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775542577; cv=none; b=AmVbpJXyh+wTdFsN31XIv0MReY+3MGCrfGFbMSejq5S+3Jyec0oKblnz9BLKEYiYVx3+Jh77RBVGXpmBDOnCtAxYd0axVWcLaNjkdXWYPN/cBuLEzsR7ZyVmlN7u/pgFcarzG5y1oR+J3KhQva4t/pXdQkqvjnDht+NU3yxBMPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775542577; c=relaxed/simple; bh=NTyKGslQ3b9P0KhAkuySw2Y+ibMjDkrKJFWk9c2rBSA=; h=From:Date:Message-ID:To:Cc:Subject; b=Thh6whDRHornc9o8YZC6Lum+bYVDdAA8Ss2ByjFrHCo5XPwxh1bf8EoQNWXmE11onfQc75f76xdw+hZsak+SHlOmUUVjLrx7MMK+1eIqgPZTcksKPK2yy9ZjDNT9WY9Odpnydl/XpRHCa8VQpOTZgDLrs5dBcJVWtMsb5BUJtU8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from 0001-powerpc-pseries-energy.eml (unknown [111.196.245.197]) by APP-01 (Coremail) with SMTP id qwCowACnT2slodRpxuh7DA--.48957S2; Tue, 07 Apr 2026 14:16:05 +0800 (CST) From: Pengpeng Hou Date: Tue, 7 Apr 2026 14:09:10 +0800 Message-ID: <20260407153003.3-powerpc-pseries-energy-pengpeng@iscas.ac.cn> To: Madhavan Srinivasan , Michael Ellerman Cc: Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] powerpc/pseries/energy: validate H_BEST_ENERGY list counts X-CM-TRANSID: qwCowACnT2slodRpxuh7DA--.48957S2 X-Coremail-Antispam: 1UD129KBjvJXoW7AF1UKFyDuFWUCF1kuFWxWFg_yoW8Xr1UpF Z8KFZrKF48Kryxt3yxtF1kGryUu34DKrW8X3y0ya43Awn8Xr1FqrnruryFqrs7GrW8Gwn3 ZFsFg3WvvFZxAaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkv14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWUAVWU twCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r 1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij 64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr 0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUhtxDUUUUU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" get_best_energy_list() reads a one-page u32 array from H_BEST_ENERGY and trusts retbuf[0] as the number of entry pairs stored there. Counts above the number of pairs that fit in one page make the loop walk past the page through buf_page[2 * i + 1]. Reject impossible entry counts before indexing the returned buffer. Signed-off-by: Pengpeng Hou --- arch/powerpc/platforms/pseries/pseries_energy.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/platforms/pseries/pseries_energy.c b/arch/powerpc= /platforms/pseries/pseries_energy.c index 2c661b798235..575216989539 100644 --- a/arch/powerpc/platforms/pseries/pseries_energy.c +++ b/arch/powerpc/platforms/pseries/pseries_energy.c @@ -184,6 +184,7 @@ static int drc_index_to_cpu(u32 drc_index) #define FLAGS_MODE1 0x004E200000080E01UL #define FLAGS_MODE2 0x004E200000080401UL #define FLAGS_ACTIVATE 0x100 +#define BEST_ENERGY_LIST_MAX_ENTRIES (PAGE_SIZE / (sizeof(u32) * 2)) =20 static ssize_t get_best_energy_list(char *page, int activate) { @@ -208,6 +209,11 @@ static ssize_t get_best_energy_list(char *page, int ac= tivate) return -EINVAL; } =20 + if (retbuf[0] > BEST_ENERGY_LIST_MAX_ENTRIES) { + free_page((unsigned long)buf_page); + return -EINVAL; + } + cnt =3D retbuf[0]; for (i =3D 0; i < cnt; i++) { cpu =3D drc_index_to_cpu(buf_page[2*i+1]); --=20 2.50.1 (Apple Git-155)