From nobody Mon Jun 15 02:50:26 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 875A5224B04 for ; Tue, 7 Apr 2026 15:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775574735; cv=none; b=JSCgA9e4ArIm3lVhjPAvADmeN7LM8ldIPfJoY4Z/4MmwRwt7ZBHebivwHyiyHLrp/EosU6xTQy/r7Z87A9VVHngSHwiNn6t8zoHp9YZzOlA1ji7tXcsQ+Qq5tRM4oL7UnXxf5gTCiwFNM2OV7DLptMEe8JqYQrj0bAWQfYcrwtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775574735; c=relaxed/simple; bh=4dHH0h7811//j5T1In6lxiOLE27Lvcfag5EAV+NB048=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HYWTXM/xYeS+7Zf6CUOef51nsKOX0qFYNVq1HBLYVifhWcmr+vQxN2ndLZQrsTaeBAxXTfW0CMBAUVTTbDi3C7imqqequIBoKkiDzxwVIJdqLdxXyN2JR3S7QcrHXZ+9B4QMRUKYeHZIZvGcEcP9LHHORgrrWqvvDophMzLbr44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n2eN9FZw; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n2eN9FZw" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso22579755e9.1 for ; Tue, 07 Apr 2026 08:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775574733; x=1776179533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YEGPU0Atu5gV0jwM3WLoUYvd7qnqbjH2TWBR26dz5rY=; b=n2eN9FZw+9HBqgmwhuzrWt0RBYUAROrUaEtQ1EZPgjHs/zvRuAAeXqJC1RpivAnggn 89LZYYkXXx1p8WRMf2XrWdVCZQvrE5XJltAcu07Jpkwa7gQlSRE6a38RIK9le6ppzykM TeJkqdmFlIbmeQ0HsT0YpR7VXiGJ/iGciGF9kh+5nWlAoaoMnHX8DDPTf92cDiD9HsRD wmoRV38zteSFjEidYKEpPYnA0eAH0w3beZebZmiNZk92tF2pPD+VGQ1haDsLrExXEUrn mA5j4q3QxUPynmDXekjufJoqJRYW7IDHQ2DaYkqZnspAcbZzeqRsUTdgEgUL5vtN35qD CvBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775574733; x=1776179533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YEGPU0Atu5gV0jwM3WLoUYvd7qnqbjH2TWBR26dz5rY=; b=i18gpczNK/WTypQUpDrB9w4bHm6co76U9wBqhm6PIX/mt1BCHEwSH4l95gf6siaPbV PbjJHmwKS2HfnlYekt0tYRorqIqsHYqeJO98qD+ITKolTw/TSi5xwIqJuy9WqOPB28gG qS1z5nmumQwMzXAt4uLThpoDuyZT/WRQgefgcg9/zYsYRQKWDVzp3ZLsQX8Ts1tSAwAG AK4vnmhiX4yCSXaA1jYuZA+ee6NrQMpjMDd0Q5iSvXGinVDnK89XqerjtW38NSNUpXkT cFYUdvNQYnPUdLz4lRn1n5ZFVo7Kpt+i5sTdmLXUVrVhKmp//c3X1VDWVjZDj5QkyW53 tf3w== X-Forwarded-Encrypted: i=1; AJvYcCWsBiYn2Nh8C1heVMkmGi97SFLuKS7AteHu7Y7dO1h3Yn+3R3tCQuQ5BJUjyI3wWBoQ/liM6bTQc5Zmbac=@vger.kernel.org X-Gm-Message-State: AOJu0YxS41GpvtMCmTrb+h+aYR0ttL9VL35FQ41ZpCoJkcUF6OUkV69g bwgIl/UOqOfgxsqFaz9sVutumpU+NDrKWOQVPH8O0NrWsQpEP7/qfPSu X-Gm-Gg: AeBDieumuDuaviG1h64J8EZdys/G9/zPgQlgGOrExGL1wzZRirjDeZuy+5opa6brOuj eHNMDHkldrgt4ttNPS6TzoZqerMauSZGFRaAw2YSpRxeFENH4yVo4vLHWTVgoEYfCnQUkWCxoL0 XQRbZDOyqPmRLSYcN9hHtVfKSHZHPfmfXt2k3xpPTNXTyO5zhiYnBax+feZhVgAbot8HLT4kCxf Cmu68g4vz0G2kBVPfA1bE46P4lQZOvmXPI14SfGV5oq5HowBfGOLj30U93kjIuGdOHdvJqJtLRb JAMEDsxBodD7nM3HEWQH6vXS0WkRCIVkHqhr1X99+hzjXjAewkd1eHHTk2HJrnDepQcpRMEEPIt 9NEcGPBsT96AfA+xw0vsRO3SR+dY3T2Uxtll2sIkoTJ0dvQrUeSqfvfrskwqDv9kCBvSYggxMZG 2Cb9n9ps0BuvkEI9/2ErZoAip8IZ/kyEUkjwgZpKKYgrsyaz6I X-Received: by 2002:a05:6000:401e:b0:43c:cda2:4f2a with SMTP id ffacd0b85a97d-43d28f8df8dmr25550860f8f.4.1775574732772; Tue, 07 Apr 2026 08:12:12 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:3f9a:11a8:20c3:fe58]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f5016sm54488360f8f.33.2026.04.07.08.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 08:12:12 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Greg Kroah-Hartman , Jiri Slaby Cc: Biju Das , Geert Uytterhoeven , Lad Prabhakar , Wolfram Sang , Thierry Bultel , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Biju Das , linux-renesas-soc@vger.kernel.org, Pavel Machek Subject: [PATCH] serial: rsci: Remove goto and refactor baud rate clock selection Date: Tue, 7 Apr 2026 16:12:05 +0100 Message-ID: <20260407151210.102693-1-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Replace the early-exit goto pattern in rsci_set_termios() with a positive conditional block. When baud rate is zero, the clock selection logic is now simply skipped rather than jumping to a 'done' label, eliminating the goto entirely. No functional change intended. Reported-by: Pavel Machek Closes: https://lore.kernel.org/all/abPpZULsXhRmXTX9@duo.ucw.cz/ Signed-off-by: Biju Das --- drivers/tty/serial/rsci.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial/rsci.c b/drivers/tty/serial/rsci.c index b00c9e385169..0b92173f8f45 100644 --- a/drivers/tty/serial/rsci.c +++ b/drivers/tty/serial/rsci.c @@ -265,20 +265,18 @@ static void rsci_set_termios(struct uart_port *port, = struct ktermios *termios, } =20 baud =3D uart_get_baud_rate(port, termios, old, 0, max_freq); - if (!baud) - goto done; - - /* Divided Functional Clock using standard Bit Rate Register */ - err =3D sci_scbrr_calc(s, baud, &brr1, &srr1, &cks1); - if (abs(err) < abs(min_err)) { - best_clk =3D SCI_FCK; - ccr0_val =3D 0; - min_err =3D err; - brr =3D brr1; - cks =3D cks1; + if (baud) { + /* Divided Functional Clock using standard Bit Rate Register */ + err =3D sci_scbrr_calc(s, baud, &brr1, &srr1, &cks1); + if (abs(err) < abs(min_err)) { + best_clk =3D SCI_FCK; + ccr0_val =3D 0; + min_err =3D err; + brr =3D brr1; + cks =3D cks1; + } } =20 -done: if (best_clk >=3D 0) dev_dbg(port->dev, "Using clk %pC for %u%+d bps\n", s->clks[best_clk], baud, min_err); --=20 2.43.0