From nobody Sun Jun 21 04:19:50 2026 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1F793B19D1 for ; Tue, 7 Apr 2026 14:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571259; cv=none; b=p+ub2bhVIN6tyY2oPhPTQgVRkKYezdrurPA1FIq4LcGA7o1ZnmBlzTAJ5NJdQ7P9nsbPVRl+3CYMmgsM37W+zed9JEKYXpHRiXl5/mrAJiVflbPMg8mkFxoHctdD7VJizdq4NZQ+qynMfs9zen2Nl7+wi/gRSkOjazNy/lvRgkA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571259; c=relaxed/simple; bh=KYvkRgaHHUN++L2bUA2eW2Gflig+j8DYhNy7PxtS/2g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HHLe7TYkgv4bvEtl2ePDwkYys+b+PiGT8c5mymrh1Hlp1UM6lsL6TM869vhrRk4udv8B6/OnyGwQJCZGqJPYnjnDmUlxPp++6Yx0477jB3n+UJ7L5xjfq4AwDxKEX4l95eLedqFxRd/Jx0BQNcIqH4Xkqtiqgv5azEWI7mEL80w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sKfaUStg; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sKfaUStg" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7d7ebe11bffso4443526a34.0 for ; Tue, 07 Apr 2026 07:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775571257; x=1776176057; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1V2lh/GaZrBlJfRbo6ax10GEA/6JMxVWK7CRPQq0TpQ=; b=sKfaUStgmK5TEJH2p923NPlPHu0IGiw2I0VvevGvGMhapCZK7uCu6lYVj4n3TzG3lx ycWx4JKUDNYtnK328LFu8QuVjFi+P3URqd9o1iIoiyU1n4Zj+G7wbnUlUCYTLZ7y6uNf rBTycvVVHSlOFGfsLljMshLO86WgmAKZvmGZBKdqmSRriS0FZbiFUYnuX+WNQsmFMynv JLDztW0XjmQIFUXNINfaSJyOvw7vGbmmcW45jAFgFW5IYQwQON1vO1Q90PIwgJTq1iSt jzjTT5Tcn4+QXgjOCYUzwA9t3RJ3l3rC5EyzPfzA/8O2QoqRoGySq56ZwC2jK0CO2zxS K2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571257; x=1776176057; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1V2lh/GaZrBlJfRbo6ax10GEA/6JMxVWK7CRPQq0TpQ=; b=Kn38fPntQPOJw1NpUjWBNwh4mynrQ8VVwGWfzaypDuEnK0ots/9HKtHKeXudyuCAYr CB4Q++kNN/jbncwgvM8Q+IfhMGOvUe1yZ9YE6SvlV+hjU0FVU/5HS4TCWjxYCrugtEvc trgXUDlN3KOWmdHPqfYYqISayoPfQl6mKVnKcVt/fqIhDWfmTr+RSyO6arFHrOky//As fvgAkyy0XCLB1gHjux8OnyBOiI4+xL7TRdWzz2AHVyGmf6qn+d2Y+iyTlZ+yuUTF1o1R 9TUoKALksmR+c4/8xpdF7z5Pw2XhihQUYD7nBI+UHzh96AzyIWnwhJuAPKdO2TUdZy92 EJSA== X-Forwarded-Encrypted: i=1; AJvYcCVQBsM4XHav53facXKLSRzeeV+Oh93KzcjSoFxM8J8stYiuIDDqxTQZDRlA5x450VfjIMun2wwvvw9u6zg=@vger.kernel.org X-Gm-Message-State: AOJu0YxQtL3gSoG7QidOKXfEyy/DkewCdFalXz8z4yXmz+tunowCBK/Q 9WwBv4GLEpDLpbsKpviN4NNlfD0HPQ8CAGksvB2CW3akNVc5y0rrwfVP X-Gm-Gg: AeBDiesHkU8F5dZA37UnufnZTiqvUWFR71fw+xOGHxf6ppNQ9OvFEX0h2hcgDlUZDqe 5Ql2lImIHmCQOUC+m+r1YyLWUr2APwwVIZWmJNBOeS+fZq0iA3gt2siZ1rNvSpTnyDgS0Jrq78x jf2xa5R1v4RDKgF6aXESU9dq+CjJzGvV8sgiXZcwNEQZed19i819L2dI0IbO14c7xEgI4UEByoK Q2r6r1TcIJs9gxH3kc1DG6DhOrkefatZypsw0iNqtxt+sI77zUQqgCFPu0gLoCNyeDUjfg2h8Od i/L+WZjRyeQ0RyKzbtT2lVENln4/RMX8wWheXMS/3BfEM57wp+/LqS/ToNozn5FIdARom3vIbpD C0xoh587TozPnR2A8r7ODf2pluf1KBG0YPNgLG2Rw0D6qj53FV3qIjwEvfPSt9Il+cJVJbWl+YY 671gjk0vdkvE8seGO9tpG+HQ== X-Received: by 2002:a05:6820:2219:b0:684:92a9:a2e2 with SMTP id 006d021491bc7-68492a9b397mr6359128eaf.39.1775571256590; Tue, 07 Apr 2026 07:14:16 -0700 (PDT) Received: from localhost ([2a03:2880:10ff:49::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-422eaf2c7c3sm13702797fac.5.2026.04.07.07.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:14:15 -0700 (PDT) From: Joshua Hahn To: Andrew Morton Cc: Jackie Liu , David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: [PATCH] mm/mempolicy: Fix weighted interleave auto sysfs name Date: Tue, 7 Apr 2026 07:14:14 -0700 Message-ID: <20260407141415.3080960-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The __ATTR macro is a utility that makes defining kobj_attributes easier by stringfying the name, verifying the mode, and setting the show/store fields in a single initializer. It takes a raw token as the first value, rather than a string, so that __ATTR family macros like __ATTR_RW can token-paste it for inferring the _show / _store function names. Commit e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning") used the __ATTR macro to define the "auto" sysfs for weighted interleave. A few months later, commit 2fb6915fa22d ("compiler_types.h: add "auto" as a macro for "__auto_type"") introduced a #define macro which expanded auto into __auto_type. This led to the "auto" token passed into __ATTR to be expanded out into __auto_type, and the sysfs entry to be displayed as __auto_type as well. Expand out the __ATTR macro and directly pass a string "auto" instead of the raw token 'auto' to prevent it from being expanded out. Also bypass the VERIFY_OCTAL_PERMISSIONS check by triple checking that 0664 is indeed the intended permissions for this sysfs file. Before: $ ls /sys/kernel/mm/mempolicy/weighted_interleave __auto_type node0 After: $ ls /sys/kernel/mm/mempolicy/weighted_interleave/ auto node0 Based on latest mm-new: 96881c429af1 Signed-off-by: Joshua Hahn Acked-by: David Hildenbrand (Arm) Acked-by: Huang Ying Acked-by: Zi Yan Reviewed-by: Gregory Price Reviewed-by: Rakie Kim --- mm/mempolicy.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 62108a5b74c4e..845458a3c18f4 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -3782,9 +3782,11 @@ static void wi_state_free(void) } } =20 -static struct kobj_attribute wi_auto_attr =3D - __ATTR(auto, 0664, weighted_interleave_auto_show, - weighted_interleave_auto_store); +static struct kobj_attribute wi_auto_attr =3D { + .attr =3D { .name =3D "auto", .mode =3D 0664 }, + .show =3D weighted_interleave_auto_show, + .store =3D weighted_interleave_auto_store, +}; =20 static void wi_cleanup(void) { sysfs_remove_file(&wi_group->wi_kobj, &wi_auto_attr.attr); --=20 2.52.0