From nobody Tue Apr 7 20:27:02 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1933B775D for ; Tue, 7 Apr 2026 13:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568935; cv=none; b=JuXbMO3A74O6z+knh4tkqeDu2IyBIU8jzew0O1l9qgkTvenz5DVK7G6fq7j4ceG5YBYkTXQeRk2KH/wcDxu30gqzVYxTLqBgkl+XYNcweHpQsD0nNxVVs240Xk2YH44NlWEZtXHyaWaM8Wp1ud89NuLl1AxhC8GN1kezdMOAt8I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568935; c=relaxed/simple; bh=GsHrr3v1WQnQ5DxgbOvb6THwJZZ0B3v3vS+57NzKOOU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AJBLbuVq/9/NlqSUzWGI+kgjGiCV/OGy18BLJww4YIMgTVKRxTZbvUpjgH1Q2ZCli4/rnAP4Bkgp9yARsseP39pQZBrYqVqPUXk3fxZs1bb4CPIo8e46+YdgytRcklKD6qFkd5jdOjmCTICmzWrheg2TGxyGiOfmfzMEH2OIpoM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=jMnAS88q; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="jMnAS88q" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488c21c636dso2370105e9.2 for ; Tue, 07 Apr 2026 06:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1775568931; x=1776173731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QzHnoo+7b5dFLN3aUDtXl6ixzTaf+bVpk2UW7fOlKww=; b=jMnAS88qmSq6/7+QpGlw2HPv4jD56tR+xneJ9mT8ZdiSyx9K5/kSHt5BJ4FGeg1IYV R49RkdgYTSmPLVD6ROllor8Eqd5FCyrwqMZaYpmKKdrY0aCmj9AqsKh0LwL8GF3OHBR4 7Ko1BS4Ggh2CPrAYTCspJco08PtJHkwdK/YwTyd9XgQHc88Cg7W6LLP7/kAR6Y6qJDuT Z5P30t+QnzrB19tysTMbZrMYnujMBNytWwg6jG+lhtAVp9eUMQ25bzaSD9TRba7DGrFv I+3cRZXl6C0XJJs7jTATpmWAeoIUqhD6M7w2Nhc0MhaicaMVZOTDYr9ZqxHr0L8I8TxL vNgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775568931; x=1776173731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QzHnoo+7b5dFLN3aUDtXl6ixzTaf+bVpk2UW7fOlKww=; b=Ll59CE0HE/5YRVmjsScvacVAGFacUBEX+3QJmRiBVEUymOZjiE+bARN/aP/Iswc2lG wd5PS0TdsWyDmijZaiaQq0t0spySAaPcMFxEG6N7AvQ4DMB8lJ++Km7C5uf6L8ugvmsw HjhV3/6tYV0qUVLpHXuRjqvpYnv4pCS+Eogrt2d0c2fHBpKBw/VQSSz8IBSP0YzNenfU LjuP/8pRRVOC0jALc/CpqJgLftypFuqLB/agHwLOrVNhUxaZnebRdEmAiHG3nnOr8PiR HksOZY2FZ22H5DyUmchPUEVzs7J4Mjd3uilGzSJE3m4VrcctoE1+tOiix9DIDbealuKi 0S0w== X-Forwarded-Encrypted: i=1; AJvYcCU+kESVn8bBPwkVM7LhMHfyuCnz2xBDYM9MqGdGKKWLGgijYsMJWXtH9OcVslrm04Ly3UnemUL/f7VjkKU=@vger.kernel.org X-Gm-Message-State: AOJu0YwmAOiS0zAhPnhsSUqLjl1IWnCbfADl8d+EE1F0zGB2kLRJvp7u L3HaCQbq0Y+LtSTwjjt+gwdevJnQI3KghR2M6g3fBpEgwWTYhts9LMRRKPJ/7FXnSII= X-Gm-Gg: AeBDiesiFM037vOJlL+aDn//tkuj1ZnJaUs2PULqkyhmAKy7oiE94DyfPZBMxkhGmrQ mcdM9FiasqzgIZ3rMbfIXi3w+Oyhq/ChjeoVRd0KSEZ0wESYdlsw1lX4u3qOwtnKo0Ww2pkQIAV PdGAv0Um/k8ZUq4ow+4+mNeucVBkoNE2MV+6RzvxN59awO5JzQDk6ba9EkpEnmVqgWWwDRdYloa KZNz9pN+Y0M/I1O6MM1SYVJIVNALZ4MmERVPS7WSr/o2MspgxvVeiRJlS3tZGZkN+nZhjWqdiAZ 1QaGnc+mtLq/nw1n+4SOsQj5OB0MgN9p/adNu9ETGXVVW1BSdpjySTlaXQACtfhfw4q1m0W62HJ qEHqpKGxgat2/JaBWGcputW2YZFjhnMZ89HoTdhRW0V+ywriXfpsirxyUZPIir4oSTWeZis/s4A bzlRMgkmPGL0gkPLHApStzUJFDrzVVnOn5pX/c5s33KjH/wmWx8gLL X-Received: by 2002:a05:600c:5292:b0:486:fe39:28b7 with SMTP id 5b1f17b1804b1-488996f08f5mr261826025e9.9.1775568931434; Tue, 07 Apr 2026 06:35:31 -0700 (PDT) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488a91686f9sm285777675e9.10.2026.04.07.06.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 06:35:30 -0700 (PDT) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, Frank.Li@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, p.zabel@pengutronix.de, geert+renesas@glider.be, fabrizio.castro.jz@renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea Subject: [PATCH v3 03/15] dmaengine: sh: rz-dmac: Do not disable the channel on error Date: Tue, 7 Apr 2026 16:34:55 +0300 Message-ID: <20260407133507.887404-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com> References: <20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Disabling the channel on error is pointless, as if other transfers are queued, the IRQ thread will be woken up and will execute them anyway by calling rz_dmac_xfer_desc(). rz_dmac_xfer_desc() re-enables the transfer. Before doing so, it sets CHCTRL.SWRST, which clears CHSTAT.DER and CHSTAT.END anyway. Skip disabling the DMA channel and just log the error instead. Signed-off-by: Claudiu Beznea --- Changes in v3: - none, this patch is new drivers/dma/sh/rz-dmac.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 12c1163cb6ef..34c00f3ffd4c 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -871,10 +871,6 @@ static void rz_dmac_irq_handle_channel(struct rz_dmac_= chan *channel) if (chstat & CHSTAT_ER) { dev_err(dmac->dev, "DMAC err CHSTAT_%d =3D %08X\n", channel->index, chstat); - - scoped_guard(spinlock_irqsave, &channel->vc.lock) - rz_dmac_disable_hw(channel); - return; } =20 /* --=20 2.43.0