From nobody Tue Apr 7 20:27:03 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56593AD506 for ; Tue, 7 Apr 2026 13:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568931; cv=none; b=BE9utnIuU6GSr24Z5owcivkzOkXYk4HB5F/8ritRGOjHi8G8lKWQCTTsOks0ClQdlyhBMJGUlcjivbGuzq2fqLAqQ85UR8V3hTp9HoAI98KvVimy7az7s7Y45mJhHZ2goM00KmkCwnRomvqMfjdJVTymfre0hMaVHPuFn2pkA7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568931; c=relaxed/simple; bh=LcM1SQxlU2zEePNOi96MarO1mcGQ7md8H0StgtARPbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cAEpW044Flw4tVQH04iNPwmtFlmg1gE8oa1wfTGFP4/hz8iDVSgcCCzYpGI0rZGLyR7hp1egsVvIhtWAN7lTPdjZgTU5zaU7o0y/4F7swJRXlVS54olDKqcLTSS/Uk7nd57Q8P72GoW6P76PXAbuAl2Q30kNhReYEmkNrzcIZR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=WQviGMsc; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="WQviGMsc" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cf8d550bdso4656093f8f.0 for ; Tue, 07 Apr 2026 06:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1775568928; x=1776173728; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zCNFfp+Y9opqUXxX/kFeUJeNq0Sa3NxuCau415grZd0=; b=WQviGMsc+PBHWW6R4QWTxwm67V2khKr+ngGMwqh1WOalxQ1dhASp08TdsHXSl4zQm2 tRn6A/WsnuiRzPAWktaDBfmiqccyd0PBJJbKvaIJMxGTThBMxwrmmBu7vqxvNg5Zo0Q2 7Ys21l40Gv+fSmVHC1g0Tp2TVa2+NQxj7zN/4qJqtzDkeRds20XQRJMy7oUBh73s6BI2 +iEeX/TsjaNvFnF9aNNlHULzvyYGfmUb1GdIAeXHzN9V9C4WyqLmorM+ajeUM7DR+iIg zr3NGWmqjXMoqMzNEyGRa8hq5Ax312SIv4on2s7DPza4MG7S1/x6tj4OrEvq5nYfRMrt +YAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775568928; x=1776173728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zCNFfp+Y9opqUXxX/kFeUJeNq0Sa3NxuCau415grZd0=; b=HOcVwSUEIcUgSUnJPDKvgni7hh3U3uM/Kb1i7jFYUBaVCDyJ6Wu+H0i9+nbVehYNbm OTzBF4Q20G+aRc0l0qrxM0i6pXfHjrHfHNYrjbx7pimtj6rNNgswuKVDXUWwGFLp2x4y y1WRETjB5dPvV4a875g1nVjLXoFsZB37J8cFGJdMdNO51uGvIS9R0aJ+ahFFhv4lie/s GXMUnYl3bBgWsg0KXIHvWfL+kXUyWeKBVKFazlheuMEJyrEY1CFmXS3tx1gi/g+ceqSw qkLoxfe7OWGux9sdXhiA+7ZgFqNhVWws/gvSaKlVSTOrMPXjwBBuZhxcaBrqGSndrny3 8Fgg== X-Forwarded-Encrypted: i=1; AJvYcCVtJPPEZ5/+Si2aCsoCyS2Kb6bKvsonoKhgoTSS5CougBiGQbUDY9qEQakFKoUqx2EJ06X8me2nDx4JMXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzsYLmpOoHBcvWULqpQY7XmqUxvCGHaHw1x4fxFn7PRrdBdsaiN gHSN+EgMabEnks7OTRjZ0EOVVv8R87qOKSt9AaTfSCseCueCif0Vpx2xr4t4Mv89tps= X-Gm-Gg: AeBDievsvdtYXO3uAB+jSRGSkcmOj2Ko5pA0uUGntp/lkrBWh4cbrQmYY2bVtuEs4IC e4RQ0x3bn/G8PTr24t9nyIsCBeweFi9/kTVY3h9n5dPU9pCzC3DxFDqkfUuxVOkcHecpIRpT0Qg 1/cInACfg+GnLZZCLc7nkpg/e0kRlSLOmulrHtSdK0ky1vQJ0rMNFn5fvVfbwBgcmS9vBx2VHLT 8Fx8Pk49exJLTGOoNHsASNiFxXaB9SWBV//5KrIb2Mx7al+9HaLCZtsGhd8ToSDWvDTeOhpAq4C AdinYUtUgR7qqM//A1nXdYpDcq2rTko3wsbs/t7DgVb63jfybogXuqLv1ImGI5ekoJDCaQAsSRm YVX3A75ILlC9CFOUyFkTXSbuWVH6bKW4tc2fsuQCH0LdweNnqnSg63gd+VcGsHSvH7//gDQoj9V +0M9zONNJl5saJFc0I0IbCdqn1Rul/NSmXhjUGaBxBy1qa8SCiACR4 X-Received: by 2002:a05:600c:8b34:b0:487:1fb4:7e1 with SMTP id 5b1f17b1804b1-488997d530fmr246087405e9.22.1775568928120; Tue, 07 Apr 2026 06:35:28 -0700 (PDT) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488a91686f9sm285777675e9.10.2026.04.07.06.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 06:35:27 -0700 (PDT) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, Frank.Li@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, p.zabel@pengutronix.de, geert+renesas@glider.be, fabrizio.castro.jz@renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea Subject: [PATCH v3 01/15] dmaengine: sh: rz-dmac: Use list_first_entry_or_null() Date: Tue, 7 Apr 2026 16:34:53 +0300 Message-ID: <20260407133507.887404-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com> References: <20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Use list_first_entry_or_null() instead of open-coding it with a list_empty() check and list_first_entry(). This simplifies the code. Signed-off-by: Claudiu Beznea --- Changes in v3: - none, this patch is new drivers/dma/sh/rz-dmac.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 625ff29024de..3d383afebecd 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -503,11 +503,10 @@ rz_dmac_prep_dma_memcpy(struct dma_chan *chan, dma_ad= dr_t dest, dma_addr_t src, __func__, channel->index, &src, &dest, len); =20 scoped_guard(spinlock_irqsave, &channel->vc.lock) { - if (list_empty(&channel->ld_free)) + desc =3D list_first_entry_or_null(&channel->ld_free, struct rz_dmac_desc= , node); + if (!desc) return NULL; =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); - desc->type =3D RZ_DMAC_DESC_MEMCPY; desc->src =3D src; desc->dest =3D dest; @@ -533,11 +532,10 @@ rz_dmac_prep_slave_sg(struct dma_chan *chan, struct s= catterlist *sgl, int i =3D 0; =20 scoped_guard(spinlock_irqsave, &channel->vc.lock) { - if (list_empty(&channel->ld_free)) + desc =3D list_first_entry_or_null(&channel->ld_free, struct rz_dmac_desc= , node); + if (!desc) return NULL; =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); - for_each_sg(sgl, sg, sg_len, i) dma_length +=3D sg_dma_len(sg); =20 --=20 2.43.0