From nobody Tue Apr 7 20:26:10 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17073BBA08 for ; Tue, 7 Apr 2026 13:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568951; cv=none; b=fGjlA+Noxw7rB7bNvbxhSMJvRQcOxGfu7lBlM1g/ucl5hiplyu9Hbe5hSCY5EjA1pU4nk5EYGA1Y6T1c/YTxHt3/DRmI/XDw5Vov90cUqlmRSgpB6KRwSHSYkrlF7+dgcIW6OM4Mvpin3reIGXIjCy1Bgily80xjBshZkJ7Avik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775568951; c=relaxed/simple; bh=q6oRXOaJk8L7LPyGO0Tyfzj+SUjE/1LBugvyTQiyfxc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QDT/QQQh9jPesc9DIdrHCg9+oFKoW0tiGG/qiOgBx92dqcZYu7q2PjComFmov1XMGYqVW331vJQ4sX4+VDO5rHK8ntN05YI2cM8suiTWZioxHZ0eOpFNOrpI4jK5zr6cDybt+GUODX17mUT4qBXmXGASEb2kvUKYLhHBGQE+4II= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=iTSeG/8J; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="iTSeG/8J" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso21715265e9.3 for ; Tue, 07 Apr 2026 06:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1775568945; x=1776173745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GrYQrHbvnZn1N2MhGkB4fAR6VCs+0IvT3ATvQcESfxg=; b=iTSeG/8Ju+t5Hyb2A/nc0BgLmUYgBlwmZtRUgietPfS6e4fTgpKy1Jpo0lmGqAWv3y 2DzcQEI63P0wZw59H8iskJ0WZXw+yWvTNjK6SB4Mo3ydyH0mdnWy9Yyt9v5azHjK1P2w CX45fLd0N8vmbza3zkGR32FP42Maro5l9ApK8cJuF0M0GcpggRwB+ikYc1vBM0w6AdBM B1gPcYnxBv+4tLoCCzBqh0Yv7rDvoZ+rdoAe6LRYvNqUjOfOIeRAeicBmST/OR221x5j 7iXL8lloZzQ6/4nL3PGfnsyPv+jrr+qq+uBwOikVBvOe/p+OZYw9yNC/AIHArXnNv1vz 3xVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775568945; x=1776173745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GrYQrHbvnZn1N2MhGkB4fAR6VCs+0IvT3ATvQcESfxg=; b=DlZBDIxoisXoODn4xyq/DMXRPoDFlqoFOjMVxXfS1TZlDVVVw0G/U6OUfr7t+7ozji 9ZwALahORG9lqlicpC6wo0QPu+o4DHKD27s3F+rEQ2ie7wFLkVNLIImRXVh/IpN0SanI KOt7lfX5WFyrwp0gnRyPyAC5qApNzJXn1vjvq0J9CI4osv7fHYjS69zTO45apHRzOZ7r z5/IDy/2NhgtSVei/THOT/iTbDY3Dbg2vf9cyxj2LOGmwdtl9djBr2HvbzCy3aosX1Oj Vevy+zA4VeD9U8C1vnVIBD1qJibzTm1cFqqfkSgFs+5oPScLVlioWfwI9zmRKqS667sE afAw== X-Forwarded-Encrypted: i=1; AJvYcCXjB2ZnQ2IvEVYTPKA68xViOQAfJB0qjjBxD0vXOQZ3oTa04JlCkzc6HucSWaT2GnJpZBXQ6q9Sn6LmYnc=@vger.kernel.org X-Gm-Message-State: AOJu0YyM+D+3Gquh5m4lsKCmcTL67MlK5HMYA4goXeP41xbqX+nheZL/ HhigCmPLm5jglORVcH3gHZWqHwxgj+GynTS8MlplHlP2qqZZPoYpmT6gr2skBLC6vJY= X-Gm-Gg: AeBDieuuJdJHXOlgJoTfyjU5FJ47+JDkmi1PG1RWLEu/QdYVyvH/obWIRRC774qCPXW +vLBbL80/izTwrB7rWBbewGdor3uFppBoxFWI6PoL9+e9twNHfZ9mgpIQZapS4Vw6gtY185kpKz TPMy02zTa1SGPeN9fTJ+Bm01p+k7WiEysfaKDhIh/KCZooncV7Z/qZSfR0Bv5OuaYbDAbsRelds NuDHu3Qx2lU/QqNpZXnyVsRFsuHpqBhk+tVBt4ttRRTjrNHTZBYeh1iirtQKX58RiHJJhbC0tLL n/34vvlxtWMjymW3gm8KDnV3QZrq64g3au5LMA5pdjnr+n2C8w3Bw6FB44vYymepaegahxMuxU2 zemZCPHkB58F7ZWDGmBHszVJzCSctRTJC5pAIP8qHJJ2lKtWLqV59SmewxuWtl8KG1EWxbe+LnI cA0M8AE1cxILfcPUmEtZhJ/V860KoDfNhlN8fI5mzhx76St59vz82a X-Received: by 2002:a05:600c:6098:b0:488:9fb7:376d with SMTP id 5b1f17b1804b1-4889fb73b1amr209462685e9.28.1775568945398; Tue, 07 Apr 2026 06:35:45 -0700 (PDT) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488a91686f9sm285777675e9.10.2026.04.07.06.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 06:35:44 -0700 (PDT) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, Frank.Li@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, p.zabel@pengutronix.de, geert+renesas@glider.be, fabrizio.castro.jz@renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea Subject: [PATCH v3 10/15] dmaengine: sh: rz-dmac: Drop the update of channel->chctrl with CHCTRL_SETEN Date: Tue, 7 Apr 2026 16:35:02 +0300 Message-ID: <20260407133507.887404-11-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com> References: <20260407133507.887404-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The CHCTRL_SETEN bit is explicitly set in rz_dmac_enable_hw(). Updating struct rz_dmac_chan::chctrl with this bit in rz_dmac_prepare_desc_for_memcpy() and rz_dmac_prepare_descs_for_slave_sg() is unnecessary in the current code base. Moreover, it conflicts with the configuration sequence that will be used for cyclic DMA channels during suspend to RAM. Cyclic DMA support will be introduced in subsequent commits. This is a preparatory commit for cyclic DMA suspend to RAM support. Signed-off-by: Claudiu Beznea --- Changes in v3: - none Changes in v2: - fixed typos in patch title and patch description drivers/dma/sh/rz-dmac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index bacde5e28616..8fbccabc94e4 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -377,7 +377,7 @@ static void rz_dmac_prepare_desc_for_memcpy(struct rz_d= mac_chan *channel) rz_dmac_set_dma_req_no(dmac, channel->index, dmac->info->default_dma_req_= no); =20 channel->chcfg =3D chcfg; - channel->chctrl =3D CHCTRL_STG | CHCTRL_SETEN; + channel->chctrl =3D CHCTRL_STG; } =20 static void rz_dmac_prepare_descs_for_slave_sg(struct rz_dmac_chan *channe= l) @@ -427,8 +427,6 @@ static void rz_dmac_prepare_descs_for_slave_sg(struct r= z_dmac_chan *channel) channel->lmdesc.tail =3D lmdesc; =20 rz_dmac_set_dma_req_no(dmac, channel->index, channel->mid_rid); - - channel->chctrl =3D CHCTRL_SETEN; } =20 static void rz_dmac_xfer_desc(struct rz_dmac_chan *chan) --=20 2.43.0