From nobody Mon Jun 15 01:40:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DD821ACED5; Tue, 7 Apr 2026 12:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564483; cv=none; b=ab9+8V5ndRD30UR2BQvOOD7m4Rbcubtmw351sIFOh+tOnQ4h3mV3vIC1zpmuRjc7a7kdnOraUkpagRolZpmIYefovDZg2qyuANu5pJqtj3a6hCq0yyvFuruX0gFJGQVrHIalMxF2UDYiBS57oG8uDRsD6E7WDBZ5mcRyqy+zguE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564483; c=relaxed/simple; bh=qe9hzNCzhvX11xJ50GGWKhIIpom0rXz4h7ZFWfkxfCQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vAIC5vV+XnBDsILC/7gfa3XpX/LBuxw+5dV/mucqdZST5ks3jNEOD7Oze4rLjtLITXYQAGlQ38zZFxoFHW6AKtjLpu6ZsG/Xol0wmN/mPhs1qvRXxb0q0SEcOK3Zt0vISrZOR+YNLeKiuuhxLoodemboQEBqzxrZiLdN8zNnz0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UYfCgxEM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UYfCgxEM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EF60C116C6; Tue, 7 Apr 2026 12:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775564483; bh=qe9hzNCzhvX11xJ50GGWKhIIpom0rXz4h7ZFWfkxfCQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UYfCgxEMLMNQEZXRYNXj7efNn6WXiOS8ySWce1KwsBc0gwuGSjeTZvfRnC7OxNODh NNLutUhKrV+GLlJETkBqaE9gSQZiouy+bAa2zvkowz4gN0LeGsU/lAe4IaeB611Jdc dWxM8ai5gZPvMSRzAHlzJi38cqv5MaxT88Cqmir1tPbwp4zekXVsJSWvIpbUm6SmR0 oXGG8+BaP110IRRJy/O4X7Q2r1vIdDtYddPbmKv21H+OLfr1jHdfh06PsR/gbffyFU S2eqSK4jAKG3bxFCiFGd8W14JluifR0HU+X7c6WDGVGFEggO4MBCJQZgNIVu2u2a6k igAGs6XQjEMMA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA5Qn-0000000BCS8-0lcp; Tue, 07 Apr 2026 14:21:21 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Bartosz Golaszewski , Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 1/3] regulator: max77650: fix OF node reference imbalance Date: Tue, 7 Apr 2026 14:20:29 +0200 Message-ID: <20260407122031.2669397-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260407122031.2669397-1-johan@kernel.org> References: <20260407122031.2669397-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: bcc61f1c44fd ("regulator: max77650: add regulator support") Cc: stable@vger.kernel.org # 5.1 Cc: Bartosz Golaszewski Signed-off-by: Johan Hovold Reviewed-by: Bartosz Golaszewski --- drivers/regulator/max77650-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max77650-regulator.c b/drivers/regulator/max= 77650-regulator.c index a809264c77fc..11b04a13f889 100644 --- a/drivers/regulator/max77650-regulator.c +++ b/drivers/regulator/max77650-regulator.c @@ -337,7 +337,7 @@ static int max77650_regulator_probe(struct platform_dev= ice *pdev) parent =3D dev->parent; =20 if (!dev->of_node) - dev->of_node =3D parent->of_node; + device_set_of_node_from_dev(dev, parent); =20 rdescs =3D devm_kcalloc(dev, MAX77650_REGULATOR_NUM_REGULATORS, sizeof(*rdescs), GFP_KERNEL); --=20 2.52.0 From nobody Mon Jun 15 01:40:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97CB8279792; Tue, 7 Apr 2026 12:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564483; cv=none; b=RW3cOqW0uHQs7JrqVA5j2Px3f4WVGx6W5mexK9CD8tf4IHpBLM1D7s34mtZVGEJz11S2NXYl9razYaxdYVijMEJZ3zVppSgUHjRIN7oP35G2zKnq6bWS0wgzsQSM7LzEjVHYIdtjPDE17CHbxDPcI8QLZChS6MlQKbhGr+H8LNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564483; c=relaxed/simple; bh=jrQBeK2x6KLluU2H0Ges4ATakn3LsGMgIHcBGMIrXB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=twLLBxSrRXAaHkcGqLxN+Irw/DzfFdzecba23m9YJXLflYBgzimB5DcMEmDBcbWvi3+ovGjUJNQjbFo3y1lcwOkZ7JUvVGNVUE+D/RB0cxb3o34gGYNPGpTJMIG/9SjuPTGrPfUsjFAKhcbDYVl3YkduG5yzBJRDoVBuQ+h09+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PmASZz3m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PmASZz3m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7360AC2BCB0; Tue, 7 Apr 2026 12:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775564483; bh=jrQBeK2x6KLluU2H0Ges4ATakn3LsGMgIHcBGMIrXB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PmASZz3mzPigCoOU3VTC0MMR69Ji4P0O79gQuVls7oHnYViE7WiS01wCItjwZi+z5 GzS6aSYgQoBWebmcCi68qP1lO/2ffVsz2KsU12chhQqXnnOunCXN7krahC43jLZjUB vdtN1OcHlygmrzfQblQGCkgmdAgrF7HOWYO4wH0S2Z4foWcKPrSQ5DFQEgu+p8+18q CNajA1QJh7By5ZhMYd2ma6XSP69INSz63GYrv53aIymOvsAx7u+M1dwojriYCd12cX wJadn2kVrZJjv6KaZu+v4XhJSMzfCH7IQAcsGGza1eIMk63yWt14CiiOgF9gJMpXcO 8xRpdfuCid1bA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA5Qn-0000000BCSA-0o2p; Tue, 07 Apr 2026 14:21:21 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Bartosz Golaszewski , Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/3] regulator: mt6357: fix OF node reference imbalance Date: Tue, 7 Apr 2026 14:20:30 +0200 Message-ID: <20260407122031.2669397-3-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260407122031.2669397-1-johan@kernel.org> References: <20260407122031.2669397-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: dafc7cde23dc ("regulator: add mt6357 regulator") Cc: stable@vger.kernel.org # 6.2 Signed-off-by: Johan Hovold --- drivers/regulator/mt6357-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6357-regulator.c b/drivers/regulator/mt635= 7-regulator.c index 1eb69c7a6acb..09feb454ab6b 100644 --- a/drivers/regulator/mt6357-regulator.c +++ b/drivers/regulator/mt6357-regulator.c @@ -410,7 +410,7 @@ static int mt6357_regulator_probe(struct platform_devic= e *pdev) struct regulator_dev *rdev; int i; =20 - pdev->dev.of_node =3D pdev->dev.parent->of_node; + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); =20 for (i =3D 0; i < MT6357_MAX_REGULATOR; i++) { config.dev =3D &pdev->dev; --=20 2.52.0 From nobody Mon Jun 15 01:40:50 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A215B3AA516; Tue, 7 Apr 2026 12:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564483; cv=none; b=AgK0bnV6NmRhx5ag9ZBEt6HTlz+0OJF/vHoYbwbB4vCDIavwgi0AnmsE+/Ay9GCzvMOQfDwn1miVezB2Pqh1VMxBcg0HiLHgs4JX4D6pzMXbJH9Vhidu11ZujKZg04k+xZMrPzbrg0ahlAQjz4dmE8VTAuGpqEPaYmlcDPwOdZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775564483; c=relaxed/simple; bh=FXyQ24BYf7morxcDyu4vsmcVP7Ek1/v6ZJhPAKuWC8g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r8xvsPrbq9mH4fYnJsKQy6N7MNmIUWxhjLGTkfIubTZIhMpodEROZVsH033Gr8tnHrxVSULi5cQasJUrBAh+xpVfxrDDYBpVAtipi+k0DxGAHcVFvenwTbvCG3qh9rmzFhkdSIbZBpNCD1fwO59zXSG62TvstH+wdMTeRbJuAa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IpHnZQbR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IpHnZQbR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 761BDC2BCB1; Tue, 7 Apr 2026 12:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775564483; bh=FXyQ24BYf7morxcDyu4vsmcVP7Ek1/v6ZJhPAKuWC8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IpHnZQbRuZPZFiqRBChLN4lzaBWDz63duZisZlsayDeuDOMtmz8dCeNgFzljGQRsQ 8y2EagF50WA3s1KLZyT9szg+ElLOhlG3MEaERmbefMebOHNdm7BhzTmuJNhGechf2p DfPE1ZUzCyuA+jW0kEeiwBfWvNccmjp87y7BYewYIAV0gmLp1nrHi8vYZwbaLAWoDP Wrq05YQulN/eGo0ZMGTf99+Pe1QGZKO2YkSBbrBhQEe9XNYskKqPV2DJ747zDEl7YO Yuz6I+bztwOEYOH7mzIk8SMHq1E4ue73u6C5ILPHOlHge5v/VND0vCIhx2/rkbD8Dq 9EVYKUiD708VQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wA5Qn-0000000BCSC-0r7f; Tue, 07 Apr 2026 14:21:21 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , Bartosz Golaszewski , Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Dzmitry Sankouski Subject: [PATCH 3/3] regulator: s2dos05: fix OF node reference imbalance Date: Tue, 7 Apr 2026 14:20:31 +0200 Message-ID: <20260407122031.2669397-4-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260407122031.2669397-1-johan@kernel.org> References: <20260407122031.2669397-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver reuses the OF node of the parent multi-function device but fails to take another reference to balance the one dropped by the platform bus code when unbinding the MFD and deregistering the child devices. Fix this by using the intended helper for reusing OF nodes. Fixes: bb2441402392 ("regulator: add s2dos05 regulator support") Cc: stable@vger.kernel.org # 6.18 Cc: Dzmitry Sankouski Signed-off-by: Johan Hovold --- drivers/regulator/s2dos05-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/s2dos05-regulator.c b/drivers/regulator/s2do= s05-regulator.c index 1463585c4565..a1c394ddbaff 100644 --- a/drivers/regulator/s2dos05-regulator.c +++ b/drivers/regulator/s2dos05-regulator.c @@ -126,7 +126,7 @@ static int s2dos05_pmic_probe(struct platform_device *p= dev) s2dos05->regmap =3D iodev->regmap_pmic; s2dos05->dev =3D dev; if (!dev->of_node) - dev->of_node =3D dev->parent->of_node; + device_set_of_node_from_dev(dev, dev->parent); =20 config.dev =3D dev; config.driver_data =3D s2dos05; --=20 2.52.0