From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78CA23A3E8E for ; Tue, 7 Apr 2026 09:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553968; cv=none; b=Q+EyK5NjCaUe9UzHSqi6THYRM0O2LCqeOaIRIcIzFjP8U62hwwSNSLCoGpgcq5xyVO56xJu3Y0MElNFtHknbBNRbawMjljTdJMDUvuQwjVnOw2ohFvGx8OfABBX4OuYPK80GfW4lwCZSh6LYZTx3XNQIEg7cFhlZzXLYyQA4MtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553968; c=relaxed/simple; bh=C6KphocZRHFRAttLmSlYzWqlwctq5zeMTmcMQK+27A4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZnMn+/hpIr699FBZVN42RQ/KZzcKr0M0PfBK3sngp2+g+LE7STwGis0Xv3JN7MBku34PeeoLNVfw6rRUFImBrkH1zYv8EVfe+PaWA+/64XQxhscAO49Cm1FuaHZqqf5u0fyrLPtUT2WxfGGBt0zcv0cAh9D4aydRo4wxI+HTJGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D04704E3A2; Tue, 7 Apr 2026 09:26:00 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7FABD4A0B2; Tue, 7 Apr 2026 09:26:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yBL4HajN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:00 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann , stable@vger.kernel.org Subject: [PATCH v2 01/10] fbcon: Avoid OOB font access if console rotation fails Date: Tue, 7 Apr 2026 11:23:12 +0200 Message-ID: <20260407092555.58816-2-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: D04704E3A2 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Score: -4.00 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Content-Type: text/plain; charset="utf-8" Clear the font buffer if the reallocation during console rotation fails in fbcon_rotate_font(). The putcs implementations for the rotated buffer will return early in this case. See [1] for an example. Currently, fbcon_rotate_font() keeps the old buffer, which is too small for the rotated font. Printing to the rotated console with a high-enough character code will overflow the font buffer. v2: - fix typos in commit message Signed-off-by: Thomas Zimmermann Fixes: 6cc50e1c5b57 ("[PATCH] fbcon: Console Rotation - Add support to rota= te font bitmap") Cc: # v2.6.15+ Link: https://elixir.bootlin.com/linux/v6.19/source/drivers/video/fbdev/cor= e/fbcon_ccw.c#L144 # [1] --- drivers/video/fbdev/core/fbcon_rotate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/= core/fbcon_rotate.c index 1562a8f20b4f..5348f6c6f57c 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.c +++ b/drivers/video/fbdev/core/fbcon_rotate.c @@ -46,6 +46,10 @@ int fbcon_rotate_font(struct fb_info *info, struct vc_da= ta *vc) info->fbops->fb_sync(info); =20 if (par->fd_size < d_cellsize * len) { + kfree(par->fontbuffer); + par->fontbuffer =3D NULL; + par->fd_size =3D 0; + dst =3D kmalloc_array(len, d_cellsize, GFP_KERNEL); =20 if (dst =3D=3D NULL) { @@ -54,7 +58,6 @@ int fbcon_rotate_font(struct fb_info *info, struct vc_dat= a *vc) } =20 par->fd_size =3D d_cellsize * len; - kfree(par->fontbuffer); par->fontbuffer =3D dst; } =20 --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02DC43A0B20 for ; Tue, 7 Apr 2026 09:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553974; cv=none; b=qGgUsmYig8VDFQewcimRVmT1ua5vk+CMZeVx3l1TdVDg4lDtppRtcNhi3KiKIT5g8wOZZaYiFLtSHqlkhOYE4QVnb5FC9G4zdB0OizODuaxaUuRBd9MffoGW/Lw+GflnOvunxdXUCrkALxf37BTWxSoIUI41zzIMbXdQA4XX75Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553974; c=relaxed/simple; bh=ySbp4aj6BQOATdrKrKKrTtOypBpwIieGr1SqRNtv37w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QP2YwE72oM1I5WWebP/O5HOm5LjQr5Ypmw2pzRm93/MgZx+Vp8I1Q/0n+uezHf9Voow8fe78MBlC7PDMLNEUFYxdW97ar9knzk5U7/kUpT1I6gUuE3VhxRaI+HLhRFDLKilaGnXxcbGX2Av+fIHdfLI8fxehAPOAUU3ObTyAbJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A78E4E3A3; Tue, 7 Apr 2026 09:26:01 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D882E4A0B1; Tue, 7 Apr 2026 09:26:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cJeDM6jN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:00 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 02/10] vt: Implement helpers for struct vc_font in source file Date: Tue, 7 Apr 2026 11:23:13 +0200 Message-ID: <20260407092555.58816-3-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 2A78E4E3A3 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Score: -4.00 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Content-Type: text/plain; charset="utf-8" Move the helpers vc_font_pitch() and vc_font_size() from the VT header file into source file. They are not called very often, so there's no benefit in keeping them in the headers. Also avoids including from the header. v2: - fix typo in commit description Signed-off-by: Thomas Zimmermann Acked-by: Greg Kroah-Hartman --- drivers/tty/vt/vt.c | 35 ++++++++++++++++++++++++++++++++++ include/linux/console_struct.h | 30 ++--------------------------- 2 files changed, 37 insertions(+), 28 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index e2df99e3d458..3d89d30c9596 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -71,6 +71,7 @@ * by Adam Tla/lka , Aug 2006 */ =20 +#include #include #include #include @@ -230,6 +231,40 @@ enum { blank_vesa_wait, }; =20 +/* + * struct vc_font + */ + +/** + * vc_font_pitch - Calculates the number of bytes between two adjacent sca= nlines + * @font: The VC font + * + * Returns: + * The number of bytes between two adjacent scanlines in the font data + */ +unsigned int vc_font_pitch(const struct vc_font *font) +{ + return DIV_ROUND_UP(font->width, 8); +} +EXPORT_SYMBOL_GPL(vc_font_pitch); + +/** + * vc_font_size - Calculates the size of the font data in bytes + * @font: The VC font + * + * vc_font_size() calculates the number of bytes of font data in the + * font specified by @font. The function calculates the size from the + * font parameters. + * + * Returns: + * The size of the font data in bytes. + */ +unsigned int vc_font_size(const struct vc_font *font) +{ + return font->height * vc_font_pitch(font) * font->charcount; +} +EXPORT_SYMBOL_GPL(vc_font_size); + /* * /sys/class/tty/tty0/ * diff --git a/include/linux/console_struct.h b/include/linux/console_struct.h index 6ce498b31855..fe915afdece5 100644 --- a/include/linux/console_struct.h +++ b/include/linux/console_struct.h @@ -13,7 +13,6 @@ #ifndef _LINUX_CONSOLE_STRUCT_H #define _LINUX_CONSOLE_STRUCT_H =20 -#include #include #include #include @@ -83,33 +82,8 @@ struct vc_font { const unsigned char *data; }; =20 -/** - * vc_font_pitch - Calculates the number of bytes between two adjacent sca= nlines - * @font: The VC font - * - * Returns: - * The number of bytes between two adjacent scanlines in the font data - */ -static inline unsigned int vc_font_pitch(const struct vc_font *font) -{ - return DIV_ROUND_UP(font->width, 8); -} - -/** - * vc_font_size - Calculates the size of the font data in bytes - * @font: The VC font - * - * vc_font_size() calculates the number of bytes of font data in the - * font specified by @font. The function calculates the size from the - * font parameters. - * - * Returns: - * The size of the font data in bytes. - */ -static inline unsigned int vc_font_size(const struct vc_font *font) -{ - return font->height * vc_font_pitch(font) * font->charcount; -} +unsigned int vc_font_pitch(const struct vc_font *font); +unsigned int vc_font_size(const struct vc_font *font); =20 /* * Example: vc_data of a console that was scrolled 3 lines down. --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C343A1D0C for ; Tue, 7 Apr 2026 09:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553981; cv=none; b=i0szgivyR5kW7gmh/Eex5CYW04vcNnSbA+jPK8kl6XNNZMQCYnuCwkqNWpZUuKJ6pXAJEjMYOLlDYg6Bm1wQ4FBMCfZ6XlKhX2mg6RX9qg//rqsIjkIuL15cXxfRBDSiEx/ji/i5t7T3EGDhwCm1CW0Yttk6wgwX2cSDCrPSFo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553981; c=relaxed/simple; bh=n2eZ5+lA30W2WcgoepYMDl+wnoD68lb5zRL7w7pqvPY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U+CkecrArx2jwO7iu6ZspysOQCleJI/ZFV/tOkAMJEE38YNQWAvnXZZN8mH8qq2ip6Pss8gLd0AisI4tRzyykUlWagKjlbYUaYzsY2aR4TkFhblHiiccMTrPB8+IPJrecTQWzVQ96GrIV+8ksM4s8b7p82crKtc3FdFhOcDcFws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 798C44E3A4; Tue, 7 Apr 2026 09:26:01 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 317A84A0B2; Tue, 7 Apr 2026 09:26:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CGjkCqnN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:01 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 03/10] lib/fonts: Provide helpers for calculating glyph pitch and size Date: Tue, 7 Apr 2026 11:23:14 +0200 Message-ID: <20260407092555.58816-4-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 798C44E3A4 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.00 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Implement pitch and size calculation for a single font glyph in the new helpers font_glyph_pitch() and font_glyph_size(). Replace the instances where the calculations are open-coded. Note that in the case of fbcon console rotation, the parameters for a glyph's width and height might be reversed. This is intentional. v2: - fix typos in commit message Signed-off-by: Thomas Zimmermann --- drivers/tty/vt/vt.c | 5 ++-- drivers/video/fbdev/core/fbcon_ccw.c | 11 +++---- drivers/video/fbdev/core/fbcon_cw.c | 11 +++---- drivers/video/fbdev/core/fbcon_rotate.c | 6 ++-- drivers/video/fbdev/core/fbcon_ud.c | 7 +++-- include/linux/font.h | 40 +++++++++++++++++++++++++ lib/fonts/fonts.c | 2 +- 7 files changed, 61 insertions(+), 21 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 3d89d30c9596..23b9683b52a5 100644 --- a/drivers/tty/vt/vt.c +++ b/drivers/tty/vt/vt.c @@ -71,7 +71,6 @@ * by Adam Tla/lka , Aug 2006 */ =20 -#include #include #include #include @@ -244,7 +243,7 @@ enum { */ unsigned int vc_font_pitch(const struct vc_font *font) { - return DIV_ROUND_UP(font->width, 8); + return font_glyph_pitch(font->width); } EXPORT_SYMBOL_GPL(vc_font_pitch); =20 @@ -261,7 +260,7 @@ EXPORT_SYMBOL_GPL(vc_font_pitch); */ unsigned int vc_font_size(const struct vc_font *font) { - return font->height * vc_font_pitch(font) * font->charcount; + return font_glyph_size(font->width, font->height) * font->charcount; } EXPORT_SYMBOL_GPL(vc_font_size); =20 diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/cor= e/fbcon_ccw.c index 2f394b5a17f7..96ef449ee6ac 100644 --- a/drivers/video/fbdev/core/fbcon_ccw.c +++ b/drivers/video/fbdev/core/fbcon_ccw.c @@ -26,7 +26,7 @@ static void ccw_update_attr(u8 *dst, u8 *src, int attribu= te, struct vc_data *vc) { int i, j, offset =3D (vc->vc_font.height < 10) ? 1 : 2; - int width =3D (vc->vc_font.height + 7) >> 3; + int width =3D font_glyph_pitch(vc->vc_font.height); int mod =3D vc->vc_font.height % 8; u8 c, msk =3D ~(0xff << offset), msk1 =3D 0; =20 @@ -101,7 +101,7 @@ static inline void ccw_putcs_aligned(struct vc_data *vc= , struct fb_info *info, { struct fbcon_par *par =3D info->fbcon_par; u16 charmask =3D vc->vc_hi_font_mask ? 0x1ff : 0xff; - u32 idx =3D (vc->vc_font.height + 7) >> 3; + u32 idx =3D font_glyph_pitch(vc->vc_font.height); u8 *src; =20 while (cnt--) { @@ -131,7 +131,7 @@ static void ccw_putcs(struct vc_data *vc, struct fb_inf= o *info, { struct fb_image image; struct fbcon_par *par =3D info->fbcon_par; - u32 width =3D (vc->vc_font.height + 7)/8; + u32 width =3D font_glyph_pitch(vc->vc_font.height); u32 cellsize =3D width * vc->vc_font.width; u32 maxcnt =3D info->pixmap.size/cellsize; u32 scan_align =3D info->pixmap.scan_align - 1; @@ -223,7 +223,8 @@ static void ccw_cursor(struct vc_data *vc, struct fb_in= fo *info, bool enable, struct fb_cursor cursor; struct fbcon_par *par =3D info->fbcon_par; unsigned short charmask =3D vc->vc_hi_font_mask ? 0x1ff : 0xff; - int w =3D (vc->vc_font.height + 7) >> 3, c; + int w =3D font_glyph_pitch(vc->vc_font.height); + int c; int y =3D real_y(par->p, vc->state.y); int attribute, use_sw =3D vc->vc_cursor_type & CUR_SW; int err =3D 1, dx, dy; @@ -297,7 +298,7 @@ static void ccw_cursor(struct vc_data *vc, struct fb_in= fo *info, bool enable, char *tmp, *mask =3D kmalloc_array(w, vc->vc_font.width, GFP_ATOMIC); int cur_height, size, i =3D 0; - int width =3D (vc->vc_font.width + 7)/8; + int width =3D font_glyph_pitch(vc->vc_font.width); =20 if (!mask) return; diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core= /fbcon_cw.c index 3c3ad3471ec4..ea712654edae 100644 --- a/drivers/video/fbdev/core/fbcon_cw.c +++ b/drivers/video/fbdev/core/fbcon_cw.c @@ -26,7 +26,7 @@ static void cw_update_attr(u8 *dst, u8 *src, int attribut= e, struct vc_data *vc) { int i, j, offset =3D (vc->vc_font.height < 10) ? 1 : 2; - int width =3D (vc->vc_font.height + 7) >> 3; + int width =3D font_glyph_pitch(vc->vc_font.height); u8 c, msk =3D ~(0xff >> offset); =20 for (i =3D 0; i < vc->vc_font.width; i++) { @@ -86,7 +86,7 @@ static inline void cw_putcs_aligned(struct vc_data *vc, s= truct fb_info *info, { struct fbcon_par *par =3D info->fbcon_par; u16 charmask =3D vc->vc_hi_font_mask ? 0x1ff : 0xff; - u32 idx =3D (vc->vc_font.height + 7) >> 3; + u32 idx =3D font_glyph_pitch(vc->vc_font.height); u8 *src; =20 while (cnt--) { @@ -116,7 +116,7 @@ static void cw_putcs(struct vc_data *vc, struct fb_info= *info, { struct fb_image image; struct fbcon_par *par =3D info->fbcon_par; - u32 width =3D (vc->vc_font.height + 7)/8; + u32 width =3D font_glyph_pitch(vc->vc_font.height); u32 cellsize =3D width * vc->vc_font.width; u32 maxcnt =3D info->pixmap.size/cellsize; u32 scan_align =3D info->pixmap.scan_align - 1; @@ -206,7 +206,8 @@ static void cw_cursor(struct vc_data *vc, struct fb_inf= o *info, bool enable, struct fb_cursor cursor; struct fbcon_par *par =3D info->fbcon_par; unsigned short charmask =3D vc->vc_hi_font_mask ? 0x1ff : 0xff; - int w =3D (vc->vc_font.height + 7) >> 3, c; + int w =3D font_glyph_pitch(vc->vc_font.height); + int c; int y =3D real_y(par->p, vc->state.y); int attribute, use_sw =3D vc->vc_cursor_type & CUR_SW; int err =3D 1, dx, dy; @@ -280,7 +281,7 @@ static void cw_cursor(struct vc_data *vc, struct fb_inf= o *info, bool enable, char *tmp, *mask =3D kmalloc_array(w, vc->vc_font.width, GFP_ATOMIC); int cur_height, size, i =3D 0; - int width =3D (vc->vc_font.width + 7)/8; + int width =3D font_glyph_pitch(vc->vc_font.width); =20 if (!mask) return; diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/= core/fbcon_rotate.c index 5348f6c6f57c..18575c5182db 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.c +++ b/drivers/video/fbdev/core/fbcon_rotate.c @@ -33,14 +33,12 @@ int fbcon_rotate_font(struct fb_info *info, struct vc_d= ata *vc) src =3D par->fontdata =3D vc->vc_font.data; par->cur_rotate =3D par->p->con_rotate; len =3D vc->vc_font.charcount; - s_cellsize =3D ((vc->vc_font.width + 7)/8) * - vc->vc_font.height; + s_cellsize =3D font_glyph_size(vc->vc_font.width, vc->vc_font.height); d_cellsize =3D s_cellsize; =20 if (par->rotate =3D=3D FB_ROTATE_CW || par->rotate =3D=3D FB_ROTATE_CCW) - d_cellsize =3D ((vc->vc_font.height + 7)/8) * - vc->vc_font.width; + d_cellsize =3D font_glyph_size(vc->vc_font.height, vc->vc_font.width); =20 if (info->fbops->fb_sync) info->fbops->fb_sync(info); diff --git a/drivers/video/fbdev/core/fbcon_ud.c b/drivers/video/fbdev/core= /fbcon_ud.c index 6fc30cad5b19..f7cd89c42b01 100644 --- a/drivers/video/fbdev/core/fbcon_ud.c +++ b/drivers/video/fbdev/core/fbcon_ud.c @@ -26,7 +26,7 @@ static void ud_update_attr(u8 *dst, u8 *src, int attribut= e, struct vc_data *vc) { int i, offset =3D (vc->vc_font.height < 10) ? 1 : 2; - int width =3D (vc->vc_font.width + 7) >> 3; + int width =3D font_glyph_pitch(vc->vc_font.width); unsigned int cellsize =3D vc->vc_font.height * width; u8 c; =20 @@ -153,7 +153,7 @@ static void ud_putcs(struct vc_data *vc, struct fb_info= *info, { struct fb_image image; struct fbcon_par *par =3D info->fbcon_par; - u32 width =3D (vc->vc_font.width + 7)/8; + u32 width =3D font_glyph_pitch(vc->vc_font.width); u32 cellsize =3D width * vc->vc_font.height; u32 maxcnt =3D info->pixmap.size/cellsize; u32 scan_align =3D info->pixmap.scan_align - 1; @@ -253,7 +253,8 @@ static void ud_cursor(struct vc_data *vc, struct fb_inf= o *info, bool enable, struct fb_cursor cursor; struct fbcon_par *par =3D info->fbcon_par; unsigned short charmask =3D vc->vc_hi_font_mask ? 0x1ff : 0xff; - int w =3D (vc->vc_font.width + 7) >> 3, c; + int w =3D font_glyph_pitch(vc->vc_font.width); + int c; int y =3D real_y(par->p, vc->state.y); int attribute, use_sw =3D vc->vc_cursor_type & CUR_SW; int err =3D 1, dx, dy; diff --git a/include/linux/font.h b/include/linux/font.h index 5401f07dd6ce..3bd49d914b22 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -11,10 +11,50 @@ #ifndef _VIDEO_FONT_H #define _VIDEO_FONT_H =20 +#include #include =20 struct console_font; =20 +/* + * Glyphs + */ + +/** + * font_glyph_pitch - Calculates the number of bytes per scanline + * @width: The glyph width in bits per scanline + * + * A glyph's pitch is the number of bytes in a single scanline, rounded + * up to the next full byte. The parameter @width receives the number + * of visible bits per scanline. For example, if width is 14 bytes per + * scanline, the pitch is 2 bytes per scanline. If width is 8 bits per + * scanline, the pitch is 1 byte per scanline. + * + * Returns: + * The number of bytes in a single scanline of the glyph + */ +static inline unsigned int font_glyph_pitch(unsigned int width) +{ + return DIV_ROUND_UP(width, 8); +} + +/** + * font_glyph_size - Calculates the number of bytes per glyph + * @width: The glyph width in bits per scanline + * @vpitch: The number of scanlines in the glyph + * + * The number of bytes in a glyph depends on the pitch and the number + * of scanlines. font_glyph_size automatically calculates the pitch + * from the given width. The parameter @vpitch gives the number of + * scanlines, which is usually the glyph's height in scanlines. Fonts + * coming from user space can sometimes have a different vertical pitch + * with empty scanlines between two adjacent glyphs. + */ +static inline unsigned int font_glyph_size(unsigned int width, unsigned in= t vpitch) +{ + return font_glyph_pitch(width) * vpitch; +} + /* * font_data_t and helpers */ diff --git a/lib/fonts/fonts.c b/lib/fonts/fonts.c index 5938f542906b..f5d5333450a0 100644 --- a/lib/fonts/fonts.c +++ b/lib/fonts/fonts.c @@ -26,7 +26,7 @@ =20 #include "font.h" =20 -#define console_font_pitch(font) DIV_ROUND_UP((font)->width, 8) +#define console_font_pitch(font) font_glyph_pitch((font)->width) =20 /* * Helpers for font_data_t --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2BAB3A0B13 for ; Tue, 7 Apr 2026 09:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553987; cv=none; b=FIDa5WVVC3yM671GH/sZJMH26RsmOxq3qq6g1r4CQF0z0FsGQ78tGP2J+fjnhvgLp71acYDv+VIKOKsiZ+NFocE0SFr9yQF6VtZsH1QiKcehHkfTpoSC+calAm+0HVDeuAH3VzPkQYjhTqOPMKUv6bd9441pfk8KJsejtBIsIO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553987; c=relaxed/simple; bh=Qioa5y+ETd9nP6o0/bt9KzMuqtj3j4mO/QsaeV4d6ls=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kb1IOKe4pW+gKsTR/jkgA6aG8KJ617Bd5d0lf0CmcC4QuNYp6kgpFJvdUdwdgrBjuNd9K2ctfzJ6KeNbidtKKo+wmBhrEh2MkrkE5bdRXzAL4s30DkQrvTZ19lafX0QMzdL85Rn26b3tzdbB0/rcOm+iOR9jKuTMv/HIBLNUBVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C7A124E3A6; Tue, 7 Apr 2026 09:26:01 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7FA5B4A0B1; Tue, 7 Apr 2026 09:26:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SOb0HanN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:01 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 04/10] lib/fonts: Clean up Makefile Date: Tue, 7 Apr 2026 11:23:15 +0200 Message-ID: <20260407092555.58816-5-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: C7A124E3A6 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Score: -4.00 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Content-Type: text/plain; charset="utf-8" Simplify the Makefile. Drop font-obj-y and sort the fonts by dictionary order. Done in preparation for supporting optional font rotation. v2: - sort Makefile font entries by Family/Size in ascending order (Geert, Jiri) Signed-off-by: Thomas Zimmermann --- lib/fonts/Makefile | 35 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/lib/fonts/Makefile b/lib/fonts/Makefile index 30a85a4292fa..b176af53d53e 100644 --- a/lib/fonts/Makefile +++ b/lib/fonts/Makefile @@ -1,23 +1,22 @@ # SPDX-License-Identifier: GPL-2.0 # Font handling =20 -font-objs :=3D fonts.o +font-y :=3D fonts.o =20 -font-objs-$(CONFIG_FONT_SUN8x16) +=3D font_sun8x16.o -font-objs-$(CONFIG_FONT_SUN12x22) +=3D font_sun12x22.o -font-objs-$(CONFIG_FONT_8x8) +=3D font_8x8.o -font-objs-$(CONFIG_FONT_8x16) +=3D font_8x16.o -font-objs-$(CONFIG_FONT_6x11) +=3D font_6x11.o -font-objs-$(CONFIG_FONT_7x14) +=3D font_7x14.o -font-objs-$(CONFIG_FONT_10x18) +=3D font_10x18.o -font-objs-$(CONFIG_FONT_PEARL_8x8) +=3D font_pearl_8x8.o -font-objs-$(CONFIG_FONT_ACORN_8x8) +=3D font_acorn_8x8.o -font-objs-$(CONFIG_FONT_MINI_4x6) +=3D font_mini_4x6.o -font-objs-$(CONFIG_FONT_6x10) +=3D font_6x10.o -font-objs-$(CONFIG_FONT_TER10x18) +=3D font_ter10x18.o -font-objs-$(CONFIG_FONT_TER16x32) +=3D font_ter16x32.o -font-objs-$(CONFIG_FONT_6x8) +=3D font_6x8.o +# Built-in fonts; sorted by Family-Size in ascending order +font-$(CONFIG_FONT_6x8) +=3D font_6x8.o +font-$(CONFIG_FONT_6x10) +=3D font_6x10.o +font-$(CONFIG_FONT_6x11) +=3D font_6x11.o +font-$(CONFIG_FONT_7x14) +=3D font_7x14.o +font-$(CONFIG_FONT_8x8) +=3D font_8x8.o +font-$(CONFIG_FONT_8x16) +=3D font_8x16.o +font-$(CONFIG_FONT_10x18) +=3D font_10x18.o +font-$(CONFIG_FONT_ACORN_8x8) +=3D font_acorn_8x8.o +font-$(CONFIG_FONT_MINI_4x6) +=3D font_mini_4x6.o +font-$(CONFIG_FONT_PEARL_8x8) +=3D font_pearl_8x8.o +font-$(CONFIG_FONT_SUN8x16) +=3D font_sun8x16.o +font-$(CONFIG_FONT_SUN12x22) +=3D font_sun12x22.o +font-$(CONFIG_FONT_TER10x18) +=3D font_ter10x18.o +font-$(CONFIG_FONT_TER16x32) +=3D font_ter16x32.o =20 -font-objs +=3D $(font-objs-y) - -obj-$(CONFIG_FONT_SUPPORT) +=3D font.o +obj-$(CONFIG_FONT_SUPPORT) +=3D font.o --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C503A382C for ; Tue, 7 Apr 2026 09:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553965; cv=none; b=Ziyk7ufu2zyQefRtggVYSoNteaWhT9IhYLlm1Tmhv1m17mJzu9a/MLzKkbhZW5kqziTW8vb9v/qrHpXHhqQ20GVx2ysMKPgnvU1XgoT5ZShcpUHdLsICa5wja+A7UR94D1a/Q+uKPRddbKwb2zeRLy8o59jXzNaDHI0isvXzPBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553965; c=relaxed/simple; bh=KCnv/j7/fFrmaCWDV5Ma//ZWy6S231YiLGUCG74mNh8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Kx2xsXyknN24Mq1FrOE/FEeeFkYuLNaO0Lok3wwY9H6SbNyC1MaPVTGerPDr9b5knXa8JxMPiO5d658Cyt9ztWNxGr3qAnLwhu1V3qoZNwRz0ir+Udct10w9FeFQtkwX9UpAOdEIa7yX4/qQ+gbWh/aSUQxCtf8pAj75ccwMxpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2284F5BD7F; Tue, 7 Apr 2026 09:26:02 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CEBBB4A0B1; Tue, 7 Apr 2026 09:26:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OIZHManN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:01 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 05/10] lib/fonts: Implement glyph rotation Date: Tue, 7 Apr 2026 11:23:16 +0200 Message-ID: <20260407092555.58816-6-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 2284F5BD7F X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.00 X-Spam-Level: Move the glyph rotation helpers from fbcon to the font library. Wrap them behind clean interfaces. Also clear the output memory to zero. Previously, the implementation relied on the caller to do that. Go through the fbcon code and callers of the glyph-rotation helpers. In addition to the font rotation, there's also the cursor code, which uses the rotation helpers. The font-rotation relied on a single memset to zero for the whole font. This is now multiple memsets on each glyph. This will be sorted out when the font library also implements font rotation. Building glyph rotation in the font library still depends on CONFIG_FRAMEBUFFER_CONSOLE_ROTATION=3Dy. If we get more users of the code, we can still add a dedicated Kconfig symbol to the font library. No changes have been made to the actual implementation of the rotate_*() and pattern_*() functions. These will be refactored as separate changes. v2: - fix typos Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbcon_ccw.c | 4 +- drivers/video/fbdev/core/fbcon_cw.c | 4 +- drivers/video/fbdev/core/fbcon_rotate.c | 12 +- drivers/video/fbdev/core/fbcon_rotate.h | 71 ----------- include/linux/font.h | 8 ++ lib/fonts/Makefile | 1 + lib/fonts/font_rotate.c | 150 ++++++++++++++++++++++++ 7 files changed, 167 insertions(+), 83 deletions(-) create mode 100644 lib/fonts/font_rotate.c diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/cor= e/fbcon_ccw.c index 96ef449ee6ac..72453a2aaca8 100644 --- a/drivers/video/fbdev/core/fbcon_ccw.c +++ b/drivers/video/fbdev/core/fbcon_ccw.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -344,8 +345,7 @@ static void ccw_cursor(struct vc_data *vc, struct fb_in= fo *info, bool enable, size =3D cur_height * width; while (size--) tmp[i++] =3D 0xff; - memset(mask, 0, w * vc->vc_font.width); - rotate_ccw(tmp, mask, vc->vc_font.width, vc->vc_font.height); + font_glyph_rotate_270(tmp, vc->vc_font.width, vc->vc_font.height, mask); kfree(tmp); } =20 diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core= /fbcon_cw.c index ea712654edae..5690fc1d7854 100644 --- a/drivers/video/fbdev/core/fbcon_cw.c +++ b/drivers/video/fbdev/core/fbcon_cw.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -327,8 +328,7 @@ static void cw_cursor(struct vc_data *vc, struct fb_inf= o *info, bool enable, size =3D cur_height * width; while (size--) tmp[i++] =3D 0xff; - memset(mask, 0, w * vc->vc_font.width); - rotate_cw(tmp, mask, vc->vc_font.width, vc->vc_font.height); + font_glyph_rotate_90(tmp, vc->vc_font.width, vc->vc_font.height, mask); kfree(tmp); } =20 diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/= core/fbcon_rotate.c index 18575c5182db..588dc9d6758a 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.c +++ b/drivers/video/fbdev/core/fbcon_rotate.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -60,30 +61,25 @@ int fbcon_rotate_font(struct fb_info *info, struct vc_d= ata *vc) } =20 dst =3D par->fontbuffer; - memset(dst, 0, par->fd_size); =20 switch (par->rotate) { case FB_ROTATE_UD: for (i =3D len; i--; ) { - rotate_ud(src, dst, vc->vc_font.width, - vc->vc_font.height); - + font_glyph_rotate_180(src, vc->vc_font.width, vc->vc_font.height, dst); src +=3D s_cellsize; dst +=3D d_cellsize; } break; case FB_ROTATE_CW: for (i =3D len; i--; ) { - rotate_cw(src, dst, vc->vc_font.width, - vc->vc_font.height); + font_glyph_rotate_90(src, vc->vc_font.width, vc->vc_font.height, dst); src +=3D s_cellsize; dst +=3D d_cellsize; } break; case FB_ROTATE_CCW: for (i =3D len; i--; ) { - rotate_ccw(src, dst, vc->vc_font.width, - vc->vc_font.height); + font_glyph_rotate_270(src, vc->vc_font.width, vc->vc_font.height, dst); src +=3D s_cellsize; dst +=3D d_cellsize; } diff --git a/drivers/video/fbdev/core/fbcon_rotate.h b/drivers/video/fbdev/= core/fbcon_rotate.h index 8cb019e8a9c0..725bcae2df61 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.h +++ b/drivers/video/fbdev/core/fbcon_rotate.h @@ -19,77 +19,6 @@ (fb_scrollmode(s) =3D=3D SCROLL_REDRAW || fb_scrollmode(s) =3D=3D = SCROLL_MOVE || !(i)->fix.xpanstep) ? \ (i)->var.xres : (i)->var.xres_virtual; }) =20 - -static inline int pattern_test_bit(u32 x, u32 y, u32 pitch, const char *pa= t) -{ - u32 tmp =3D (y * pitch) + x, index =3D tmp / 8, bit =3D tmp % 8; - - pat +=3Dindex; - return (*pat) & (0x80 >> bit); -} - -static inline void pattern_set_bit(u32 x, u32 y, u32 pitch, char *pat) -{ - u32 tmp =3D (y * pitch) + x, index =3D tmp / 8, bit =3D tmp % 8; - - pat +=3D index; - - (*pat) |=3D 0x80 >> bit; -} - -static inline void rotate_ud(const char *in, char *out, u32 width, u32 hei= ght) -{ - int i, j; - int shift =3D (8 - (width % 8)) & 7; - - width =3D (width + 7) & ~7; - - for (i =3D 0; i < height; i++) { - for (j =3D 0; j < width - shift; j++) { - if (pattern_test_bit(j, i, width, in)) - pattern_set_bit(width - (1 + j + shift), - height - (1 + i), - width, out); - } - - } -} - -static inline void rotate_cw(const char *in, char *out, u32 width, u32 hei= ght) -{ - int i, j, h =3D height, w =3D width; - int shift =3D (8 - (height % 8)) & 7; - - width =3D (width + 7) & ~7; - height =3D (height + 7) & ~7; - - for (i =3D 0; i < h; i++) { - for (j =3D 0; j < w; j++) { - if (pattern_test_bit(j, i, width, in)) - pattern_set_bit(height - 1 - i - shift, j, - height, out); - - } - } -} - -static inline void rotate_ccw(const char *in, char *out, u32 width, u32 he= ight) -{ - int i, j, h =3D height, w =3D width; - int shift =3D (8 - (width % 8)) & 7; - - width =3D (width + 7) & ~7; - height =3D (height + 7) & ~7; - - for (i =3D 0; i < h; i++) { - for (j =3D 0; j < w; j++) { - if (pattern_test_bit(j, i, width, in)) - pattern_set_bit(i, width - 1 - j - shift, - height, out); - } - } -} - int fbcon_rotate_font(struct fb_info *info, struct vc_data *vc); =20 #if defined(CONFIG_FRAMEBUFFER_CONSOLE_ROTATION) diff --git a/include/linux/font.h b/include/linux/font.h index 3bd49d914b22..0a240dd70422 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -104,6 +104,14 @@ unsigned int font_data_size(font_data_t *fd); bool font_data_is_equal(font_data_t *lhs, font_data_t *rhs); int font_data_export(font_data_t *fd, struct console_font *font, unsigned = int vpitch); =20 +/* font_rotate.c */ +void font_glyph_rotate_90(const unsigned char *glyph, unsigned int width, = unsigned int height, + unsigned char *out); +void font_glyph_rotate_180(const unsigned char *glyph, unsigned int width,= unsigned int height, + unsigned char *out); +void font_glyph_rotate_270(const unsigned char *glyph, unsigned int width,= unsigned int height, + unsigned char *out); + /* * Font description */ diff --git a/lib/fonts/Makefile b/lib/fonts/Makefile index b176af53d53e..7202a70a56ef 100644 --- a/lib/fonts/Makefile +++ b/lib/fonts/Makefile @@ -2,6 +2,7 @@ # Font handling =20 font-y :=3D fonts.o +font-$(CONFIG_FRAMEBUFFER_CONSOLE_ROTATION) +=3D font_rotate.o =20 # Built-in fonts; sorted by Family-Size in ascending order font-$(CONFIG_FONT_6x8) +=3D font_6x8.o diff --git a/lib/fonts/font_rotate.c b/lib/fonts/font_rotate.c new file mode 100644 index 000000000000..d107a8d0a2b0 --- /dev/null +++ b/lib/fonts/font_rotate.c @@ -0,0 +1,150 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Font rotation + * + * Copyright (C) 2005 Antonino Daplas + * + * This file is subject to the terms and conditions of the GNU General Pub= lic + * License. See the file COPYING in the main directory of this archive for + * more details. + */ + +#include +#include +#include + +#include "font.h" + +static inline int pattern_test_bit(u32 x, u32 y, u32 pitch, const char *pa= t) +{ + u32 tmp =3D (y * pitch) + x, index =3D tmp / 8, bit =3D tmp % 8; + + pat +=3D index; + return (*pat) & (0x80 >> bit); +} + +static inline void pattern_set_bit(u32 x, u32 y, u32 pitch, char *pat) +{ + u32 tmp =3D (y * pitch) + x, index =3D tmp / 8, bit =3D tmp % 8; + + pat +=3D index; + + (*pat) |=3D 0x80 >> bit; +} + +static inline void rotate_cw(const char *in, char *out, u32 width, u32 hei= ght) +{ + int i, j, h =3D height, w =3D width; + int shift =3D (8 - (height % 8)) & 7; + + width =3D (width + 7) & ~7; + height =3D (height + 7) & ~7; + + for (i =3D 0; i < h; i++) { + for (j =3D 0; j < w; j++) { + if (pattern_test_bit(j, i, width, in)) + pattern_set_bit(height - 1 - i - shift, j, + height, out); + } + } +} + +/** + * font_glyph_rotate_90 - Rotate a glyph pattern by 90=C2=B0 in clockwise = direction + * @glyph: The glyph to rotate + * @width: The glyph width in bits per scanline + * @height: The number of scanlines in the glyph + * @out: The rotated glyph bitmap + * + * The parameters @width and @height refer to the input glyph given in @gl= yph. + * The caller has to provide the output buffer @out of sufficient size to = hold + * the rotated glyph. Rotating by 90=C2=B0 flips the width and height for = the output + * glyph. Depending on the glyph pitch, the size of the output glyph can be + * different than the size of the input. Callers have to take this into ac= count + * when allocating the output memory. + */ +void font_glyph_rotate_90(const unsigned char *glyph, unsigned int width, = unsigned int height, + unsigned char *out) +{ + memset(out, 0, font_glyph_size(height, width)); /* flip width/height */ + + rotate_cw(glyph, out, width, height); +} +EXPORT_SYMBOL_GPL(font_glyph_rotate_90); + +static inline void rotate_ud(const char *in, char *out, u32 width, u32 hei= ght) +{ + int i, j; + int shift =3D (8 - (width % 8)) & 7; + + width =3D (width + 7) & ~7; + + for (i =3D 0; i < height; i++) { + for (j =3D 0; j < width - shift; j++) { + if (pattern_test_bit(j, i, width, in)) + pattern_set_bit(width - (1 + j + shift), + height - (1 + i), + width, out); + } + } +} + +/** + * font_glyph_rotate_180 - Rotate a glyph pattern by 180=C2=B0 + * @glyph: The glyph to rotate + * @width: The glyph width in bits per scanline + * @height: The number of scanlines in the glyph + * @out: The rotated glyph bitmap + * + * The parameters @width and @height refer to the input glyph given in @gl= yph. + * The caller has to provide the output buffer @out of sufficient size to = hold + * the rotated glyph. + */ +void font_glyph_rotate_180(const unsigned char *glyph, unsigned int width,= unsigned int height, + unsigned char *out) +{ + memset(out, 0, font_glyph_size(width, height)); + + rotate_ud(glyph, out, width, height); +} +EXPORT_SYMBOL_GPL(font_glyph_rotate_180); + +static inline void rotate_ccw(const char *in, char *out, u32 width, u32 he= ight) +{ + int i, j, h =3D height, w =3D width; + int shift =3D (8 - (width % 8)) & 7; + + width =3D (width + 7) & ~7; + height =3D (height + 7) & ~7; + + for (i =3D 0; i < h; i++) { + for (j =3D 0; j < w; j++) { + if (pattern_test_bit(j, i, width, in)) + pattern_set_bit(i, width - 1 - j - shift, + height, out); + } + } +} + +/** + * font_glyph_rotate_270 - Rotate a glyph pattern by 270=C2=B0 in clockwis= e direction + * @glyph: The glyph to rotate + * @width: The glyph width in bits per scanline + * @height: The number of scanlines in the glyph + * @out: The rotated glyph bitmap + * + * The parameters @width and @height refer to the input glyph given in @gl= yph. + * The caller has to provide the output buffer @out of sufficient size to = hold + * the rotated glyph. Rotating by 270=C2=B0 flips the width and height for= the output + * glyph. Depending on the glyph pitch, the size of the output glyph can be + * different than the size of the input. Callers have to take this into ac= count + * when allocating the output memory. + */ +void font_glyph_rotate_270(const unsigned char *glyph, unsigned int width,= unsigned int height, + unsigned char *out) +{ + memset(out, 0, font_glyph_size(height, width)); /* flip width/height */ + + rotate_ccw(glyph, out, width, height); +} +EXPORT_SYMBOL_GPL(font_glyph_rotate_270); --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4FC53921C2 for ; Tue, 7 Apr 2026 09:26:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553973; cv=none; b=A1b6aE+ytQOYQhpj5yLxg9t/xWZxHc0e48iIRM9naDpmakPsweA6C9xvowtcCWqmTDyW/5qHeGQv4rYnPumqt2qk4Wu0u9Q4acOIM5FD6qPr+8DbYPYxW8tz/1W9Dk1CRcDIgVB0WwHtAG3ETvFNYfv0lLIUUDTfZ3qmp0qvdeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553973; c=relaxed/simple; bh=Q0YrM80+9BR2rwh+XvdR+CvuMQx5eZDfzTCekUhR9H0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rU3HDEWRShmw1bQxHWKjzebKCtfju0wlbYQfhycJ5uYlXAtF1rhP4YAwnIHjD6LSFEWomMoFOyRW/wysFsyqwtVMvvfFfBWec+8hD9snh8cK7H1d0Ddlwo1AYoX4nSqIHlO22aYfrTxX+vxgGGUJoq7BXhH6nG0RHdcQopVp0DE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=tQ6A63eE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=x3nBAkET; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=tQ6A63eE; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=x3nBAkET; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tQ6A63eE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="x3nBAkET"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="tQ6A63eE"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="x3nBAkET" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 701F55BDC9; Tue, 7 Apr 2026 09:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApLXYBVZV9e6jW5EshZorOekllfCvuYRwCb90bprZVY=; b=tQ6A63eEoC84swYshVJMmcr7LIW2kTKTia6aL6LTdqOdXf7Z9juplY3E05eqVCIbjlImll puZukf4P1RXgTitaSWoADmZm+A6nhPXWSsC0L655wCIEuD9DiFTyJEJf7RkJoM3pfeEVpY i7q61PNn6fXweFCgU0lN5eLVu0SxF/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApLXYBVZV9e6jW5EshZorOekllfCvuYRwCb90bprZVY=; b=x3nBAkETuy+6PfyrzScueCR7vnQv7FHcAbghRSTJ9FSDA37ua6gXj/fsRm4IafRYxmXvn6 5s8tte4E4m+hDyAg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApLXYBVZV9e6jW5EshZorOekllfCvuYRwCb90bprZVY=; b=tQ6A63eEoC84swYshVJMmcr7LIW2kTKTia6aL6LTdqOdXf7Z9juplY3E05eqVCIbjlImll puZukf4P1RXgTitaSWoADmZm+A6nhPXWSsC0L655wCIEuD9DiFTyJEJf7RkJoM3pfeEVpY i7q61PNn6fXweFCgU0lN5eLVu0SxF/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ApLXYBVZV9e6jW5EshZorOekllfCvuYRwCb90bprZVY=; b=x3nBAkETuy+6PfyrzScueCR7vnQv7FHcAbghRSTJ9FSDA37ua6gXj/fsRm4IafRYxmXvn6 5s8tte4E4m+hDyAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 28B2D4A0B2; Tue, 7 Apr 2026 09:26:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +Om/CKrN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:02 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 06/10] lib/fonts: Refactor glyph-pattern helpers Date: Tue, 7 Apr 2026 11:23:17 +0200 Message-ID: <20260407092555.58816-7-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_TO(0.00)[gmx.de,linuxfoundation.org,kernel.org,linux-m68k.org,ffwll.ch,ravnborg.org]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_SEVEN(0.00)[11]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO X-Spam-Score: -6.80 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Change the signatures of the pattern helpers to align them with other font-glyph helpers: use the font_glyph_ prefix and pass the glyph buffer first. Calculating the position of the involved bit is somewhat obfuscated in the original implementation. Move it into the new helper __font_glyph_pos() and use the result as array index and bit position. Note that these bit helpers use a bit pitch, while other code uses a byte pitch. This is intentional and required here. v2: - fix typos in commit message Signed-off-by: Thomas Zimmermann --- lib/fonts/font_rotate.c | 45 ++++++++++++++++++++++++----------------- 1 file changed, 27 insertions(+), 18 deletions(-) diff --git a/lib/fonts/font_rotate.c b/lib/fonts/font_rotate.c index d107a8d0a2b0..d79ec5eef712 100644 --- a/lib/fonts/font_rotate.c +++ b/lib/fonts/font_rotate.c @@ -15,21 +15,33 @@ =20 #include "font.h" =20 -static inline int pattern_test_bit(u32 x, u32 y, u32 pitch, const char *pa= t) +static unsigned int __font_glyph_pos(unsigned int x, unsigned int y, unsig= ned int bit_pitch, + unsigned int *bit) { - u32 tmp =3D (y * pitch) + x, index =3D tmp / 8, bit =3D tmp % 8; + unsigned int off =3D y * bit_pitch + x; + unsigned int bit_shift =3D off % 8; =20 - pat +=3D index; - return (*pat) & (0x80 >> bit); + *bit =3D 0x80 >> bit_shift; /* MSB has position 0, LSB has position 7 */ + + return off / 8; } =20 -static inline void pattern_set_bit(u32 x, u32 y, u32 pitch, char *pat) +static bool font_glyph_test_bit(const unsigned char *glyph, unsigned int x= , unsigned int y, + unsigned int bit_pitch) { - u32 tmp =3D (y * pitch) + x, index =3D tmp / 8, bit =3D tmp % 8; + unsigned int bit; + unsigned int i =3D __font_glyph_pos(x, y, bit_pitch, &bit); + + return glyph[i] & bit; +} =20 - pat +=3D index; +static void font_glyph_set_bit(unsigned char *glyph, unsigned int x, unsig= ned int y, + unsigned int bit_pitch) +{ + unsigned int bit; + unsigned int i =3D __font_glyph_pos(x, y, bit_pitch, &bit); =20 - (*pat) |=3D 0x80 >> bit; + glyph[i] |=3D bit; } =20 static inline void rotate_cw(const char *in, char *out, u32 width, u32 hei= ght) @@ -42,9 +54,8 @@ static inline void rotate_cw(const char *in, char *out, u= 32 width, u32 height) =20 for (i =3D 0; i < h; i++) { for (j =3D 0; j < w; j++) { - if (pattern_test_bit(j, i, width, in)) - pattern_set_bit(height - 1 - i - shift, j, - height, out); + if (font_glyph_test_bit(in, j, i, width)) + font_glyph_set_bit(out, height - 1 - i - shift, j, height); } } } @@ -81,10 +92,9 @@ static inline void rotate_ud(const char *in, char *out, = u32 width, u32 height) =20 for (i =3D 0; i < height; i++) { for (j =3D 0; j < width - shift; j++) { - if (pattern_test_bit(j, i, width, in)) - pattern_set_bit(width - (1 + j + shift), - height - (1 + i), - width, out); + if (font_glyph_test_bit(in, j, i, width)) + font_glyph_set_bit(out, width - (1 + j + shift), + height - (1 + i), width); } } } @@ -119,9 +129,8 @@ static inline void rotate_ccw(const char *in, char *out= , u32 width, u32 height) =20 for (i =3D 0; i < h; i++) { for (j =3D 0; j < w; j++) { - if (pattern_test_bit(j, i, width, in)) - pattern_set_bit(i, width - 1 - j - shift, - height, out); + if (font_glyph_test_bit(in, j, i, width)) + font_glyph_set_bit(out, i, width - 1 - j - shift, height); } } } --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E2213A63EF for ; Tue, 7 Apr 2026 09:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553997; cv=none; b=nSP8vezqT4Nbg1QqwqYhlbQNuxZYjwwBrYGAMgAfNBBspJN6ByU30nJVs4UdQ3E2v8QyWD/B6HSpebLS1PjNuR9X05DtlFw5Q2nOxI1irLfd/rWg3O8jWUOwheXEYCEjtKbsd8DHDiaE81HUDnsouz2k8ORwaRKJExx+0IMAvEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553997; c=relaxed/simple; bh=sofMrLVaRJmHnvOi/WZ5dFviNY/Uz7j8i1kFmDfvWb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g5oCWEmyyiLaPm91GwpuMpJNlXJvVmRgkfVVOjhx+ZPFsCLqbYpFvM1EeWeRL4JUJ4xLnu8eVrWqwLZytEOhAi83rLykKax7eUfwqB6Lq3BHNxPK6CtO87f3IXcgPrYpXQyqwshIA/oIdiIaLcuIuhMXXqP2dDnsZ6H/goLdGRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=VRUh9Pu4; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=f2PBLy9Q; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=VRUh9Pu4; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=f2PBLy9Q; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="VRUh9Pu4"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="f2PBLy9Q"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="VRUh9Pu4"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="f2PBLy9Q" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BEE1F4E3A7; Tue, 7 Apr 2026 09:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCDCXBTApxJH1hMKkIqxFlk34L2bDMI+B4Yn1SPG6x8=; b=VRUh9Pu4nPuT0+fqL7252IVmy/67zz8WbsIjC0T/lHmerDDqlEq0LTrhghsfE9HDukxNPd XrKkR7oBkWg8wOSf6CtWClCQhzkzuGh6hbwam8CjS2lXklwwMWelHIcBvC2mejSXJZaQi8 x8iqwa1m0IpML/K5fs0QJpORJMj+884= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCDCXBTApxJH1hMKkIqxFlk34L2bDMI+B4Yn1SPG6x8=; b=f2PBLy9QFyHaNXvGyoFOmZqiztopXPastvaMT95Ki9u/8a4opgT7g9m1A+A5MONLgrp/6V vImn70S5btaeF4AQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCDCXBTApxJH1hMKkIqxFlk34L2bDMI+B4Yn1SPG6x8=; b=VRUh9Pu4nPuT0+fqL7252IVmy/67zz8WbsIjC0T/lHmerDDqlEq0LTrhghsfE9HDukxNPd XrKkR7oBkWg8wOSf6CtWClCQhzkzuGh6hbwam8CjS2lXklwwMWelHIcBvC2mejSXJZaQi8 x8iqwa1m0IpML/K5fs0QJpORJMj+884= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775553962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DCDCXBTApxJH1hMKkIqxFlk34L2bDMI+B4Yn1SPG6x8=; b=f2PBLy9QFyHaNXvGyoFOmZqiztopXPastvaMT95Ki9u/8a4opgT7g9m1A+A5MONLgrp/6V vImn70S5btaeF4AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 75DB04A0B1; Tue, 7 Apr 2026 09:26:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8OeTG6rN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:02 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 07/10] lib/fonts: Refactor glyph-rotation helpers Date: Tue, 7 Apr 2026 11:23:18 +0200 Message-ID: <20260407092555.58816-8-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.80 X-Spam-Level: X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmx.de,linuxfoundation.org,kernel.org,linux-m68k.org,ffwll.ch,ravnborg.org]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLqirfcw6gnbcr9a9yhi49fhi6)]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVRCPT(0.00)[gmx.de] X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Change the signatures of the glyph-rotation helpers to match their public interfaces. Drop the inline qualifier. Rename several variables to better match their meaning. Especially rename variables to bit_pitch (or a variant thereof) if they store a pitch value in bits per scanline. The original code is fairly confusing about this. Move the calculation of the bit pitch into the new helper font_glyph_bit_pitch(). Signed-off-by: Thomas Zimmermann --- lib/fonts/font_rotate.c | 85 ++++++++++++++++++++++++----------------- 1 file changed, 49 insertions(+), 36 deletions(-) diff --git a/lib/fonts/font_rotate.c b/lib/fonts/font_rotate.c index d79ec5eef712..09f6218e036f 100644 --- a/lib/fonts/font_rotate.c +++ b/lib/fonts/font_rotate.c @@ -15,6 +15,12 @@ =20 #include "font.h" =20 +/* number of bits per line */ +static unsigned int font_glyph_bit_pitch(unsigned int width) +{ + return round_up(width, 8); +} + static unsigned int __font_glyph_pos(unsigned int x, unsigned int y, unsig= ned int bit_pitch, unsigned int *bit) { @@ -44,18 +50,21 @@ static void font_glyph_set_bit(unsigned char *glyph, un= signed int x, unsigned in glyph[i] |=3D bit; } =20 -static inline void rotate_cw(const char *in, char *out, u32 width, u32 hei= ght) +static void __font_glyph_rotate_90(const unsigned char *glyph, + unsigned int width, unsigned int height, + unsigned char *out) { - int i, j, h =3D height, w =3D width; - int shift =3D (8 - (height % 8)) & 7; - - width =3D (width + 7) & ~7; - height =3D (height + 7) & ~7; - - for (i =3D 0; i < h; i++) { - for (j =3D 0; j < w; j++) { - if (font_glyph_test_bit(in, j, i, width)) - font_glyph_set_bit(out, height - 1 - i - shift, j, height); + unsigned int x, y; + unsigned int shift =3D (8 - (height % 8)) & 7; + unsigned int bit_pitch =3D font_glyph_bit_pitch(width); + unsigned int out_bit_pitch =3D font_glyph_bit_pitch(height); + + for (y =3D 0; y < height; y++) { + for (x =3D 0; x < width; x++) { + if (font_glyph_test_bit(glyph, x, y, bit_pitch)) { + font_glyph_set_bit(out, out_bit_pitch - 1 - y - shift, x, + out_bit_pitch); + } } } } @@ -79,22 +88,24 @@ void font_glyph_rotate_90(const unsigned char *glyph, u= nsigned int width, unsign { memset(out, 0, font_glyph_size(height, width)); /* flip width/height */ =20 - rotate_cw(glyph, out, width, height); + __font_glyph_rotate_90(glyph, width, height, out); } EXPORT_SYMBOL_GPL(font_glyph_rotate_90); =20 -static inline void rotate_ud(const char *in, char *out, u32 width, u32 hei= ght) +static void __font_glyph_rotate_180(const unsigned char *glyph, + unsigned int width, unsigned int height, + unsigned char *out) { - int i, j; - int shift =3D (8 - (width % 8)) & 7; - - width =3D (width + 7) & ~7; - - for (i =3D 0; i < height; i++) { - for (j =3D 0; j < width - shift; j++) { - if (font_glyph_test_bit(in, j, i, width)) - font_glyph_set_bit(out, width - (1 + j + shift), - height - (1 + i), width); + unsigned int x, y; + unsigned int shift =3D (8 - (width % 8)) & 7; + unsigned int bit_pitch =3D font_glyph_bit_pitch(width); + + for (y =3D 0; y < height; y++) { + for (x =3D 0; x < width; x++) { + if (font_glyph_test_bit(glyph, x, y, bit_pitch)) { + font_glyph_set_bit(out, width - (1 + x + shift), height - (1 + y), + bit_pitch); + } } } } @@ -115,22 +126,24 @@ void font_glyph_rotate_180(const unsigned char *glyph= , unsigned int width, unsig { memset(out, 0, font_glyph_size(width, height)); =20 - rotate_ud(glyph, out, width, height); + __font_glyph_rotate_180(glyph, width, height, out); } EXPORT_SYMBOL_GPL(font_glyph_rotate_180); =20 -static inline void rotate_ccw(const char *in, char *out, u32 width, u32 he= ight) +static void __font_glyph_rotate_270(const unsigned char *glyph, + unsigned int width, unsigned int height, + unsigned char *out) { - int i, j, h =3D height, w =3D width; - int shift =3D (8 - (width % 8)) & 7; - - width =3D (width + 7) & ~7; - height =3D (height + 7) & ~7; - - for (i =3D 0; i < h; i++) { - for (j =3D 0; j < w; j++) { - if (font_glyph_test_bit(in, j, i, width)) - font_glyph_set_bit(out, i, width - 1 - j - shift, height); + unsigned int x, y; + unsigned int shift =3D (8 - (width % 8)) & 7; + unsigned int bit_pitch =3D font_glyph_bit_pitch(width); + unsigned int out_bit_pitch =3D font_glyph_bit_pitch(height); + + for (y =3D 0; y < height; y++) { + for (x =3D 0; x < width; x++) { + if (font_glyph_test_bit(glyph, x, y, bit_pitch)) + font_glyph_set_bit(out, y, bit_pitch - 1 - x - shift, + out_bit_pitch); } } } @@ -154,6 +167,6 @@ void font_glyph_rotate_270(const unsigned char *glyph, = unsigned int width, unsig { memset(out, 0, font_glyph_size(height, width)); /* flip width/height */ =20 - rotate_ccw(glyph, out, width, height); + __font_glyph_rotate_270(glyph, width, height, out); } EXPORT_SYMBOL_GPL(font_glyph_rotate_270); --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50092399373 for ; Tue, 7 Apr 2026 09:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553979; cv=none; b=PNi5vL1Z23oKn0yEUv4jfpxHh6zMq8wOhL2sw2/wOLoPurh3iOBc/8X+SDSi1jWNkHpmiWZEWbEtew57DXN6tae58ZTsP+RBMjJPowqw2Gijd/lNMODToV00P4tzZl1ldQP86ACqNYWDGuHliQalCAmLWN1ElEJZB33INcC0XWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553979; c=relaxed/simple; bh=hd2mfuDjZXfZLsXF6AetLiRsdIjypjK39jjTH8sX+qQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hp+QVjJ5o5HZOuSOq7N76vcYDiHZtQHwPmWsXvlGQSX715+/30TzQzM+SUggVV7B8Fyh1ZR9xCq3lwaHL7blUjZ4bY6srP7eHfhEQJvHQVfjDhtoq+Y8oUxM5R0GRs3WU40BEzRtA1q8YA8anBEYIdAj0/7BczR3QncXHE3fqbs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 17F405BDCF; Tue, 7 Apr 2026 09:26:03 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C4FFE4A0B2; Tue, 7 Apr 2026 09:26:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WG7nLqrN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:02 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 08/10] lib/fonts: Implement font rotation Date: Tue, 7 Apr 2026 11:23:19 +0200 Message-ID: <20260407092555.58816-9-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 17F405BDCF X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.00 X-Spam-Level: Move the core of fbcon's font-rotation code to the font library as the new helper font_data_rotate(). The code can rotate in steps of 90=C2=B0. For completeness, it also copies the glyph data for multiples of 360=C2=B0. Bring back the memset optimization. A memset to 0 again clears the whole glyph output buffer. Then use the internal rotation helpers on the cleared output. Fbcon's original implementation worked like this, but lost it during refactoring. Replace fbcon's font-rotation code with the new implementations. All that's left to do for fbcon is to maintain its internal fbcon state. v2: - fix typos Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbcon.h | 2 +- drivers/video/fbdev/core/fbcon_rotate.c | 78 +++++------------- include/linux/font.h | 3 + lib/fonts/font_rotate.c | 103 ++++++++++++++++++++++++ 4 files changed, 126 insertions(+), 60 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.h b/drivers/video/fbdev/core/fb= con.h index 1e3c1ef84762..1793f34a6c84 100644 --- a/drivers/video/fbdev/core/fbcon.h +++ b/drivers/video/fbdev/core/fbcon.h @@ -86,7 +86,7 @@ struct fbcon_par { const u8 *fontdata; u8 *cursor_src; u32 cursor_size; - u32 fd_size; + size_t fd_size; =20 const struct fbcon_bitops *bitops; }; diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/= core/fbcon_rotate.c index 588dc9d6758a..74206f5a6e98 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.c +++ b/drivers/video/fbdev/core/fbcon_rotate.c @@ -8,84 +8,44 @@ * more details. */ =20 -#include -#include -#include +#include #include #include -#include -#include -#include + #include "fbcon.h" #include "fbcon_rotate.h" =20 int fbcon_rotate_font(struct fb_info *info, struct vc_data *vc) { struct fbcon_par *par =3D info->fbcon_par; - int len, err =3D 0; - int s_cellsize, d_cellsize, i; - const u8 *src; - u8 *dst; + unsigned char *fontbuffer; + int ret; =20 if (vc->vc_font.data =3D=3D par->fontdata && par->p->con_rotate =3D=3D par->cur_rotate) - goto finished; + return 0; =20 - src =3D par->fontdata =3D vc->vc_font.data; + par->fontdata =3D vc->vc_font.data; par->cur_rotate =3D par->p->con_rotate; - len =3D vc->vc_font.charcount; - s_cellsize =3D font_glyph_size(vc->vc_font.width, vc->vc_font.height); - d_cellsize =3D s_cellsize; - - if (par->rotate =3D=3D FB_ROTATE_CW || - par->rotate =3D=3D FB_ROTATE_CCW) - d_cellsize =3D font_glyph_size(vc->vc_font.height, vc->vc_font.width); =20 if (info->fbops->fb_sync) info->fbops->fb_sync(info); =20 - if (par->fd_size < d_cellsize * len) { - kfree(par->fontbuffer); - par->fontbuffer =3D NULL; - par->fd_size =3D 0; - - dst =3D kmalloc_array(len, d_cellsize, GFP_KERNEL); - - if (dst =3D=3D NULL) { - err =3D -ENOMEM; - goto finished; - } - - par->fd_size =3D d_cellsize * len; - par->fontbuffer =3D dst; + fontbuffer =3D font_data_rotate(par->p->fontdata, vc->vc_font.width, + vc->vc_font.height, vc->vc_font.charcount, + par->rotate, par->fontbuffer, &par->fd_size); + if (IS_ERR(fontbuffer)) { + ret =3D PTR_ERR(fontbuffer); + goto err_kfree; } =20 - dst =3D par->fontbuffer; + par->fontbuffer =3D fontbuffer; =20 - switch (par->rotate) { - case FB_ROTATE_UD: - for (i =3D len; i--; ) { - font_glyph_rotate_180(src, vc->vc_font.width, vc->vc_font.height, dst); - src +=3D s_cellsize; - dst +=3D d_cellsize; - } - break; - case FB_ROTATE_CW: - for (i =3D len; i--; ) { - font_glyph_rotate_90(src, vc->vc_font.width, vc->vc_font.height, dst); - src +=3D s_cellsize; - dst +=3D d_cellsize; - } - break; - case FB_ROTATE_CCW: - for (i =3D len; i--; ) { - font_glyph_rotate_270(src, vc->vc_font.width, vc->vc_font.height, dst); - src +=3D s_cellsize; - dst +=3D d_cellsize; - } - break; - } + return 0; + +err_kfree: + kfree(par->fontbuffer); + par->fontbuffer =3D NULL; /* clear here to avoid output */ =20 -finished: - return err; + return ret; } diff --git a/include/linux/font.h b/include/linux/font.h index 0a240dd70422..6845f02d739a 100644 --- a/include/linux/font.h +++ b/include/linux/font.h @@ -111,6 +111,9 @@ void font_glyph_rotate_180(const unsigned char *glyph, = unsigned int width, unsig unsigned char *out); void font_glyph_rotate_270(const unsigned char *glyph, unsigned int width,= unsigned int height, unsigned char *out); +unsigned char *font_data_rotate(font_data_t *fd, unsigned int width, unsig= ned int height, + unsigned int charcount, unsigned int steps, + unsigned char *buf, size_t *bufsize); =20 /* * Font description diff --git a/lib/fonts/font_rotate.c b/lib/fonts/font_rotate.c index 09f6218e036f..065e0fc0667b 100644 --- a/lib/fonts/font_rotate.c +++ b/lib/fonts/font_rotate.c @@ -9,8 +9,11 @@ * more details. */ =20 +#include #include #include +#include +#include #include =20 #include "font.h" @@ -170,3 +173,103 @@ void font_glyph_rotate_270(const unsigned char *glyph= , unsigned int width, unsig __font_glyph_rotate_270(glyph, width, height, out); } EXPORT_SYMBOL_GPL(font_glyph_rotate_270); + +/** + * font_data_rotate - Rotate font data by multiples of 90=C2=B0 + * @fd: The font data to rotate + * @width: The glyph width in bits per scanline + * @height: The number of scanlines in the glyph + * @charcount: The number of glyphs in the font + * @steps: Number of rotation steps of 90=C2=B0 + * @buf: Preallocated output buffer; can be NULL + * @bufsize: The size of @buf in bytes; can be NULL + * + * The parameters @width and @height refer to the visible number of pixels + * and scanlines in a single glyph. The number of glyphs is given in @char= count. + * Rotation happens in steps of 90=C2=B0. The @steps parameter can have an= y value, + * but only 0 to 3 produce distinct results. With 4 or higher, a full rota= tion + * has been performed. You can pass any value for @steps and the helper wi= ll + * perform the appropriate rotation. Note that the returned buffer is not + * compatible with font_data_t. It only contains glyph data in the same fo= rmat + * as returned by font_data_buf(). Callers are responsible to free the ret= urned + * buffer with kfree(). Font rotation typically happens when displays get + * re-oriented. To avoid unnecessary re-allocation of the memory buffer, t= he + * caller can pass in an earlier result buffer in @buf for reuse. The old = and + * new buffer sizes are given and retrieved by the caller in @bufsize. The + * allocation semantics are compatible with krealloc(). + * + * Returns: + * A buffer with rotated glyphs on success, or an error pointer otherwise + */ +unsigned char *font_data_rotate(font_data_t *fd, unsigned int width, unsig= ned int height, + unsigned int charcount, unsigned int steps, + unsigned char *buf, size_t *bufsize) +{ + const unsigned char *src =3D font_data_buf(fd); + unsigned int s_cellsize =3D font_glyph_size(width, height); + unsigned int d_cellsize, i; + unsigned char *dst; + size_t size; + + steps %=3D 4; + + switch (steps) { + case 0: + case 2: + d_cellsize =3D s_cellsize; + break; + case 1: + case 3: + d_cellsize =3D font_glyph_size(height, width); /* flip width/height */ + break; + } + + if (check_mul_overflow(charcount, d_cellsize, &size)) + return ERR_PTR(-EINVAL); + + if (!buf || !bufsize || size > *bufsize) { + dst =3D kmalloc_array(charcount, d_cellsize, GFP_KERNEL); + if (!dst) + return ERR_PTR(-ENOMEM); + + kfree(buf); + buf =3D dst; + if (bufsize) + *bufsize =3D size; + } else { + dst =3D buf; + } + + switch (steps) { + case 0: + memcpy(dst, src, size); + break; + case 1: + memset(dst, 0, size); + for (i =3D 0; i < charcount; ++i) { + __font_glyph_rotate_90(src, width, height, dst); + src +=3D s_cellsize; + dst +=3D d_cellsize; + } + break; + case 2: + memset(dst, 0, size); + for (i =3D 0; i < charcount; ++i) { + __font_glyph_rotate_180(src, width, height, dst); + src +=3D s_cellsize; + dst +=3D d_cellsize; + } + break; + case 3: + memset(dst, 0, size); + for (i =3D 0; i < charcount; ++i) { + __font_glyph_rotate_270(src, width, height, dst); + src +=3D s_cellsize; + dst +=3D d_cellsize; + } + break; + } + + return buf; +} +EXPORT_SYMBOL_GPL(font_data_rotate); --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F36E43A0B20 for ; Tue, 7 Apr 2026 09:26:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553988; cv=none; b=JNhf+mwAJJCKFqN0WYUZirIboE+BaZyM11dO3joC9OkpOKQdot1sYpCR6LUx3D4n0PFPN9dNsj7pMwUpwSsOcGELMuR2WguhZeHo11bMGQhJAs+e1dwakS7O9Z4EDKgCmrGDHV/AGAizUWt62lyvpCp1ILWUDuoXB8XVYkbQ+pE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775553988; c=relaxed/simple; bh=PRmaFX2pxn+Dd4vrvpEz33Y5uFvWYp/PSi7dCeRvYgA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LcRpzaMQcs6ss/ofnrgxa9Ymi1SIfz1NtWqEtI29Oucp8OrXyRRdd4SJiM04ApHr0AXfXnFiZeh3zLbATbKEn+kzvMwdgA8Yk7QiXapWucXzfa0tYIFs25fUMwds7RIbt2aMyt5w0Xqaa2p728N0DULaQ6oq8KGKpieWYOvx59o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 63A475BDD1; Tue, 7 Apr 2026 09:26:03 +0000 (UTC) Authentication-Results: smtp-out2.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1DFD94A0B1; Tue, 7 Apr 2026 09:26:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MEgiBqvN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:03 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 09/10] fbcon: Fill cursor mask in helper function Date: Tue, 7 Apr 2026 11:23:20 +0200 Message-ID: <20260407092555.58816-10-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 63A475BDD1 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Score: -4.00 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Content-Type: text/plain; charset="utf-8" Fbcon creates a cursor shape on the fly from the user-configured settings. The logic to create a glyph with the cursor's bitmap mask is duplicated in four places. In the cases that involve console rotation, the implementation further rotates the cursor glyph for displaying. Consolidate all cursor-mask creation in a single helper. Update the callers accordingly. For console rotation, use the glyph helpers to rotate the created cursor glyph to the correct orientation. v2: - fix sparse truncated-bits warning Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/bitblit.c | 35 ++----------------- drivers/video/fbdev/core/fbcon.c | 40 ++++++++++++++++++++++ drivers/video/fbdev/core/fbcon.h | 2 ++ drivers/video/fbdev/core/fbcon_ccw.c | 51 ++++++---------------------- drivers/video/fbdev/core/fbcon_cw.c | 51 ++++++---------------------- drivers/video/fbdev/core/fbcon_ud.c | 50 +++++++-------------------- 6 files changed, 78 insertions(+), 151 deletions(-) diff --git a/drivers/video/fbdev/core/bitblit.c b/drivers/video/fbdev/core/= bitblit.c index 7478accea8ec..65681dcc5930 100644 --- a/drivers/video/fbdev/core/bitblit.c +++ b/drivers/video/fbdev/core/bitblit.c @@ -329,46 +329,17 @@ static void bit_cursor(struct vc_data *vc, struct fb_= info *info, bool enable, vc->vc_cursor_type !=3D par->p->cursor_shape || par->cursor_state.mask =3D=3D NULL || par->cursor_reset) { - char *mask =3D kmalloc_array(w, vc->vc_font.height, GFP_ATOMIC); - int cur_height, size, i =3D 0; - u8 msk =3D 0xff; + unsigned char *mask =3D kmalloc_array(vc->vc_font.height, w, GFP_ATOMIC); =20 if (!mask) return; + fbcon_fill_cursor_mask(par, vc, mask); =20 kfree(par->cursor_state.mask); - par->cursor_state.mask =3D mask; + par->cursor_state.mask =3D (const char *)mask; =20 par->p->cursor_shape =3D vc->vc_cursor_type; cursor.set |=3D FB_CUR_SETSHAPE; - - switch (CUR_SIZE(par->p->cursor_shape)) { - case CUR_NONE: - cur_height =3D 0; - break; - case CUR_UNDERLINE: - cur_height =3D (vc->vc_font.height < 10) ? 1 : 2; - break; - case CUR_LOWER_THIRD: - cur_height =3D vc->vc_font.height/3; - break; - case CUR_LOWER_HALF: - cur_height =3D vc->vc_font.height >> 1; - break; - case CUR_TWO_THIRDS: - cur_height =3D (vc->vc_font.height << 1)/3; - break; - case CUR_BLOCK: - default: - cur_height =3D vc->vc_font.height; - break; - } - size =3D (vc->vc_font.height - cur_height) * w; - while (size--) - mask[i++] =3D ~msk; - size =3D cur_height * w; - while (size--) - mask[i++] =3D msk; } =20 par->cursor_state.enable =3D enable && !use_sw; diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index 8641b0b3edc4..ff4c69e971f8 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -446,6 +446,46 @@ static void fbcon_del_cursor_work(struct fb_info *info) cancel_delayed_work_sync(&par->cursor_work); } =20 +void fbcon_fill_cursor_mask(struct fbcon_par *par, struct vc_data *vc, uns= igned char *mask) +{ + static const unsigned int pattern =3D 0xffffffff; + unsigned int pitch =3D vc_font_pitch(&vc->vc_font); + unsigned int cur_height, size; + + switch (CUR_SIZE(vc->vc_cursor_type)) { + case CUR_NONE: + cur_height =3D 0; + break; + case CUR_UNDERLINE: + if (vc->vc_font.height < 10) + cur_height =3D 1; + else + cur_height =3D 2; + break; + case CUR_LOWER_THIRD: + cur_height =3D vc->vc_font.height / 3; + break; + case CUR_LOWER_HALF: + cur_height =3D vc->vc_font.height / 2; + break; + case CUR_TWO_THIRDS: + cur_height =3D (vc->vc_font.height * 2) / 3; + break; + case CUR_BLOCK: + default: + cur_height =3D vc->vc_font.height; + break; + } + + size =3D (vc->vc_font.height - cur_height) * pitch; + while (size--) + *mask++ =3D (unsigned char)~pattern; + + size =3D cur_height * pitch; + while (size--) + *mask++ =3D (unsigned char)pattern; +} + #ifndef MODULE static int __init fb_console_setup(char *this_opt) { diff --git a/drivers/video/fbdev/core/fbcon.h b/drivers/video/fbdev/core/fb= con.h index 1793f34a6c84..bb0727b70631 100644 --- a/drivers/video/fbdev/core/fbcon.h +++ b/drivers/video/fbdev/core/fbcon.h @@ -192,6 +192,8 @@ extern void fbcon_set_tileops(struct vc_data *vc, struc= t fb_info *info); extern void fbcon_set_bitops_ur(struct fbcon_par *par); extern int soft_cursor(struct fb_info *info, struct fb_cursor *cursor); =20 +void fbcon_fill_cursor_mask(struct fbcon_par *par, struct vc_data *vc, uns= igned char *mask); + #define FBCON_ATTRIBUTE_UNDERLINE 1 #define FBCON_ATTRIBUTE_REVERSE 2 #define FBCON_ATTRIBUTE_BOLD 4 diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/cor= e/fbcon_ccw.c index 72453a2aaca8..723d9a33067f 100644 --- a/drivers/video/fbdev/core/fbcon_ccw.c +++ b/drivers/video/fbdev/core/fbcon_ccw.c @@ -296,57 +296,26 @@ static void ccw_cursor(struct vc_data *vc, struct fb_= info *info, bool enable, vc->vc_cursor_type !=3D par->p->cursor_shape || par->cursor_state.mask =3D=3D NULL || par->cursor_reset) { - char *tmp, *mask =3D kmalloc_array(w, vc->vc_font.width, - GFP_ATOMIC); - int cur_height, size, i =3D 0; - int width =3D font_glyph_pitch(vc->vc_font.width); + unsigned char *tmp, *mask; =20 - if (!mask) + tmp =3D kmalloc_array(vc->vc_font.height, vc_font_pitch(&vc->vc_font), G= FP_ATOMIC); + if (!tmp) return; + fbcon_fill_cursor_mask(par, vc, tmp); =20 - tmp =3D kmalloc_array(width, vc->vc_font.height, GFP_ATOMIC); - - if (!tmp) { - kfree(mask); + mask =3D kmalloc_array(vc->vc_font.width, w, GFP_ATOMIC); + if (!mask) { + kfree(tmp); return; } + font_glyph_rotate_270(tmp, vc->vc_font.width, vc->vc_font.height, mask); + kfree(tmp); =20 kfree(par->cursor_state.mask); - par->cursor_state.mask =3D mask; + par->cursor_state.mask =3D (const char *)mask; =20 par->p->cursor_shape =3D vc->vc_cursor_type; cursor.set |=3D FB_CUR_SETSHAPE; - - switch (CUR_SIZE(par->p->cursor_shape)) { - case CUR_NONE: - cur_height =3D 0; - break; - case CUR_UNDERLINE: - cur_height =3D (vc->vc_font.height < 10) ? 1 : 2; - break; - case CUR_LOWER_THIRD: - cur_height =3D vc->vc_font.height/3; - break; - case CUR_LOWER_HALF: - cur_height =3D vc->vc_font.height >> 1; - break; - case CUR_TWO_THIRDS: - cur_height =3D (vc->vc_font.height << 1)/3; - break; - case CUR_BLOCK: - default: - cur_height =3D vc->vc_font.height; - break; - } - - size =3D (vc->vc_font.height - cur_height) * width; - while (size--) - tmp[i++] =3D 0; - size =3D cur_height * width; - while (size--) - tmp[i++] =3D 0xff; - font_glyph_rotate_270(tmp, vc->vc_font.width, vc->vc_font.height, mask); - kfree(tmp); } =20 par->cursor_state.enable =3D enable && !use_sw; diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core= /fbcon_cw.c index 5690fc1d7854..732d093d462f 100644 --- a/drivers/video/fbdev/core/fbcon_cw.c +++ b/drivers/video/fbdev/core/fbcon_cw.c @@ -279,57 +279,26 @@ static void cw_cursor(struct vc_data *vc, struct fb_i= nfo *info, bool enable, vc->vc_cursor_type !=3D par->p->cursor_shape || par->cursor_state.mask =3D=3D NULL || par->cursor_reset) { - char *tmp, *mask =3D kmalloc_array(w, vc->vc_font.width, - GFP_ATOMIC); - int cur_height, size, i =3D 0; - int width =3D font_glyph_pitch(vc->vc_font.width); + unsigned char *tmp, *mask; =20 - if (!mask) + tmp =3D kmalloc_array(vc->vc_font.height, vc_font_pitch(&vc->vc_font), G= FP_ATOMIC); + if (!tmp) return; + fbcon_fill_cursor_mask(par, vc, tmp); =20 - tmp =3D kmalloc_array(width, vc->vc_font.height, GFP_ATOMIC); - - if (!tmp) { - kfree(mask); + mask =3D kmalloc_array(vc->vc_font.width, w, GFP_ATOMIC); + if (!mask) { + kfree(tmp); return; } + font_glyph_rotate_90(tmp, vc->vc_font.width, vc->vc_font.height, mask); + kfree(tmp); =20 kfree(par->cursor_state.mask); - par->cursor_state.mask =3D mask; + par->cursor_state.mask =3D (const char *)mask; =20 par->p->cursor_shape =3D vc->vc_cursor_type; cursor.set |=3D FB_CUR_SETSHAPE; - - switch (CUR_SIZE(par->p->cursor_shape)) { - case CUR_NONE: - cur_height =3D 0; - break; - case CUR_UNDERLINE: - cur_height =3D (vc->vc_font.height < 10) ? 1 : 2; - break; - case CUR_LOWER_THIRD: - cur_height =3D vc->vc_font.height/3; - break; - case CUR_LOWER_HALF: - cur_height =3D vc->vc_font.height >> 1; - break; - case CUR_TWO_THIRDS: - cur_height =3D (vc->vc_font.height << 1)/3; - break; - case CUR_BLOCK: - default: - cur_height =3D vc->vc_font.height; - break; - } - - size =3D (vc->vc_font.height - cur_height) * width; - while (size--) - tmp[i++] =3D 0; - size =3D cur_height * width; - while (size--) - tmp[i++] =3D 0xff; - font_glyph_rotate_90(tmp, vc->vc_font.width, vc->vc_font.height, mask); - kfree(tmp); } =20 par->cursor_state.enable =3D enable && !use_sw; diff --git a/drivers/video/fbdev/core/fbcon_ud.c b/drivers/video/fbdev/core= /fbcon_ud.c index f7cd89c42b01..a1981fa4701a 100644 --- a/drivers/video/fbdev/core/fbcon_ud.c +++ b/drivers/video/fbdev/core/fbcon_ud.c @@ -326,50 +326,26 @@ static void ud_cursor(struct vc_data *vc, struct fb_i= nfo *info, bool enable, vc->vc_cursor_type !=3D par->p->cursor_shape || par->cursor_state.mask =3D=3D NULL || par->cursor_reset) { - char *mask =3D kmalloc_array(w, vc->vc_font.height, GFP_ATOMIC); - int cur_height, size, i =3D 0; - u8 msk =3D 0xff; + unsigned char *tmp, *mask; =20 - if (!mask) + tmp =3D kmalloc_array(vc->vc_font.height, w, GFP_ATOMIC); + if (!tmp) return; + fbcon_fill_cursor_mask(par, vc, tmp); + + mask =3D kmalloc_array(vc->vc_font.height, w, GFP_ATOMIC); + if (!mask) { + kfree(tmp); + return; + } + font_glyph_rotate_180(tmp, vc->vc_font.width, vc->vc_font.height, mask); + kfree(tmp); =20 kfree(par->cursor_state.mask); - par->cursor_state.mask =3D mask; + par->cursor_state.mask =3D (const char *)mask; =20 par->p->cursor_shape =3D vc->vc_cursor_type; cursor.set |=3D FB_CUR_SETSHAPE; - - switch (CUR_SIZE(par->p->cursor_shape)) { - case CUR_NONE: - cur_height =3D 0; - break; - case CUR_UNDERLINE: - cur_height =3D (vc->vc_font.height < 10) ? 1 : 2; - break; - case CUR_LOWER_THIRD: - cur_height =3D vc->vc_font.height/3; - break; - case CUR_LOWER_HALF: - cur_height =3D vc->vc_font.height >> 1; - break; - case CUR_TWO_THIRDS: - cur_height =3D (vc->vc_font.height << 1)/3; - break; - case CUR_BLOCK: - default: - cur_height =3D vc->vc_font.height; - break; - } - - size =3D cur_height * w; - - while (size--) - mask[i++] =3D msk; - - size =3D (vc->vc_font.height - cur_height) * w; - - while (size--) - mask[i++] =3D ~msk; } =20 par->cursor_state.enable =3D enable && !use_sw; --=20 2.53.0 From nobody Sat Jun 13 09:18:31 2026 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F443A6F04 for ; Tue, 7 Apr 2026 09:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775554005; cv=none; b=jiDReeWldAUbnaQ5eTyd4vHfN78IX8QocQWZauZkmbiI+Hd4/AVv6vCO0D1TJjbmstJNRbg1f2zA8HVabdHrnHEkd6zrMG0CIAVCgMxewx+D0orYb+2L1sUOaUhmPGa9DmwR1S/QPJN7XXoLXeL9kfqfDgpnmoCNDkte700409U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775554005; c=relaxed/simple; bh=g1rGNX/bXlKdjwtDqDMFgZJbJEwu3pOd1L0E8WPENRA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LmVqZAh7/6vef3EyZbc6QiBeq4V5/mdBjKyDCjstwYr0Iyh3G4q9ID6V4QFn20ZvrXuATJShQryviV8yGy8qk6FFkgxjw7MuZcfdZdhOzKIxA/tmCTwqn3fToM7OFQ3YoM9X3OLwSKDj4uKlRdcioFWO4W1fJnZPH2AzN5hjfwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B07BE4E3A8; Tue, 7 Apr 2026 09:26:03 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6A3D04A0B2; Tue, 7 Apr 2026 09:26:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mFS5GKvN1GmDVwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 09:26:03 +0000 From: Thomas Zimmermann To: deller@gmx.de, gregkh@linuxfoundation.org, jirislaby@kernel.org, geert@linux-m68k.org, simona@ffwll.ch, sam@ravnborg.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v2 10/10] fbcon: Put font-rotation state into separate struct Date: Tue, 7 Apr 2026 11:23:21 +0200 Message-ID: <20260407092555.58816-11-tzimmermann@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407092555.58816-1-tzimmermann@suse.de> References: <20260407092555.58816-1-tzimmermann@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: B07BE4E3A8 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.00 X-Spam-Level: Content-Type: text/plain; charset="utf-8" Move all temporary state of the font-rotation code into the struct rotated in struct fbcon_par. Protect it with the Kconfig symbol CONFIG_FRAMEBUFFER_CONSOLE_ROTATION. Avoids mixing it up with fbcon's regular state. v2: - fix typos Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbcon.c | 8 ++++++-- drivers/video/fbdev/core/fbcon.h | 12 +++++++---- drivers/video/fbdev/core/fbcon_ccw.c | 8 ++++---- drivers/video/fbdev/core/fbcon_cw.c | 8 ++++---- drivers/video/fbdev/core/fbcon_rotate.c | 27 +++++++++++++------------ drivers/video/fbdev/core/fbcon_ud.c | 10 ++++----- 6 files changed, 41 insertions(+), 32 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fb= con.c index ff4c69e971f8..b0e3e765360d 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -787,7 +787,9 @@ static void fbcon_release(struct fb_info *info) kfree(par->cursor_state.mask); kfree(par->cursor_data); kfree(par->cursor_src); - kfree(par->fontbuffer); +#ifdef CONFIG_FRAMEBUFFER_CONSOLE_ROTATION + kfree(par->rotated.buf); +#endif kfree(info->fbcon_par); info->fbcon_par =3D NULL; } @@ -1040,7 +1042,9 @@ static const char *fbcon_startup(void) par =3D info->fbcon_par; par->currcon =3D -1; par->graphics =3D 1; - par->cur_rotate =3D -1; +#ifdef CONFIG_FRAMEBUFFER_CONSOLE_ROTATION + par->rotated.buf_rotate =3D -1; +#endif =20 p->con_rotate =3D initial_rotation; if (p->con_rotate =3D=3D -1) diff --git a/drivers/video/fbdev/core/fbcon.h b/drivers/video/fbdev/core/fb= con.h index bb0727b70631..321cc7f44baa 100644 --- a/drivers/video/fbdev/core/fbcon.h +++ b/drivers/video/fbdev/core/fbcon.h @@ -80,13 +80,17 @@ struct fbcon_par { int graphics; bool initialized; int rotate; - int cur_rotate; char *cursor_data; - u8 *fontbuffer; - const u8 *fontdata; +#ifdef CONFIG_FRAMEBUFFER_CONSOLE_ROTATION + struct { + font_data_t *fontdata; /* source font */ + u8 *buf; /* rotated glyphs */ + size_t bufsize; + int buf_rotate; /* rotation of buf */ + } rotated; +#endif u8 *cursor_src; u32 cursor_size; - size_t fd_size; =20 const struct fbcon_bitops *bitops; }; diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/cor= e/fbcon_ccw.c index 723d9a33067f..33f02d579e02 100644 --- a/drivers/video/fbdev/core/fbcon_ccw.c +++ b/drivers/video/fbdev/core/fbcon_ccw.c @@ -106,7 +106,7 @@ static inline void ccw_putcs_aligned(struct vc_data *vc= , struct fb_info *info, u8 *src; =20 while (cnt--) { - src =3D par->fontbuffer + (scr_readw(s--) & charmask) * cellsize; + src =3D par->rotated.buf + (scr_readw(s--) & charmask) * cellsize; =20 if (attr) { ccw_update_attr(buf, src, attr, vc); @@ -142,7 +142,7 @@ static void ccw_putcs(struct vc_data *vc, struct fb_inf= o *info, u8 *dst, *buf =3D NULL; u32 vyres =3D GETVYRES(par->p, info); =20 - if (!par->fontbuffer) + if (!par->rotated.buf) return; =20 image.fg_color =3D fg; @@ -232,14 +232,14 @@ static void ccw_cursor(struct vc_data *vc, struct fb_= info *info, bool enable, char *src; u32 vyres =3D GETVYRES(par->p, info); =20 - if (!par->fontbuffer) + if (!par->rotated.buf) return; =20 cursor.set =3D 0; =20 c =3D scr_readw((u16 *) vc->vc_pos); attribute =3D get_attribute(info, c); - src =3D par->fontbuffer + ((c & charmask) * (w * vc->vc_font.width)); + src =3D par->rotated.buf + ((c & charmask) * (w * vc->vc_font.width)); =20 if (par->cursor_state.image.data !=3D src || par->cursor_reset) { diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core= /fbcon_cw.c index 732d093d462f..bde820967eb9 100644 --- a/drivers/video/fbdev/core/fbcon_cw.c +++ b/drivers/video/fbdev/core/fbcon_cw.c @@ -91,7 +91,7 @@ static inline void cw_putcs_aligned(struct vc_data *vc, s= truct fb_info *info, u8 *src; =20 while (cnt--) { - src =3D par->fontbuffer + (scr_readw(s++) & charmask) * cellsize; + src =3D par->rotated.buf + (scr_readw(s++) & charmask) * cellsize; =20 if (attr) { cw_update_attr(buf, src, attr, vc); @@ -127,7 +127,7 @@ static void cw_putcs(struct vc_data *vc, struct fb_info= *info, u8 *dst, *buf =3D NULL; u32 vxres =3D GETVXRES(par->p, info); =20 - if (!par->fontbuffer) + if (!par->rotated.buf) return; =20 image.fg_color =3D fg; @@ -215,14 +215,14 @@ static void cw_cursor(struct vc_data *vc, struct fb_i= nfo *info, bool enable, char *src; u32 vxres =3D GETVXRES(par->p, info); =20 - if (!par->fontbuffer) + if (!par->rotated.buf) return; =20 cursor.set =3D 0; =20 c =3D scr_readw((u16 *) vc->vc_pos); attribute =3D get_attribute(info, c); - src =3D par->fontbuffer + ((c & charmask) * (w * vc->vc_font.width)); + src =3D par->rotated.buf + ((c & charmask) * (w * vc->vc_font.width)); =20 if (par->cursor_state.image.data !=3D src || par->cursor_reset) { diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/= core/fbcon_rotate.c index 74206f5a6e98..6cdbc96eeca6 100644 --- a/drivers/video/fbdev/core/fbcon_rotate.c +++ b/drivers/video/fbdev/core/fbcon_rotate.c @@ -18,34 +18,35 @@ int fbcon_rotate_font(struct fb_info *info, struct vc_data *vc) { struct fbcon_par *par =3D info->fbcon_par; - unsigned char *fontbuffer; + unsigned char *buf; int ret; =20 - if (vc->vc_font.data =3D=3D par->fontdata && - par->p->con_rotate =3D=3D par->cur_rotate) + if (par->p->fontdata =3D=3D par->rotated.fontdata && par->rotate =3D=3D p= ar->rotated.buf_rotate) return 0; =20 - par->fontdata =3D vc->vc_font.data; - par->cur_rotate =3D par->p->con_rotate; + par->rotated.fontdata =3D par->p->fontdata; + par->rotated.buf_rotate =3D par->rotate; =20 if (info->fbops->fb_sync) info->fbops->fb_sync(info); =20 - fontbuffer =3D font_data_rotate(par->p->fontdata, vc->vc_font.width, - vc->vc_font.height, vc->vc_font.charcount, - par->rotate, par->fontbuffer, &par->fd_size); - if (IS_ERR(fontbuffer)) { - ret =3D PTR_ERR(fontbuffer); + buf =3D font_data_rotate(par->rotated.fontdata, vc->vc_font.width, + vc->vc_font.height, vc->vc_font.charcount, + par->rotated.buf_rotate, par->rotated.buf, + &par->rotated.bufsize); + if (IS_ERR(buf)) { + ret =3D PTR_ERR(buf); goto err_kfree; } =20 - par->fontbuffer =3D fontbuffer; + par->rotated.buf =3D buf; =20 return 0; =20 err_kfree: - kfree(par->fontbuffer); - par->fontbuffer =3D NULL; /* clear here to avoid output */ + kfree(par->rotated.buf); + par->rotated.buf =3D NULL; /* clear here to avoid output */ + par->rotated.bufsize =3D 0; =20 return ret; } diff --git a/drivers/video/fbdev/core/fbcon_ud.c b/drivers/video/fbdev/core= /fbcon_ud.c index a1981fa4701a..eaf08999e249 100644 --- a/drivers/video/fbdev/core/fbcon_ud.c +++ b/drivers/video/fbdev/core/fbcon_ud.c @@ -92,7 +92,7 @@ static inline void ud_putcs_aligned(struct vc_data *vc, s= truct fb_info *info, u8 *src; =20 while (cnt--) { - src =3D par->fontbuffer + (scr_readw(s--) & charmask) * cellsize; + src =3D par->rotated.buf + (scr_readw(s--) & charmask) * cellsize; =20 if (attr) { ud_update_attr(buf, src, attr, vc); @@ -127,7 +127,7 @@ static inline void ud_putcs_unaligned(struct vc_data *v= c, u8 *src; =20 while (cnt--) { - src =3D par->fontbuffer + (scr_readw(s--) & charmask) * cellsize; + src =3D par->rotated.buf + (scr_readw(s--) & charmask) * cellsize; =20 if (attr) { ud_update_attr(buf, src, attr, vc); @@ -164,7 +164,7 @@ static void ud_putcs(struct vc_data *vc, struct fb_info= *info, u32 vyres =3D GETVYRES(par->p, info); u32 vxres =3D GETVXRES(par->p, info); =20 - if (!par->fontbuffer) + if (!par->rotated.buf) return; =20 image.fg_color =3D fg; @@ -262,14 +262,14 @@ static void ud_cursor(struct vc_data *vc, struct fb_i= nfo *info, bool enable, u32 vyres =3D GETVYRES(par->p, info); u32 vxres =3D GETVXRES(par->p, info); =20 - if (!par->fontbuffer) + if (!par->rotated.buf) return; =20 cursor.set =3D 0; =20 c =3D scr_readw((u16 *) vc->vc_pos); attribute =3D get_attribute(info, c); - src =3D par->fontbuffer + ((c & charmask) * (w * vc->vc_font.height)); + src =3D par->rotated.buf + ((c & charmask) * (w * vc->vc_font.height)); =20 if (par->cursor_state.image.data !=3D src || par->cursor_reset) { --=20 2.53.0