From nobody Mon Jun 15 00:02:32 2026 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37CD538F63B for ; Tue, 7 Apr 2026 07:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775545257; cv=none; b=ZOJfH/8ndWzO2tyTWgh+rZ+mzjLPED6NEI5vHt7WscwkpJZwbXg2FGkfflny+63nC1uMT6o3rLA37GwUOK5tq5wp3gTapVqrfcF46shfN3+7DiMhd8Z+nXT0Rke2ar5Ff8ANwS05XPdTa1O6kY5XtBAv3yVUmBLRktWpuL6vg7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775545257; c=relaxed/simple; bh=mQR+a8OPBvteI0W4O45g2Imlr9m8CgVQu0HSfanxxx4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SCkTUR/9uPdgVCTna2Z3j9IwEycKzZb7AWjDIadMvKi8cgKORj4JyUgeOz5nOwUdyf5fR+W6g24llxebzBZxjjmI5siPmLiXJRhLUuZnQoVCqDY2RwLRw6Ms/l8LEM/umzVM90iWEYd67wkGOSBRhy0QADqR+KABgvxfdj9M5Mo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com; spf=none smtp.mailfrom=smartx.com; dkim=pass (2048-bit key) header.d=smartx-com.20251104.gappssmtp.com header.i=@smartx-com.20251104.gappssmtp.com header.b=bPxESway; arc=none smtp.client-ip=209.85.216.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=smartx.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=smartx.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=smartx-com.20251104.gappssmtp.com header.i=@smartx-com.20251104.gappssmtp.com header.b="bPxESway" Received: by mail-pj1-f68.google.com with SMTP id 98e67ed59e1d1-35da9692ec3so4252728a91.1 for ; Tue, 07 Apr 2026 00:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20251104.gappssmtp.com; s=20251104; t=1775545253; x=1776150053; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ycWHTJCFcSaHWVinTdmZisX3flH8CquJ9HqYIsGNcVo=; b=bPxESway5wmN4CWlc4R+XT/EJf5q5uD+Q01+ameb2Hs/TUOc2beiLlPt8Zgh9HPyp9 FWu0bN9nbkv+FJU1H34PyN3l3B8NFlNvexiVZ/8wEPM+QrUdJw/VBuoXFmwZYgOzTTqB FhrFthzq2jaNwdcGBABLFwmCfsWLJcumKU9u8Kyi/I/syRsQuw41SrHPW1SVT7iZ8Zhw B2nbdJHnqLXjdq/I5xX+96sQX27zVxJomHQHrAmphp+Jd8cHXsD8TifEpDeC+AXKBwhT t+SHVdbv1aQOBpkMfOp8u6MrXdsnRu/W4ylTirLCz73hew9agYA/cOU2LLlEGCr3htjS BHqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775545253; x=1776150053; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ycWHTJCFcSaHWVinTdmZisX3flH8CquJ9HqYIsGNcVo=; b=FGQOups7BkThrXSrUUMkqvy6lZIiCd02D308ekcS4Oxx98oJratsdFAOjz6scUSZ4K wqx6hoGL4l6ecUFa/l/Jf8/8IdT6EJb8wMQ5tCB1CMzSw9Dy6CsgttDrzUv2Ds97rmii VpX1pYZUVj5V1UoTXwviTh/DpIHTW147/lMmFLObYF6KFCfeUS0HEhDOmqG20waRiBYX ZuEDeq2/iyRHVC0zvRl9PDc44i13CYF+UsTNeIO0XJPutb93GyaJlAkKEMEjcdYUYzTM ymZfQiy6+Y8OhgbtHL4CPoTwxTySdat+T9kD+NWHI76T407wmPtjxU7qkxMGPsbKH4Cp pM4Q== X-Forwarded-Encrypted: i=1; AJvYcCXr7S88gQJXklhkYZ0cQz+jfCLJ4dAGlZO+OZvOfuD2Kd0gwbz0XnttwbHoFduzGuuADsjb4NoyK61ym0U=@vger.kernel.org X-Gm-Message-State: AOJu0YzsK64/FYVDkd5Sub7fhTweiusi1w02iXb6t76T9kq4ZaklKqPJ /x6jeqxIgRZkjrLZlBRrOysbtFNI7F7jiMntSTdDHcDLoFlrA+CiyC0yaRdNwetr9+dHkyGLEPO KxOTYIK2LFleyj0ICd9gyD/EQ03dn18fh3NiW4WO6PO7BSAvJq0WyliIsr5o= X-Gm-Gg: AeBDieuDDJQ8DRWeoD3JPwJAA1JljaZPieB83EcNbL4W+uQ3F6lYaOBCjWNOyUXkbHV 25XHiezPIO69zhQ4+/h8BzBZKllwsBho4AmCD+KVit1k4ef4BxFY10yLnQEKMOG0LUnr7WINRwO 1TSFReQ+NgWmnmnygEHTPPZR3wCQNg26E0ye5clO4psn2v5Vp+iIsS6/WJZwYl/jwvW6zTFEmXW Ru+cT7pH3HSK+YAArmSrJOMkZpLDJwhTtU8lGHeiMXo8o8ZFVKCsuuo/10ipEZXnVFMzN/J2sVP Zp/qb6ffRTTRx2NiC4PDeTBqsh91VQyPD5XLP3Q4fpXRQESXo1ppy3WM7flKetZU5KwxjIm5XzO sBnJsR4CkF6xMn1TZ8pheE7pZ6SjxNsk886B9biGjZBttOjn+IyrFg3HULVW6oLwl2oM8cS/SOB MM+73z8r51djpJYJnGH/IyWta/1ZV8PQ== X-Received: by 2002:a17:902:c405:b0:2b2:549f:7d2b with SMTP id d9443c01a7336-2b2816c2d9bmr172080735ad.11.1775545253443; Tue, 07 Apr 2026 00:00:53 -0700 (PDT) Received: from DESKTOP-AMNC9SI.localdomain ([2407:cdc0:d00b::3]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b2749a2e42sm149648315ad.56.2026.04.07.00.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 00:00:53 -0700 (PDT) From: Lei Chen To: seanjc@google.com Cc: igor@gooddata.com, jan.cipa@gooddata.com, jaroslav.pulchart@gooddata.com, kvm@vger.kernel.org, lei.chen@smartx.com, linux-kernel@vger.kernel.org, pbonzini@redhat.com Subject: [PATCH v1] KVM: x86: Rate-limit global clock updates on vCPU load Date: Tue, 7 Apr 2026 15:00:46 +0800 Message-ID: <20260407070046.2336-1-lei.chen@smartx.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 446fcce2a52b ("Revert "x86: kvm: rate-limit global clock updates"") dropped the rate limiting for KVM_REQ_GLOBAL_CLOCK_UPDATE. As a result, kvm_arch_vcpu_load() can queue global clock update requests every time a vCPU is scheduled when the master clock is disabled or when the vCPU is loaded for the first time. Restore the throttling with a per-VM ratelimit state and gate KVM_REQ_GLOBAL_CLOCK_UPDATE through __ratelimit(), so frequent vCPU scheduling does not generate a steady stream of redundant clock update requests. Fixes: 446fcce2a52b ("Revert "x86: kvm: rate-limit global clock updates"") Signed-off-by: Lei Chen Reported-by: Jaroslav Pulchart Closes: https://lore.kernel.org/all/CAK8fFZ5gY8_Mw2A=3DiZVFNVKQNrXQzVsn-HTd= +Me9K6ZfmdgA+Q@mail.gmail.com/ --- arch/x86/include/asm/kvm_host.h | 2 ++ arch/x86/kvm/x86.c | 5 ++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_hos= t.h index 5a3bfa293e8b..6d3d3f19af01 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1453,6 +1453,8 @@ struct kvm_arch { bool use_master_clock; u64 master_kernel_ns; u64 master_cycle_now; + /* how often to make KVM_REQ_GLOBAL_CLOCK_UPDATE on vcpu sched*/ + struct ratelimit_state kvmclock_update_rs; =20 #ifdef CONFIG_KVM_HYPERV struct kvm_hv hyperv; diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 63afdb6bb078..4a37027cc0b8 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5211,7 +5211,9 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, int cp= u) * kvmclock on vcpu->cpu migration */ if (!vcpu->kvm->arch.use_master_clock || vcpu->cpu =3D=3D -1) - kvm_make_request(KVM_REQ_GLOBAL_CLOCK_UPDATE, vcpu); + if (__ratelimit(&vcpu->kvm->arch.kvmclock_update_rs)) + kvm_make_request(KVM_REQ_GLOBAL_CLOCK_UPDATE, vcpu); + if (vcpu->cpu !=3D cpu) kvm_make_request(KVM_REQ_MIGRATE_TIMER, vcpu); vcpu->cpu =3D cpu; @@ -13189,6 +13191,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long= type) raw_spin_lock_init(&kvm->arch.tsc_write_lock); mutex_init(&kvm->arch.apic_map_lock); seqcount_raw_spinlock_init(&kvm->arch.pvclock_sc, &kvm->arch.tsc_write_lo= ck); + ratelimit_state_init(&kvm->arch.kvmclock_update_rs, HZ, 10); kvm->arch.kvmclock_offset =3D -get_kvmclock_base_ns(); =20 raw_spin_lock_irqsave(&kvm->arch.tsc_write_lock, flags); --=20 2.51.0