From nobody Sun Jun 14 22:58:47 2026 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6575199949 for ; Tue, 7 Apr 2026 00:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520968; cv=none; b=Qq3D4JqvygXC6jHUbXXRzX92Ps7klRhLPCi37AdHB4rvQmVdVVh0TfmcIKN/+j7WC56ZeTciuLT4MXgRv9mNSdJBCl9Y8iawxU71UqF02D9Kqy1YXRq4OZQhE3bvmemn9p7e9opN7ZnqB3Pu9Y2CGgvji55Mwe+tfOZ0xxKHhpU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520968; c=relaxed/simple; bh=+50rzGhBt4ishhKokCcSA1l9V0TX9Tak+B9Pgz58g80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CR4SwlPBFikahB/TTyCLjK9+BU0vNRtuOoQtevXWRGoqX/QVPo/GsttWtN6Po1qNEgVqpxLOAveWkr1mRndKqFTSSrPm8yLLRivehuxoFJZVsvaN2L6+fXreFS8wmbvpU92I8Yh0FLKqLUB3xKB7IoSLS3oAypCHXPfullcHM+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GDNtDDiM; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GDNtDDiM" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-64937edbc9eso3857840d50.2 for ; Mon, 06 Apr 2026 17:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520966; x=1776125766; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5l12nMVHZLcuAdmgVWy1G8JLewfzqeYRmAf+JAzu/Tc=; b=GDNtDDiMUUpnqJylFJIDfNUrUR6J0Mx+5K48C/JLyaW50IZQ8rxADj7Eoxe1n0dZBQ hDkLIVwtO4goLWDlWuIKv0mXUcqNEn8A5huMeIHlP5XLyCrvCObJTF2HKv00xJBv/waY BhDOUxJi8bgHAar8Zp+6CxVw2S7+i/V/a9g99zJ99O3lXDodPhO6qF2BtThoIAXLFNTV u/T5gykwA5DaNrbnNYTLzphoEGwSjOKSkB6BM7ATpo1kRiJuXVlmKVYt+MmmAJ19Kfjj SieqwXeUhaCzIwVFkqO7yuYXILLYLOIdKKE/MaKBt/xjsBFlpO4rDmuvX3tTwS3MyBJ6 BLRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520966; x=1776125766; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5l12nMVHZLcuAdmgVWy1G8JLewfzqeYRmAf+JAzu/Tc=; b=dmakBTJ0v+VV2C9QDSi1xmacrs4B2QbSkm3IpEldkOMWD9TdH8veBA77qugLBFxqCv dj/oti1Ro16qEt7lT/8nf4/ECKgg3p1qf/f6ugkZDbbv61QR0H+d48nflYUmVpg5sCQB RqoLI6qIZipjli9REzaJdUHlYFZ+XTldBhW8BFWUstlwjE5RzlhZMX7aZuUPEpZ+GlSZ eesxOqZwBIudeF2audXHq9+eaHq6e/ZuHRQ6BnI2omBn0GnsW8TVRYBIx0EDjS73GnVE vCVdH9St2rLSGiA49xuTUrRwIlfRwWcMM+ACFKoybxwNL8BLg//JWBMKVixC3xHAZAR1 Q70A== X-Forwarded-Encrypted: i=1; AJvYcCXyooKtrjCfqqccLJTR0Eu41H7NvcXfMMoI/ezLcxMPW27id7bdzT9Sb43TQnwc65wooYIPhVQHJ9+i8Vo=@vger.kernel.org X-Gm-Message-State: AOJu0YyXo3/ippXz5rKS0TeO+xEddL18pcEATq25dywRfS97RJjLUpxX 2ZPqPErgMRrtU+umrjvAzYQmNWPdm+S6cjpVfm2pkIJRT8QGJdf962a6 X-Gm-Gg: AeBDietMp3QATNNS1Osd2WZNds1X+WGHMC/c1AQU70WKQ7dlHI/asAOyq1yVExclMFu KmtdJmIP8FvHmWLSj3+sTpSLCcRior4Jbs5t6PWfPHHD1vhesU2XZheapX2NjKqGg/A2UlcYclw SwzsSzh9mTpRhpr4QNtqhZPszS3BhUcXv3CLfSr15Qnm4wERM3fKAv/IAQKK/k42pJedfgPKowK bhQPf+Dv8c0azJzx/7nxbVRmDAM7O7e1Mdl9HWX+7zwB3RcVxUr4zGu8ooBlMHBEd1Ec8KwMHrz i8D/CkXy/gXZcRXIJYPX/QnL+2Gg6REE7WzZHUeDgvyaDplVZrHy16V4lGC8iXeMNpuHjXHcH4r qtqYK0Fh+2NdF6LtazYQQpIZeVYQyhwJ5sC74wYBf7lsDZpXsvWVNFlgn5TscjuG/yxokoXqldg +z9x0L9kETvMGeaCUXCDSD52z7dD/jsd4rQb54HXjPHjnudwy7mi2HQAACTT2F X-Received: by 2002:a05:690e:128c:b0:650:747d:f70f with SMTP id 956f58d0204a3-650747df9a4mr3030565d50.66.1775520965820; Mon, 06 Apr 2026 17:16:05 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a9d50afsm6698649d50.19.2026.04.06.17.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:16:05 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 1/4] wifi: mt76: mt7915: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 20:15:57 -0400 Message-ID: <20260407001600.31234-2-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001600.31234-1-joshuaklinesmith@gmail.com> References: <20260407001600.31234-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chips= ets") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7915/mac.c index cefe56c057..cf72b38c85 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c @@ -221,7 +221,7 @@ static void mt7915_mac_sta_poll(struct mt7915_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 msta->ack_signal =3D mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); --=20 2.43.0 From nobody Sun Jun 14 22:58:47 2026 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105293C465 for ; Tue, 7 Apr 2026 00:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520969; cv=none; b=e+GGXmsJ/5RDazI/iM1VSYywC5XJlQGRI8JLnUSMFSgTekjhKaSKIpaXpkzv9i+71Op2jUGs3h/PP5C0qswWzZl33uHqLnZWbVyhw3XmVFVKyYyncp4gEd9jcMCZ9VOHq3EJPQmrXrJep7Yj1KTF74R53/uWm9HCwIsC31Ck/uo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520969; c=relaxed/simple; bh=LfkYvGNeVcUMPzu6EUpovhxxAgmTZnYfYq+C8OGymRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nQn5JFtI8fhe89QuTSdcbVg6VNpacnUjPHEITnN9svG+EYQK3rveA/Gc/nTfxKl/tyTOYW4baFzMlQF1TAK28G5/BETBf1Rnay13AWbYFrxf3+XYqJZ2Om5CJdnF4O/RhZo7/GEpaI6Xkkuj3Ap14YfUK2yDZ+UN22K5ct3jKzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n1IryfIF; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n1IryfIF" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-6501725d888so3430940d50.0 for ; Mon, 06 Apr 2026 17:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520967; x=1776125767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xFQLJBb/lmxRWKB/kx5iZa1pg9O2vzapGfay6oRBkO0=; b=n1IryfIFiR0hQp5Lgkw7I+X4jRXY1eIajpiyQYEKLgTMfNUP97iHJC2+teAqhcObIy t2n5vXFJAzpeN2+PquAjxsVcCa8laE54lKZxKdMz+CZEaonfcTE4xTL3RPVG0Fv2jFS9 ZnSyIJRZN48LPNywfCadM2BKlPjJAQIe+PQ0zi/CwxZYDy1PUSEM8dJG0lcBgsOa0hFW OHCiebc5HyT7P2IK9upx5NbJknz0zC6f0EN7rPSQPzGIT37xwh9IdCryhhmn32Yh2ImS j/etsFpKuKMLklxI/oI+mlf6KjfXF3c8ZOu6kCxjpvJw01fjcIJzDT3a9vLzNbj/ysuV uQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520967; x=1776125767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xFQLJBb/lmxRWKB/kx5iZa1pg9O2vzapGfay6oRBkO0=; b=JzAnHWgBVDtBUJJhdy/6xpTanxKvPollNZrVzeGwMi8FRGWXUR2LknlNtnWD700YNB 9jwoOrEEXBBCnTFMSI6fCtS+nNTVba2SNhSylK6EXS+Ef5gxQJmAicbjoZtIlPE2+BRa s2HIpM4BwtOwghnVomz6A7LcXT9d5RPdw9n6hTexX37V5/evOfTfUQKr0Loohy/4leZ9 eHZlIb7cX6ztDfM1lWaBbf/IvAIFBqIXtwxrcOGRfvAy6HrmmkJU3vW5B7vBA4N7nlTv tqsUTCMLx20S/db4D26G4jgyHgREpZ/4MM4iHm1uJSk91zV//j8R13WCPDqyhGke0AxC C+2w== X-Forwarded-Encrypted: i=1; AJvYcCW7Mw1byzA2UDrwJ6RRtFh+QmiJgrj+6gn4K2fJAmw+G6Wk4/uQx1ihTx5tER4PYXUIHiNKzouS3N14Qns=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6D5UBbyA7SxLZgbyi06dAMxYmt2OstKUrMsrz6tPQU5gByfWf wgv0XrWdAFaaWh5qZ6HGQnhcWBKWmtbkZsH8fkU7q5AMAlEQFyyE1MK4Rea3JpFt X-Gm-Gg: AeBDiettxoIeSKnZZv+WdCBVqXtO7+Vc6i5yBIgUk6x+qoAvsjJEbNlWiwQq/xI6cuN lcBBu2oxQJvLd+ttuejCM5QBoFN2uSl5iXTzOODjl8Fm3GWZRVTtKTKF6MhVsZlhW/+z2I9gzJM EfN2/ky5xgvbTjwktP+QaWBgy3elcRY82PVZtUr+aaTBEeKFAqQoXzUzJS9K+zENu9rmUhNENeo o72hY1ZS4OUz8KSaeAM8lNAst25JwxY6WNCJ6mBn49hfgfHKOg+/XQabSSl5+nh1B1OAVMEEuaz o6jjviXgKjoFd3OF54WMr2r8Ae8vuv4UzGW/yH/Uw8IZGm98sG/V+E+Jbwh9i5HUvZZxwn0+1EZ REFI0Y2McZ3tut2xg2TMwJsbg49JVrOOaX8z3q0qaL7VQ0GvoPw1W/7Hs4OC2YDNIOTv3W6pgQc y5fUykyIhPGIzPIZ2F5Nlh4VSyPK6mRP4f84fcuMj7x4mhfWCMd4r14EbgRPNU X-Received: by 2002:a05:690e:d49:b0:650:37e7:e590 with SMTP id 956f58d0204a3-6504869b126mr13770674d50.15.1775520966993; Mon, 06 Apr 2026 17:16:06 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a9d50afsm6698649d50.19.2026.04.06.17.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:16:06 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 2/4] wifi: mt76: mt7996: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 20:15:58 -0400 Message-ID: <20260407001600.31234-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001600.31234-1-joshuaklinesmith@gmail.com> References: <20260407001600.31234-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (= 802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7996/mac.c index d4f3ee943b..a0342012e5 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c @@ -205,7 +205,7 @@ static void mt7996_mac_sta_poll(struct mt7996_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 mlink =3D rcu_dereference(msta->vif->mt76.link[wcid->link_id]); if (mlink) { --=20 2.43.0 From nobody Sun Jun 14 22:58:47 2026 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7866716132A for ; Tue, 7 Apr 2026 00:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520970; cv=none; b=Sx2CRX5lkwQpnBGZtPnvz7SRDFXlVeQpa7HCHGoyZZOm78m+DlyDal0liYR8u1dGXANmzSv4UGFJK/bYaijQl10o3QTI76N9aenrQ8Jaa7V8F4Za22zud3pcHlmVey0p5by7TTktfKhfXeLWfhdUugFlYatvae9hpbp/sqUT00k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520970; c=relaxed/simple; bh=Nysgk0uciCPiocl22DBJxD3R6NfAICtbGv+6Cp+q9CM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iOUMLMLTg38x6pQHr35LKR8eLDuyJxF8hBPYeeRrTyXIrNJdRykx/QAfjf5qvbNe3bRYNIM/f+PyjwJWvItCnt6ZIULhctHsMgWuoOIVMTsZ+gI8k/sTiK1Lyh+P+3yE3uOyitAGdXLy/cDb1temJ8ZnzQ2VuUxZ3+nECT/15nU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VjVTSiGE; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VjVTSiGE" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-650775f427eso834660d50.2 for ; Mon, 06 Apr 2026 17:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520968; x=1776125768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hRqvQs6ivSDyEsQUNGAHXVReKeGYQz/kj2ZPLDDhbBc=; b=VjVTSiGEHwbxRA3LxPdMPj4UFxQca60eFzukPMNGNEuMZvCEtoqFV4w+iXHUr5X7Eg FVXz4/ailyp5Glbqx3IaNG+URZsbnX/B6xGmFaYPB0jhi7kCnGX59svnJyqiUE3dtyeR YMALRVMq3Rcv4s2pJjAn7QR2dRf2x68IcBN07fs2o5ZI24hpdgDW9bU4Mr4LSjXM5gdu pkvvK4rwtRMz/eImO/pM1GjV0+HhBypz0Lam4xoJdIl2N4JfALfx0sFjkGO2eer6k8BT /YozR5ilZKa+P2GJe8xzAgecEmrgrO/CP5+XQASgs1kJsJdaRPp/0UL8hcIctn+6Pqdv LjoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520968; x=1776125768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hRqvQs6ivSDyEsQUNGAHXVReKeGYQz/kj2ZPLDDhbBc=; b=PKaw9hlKm+Rw5iu1mqFpuS6AyX3Eh5r+4bxCa9je4YOppdxsBOXrX72Ldt2PcX4wAD 5N5HKp8YKgtuMui8iXVUTsGDfSWgzXXc6/IAD/FOWmJGj+bLrq8A4FsdoozI49IAAPXJ OMr3bbocb1dJ16dfBlb7WPGSNv9ZqCD8zzMpSCPFKhAwU1KC6657QtnTirsPgTpVquOy gb/0RMm0o1kjFL5jRIJTzqaNQ9JKrd/BxyDRkN4oiku0JA2q+ctMKSWB6iHcN+3fCX/L Gb5USPIliXit66m8V+5kLd5jVLXuGButOkblUcI0KMVIGp3SaDPd1UClSfP3ouEprXGj uZpA== X-Forwarded-Encrypted: i=1; AJvYcCXnlxW+2hWfJDo6R+MTUHh0DCKETqApPfIhuFMfqc/QgsN1Y5X1IujPPTUNe/NoQHoVV81EkuUxaeLVIZ4=@vger.kernel.org X-Gm-Message-State: AOJu0YyMVpLf4jgT/6OYZIGFvQ5Vb7eXFBT3iG8ZRUP2gRNwLioYu8qr N/rsKl2y6IgG4yrzSLgN2zEKxNN9sFP3DKE38UJFSbuxsfe1l5vSpLIs X-Gm-Gg: AeBDieuzHbAqxhVWhINAqotNa2L2vRVVm2+R95+3j2uHZBxMCAB8++JYuuFwUbUqZM/ 3wlMw03P4+cs3thq04hoSBWjv+HyG0Moa+S24B+HuA85bkxjfcrZeuAN+XaFs6zjp1YUUaPbkUv 30KLbaZ/yaJNIlHcJwGrrruzEHRb0vBKyXX/9RasBDQjTnnb2RcuGlwrxAiX8KqlWAkiXZ5xO++ a5gbK4/7hPefp0n5sJbjjgaRbuS9WsV6AIeJQOL8lPCCj5sy17CwNnM/eUGkqdJg0/Muazi3Xay C4jdVcXGImD0OznvcvpMU6TbPXZ7mYApTW5G6/yREf2/aTRWW/F6goBsmYWRROJiiTpnJvhkJzG 8yVRr30iIVLzarfiRd7WaXTxvBTsz4jwtwzpYUw6ZeVOtboVgHeZ9m2exVbNrociYqMeajgQOvR tw4U8NqXoVNv1mued4fAPJiih9RPKZwYvHLS0+uAvDXjrfmzFr922kttGHTjNj X-Received: by 2002:a05:690e:1302:b0:650:f54:69f4 with SMTP id 956f58d0204a3-650486bf223mr14232730d50.13.1775520968649; Mon, 06 Apr 2026 17:16:08 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a9d50afsm6698649d50.19.2026.04.06.17.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:16:08 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 3/4] wifi: mt76: mt7921: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 20:15:59 -0400 Message-ID: <20260407001600.31234-4-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001600.31234-1-joshuaklinesmith@gmail.com> References: <20260407001600.31234-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 163f4d22c118 ("mt76: mt7921: add MAC support") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7921/mac.c index 03b4960db7..fa5631b879 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -155,7 +155,7 @@ static void mt7921_mac_sta_poll(struct mt792x_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 mlink->ack_signal =3D mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); --=20 2.43.0 From nobody Sun Jun 14 22:58:47 2026 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF7CB19A2A3 for ; Tue, 7 Apr 2026 00:16:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520972; cv=none; b=f4pN/8DhMpmQPKWSeewWQrHHB8qeIzEdXFA6803yfcqv76DaR+YTjnvIRNCl/dEI2qs2k6PhIExlVDaMYecdgjMBMj8duKOGBpxT97RWHqrZSncirG1DeMZd/8QxMA8lRYk1vqvh+Y3WXlXZVNu+ykwuVkow/mCFLDLhkyb70vI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520972; c=relaxed/simple; bh=VjyvCnOPToeXVmCuBRK0MixnZpWd9wXYBTD/NVXy+mw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lQfjENlNEgUhpzmOL6/Pv7vEICrML4xo6dN0CcW7yJo052L5tQoiu34Yw3jgeEdbbVlFhgHLuQWWLhXInGiG/4WDUcZpK6LvAFBp5yWKhs9sYonza0zO9j0T581IuJgNuswNhSb2QMkHGVMsaiRatnTHSL6j0EasYMSv5H1pD5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AyFK9nXb; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AyFK9nXb" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-65003f40a22so1812464d50.2 for ; Mon, 06 Apr 2026 17:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520970; x=1776125770; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YwAUYgcUQbMzd5TGf/Ouq5Y4qwptEf+4MYg7+HsO1/0=; b=AyFK9nXbDAqiX2WrCvxSmBo/qCL1q2ZjOOl2Rq3SdJYVBahtv4zg90/1RQTMTjC0DV BXWFI/Urc7Al+NKnE1qcLZD3c2LoeTLqa1FhjrcX2Pv+wZ3KZAJUSlZaJpyP2GgFdzsU Xij1koRISuLp5fPd6skNJuMjfujURkItHNkjjGaGZfK4aM0ygXdqJ8eg6Fuug2JPXHHD 8tWXPxse5mWUtKJc1p/CeXNf2x3fdajLfnIGIjZ5QET1smXWCeW6THZWbAWFdDL+qQzD og6bfJr21XuXy5wcTUhjUfAHyNpyZ2G8Np/rPFUOHl0aEqORmYXClkujpOQZHIwRAlnE aCog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520970; x=1776125770; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YwAUYgcUQbMzd5TGf/Ouq5Y4qwptEf+4MYg7+HsO1/0=; b=Gb0DbRpH6o6fsTXRmi3MTt+4WNKoasf90mx4t3FtQQI9DlzmEer1b/OtkAnNV+5bUP RqD5AVpLIfHPTIMZQo+PS7Iz03qQY1s028fGJPOqAy4/qEexOFIiOYN/Z3HP7F2qxntE JJSzjfi2Vtd0wkuYZ1F8O9ZvBVXtvGfrewjX/osEaudXK5jQAZvLggrlgA2tFqAZPAvp KL/9/TY0fQSu+4yHBC+Rw60bmk5Iws5UNitnWq2tMEWLLXQ1qE8jh6GeVtzb5PCspCd0 ISfcRYbDeG2zFdKEW7KgRYBQ9whRZO3eO/xZHKeO3woWQy8+pim85sug2coQIfuquRXS OFxg== X-Forwarded-Encrypted: i=1; AJvYcCXPHqPnmw2Df8jalzs7h5GIlVKTzzNHXmscU6aNsv93xM78Se/Tn2JvSc2ev2LR+0ulHD6bkElVUP+DiXM=@vger.kernel.org X-Gm-Message-State: AOJu0YyMjkwFTiTc3+P5HjpcgkERGe0ibvcODiksIEEMHeXUE4YY6J9R XUz9w35HYRglQ+mitnvMIixUwXnNrTruLt44mROM/2wWWjlzyhAqVYiF X-Gm-Gg: AeBDiesQvl7LI/0UszFJjIEtIyELeJk3i2zF7wHcjJ0pjDISEFsn+C1aLYj2hlO9cR+ 0n2zcEd119+KEEoRFmPPJYzSEw6HeuedgWuliOGVAFx44h+SCLnf9m87EaJB9Z32YaZHMArnEj6 AHbRlBY2Mi1Ij6ks8+xl/QZohMvgTcAwBxdRxeLlq44kBbaYIntAI3qTaZnVI0wvBOb6sSIEerQ p/90hijh1hJ8+toaBLijwBgq25qZnLl570z7Jb3ZkJJ6sIsh4HANAfwPDqiYdIJEZGTCI1PyS2h BXJKjUcavySZY/KV2lh7YFxj8XkI19I5sUzznNo1detJPyiYmWDuzP3n2tQ+c3a6zy7HiHnJAns voClzmkBqNC7iQMwXObGHyb88VruJxsN9/yE84zDYAst38df1RtnrVitSaWLXgd1Jr7l9U6cAp+ 4KtKM3rvJj3AfGQvlE5r7NNFXNMVdq7r93BUD7DXkDXRjdCZaFTJt8pes5bTXN X-Received: by 2002:a05:690e:4801:b0:64a:d479:bfbe with SMTP id 956f58d0204a3-650486c0987mr11575623d50.11.1775520969817; Mon, 06 Apr 2026 17:16:09 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a9d50afsm6698649d50.19.2026.04.06.17.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:16:09 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 4/4] wifi: mt76: mt7925: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 20:16:00 -0400 Message-ID: <20260407001600.31234-5-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001600.31234-1-joshuaklinesmith@gmail.com> References: <20260407001600.31234-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7925/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7925/mac.c index 0d94359004..596bc21b02 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c @@ -145,7 +145,7 @@ static void mt7925_mac_sta_poll(struct mt792x_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 mlink->ack_signal =3D mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); --=20 2.43.0