From nobody Sun Jun 14 22:58:47 2026 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CDE213AD1C for ; Tue, 7 Apr 2026 00:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520946; cv=none; b=RfXjapuZ6+y+zqGwHlY6mZ/YXb7iDuEEDaXIFXkvq3f0qISn/Fj1ZI029gQL40vhLeOpAdGJvF8AxpMqtrX0gqz0sGFjKcPN9ew2dMfTYDxfzv9B1Ra6j2VClTVaen/zuZuKBs1ElMl7HW6XWOaciSdcv+Dg+PzUO6qMGLXfO+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520946; c=relaxed/simple; bh=p+heu8oqAJ8mKuDQBckMkIu9ukpFg/92WpoiU5ZTiKQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G4ca5nntQX5kvROtWJLca3/+WhhDK7IW0x40i+Nz/SKjbxwgtSrqyaUNcgnD6e1wu1YvzbQrZV4ncrGjXTPYq+n7IOdtznX2EaxO6Bu+I3xl0J7Rgo1Pi7caRBF5JG1A4a3W73cWGxodHTNmwXSCvcj2mojjygfkIXgBKQjmy1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HSVgy9ik; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HSVgy9ik" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-7a17bc5745eso40702497b3.1 for ; Mon, 06 Apr 2026 17:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520943; x=1776125743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B2OqRI8ckw+xa4yxPr5+ydqFc4r4rT0slahm2J/yIYk=; b=HSVgy9ikS/fW8GP3UzWesGj5h/RwEV3N0thLFIC27fDEU9/bzH/CwcxuonG2VT54uG 9umgMDaXpjqR1QIeIsjy+T+dRisnNLAUO8GxEhZvZH47IciC1Df3l2jfy5iLACHg+vGH Ntze/COBQ+m93OubWNNPfUK3gkyGOHVq8T0Xdbv5zMeB4cQv3yxKb3ZWhwkWoPduMvvY vkzH636mTKenm9FBKZocCRpWX2INSdBZpYi2xi0tqYaqPJnYYgwh3PdQshtNeNWngl8x OMRs00d65suGDKKxlsF9+T2j/LYAYlvb7mrJArq+xOgu6X00bELlr8KqsGXVjOKnOZCj Y66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520943; x=1776125743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B2OqRI8ckw+xa4yxPr5+ydqFc4r4rT0slahm2J/yIYk=; b=hjvHEdNe95eBKIwBijY+WUQmPbazRaNF409qb8OVd1d3fSpUEalYonTzdOQ4bOf9W+ GZdEmocPzAQfgXN7XMbaPDs8ZaXYkNrndb5EvflKabLpFPxsghZG8TZGEOVu2yq7pZZf LGm3txmNq3Byr4uI8gOTPlyD5xdMj6xqQzV1hy6RFRlXUdfZDF1Q9/82+0GBRb849cNJ VK28bpTbZrPfVSDa9TfA8WaIsqSYShgamKdrpAIdd5BE8sAI1SsFgZ0fhbFJCIUt/afF mKCIh3mGEPvyaY93SgA5lR60huCESGxrMAoWWQV65aXgpqBHceVs+eb14seouJ3UYuFv FyfQ== X-Forwarded-Encrypted: i=1; AJvYcCUBfcWd1Nf7uHMzBJ0MG2elVcIFV8AM5BUjyMKGZ2km3v0kdu+KyyAyGUM+7hnVSfespKNAaZN7oZZQniI=@vger.kernel.org X-Gm-Message-State: AOJu0YxNksrBJ9LoXM19ub56z0q6lXePzhnPtC4wQ3FAJPuAxzbnwPPB fdylmcmHj6T9RCwcM1p/ZMYxqwoofsrTJ5bCDb/6nricPp4lc2uxnesD X-Gm-Gg: AeBDiesHMzs8YU+w6jt1ett8euSnddDfaCwlt1+uHT1lEKIxMrw1WoxivITjeo+VPQ5 Id1Pkaw7yWAfU+CZUp+uacZB0nBUPpfDL4VcYpzdjLT3V1Pxg8Ic/rV6mZxeB05OWscdJHrOU9O NBzVJI8MfgXvtyijsWW5BhWwQ9eyR9wUBHiVJCbwqBw0WWywwytJD9MIuL1Anh4fJLVn4a6NbbE Z0xHeSHfxwbwpDHFvQuwEgpuXSgRcATyWZ22VimGbs54iNAV8ZqNrgpkM7CPyeHNtlt8wSFWqqe LyRbXFrwHnClrsI8Ghf/Nwd5BMMFBge+5x7bVqOBKX4nVOSaE2Ll71jyiOfsIVx6Aj2k6cP1zO0 aRsZwLW7jPJ0hyp1PXkRE1iiRKW27U5y4ykmMWjVsnHQWB8IneH3ty1ENCo472Z54cBVWIjMmMb Uj/8jAm0PnwxxYC3wRMbbQw+pWeBBGXx4tg/BcMAUIIq7gkhqU/LjF6H26rbZn X-Received: by 2002:a05:690c:488a:b0:798:ff2f:267a with SMTP id 00721157ae682-7a4d6546abcmr154271267b3.52.1775520943192; Mon, 06 Apr 2026 17:15:43 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e320670sm59858877b3.2.2026.04.06.17.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:15:43 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 1/2] wifi: mt76: mt7915: clear cipher state on key removal for WED offload Date: Mon, 6 Apr 2026 20:15:30 -0400 Message-ID: <20260407001531.31207-2-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001531.31207-1-joshuaklinesmith@gmail.com> References: <20260407001531.31207-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When switching from WPA-PSK/SAE to open/no encryption, the DISABLE_KEY path never resets mvif->mt76.cipher back to zero. The stale cipher value is sent to the WA firmware via BSS_INFO updates, causing the firmware to keep the protection bit set on WED-offloaded packets. The hardware then drops all plaintext frames, resulting in zero throughput. Reset mvif->mt76.cipher to zero and notify the firmware via mt7915_mcu_add_bss_info() when the last group key is removed. Fixes: 3fd2dbd6a1d3 ("mt76: mt7915: update bss_info with cipher after setti= ng the group key") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7915/main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net= /wireless/mediatek/mt76/mt7915/main.c index 90d5e79fbf..6e7442cac4 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c @@ -414,6 +414,12 @@ static int mt7915_set_key(struct ieee80211_hw *hw, enu= m set_key_cmd cmd, } else { if (idx =3D=3D *wcid_keyidx) *wcid_keyidx =3D -1; + + if (!sta && mvif->mt76.cipher) { + mvif->mt76.cipher =3D 0; + mt7915_mcu_add_bss_info(phy, vif, true); + } + goto out; } =20 --=20 2.43.0 From nobody Sun Jun 14 22:58:47 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B0D719CCF7 for ; Tue, 7 Apr 2026 00:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520946; cv=none; b=OyPZP19G0QHMdJQ8uwNinzZF0YT2rtPh8XvX9XKb/Hg3m1sZ8VXLLjUz9FIrYE6RMLJPhFGzVpUOoKwOnOXE2pt0l6qsqx3DBiJtJWmaWM4dwm2y9Xip1EJDnCta+/CrG7tOygeEr4NR+RuGJLPrKmSgxQhyxsiIDDI0pkQpRag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520946; c=relaxed/simple; bh=WYY0327PGP6EmPVdxZ/UKxYSGwk28K0MY8yfuwYdQVo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UfYog6YB3ARMy2eTAzTknvPPioJYz9GUpk0Abet/yZK82MsbsvS1BeaOOqMasYXFBRdYOUDeyIQE4Jy8d59AUP2grCMKUGNu4f+9nTyacpPK5Hzl15haubwRIR/PG3Ofep9XwkyhKq1PvMFG+m7HS1DTHDvryjyic6nP0Tjd6eY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CuJ7lmTn; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CuJ7lmTn" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-79a46260385so40651857b3.3 for ; Mon, 06 Apr 2026 17:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520944; x=1776125744; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ax4QSQrnjy0pjzWmEl9UqqUoL/S+ZOGYtKORago0N/M=; b=CuJ7lmTnjhy+m9/mkw2aTco/SkBdUZOQiUdXZ6YHNvwOsqNeSvdiUI71bwrZVoawNC yyRDffyz6rW252tJ2O45y7026JjbpaYGAsScNucs/Jq2BqZSBEURh7Qle0df2tkNy3TH UFB1BE56irV7pQeOr023G0fCOy1Iq30rL7gXSyn8LaoZiRWtozUripc+5qxtWY+jEnBD vl6ejClo5VpcmG2XcxzghZFdDASRYm3zXLzGQUC4shAwIDO/RPq4k9QQ6eWx9b5/WBqP WcBWqtz+yre751MPyyWq7kL6tYt0o0GF3tQaI1E3PLra6z3Zei8hCWLBlMCsie2mVJ4m H0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520944; x=1776125744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ax4QSQrnjy0pjzWmEl9UqqUoL/S+ZOGYtKORago0N/M=; b=qbNeq0e8cruUEbpTjGc7v3jcKzXuY44FCk5STkoYAgks7xFSdzJswvZ11zROfid8Wj CnQxxU1l26tlU6kaRNvd3+WE+rH/IOmXTDy3T7xtrcH4e6WH61lRq9Gi3iB8RDhvmw6Z KHHqMrFyYtM9EFQQ83nuHjbWEGqtLeJ8gQoZap2X+N9o0JZ20iLER0wTJdZX1rHddtDQ vyrwvTtjZSNZGY6RbxYSvvQgFyJfvqwZygssu5kge41DtHasIPYGh8jFxh5z7BhJhvRJ tlAHdxH9z1dAEMpP24OOr7J3Yf7HFL5avFUD9miIQD1bjbnSZIWe+r4EH/mU4B1rTjGk 2lLw== X-Forwarded-Encrypted: i=1; AJvYcCVqJKZLBZCReo2ZAVYtESWFkyMMSAmhTch0YbQgFleEaTIZoajMxzQ/ZazxAS1YKKnQV6kvr3V1Zuc/md4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0r3w4OwdKtTkXqGu99BrLtiuZFFeSRHxFZA+Fj7ev9N0YHHjV COB+6GyKYWdsPL8mZXo+UQiTwjo1z7GTVoBkvoNMs7zzENJvEy1WVVLA X-Gm-Gg: AeBDievmv5tEhQ0C+3lHu2qdZs/42Cj0t3QoJEOyp8SHlyMSyqOpbeyKetOhNt6WgEE 2OiOBdywEtxrULpfi9O+eZRCGzc9gcx9o25XTGfhjC8iHg1HFOdPmTrppbChxnTiDN7EilBNNQu iEHcZ7qOxOEI6wVT9ZoGGVz0VwUFbq7Vd+bXtwQIypeg0vXP6im+mJDB5ujR0Sb2NE9O5Nymzat eCeQsvnvAWpg2bBkXYWdxX8tGushRgq7AUFSxuWiAL2/GDCegfovTcwrSz0FhGWcbA4jV4Lu7NX FrQFdgdBxAwk2qZp2ptPF+rwwjISe6PlXguIZJJBqnLUHAO0/CU06OHLuUG9gRRm5SIOrlEG0NW HchGMwEL40fPQeY7Y5ljeu+ohc6e7ALHEteOx3YGiF9LuW28RP2kJTKv3I3B70pyw2B4NMLg4GP hEcKy96I1biZr1RNkUoyX4FXKloTC4ynYt/T+M4ylOEja7DYZeNvLbjFtrAOy8C0mdi0hNkck= X-Received: by 2002:a05:690c:e3ec:b0:79c:ff02:a03d with SMTP id 00721157ae682-7a4d35d5df3mr150303367b3.10.1775520944129; Mon, 06 Apr 2026 17:15:44 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e320670sm59858877b3.2.2026.04.06.17.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:15:43 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 2/2] wifi: mt76: mt7996: clear cipher state on key removal for WED offload Date: Mon, 6 Apr 2026 20:15:31 -0400 Message-ID: <20260407001531.31207-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001531.31207-1-joshuaklinesmith@gmail.com> References: <20260407001531.31207-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Same issue as mt7915: link->mt76.cipher is set on key installation but never cleared on removal. The WA firmware retains the stale cipher in BSS_INFO, sets the protection bit on WED-offloaded frames, and drops all plaintext traffic when encryption is switched to open/none. Reset link->mt76.cipher to zero and call mt7996_mcu_add_bss_info() when the last group key is removed. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (= 802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net= /wireless/mediatek/mt76/mt7996/main.c index f16135f0b7..d464fc3d90 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c @@ -249,6 +249,13 @@ mt7996_set_hw_key(struct ieee80211_hw *hw, enum set_ke= y_cmd cmd, else if (idx =3D=3D *wcid_keyidx) *wcid_keyidx =3D -1; =20 + if (cmd !=3D SET_KEY && !sta && link->mt76.cipher) { + link->mt76.cipher =3D 0; + if (link->phy) + mt7996_mcu_add_bss_info(link->phy, vif, link_conf, + &link->mt76, msta_link, true); + } + /* only do remove key for BIGTK */ if (cmd !=3D SET_KEY && !is_bigtk) return 0; --=20 2.43.0