From nobody Mon Jun 15 00:20:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D133AB292 for ; Tue, 7 Apr 2026 11:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560192; cv=none; b=c0KpNV6VX3xET/jjRs/Ch3saGyXsOu16WWGsslVfiHj/qmA4hdEQyaNaXVABuGcA0CINSzvYehxc4+Ag6Y0y8THsCBKukP6g8PU/8jhNNSVvrnITQR9duTZqMh6Wr/bTFSa3szDQ4OwTE/uqU6gpRmKc2gznw0bMUIAmJ6k+vyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775560192; c=relaxed/simple; bh=Ryy3e1hHof218D/jXmpm5NKJoiAriIQop6leRdG8slA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JW0JJqVGry0YHd6kr0ewXN7W2yxtflkg4t/M58NlvEzBKghZWe8d6kFYqJFvGdMut1PhKBuPYjECDo6DcQ1RGd7asHWlqdyd72Q+Pwx1EcOAgrEZ7uUx3KefPTw+udSTnFCwpcFwCi+aa1IBKbdUA9YvV20EHVYDkoHkA6dR3I0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jsWffUnK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UFczrqMM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jsWffUnK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UFczrqMM" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6376r40K1584991 for ; Tue, 7 Apr 2026 11:09:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=V38AHF05pbRntEo446Orjq YBc2iMpCuuflqVj2qKSEM=; b=jsWffUnKe/BsOcS0r/yEOn9tRRkFaITi6ulV3s ukYOTYklMTiLGOR7n4sRqUy0csd01Dp5Mf0omqf6LkefksLXNnWiJhb0PMwuS5m9 w6CjqiSLdEexskuWr9DXm/vN4VdW/Jmk5qa5IJEkceLkzDAtaB/8HBNCtdtKLXZt IKqPTaCRe5ONhO6WIRjyj9PKnIM+NyOWU1TftCffpA/dhDHdpO2XoIFmz4aL277r LeIn3PHeES/eFTVbODM2NlkHdsA5fFWkrW34D67MXP60Ycesl77sov9+sFUvC84I bQD5JE4/h50HNtfvFN4dYpzIFKz8OsiS3v1sEM8k0vQttdPA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr9te8s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 11:09:50 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c769b25315eso7086600a12.2 for ; Tue, 07 Apr 2026 04:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775560189; x=1776164989; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=V38AHF05pbRntEo446OrjqYBc2iMpCuuflqVj2qKSEM=; b=UFczrqMMHVl1zI4OkzRKXOoE/8Wcaj7EKpzKVNU8f18bGkd0+q9qM+LCrruevErQE9 EraI6Tpf8X3KaUlDDVsAOs1F1/DLGy73So3OodBwJY6Y+vt7IylFDrmRuSnN/P5ojbNb R5k+iZDr/XLEGbJ3vQE49TzNewOv3br/UpByYSjjaXEMt0wjXfJ7cex3evvffvwWXOwm 7ARCz5WSHhNyOPzJLsIVNY3OGuiLx9jNPa91OwK8HIPAh0INBd5uPYx1tEmJf4oa1b1g MOJi/wHJLXCRe2DRe/o1cXIOPpnEFwnea6kFErVjToIx/YS07JwQy+548ZCslCHmX9vG tbKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775560189; x=1776164989; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V38AHF05pbRntEo446OrjqYBc2iMpCuuflqVj2qKSEM=; b=lFNF0EC8gfJUNytQIRtZBvoP5ZKVKs5jpic9X6eZkSCMEBAMggA07NbYLf3t36fUD/ 4qOTdp5dzpbvBf+HwErh3vZos0sTeWOFd+2bAP6Jx6KOCLJ1YvsYtp5z4I543s8dmf2x 3mhfTZ7r/Ar1bD1KRY17eoZarYXyKE65aS5txnwzuMC3Tm0uD1CxP+HXG+s8UcmPdqco BRVlyULHxKmHiPnDWRdbTThW2hKG1CxgerrdowjL19OPw9AgLLNgmP1HCHg2bqo5kqa0 OyiDZ71W1/55XbUR9lStiF8tvIHwDOSTH0LgsRCbUJnBhbwJ4NY4fmv3+FHc7wh4zRIi I/RQ== X-Forwarded-Encrypted: i=1; AJvYcCWT5b9dCYPwWfKmsR2eXw7G8vGzEVSmaBSPfTR3lwFjuojA5RO5D+934eDLD0N218GzHAw1b1siiEiayuo=@vger.kernel.org X-Gm-Message-State: AOJu0YwwPDz9oxtjeKjoBo1DcpdFwWUTcMYOFOE7HM6KnJGxg0avV2TN B4TK5RGi7nzS0v1X6uTTwb7lWydR3njhn0FKXSKnyzvjp0uSTFRbCwgR6nk6Kq/4Ui2HTWln/ad HKqJSVFBuWzX1L6oODips36LJZ4aBRH+nrfXZgJFKVDpV4Ou1Dt5O0971OuJQYlj7ZjY= X-Gm-Gg: AeBDievKuD24PT0OYj1mDmJfdPqZi1bawhHQQJDqCNy9xm+NLnoIYeXqueZytdKwSDG 3xvIQRu0jylPAy2kN+gp16gfPwOa9wrQRHfq6zNI8Ja/mEae75grv2tgArxyL+j3/R0VFuHxmsr MSZ3bKcFtceIZrIpTtrvuemK8vRM2egTjyz1dGITKNBMQV6TFzdFgIgixDEGSMgZsQoYvukCc6i gHRmFsrWx9WHioxHy4nom7UkzDZQUzyqbM/rNQxd+scOZpM5fHbgWcmwpb1Q7gQmgWKbp5DD1Lp MqcsyUyPlSevrravUn2/sFQAuxuHd7f1ULWpWnO3b4mxA8nEVD9ogTUYDtjCXQuKJQ/ucyFS6pd OV0Iy6UUvLOQDcQgdBsgrCm3eLtknStyIQpY+BUMTOwLN7fZTYKPjAOKq+YyeUb7oai+FnSdrW9 san0WMRgub X-Received: by 2002:a05:6a20:7f91:b0:398:71f2:59d8 with SMTP id adf61e73a8af0-39f2f1296b9mr16645133637.56.1775560189445; Tue, 07 Apr 2026 04:09:49 -0700 (PDT) X-Received: by 2002:a05:6a20:7f91:b0:398:71f2:59d8 with SMTP id adf61e73a8af0-39f2f1296b9mr16645101637.56.1775560188975; Tue, 07 Apr 2026 04:09:48 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76cffd9611sm12610034a12.17.2026.04.07.04.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 04:09:48 -0700 (PDT) From: Jie Gan Date: Tue, 07 Apr 2026 19:09:05 +0800 Subject: [PATCH v2] coresight: tpdm: fix invalid MMIO access issue Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260407-fix-potential-issue-in-tpdm-v2-1-1d0e0d3cb793@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIANHl1GkC/42NQQ6CMBBFr2Jm7ZBpU0FdeQ/DokCVSaDFTiEaw t2tnMDNT97Pz/sriIvsBK6HFaJbWDj4DPp4gLa3/umQu8ygSZdkqMIHv3EKyfnEdkAWmfPEY5q 6ERuqGmOMKumkIBum6PJ8t9/rzD1LCvGzny3q1/7nXRQqNJou1OmqJXu+BZHiNduhDeNY5IB62 7YvhsS1uc0AAAA= To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775560185; l=1836; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=Ryy3e1hHof218D/jXmpm5NKJoiAriIQop6leRdG8slA=; b=49AuxkdiSQQBK8zVgQdJmzbQDS2Xe3Qm2hjtbTTsO5cJnjfXheOsomcCNIsVvCoe7BhQT/FGu BCUC9dTDszgCuNXEBbJCwyJKzJIqSAKVGFVjGAyN9wg/ClYA/sZUZYL X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=SMdykuvH c=1 sm=1 tr=0 ts=69d4e5fe cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=7CQSdrXTAAAA:8 a=z9rP18_Dhswye3MgaU4A:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDEwNCBTYWx0ZWRfX8zm8p+J4s2UZ /qoMo8uwZx0yS0SOkIJavrr4ZxOAITCiiYN33AdrqTPiohTdE7IGYZbPJmrzRI6H8uq/2SOvR3d 9WvoRxmPVURD2pgQJ4poXJCeF1YXyt6cCZyOT3M83swxsLM10j/P7sw3LxojQCcuojzF6OwlWR9 yqJ4l3fY/CORp7jcWElcX5vH8UGZf1AFbrfDkSpyontqzxtiGLsFLkyUbIY+Nb5v0B29iC9oCJT b0FJ83FrPZ17oZ9MOEb/kHlvtJYKau8D4VayRUvjW78VgtZWCjVEhQcxGjJ2BKFWwQ8FDyU/Pjr kFP2jF/lt/jBm7NtCMmEo0M3hOG/rn+u/PwJCcZRTvy9/7SiYZewZJuwspfe6jZkgmpPb5CmSlw 7cE0I0mY7g1dB2yqFtS6lN+UY2KuTVD6KVSsund+xpCZeCUlEpbRkKe4VrdEUjPzsiX+eGNbSVm MIS3vQeKn0PrMKZOicA== X-Proofpoint-GUID: vV3qiY3KTR39ttprQf_Qo26Qwo3wNAhj X-Proofpoint-ORIG-GUID: vV3qiY3KTR39ttprQf_Qo26Qwo3wNAhj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-07_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070104 Create the csdev_access struct only when a valid MMIO resource is available. In tpdm_probe(), base is uninitialized for static TPDM instances that lack an MMIO resource, causing csdev_access to be created with a garbage address. So far there has no register access for static instance, but this change helps mitigate potential risks in the future. Fixes: 14ae052f7947 ("coresight: tpdm: add static tpdm support") Reviewed-by: Leo Yan Signed-off-by: Jie Gan --- Changes in v2: - add more description in the commit message to clarify the change. - Link to v1: https://lore.kernel.org/r/20260407-fix-potential-issue-in-tpd= m-v1-1-42090d27c0a8@oss.qualcomm.com --- drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtraci= ng/coresight/coresight-tpdm.c index 9b16f368a58b..eaf7210af648 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -1430,6 +1430,7 @@ static int tpdm_probe(struct device *dev, struct reso= urce *res) if (ret) return ret; =20 + desc.access =3D CSDEV_ACCESS_IOMEM(base); if (tpdm_has_dsb_dataset(drvdata)) of_property_read_u32(drvdata->dev->of_node, "qcom,dsb-msrs-num", &drvdata->dsb_msr_num); @@ -1452,7 +1453,6 @@ static int tpdm_probe(struct device *dev, struct reso= urce *res) desc.ops =3D &tpdm_cs_ops; desc.pdata =3D dev->platform_data; desc.dev =3D dev; - desc.access =3D CSDEV_ACCESS_IOMEM(base); if (res) desc.groups =3D tpdm_attr_grps; else --- base-commit: 816f193dd0d95246f208590924dd962b192def78 change-id: 20260407-fix-potential-issue-in-tpdm-b07b44416051 Best regards, --=20 Jie Gan