From nobody Mon Jun 15 00:20:59 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E2E40DFDF for ; Tue, 7 Apr 2026 04:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775537251; cv=none; b=I8ri19j37+YS9vaywpxtTsiZ6BFn4t0NQuf07ky9kZ2pROQbj5ha7OsAUwoTjbXkyMyrjExV/T/bPPwUgKCIyZ+OweuVtVnWxgF1eGeWxWpYk4iYA5+7u/AjwR0Drgk0nu0sZqrIPtGKl7qrSt2c0s1cOOpOKev+T4v3JdCJxVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775537251; c=relaxed/simple; bh=q6N0WfkFV9v4xEgCEWlWJ743nK/v6b/vWjyL8Sc1oz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=UjHPGwvGwwvALcimLNuSJRlKalUbnzvodWwUuWYcrvna6OXht9J5hhX2tQqMd4n5yUoV00+EI5Ud9HDX8uTFVPG8jgNg8WCzhSzjxWNkdhyZ0BJwOavlCGWC36GnAc98rTnUhfNP5vxfqBwFVBzLdV9jXIIjCHV4uTVD8NYisFg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JWrxfBDs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Fjd7h5B9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JWrxfBDs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Fjd7h5B9" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LQpx61584991 for ; Tue, 7 Apr 2026 04:47:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=+aaEBZPA3YHdfTo6KRYe5g 3z2LS1IYocldEBGvZCBpc=; b=JWrxfBDsZaLNxP8+vgwVEGUw8vEPx/u3IAp9VN 7yHTNjMy/WgFI8J6cYUiqXs8nzxy66tlHCjT4ZpiIv0ozDRpgqq9LBVjvmN4Fecp ak2bW1ScJ2/CvySeABqy1nauIRBpKWk9JDRS5P2JFMmfRqPFqi2mSScAYU1Pkg9z e/StIFfB1GSSBEcWQ8Je8Y3hc9Y9PJb6m7HFRrNxmv4rG5E6691FTeKDu0swRtOU Yp1w/HT5K3/4HyNExgCh+UlWdWBdfmoYFhgBvjcPvKq5fA3XFJi8A1Y6C17b09Hm dj2FFLYs4bmFPvXdiqhycDPbwWbXNWJapTaCAclED5PBORtw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr9s249-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 04:47:29 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82d42b6f2b0so763832b3a.1 for ; Mon, 06 Apr 2026 21:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775537249; x=1776142049; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=+aaEBZPA3YHdfTo6KRYe5g3z2LS1IYocldEBGvZCBpc=; b=Fjd7h5B9WK6XtMSaaV4dJ3ilTz8j9JmC5XhPuOmHls3d4drleSrOEANWAbes6LbIt4 vLkaZnb7BWwX7bQ36SmLJ/1RE2C7j++Fl54sNpoWDsjShdPZbQD1Ab6xBOu1LO5itHc2 I9CNSnFFZ8Of6GvlZcdSnQAFxW8IZdM1naAjvlFHJIl5Mx0MvsEGB4E0Koy9+ItB6egO YBOiVYVsAdhvIctC23HRN39A/f93C05s1XhaY7dY+tE43GuDosn+Q7Rc1vvSDpkJSTQN sJsgwm3aIH5oqSEXUK1lp1QrsFeE7aAz2j6NTEvK/t0k6svgCiELXNVOe+fw5ORU0iZC 0VMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775537249; x=1776142049; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+aaEBZPA3YHdfTo6KRYe5g3z2LS1IYocldEBGvZCBpc=; b=cfv0h6gFPVpdwLsG2dtNgANtHZcZ13K40Xc7soxudEbvfXhksDrAUYVT7ByWLrvssp u2miVx71fRWYpeOaWfFvw1GD9j8F6NZRMrEHXDOw7uldVrYuoZw7GAV1m+qEUb0NWDhS dPCTn/su/oPU8Z9Utk1xsR7H+QfWhLB9wHe1yDmGVKkVHXbFavOaPlHZ+SIQjcVzlUdw HNcxIiAVaiYgnG8txshtont6otlDCzA7mpZ554BNHWXrybmngZUQQ72i+DvDOsQbIsnt lH6ej/Dr+zeGwvdsyJQZvoQ4vVXIqO73vzWY4ky/g5aeStkPPhrfeqMMtYOHmT3v8D0X 8ghQ== X-Forwarded-Encrypted: i=1; AJvYcCWQufjbLzxxb/2MhTFI6W3B3AhJuQ5O4mtAfTaZzswr1iFwoP3w+EjcpubScyLUzvHxHXr1ESbEpjrVgxU=@vger.kernel.org X-Gm-Message-State: AOJu0YwGB8qNZIpcLULW7nau+FJm9SvSwfb0ej3GMNiHDeHHNhye/sEp Iuk5Jnxhy6b29LX1t7ZZKqd/RwsZDDD0mfpuNK5rmRBKrKbFqlWib9Ta4vcmOeyET3M3VPy/agg v0jzlM7X+NUzPql6TVq6kzfrauAAsf69g6Gu4mim8xVu/q/yKks24C1rl941HVnWpKbU= X-Gm-Gg: AeBDievPFSv1ktNT4D7hmxffrXaCPCJRc3Iy9xgEpY9ZZEioE9qVLVumKbJkzmv3L4w mFpWHqNqJ6o6aCpkcMI/rQHcBbL6mJ4JPY+wq37BAE+Uv46LFe3xhcTiHvvxCqFWLLsJ4Vyo+jR rq0X6Yf+CB8hUBx5q9onMiR31uAhWh8ooO74O4X3i/mZVhegnuQc0MGHoFjXzsLGIK68pp8Lqbh HIJKh/n9mBh3urgDJm6DQfEDy+vwcmrdgBMapx0cQpJ0Z2KK4+h4N6Tzv1xF3q92CeoQkKQU4+Z DFara1gSIIAf6FKQRyZtwUp/hAF5nRoJx0kspDALmL/BOVxzXEaqhMM9PLYj5202UBZeN2mS/ih TgSfcqEEXYNNXYHKKobiUsd4aJyXTjnUDUDyvvs03gToIWrkzdauRDLTtdKgulA1cCMmD0tRhlX BbwvC3NgG9 X-Received: by 2002:a05:6a00:3d56:b0:82c:d7c4:4c6b with SMTP id d2e1a72fcca58-82d0da2e1ffmr13231222b3a.11.1775537248923; Mon, 06 Apr 2026 21:47:28 -0700 (PDT) X-Received: by 2002:a05:6a00:3d56:b0:82c:d7c4:4c6b with SMTP id d2e1a72fcca58-82d0da2e1ffmr13231199b3a.11.1775537248412; Mon, 06 Apr 2026 21:47:28 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9cf065asm14998963b3a.8.2026.04.06.21.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 21:47:27 -0700 (PDT) From: Jie Gan Date: Tue, 07 Apr 2026 12:47:11 +0800 Subject: [PATCH] coresight: tpdm: fix invalid MMIO access issue Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260407-fix-potential-issue-in-tpdm-v1-1-42090d27c0a8@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAE6M1GkC/x3MTQqEMAxA4atI1gZS6Sh4FXHhT0YDWktTRRDvP mGWDz7eA8pJWKEtHkh8icoRLFxZwLQOYWGU2Roqqmry1OBXboxH5pBl2FBUTyMBc5x3HKkZvfe upo8DO8TExv/3rn/fH+/w5/VtAAAA To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775537244; l=1516; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=q6N0WfkFV9v4xEgCEWlWJ743nK/v6b/vWjyL8Sc1oz4=; b=BsyoxXij77HoegeG9nCNSoetgIv0hrvCEaK9jySxdSq+mjgInZ5uPGK6camjMJ5sUTUNvANQ0 oKhJQknL49fDXgFnEa0ruWYLxzlUT/0YRgGoDRpPMgRseAVT2xAydti X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=SMdykuvH c=1 sm=1 tr=0 ts=69d48c61 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=z9rP18_Dhswye3MgaU4A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA0MiBTYWx0ZWRfX91e/dQy7zwsf GNuH7P43BVpUNVTLmomA8Xn+O0Il5EKKprX/5+qVwMVlrVbvzeaNp0J8OE09vq5BhGcIJR1cE9f HikZSCCOANVgXx7yhEUxlJtn7AJ3pTqDdkO47aLxtyj+KTXJuR9kkPLlEMLK3y6HGmp928sGVDN La/V8Mww+uGvzErePvyh6x/2ORZj3kcjFwvK69WfM71kDfBrJUHOeifKYEJizE03WHg9exIiaCR If9tdY48YWG0TjAr4cfakqlK6VANBmDns0GnvgRaEP8Qi9CaisZqWr5YwSBXnocfbySJ49M19PX tuZlWNFIdca6JOTP8gXcctiB9ZstaBx6Ucwua+342X5DeMkkbWhMw8/ScP42r7+K5Spzwd+qCHR oYj3o5O7EWoHpoHYRmMywwALDVFSC/2ihbTIZYh5xRQr0h1Fku2Vn7fCMvDJL5Zq796uNL8/oYu FoHRxiO3CeFcIOkYTXQ== X-Proofpoint-GUID: 8IoRjEwt8H0UWZoOkijMmOalGaOovgq6 X-Proofpoint-ORIG-GUID: 8IoRjEwt8H0UWZoOkijMmOalGaOovgq6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070042 Create the csdev_access struct only when a valid MMIO resource is available. In tpdm_probe(), base is uninitialized for static TPDM instances that lack an MMIO resource, causing csdev_access to be created with a garbage address and potentially leading to unexpected issues. Fixes: 14ae052f7947 ("coresight: tpdm: add static tpdm support") Signed-off-by: Jie Gan Reviewed-by: Leo Yan --- drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtraci= ng/coresight/coresight-tpdm.c index 9b16f368a58b..eaf7210af648 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -1430,6 +1430,7 @@ static int tpdm_probe(struct device *dev, struct reso= urce *res) if (ret) return ret; =20 + desc.access =3D CSDEV_ACCESS_IOMEM(base); if (tpdm_has_dsb_dataset(drvdata)) of_property_read_u32(drvdata->dev->of_node, "qcom,dsb-msrs-num", &drvdata->dsb_msr_num); @@ -1452,7 +1453,6 @@ static int tpdm_probe(struct device *dev, struct reso= urce *res) desc.ops =3D &tpdm_cs_ops; desc.pdata =3D dev->platform_data; desc.dev =3D dev; - desc.access =3D CSDEV_ACCESS_IOMEM(base); if (res) desc.groups =3D tpdm_attr_grps; else --- base-commit: 816f193dd0d95246f208590924dd962b192def78 change-id: 20260407-fix-potential-issue-in-tpdm-b07b44416051 Best regards, --=20 Jie Gan