From nobody Sun Jun 21 05:19:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBEF9374198 for ; Tue, 7 Apr 2026 03:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775532241; cv=none; b=aQ/dRbXe152qrKGIoBkf3/1U+ISbKT/DcAbvSpgHpfucekc3OdBRE9ZRvZPV/PxgfyPXAwV8O622cXdbQVU6u65FD+kn46wvRGwqGwfKYZZS4dfYBGSJtQBT30bOImsc+v0ahSZh9b7YN+615F4inFP8XYn6YxabL6P+7PlxIk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775532241; c=relaxed/simple; bh=worjPPj4ESVBaBV4MNEMASe3hAq2NdQk3yUJ68sqnTA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Zqtxaamy3LIoXvmUUmshwB4VnnRMB6vsSC1pEAIyfkhaq9nZw89X5gRIFx83B5z4x6gfj0lil9mI0RHXo1B7KtDkWsf7wU0v7gs7V4Or4poVUpJG8sIUJYMO5YGpvP4h+W5FfgwiE2Mw9ZvJRoMF2v6Hqp27ts7kKGDhYoDFtMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GEt+DKcT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aeiU+xzA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GEt+DKcT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aeiU+xzA" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LQUcr1407039 for ; Tue, 7 Apr 2026 03:23:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=OK++8WcMbyqDqJRvkHrdUK BaMe3ofWql14darhFggQc=; b=GEt+DKcT9JCXfCu/QMCnfTshCZUlcvracIlddE YmMp0mMp1Jib900PZZAra22KI9yi8izg5L0W3vvl3LsCH9BT8zNdsHrgIetQsS7M ErCritSK7faQwtTiYO7WkNutc+o14spbUTPDi+PaLKWjcf59llozU/ONrHYKVeTY 002W4lpM49b22qbJ+uAoTC8Ax1DB5PGYxieZxXNjQPRAEvTg13ct9mODSCdr236U m8MpA6m/nUqB+OXm0qGGOy78f963MlkOD+x8gmT6cSUPBN/aSqN8tAI4x21aVl+d vwGJm1/+JkXgPBKvV5nAkD4gO8dg64mwUaCnIIoKOaj/fY8w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrartq6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 03:23:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50d826ed6f9so53300301cf.1 for ; Mon, 06 Apr 2026 20:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775532237; x=1776137037; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=OK++8WcMbyqDqJRvkHrdUKBaMe3ofWql14darhFggQc=; b=aeiU+xzA9I7VRDs3OcLvjuowHnY/l5/s989nnwHAZbjAftGfRk3dcQ2EVCKxgXTUNI b9kMzekCLP7opou2ng3mvYeGBDXtW03xPBByoX90Kv1SttD4flXnQf6ssjf2UBZFP7OB Q8889tpTWVhNnJ283Q32Oivs5vehO7Brt434jMk2Jp3ji/hpFUxpkK62YywlseAmjfos paysC6d9Al5P7MahhZJ39sFsFkw4Rq6MMETVq7ULmpbZXtfrwu9K+eLsV8O7vTh1LIuc /y9qYVmJA+qJszowJZDYbQ/4yJQWwJO37HECTGY7uX/wTX2vf7+ofmQ07/KZdbcYGoho RuxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775532237; x=1776137037; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OK++8WcMbyqDqJRvkHrdUKBaMe3ofWql14darhFggQc=; b=e81rzi8Cw84SuEly8T8zRMWCrF8EYPXpDLjb2iYrDJeZgw6096sth3L1NXC485eI/G 1kYgC9eOTdrQzfcuy2/koL7roJ7/Y/CH4ChCZ/0gxmz6eWoa2rlDhXUm3RgQrW6BuvbT L/K57LfTVLTuxrRcWJuofA2Xb44MWZ+8RrpO5sQ5FO/P+mDq4H/CduBXomwwbloGrDE2 SA3hqdpDY904tbkwc9g1EDR8uYTO50WeidMjHTFs+gOV0ZKaArkDTSWGPPontLX4V+h2 RVT5JAGrlTyxcsk7wUcbNWq06/pc3wbpVt9qiRVYRtVa4bHDnbIpDBH8GA/Yj4ERqtSi R+xw== X-Forwarded-Encrypted: i=1; AJvYcCW/1ZM3kxr2SDpFBEC8RAaIpSiFStsjorWq32+14gBiL79DRex88fV8FYXHpxZpPJqlCUOzRr2LdFXugjg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4bqOdtZ+OWVWSntLB1rhf8qTweE+muAqRqk05Xiz9egQtT5mm oyqj+wa7c78MowAMuna0s3NcGpIFSFaOUHj3MF7ke8VUb2VQNOtxk5plvSqE+ZnzYFi5vmoL8YK SiQYXTA022TimOQDmsKNrSbOCz4r283sL7p0uzufO1TIcWAmnIp1ghUfE9yCFTyXh0F0= X-Gm-Gg: AeBDiet+mI9h67SWBRze3Z+YgTPh4pvprNxAb14DOzovzNUTA1ujjpLhxGqROs6oWI5 sF4ZK5XGneoKjGH0QjJhOGclb1PDwaAve39+xaTS27GLy7c00F6GMobLmoClVWqgUu0RqLBZGXK 5elbUvPOvhmeCZRyZMJ0XFbFHks8rEdT3jO199y2UfLJIA12XqIVIdJUC70k4GTW0l24+aH2lV0 8RN900nrO34tMzmT/hmLAmIMiV1xfQiToRKy6q8nbazVQ9QKwcXDygpmX79BrsqOV791Rs0JgTh v1A6B+YO1L7kjzcEtx94KpDl/1vRI2Q5wX+xrRam2rLJlK5y9eGCuCtfsxXTF7sgSJKoVphCyru N1fUfcT3NxBmsCgvPnlCu/A/MkalWyr+O/9d38EPqB4IR94aFnT3dbK0gFlM7GzAxf67KrP/yty 1vlN1/P1I40/V+YOVLgjHblZhaPaD6b+KXdno= X-Received: by 2002:ac8:7dc5:0:b0:509:202f:f03 with SMTP id d75a77b69052e-50d4fd24b4dmr235753071cf.38.1775532237197; Mon, 06 Apr 2026 20:23:57 -0700 (PDT) X-Received: by 2002:ac8:7dc5:0:b0:509:202f:f03 with SMTP id d75a77b69052e-50d4fd24b4dmr235752751cf.38.1775532236732; Mon, 06 Apr 2026 20:23:56 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38cd1fff886sm30768591fa.17.2026.04.06.20.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 20:23:54 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 07 Apr 2026 06:23:51 +0300 Subject: [PATCH v2] drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260407-adreno-fix-ubwc-v2-1-7ff73624635e@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAMZ41GkC/3WNyw6CMBBFf4XM2iFtw0Nd+R+GRVtGqRGqHUAN6 b9bcO1mkpN775kFmIIjhmO2QKDZsfNDArXLwHZ6uBK6NjEooSpRiBp1G2jweHFvnMzLYqVVWRW 1FKQkpNUjUMo247n5MU/mRnZcNWujczz68NleznLt/bfPEiUao4w4FKUw+/rkmfPnpO/W932eD jQxxi9KCbVzxwAAAA== X-Change-ID: 20260407-adreno-fix-ubwc-6a2564710e21 To: Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1883; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=worjPPj4ESVBaBV4MNEMASe3hAq2NdQk3yUJ68sqnTA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp1HjIDXCRr5zKUdKi2UpZ12hKraipBs3O9o8Gu yc7oN+r8DWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCadR4yAAKCRCLPIo+Aiko 1YQSCACIV5VUw/gWw2R562oWys03qBIMJyr2ym4v+Pg3fUrsAiIRATT3pSktxFBBM3n7DId+G0b 83Fw2IdKcmLE83kLL2KEtqKH6t0L2sjk6/yc1mL9VwKH/uJXQLECUvhz2TWm0vpDv98lQ5P/PZW 6RWB5uJywzfg7edo9NtTUCfQQ5RNu+8Zi62Dnc453Rt2eVbGt9kQRxNb1lpUTs8tlR6ZviCEoIc RWEz9u75r4D7r6DrtRRMsdyJZIwUqDWSP6D3GrYSj388eeOMJPvAMCxzn6yP+GN4G226xW1RSSO Nq4Jyzyia2TWyIqONt8Ua9d++lAcUkGXQ6Tpu8e0XR94LAXc X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: xbkb4R_KLt33vuXMScsAiVd7VkjOOYbD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDAyOSBTYWx0ZWRfXxoJD6YrR8Yzy QK+OGQqm3E40MxXyrfxwWdkF9y/5Quo11LM+8N6ruIdS7bmErnN3I9hHQ31w8xUP9vFNzOPpbLd jfT62h4mbBtPxGT8IuJYnQ7AqVbCgHJ+7Q+F2aMJxMTtj8BvSart/uaEy8+AZMq09gGQGbr5+aP /Q7NKTBTV4WRofn89MmnmGb32AvicyY44exbsKeCXXj0c2b6NPBAu/TyyWClWcg1Jg67yEl9dN1 wbbjnYjnWpQoBxuZKseWsWIi9OBMXqC876sKYp/Thg6AtupXg06uVpUb5QhD923LLShfKSFOVQc j3EFQiwxlEyb11F8RqaqwBGEvivUyWwkhvFIsuA4Bdn3WX3lwBKWRT75BjxQtUiyoOv2zBl85ld dLSszZe6AhSFLUIaJZRGRoAfZXvr1t3xzLIzTvFtZKdk+tGHVugN3Ppao5l7ClD5GZXmxm1nBDl YA4mJGyLi3M2zcaQkbQ== X-Proofpoint-GUID: xbkb4R_KLt33vuXMScsAiVd7VkjOOYbD X-Authority-Analysis: v=2.4 cv=D/d37PRj c=1 sm=1 tr=0 ts=69d478ce cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=5ICTkH4HVDsf0thFk5wA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_01,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070029 Before a5xx Adreno driver will not try fetching UBWC params (because those generations didn't support UBWC anyway), however it's still possible to query UBWC-related params from the userspace, triggering possible NULL pointer dereference. Check for UBWC config in adreno_get_param() and return sane defaults if there is none. Fixes: a452510aad53 ("drm/msm/adreno: Switch to the common UBWC config stru= ct") Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen --- Changes in v2: - Changed adreno_get_param() return -ENOENT for affected params (Rob) - Link to v1: https://patch.msgid.link/20260407-adreno-fix-ubwc-v1-1-bb2b09= 450b87@oss.qualcomm.com --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index d5fe6f6f0dec..34e4ab43b0f6 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -426,15 +426,21 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_= context *ctx, *value =3D vm->mm_range; return 0; case MSM_PARAM_HIGHEST_BANK_BIT: + if (!adreno_gpu->ubwc_config) + return -ENOENT; *value =3D adreno_gpu->ubwc_config->highest_bank_bit; return 0; case MSM_PARAM_RAYTRACING: *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: + if (!adreno_gpu->ubwc_config) + return -ENOENT; *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; return 0; case MSM_PARAM_MACROTILE_MODE: + if (!adreno_gpu->ubwc_config) + return -ENOENT; *value =3D adreno_gpu->ubwc_config->macrotile_mode; return 0; case MSM_PARAM_UCHE_TRAP_BASE: --- base-commit: 36ece9697e89016181e5ae87510e40fb31d86f2b change-id: 20260407-adreno-fix-ubwc-6a2564710e21 Best regards, -- =20 With best wishes Dmitry