From nobody Sun Jun 14 23:10:08 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4571439DBC7 for ; Mon, 6 Apr 2026 22:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513692; cv=none; b=RRsNZEVujZtQAkpmv7wXRnwjLYO40uSFlJgsu2QN2CjGIzchPw/F9s3ZNDRu5uKplRng40HKuwPL9G1ChG1mb0jH02XCegk8Y60hayIErDYiN+b1E/W9y9flAfT0CryKJSoQY0YOl062ZPXzt0r7J1EpVFZs/RxNd8S73jFB094= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513692; c=relaxed/simple; bh=iOwuvALQIxMbLYv7A9rd+WY0kqRMtLoK0llPgfx8U1s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=PLqod95Rb6Xpufr3G65kFdGb5VPDtDcMSH3C6xDvra8ENQuc6gscgX2GLWS3HT3gwEEG0uSvRLMkmKpIYbGSI0epwGzRl/ENb/+w3F494QBdqNCi9wKoBo8K7/AQT/41zDvqwVdfZJ66MDQOVfPDeWY2G5RL+R1NOaN+7DSga5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gtOFeecX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SmFGajlQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gtOFeecX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SmFGajlQ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LQhpS1584837 for ; Mon, 6 Apr 2026 22:14:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=EumurGm868mUc3WSikFqcK cfbgvr1fOR4UqmCi3WbQY=; b=gtOFeecX8LB9k383vAyrgqTdvzuG7StUpAFg04 hpxfqDMZz4JaOplsmW1Qo7q0CBUo+WKhR1rahgZYyI5KVOaiQlmOV5HSsm8zj+pg KH7ASRXHXCxhaSH07imyu/GtBKMgYqMqnR9HaqmmXDcQhVKTMzHOyj5ALzt8buvz KNSH4M+5YXU5MXiAAJF9V/vRMUjXxh/hdBPJkPDp8a3oHYRh6aOsAWiF9JTt5jfP kNX4zzoDpd1S2CpY7HFEkHYTnZjETRE7BZlvNUV5pDa42UzXXE/aDkHE6xbopsYT i/dNQEGRZqmtsspGd1EKf+tdXT5ujQD8HdAdZiZB10zNdIJQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmr9r35p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Apr 2026 22:14:50 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50d9d52ad9aso17457711cf.0 for ; Mon, 06 Apr 2026 15:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775513689; x=1776118489; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=EumurGm868mUc3WSikFqcKcfbgvr1fOR4UqmCi3WbQY=; b=SmFGajlQBSy9FZgqAX6f1DuL5rfRgglqtH5n2fzmIesIDM6UMuyeYhbw+WrZHwAu2O doi4RtakYl4YLJab0opQF4ODYlXWKPrSkJeKilWY7Gr9fXy3xd+fyiw7QYM59kas8j7w AZiWW1I/hBXJK5Y2BvBclU9SHX7Nf6rNn+UMzDPloOGKg98/IKA3T4qhJHQe9jBY4wFB Caw9Nijew05JYoYGSWnONa8hT9+jruz9kQDbwGa0ClD9VAfPANRUekF3y2rn9XNKb5Ow WkVhGi8CeOo1shCXBuY4AcbCO1doE1n4qPsoNRSbmYZLF7v9fkYpskpUU1Vmt6/W6bNV ck/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775513689; x=1776118489; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EumurGm868mUc3WSikFqcKcfbgvr1fOR4UqmCi3WbQY=; b=SCxBpr1gUaaN+M4juNQQY/jmcgyYSxb1NpewA8FGKCl9DdyG5d89fExiBint9+ZwaQ ha2UXh+RkJC397+7KQRvy4JvxN/PkBJho/rJi8Sq/2B8vMDvYxTLYr2qJsJSQjNjy+AN otc1eXtGaLvZ7UZ/OwokSMcKbIBa0cBo3zKAwduXPgqN+txjZc5p9HYs1+306vsbv2Mt uQsXSbHKK/IvyDnWViXVmRyo1d01UDiptGWp9a6pP+v1aXTaiow+S6vFycQSUwJUjqOD 8LzJWAXcF5m1+7sRXQEtEI3LREE/0f3Kr/UMNcbQOPJwLEAnHOanhTDAR9D5xHZBNJzt e2Lw== X-Forwarded-Encrypted: i=1; AJvYcCXoIbgHt9c1BI4Y/x7/9oyOi1o3F2OGAE26Y+b0Pg1pr2CEE/K85fAgfxnA3J6SptEpOE7ooWuhK+ReWyA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2loJddKvqbhtP778sonHJDWC6hKUDcoaIotobJvSVbPHsBXHv 9CLB14EncITLNUdHWx5a7tZC1q47z6B6fd0/TvTLplPIFkYD318gwJ405+XIKG0ZhvYAjYpiZUU C05PGbsao3jp3K5SFHW8MNFboEnlvAAC+//aXrH+Y5uqSZTAlYR3hY1kgao4N1mSi9II= X-Gm-Gg: AeBDievZSoFU2uJCY7kkQpVjsk7OI7OPSI2FFDuobP6cHdHsN7VFu9QowdDvuJ2PgMo R0fyF+cwknj8He2NoJmAayMp52xIQV3rL2nw4k/j9rFFsepGsU40NICkC76j1FQjI/zYHVpnWTJ wX7Vfh+jjxv0OCa6XmW57OVPGvGog9BOp8ODsEX26THrdEax23tXakqeH7S+CAymbfDrmBqJNyc VCnaB7J0GwzmYkBy2uzXprPcrGwZWLkQa0Jf5DGUDsjFiTnSfZBoIhifC8j+EfJ4vDHbaCGy3lj 9n/PojFdFOoyfcA2EHsKH+jJvlBdCmaKFnW2vkTUW+a3bmXsaH2WbmK4JU0W3aTXeRyWyJQhKvw LSiiBCQs3fwXFm+o/kDwDKU/TiQBcsI99B+dTzKlgnH4TcJNaqYgJYDxmnDyVvh/U+G0tc59AfK DnTLzIk364XftrF7pSMN7anliLCu+wfEQUg9k= X-Received: by 2002:ac8:5dcc:0:b0:50d:714a:327a with SMTP id d75a77b69052e-50d714a37eemr183759921cf.10.1775513689279; Mon, 06 Apr 2026 15:14:49 -0700 (PDT) X-Received: by 2002:ac8:5dcc:0:b0:50d:714a:327a with SMTP id d75a77b69052e-50d714a37eemr183759421cf.10.1775513688754; Mon, 06 Apr 2026 15:14:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6cc60b2sm3727087e87.38.2026.04.06.15.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 15:14:47 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 07 Apr 2026 01:14:44 +0300 Subject: [PATCH] drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260407-adreno-fix-ubwc-v1-1-bb2b09450b87@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAFMw1GkC/yXMywqAIBCF4VeJWTegUga9SrRQm2paWGg3iN49q +XH4fwXRApMEersgkA7R559gswzcKPxAyF3yaCE0qIQFZoukJ+x5xM3ezjURpW6qKQgJSG9lkB p+4pN+ztudiK3vhm47wcZ1uhUcwAAAA== X-Change-ID: 20260407-adreno-fix-ubwc-6a2564710e21 To: Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1940; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=iOwuvALQIxMbLYv7A9rd+WY0kqRMtLoK0llPgfx8U1s=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp1DBVMGuNvEWzn24DV3+IqffS84tw+zeK0/bjp MPQSyKN/d2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCadQwVQAKCRCLPIo+Aiko 1XYaB/0f7EZ0LEcOnLO+p250YjjW58iR2HHQkFHfm2HaRzfPcYArqZKuit0fMJQEeix/B3FrWuF pC0Hg12DreYcAsqcDt0+AModK9M2hcgMDsx0i1eh2HNNj8mBzS/mRAmSRaIlKvvQNSWZIRNAHa2 U0z4c71wfCW4v7vdmQ1h5lNqupCk+8+pPomMalg0lybWESOzHd1mPOMg1hRcciukKtLCY7lQd9X 2v/I2+d9H9BI+jehSC9I506XK4VhrZCti4K1WsdW9ZUYr6x1QckGyTakbt/rHjlOIEBZntehDI0 YtHkzrd7CEgQICkAP+ny20d7gdNsUuC0rlGvFnj5rpM6fnVA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=SMdykuvH c=1 sm=1 tr=0 ts=69d4305a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=5ICTkH4HVDsf0thFk5wA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA2MDIxOCBTYWx0ZWRfX3ElqfMPN5xe0 t9P0aZllDwK6QhFWnQi0pZJV0N5oXiBs8uSZTD3UmT+OfuQdbv76Jw2cF9XVICGtyzRE7fgX72t FMVdV4ASIiYrr+xnZl8lQMUULbexv0asFjP3/O580y4Wt6k09A8YhUnSEG+IKqXkr7ASOAf04Tw vD1hOEpDhWyjRDV5QFoMRmyUS9nrFD5waNYQMjVJDYss0EeMGJ18oCPdTKvyxdUN0iCOI/gbych GED1HuBjIHdrU3Oa37qFhW/TnqI5x3nxa/gOrELasDsNQl6uWNJFst3+LqXPqqaFtjEqHWT4E7X bectoIw24lDhVuV8Ygpei/w6YztpmSqgfNthdIQjLN6WTl9DiCO7ryLkm5vmX99MG09SLXPh0kZ Y6cNf61Kntd9FXFauOX/VDnf21KY76fvQOjQYayYUWq0Ybzaw79B0/gVh2uZbqDsY8XUIASV4JM nZAOs7uGG3TsDAhvUoQ== X-Proofpoint-GUID: f0ZSr_-MxMO75f8P_aoSGn-SKN-keZCv X-Proofpoint-ORIG-GUID: f0ZSr_-MxMO75f8P_aoSGn-SKN-keZCv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-06_04,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604060218 Before a5xx Adreno driver will not try fetching UBWC params (because those generations didn't support UBWC anyway), however it's still possible to query UBWC-related params from the userspace, triggering possible NULL pointer dereference. Check for UBWC config in adreno_get_param() and return sane defaults if there is none. Fixes: a452510aad53 ("drm/msm/adreno: Switch to the common UBWC config stru= ct") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index d5fe6f6f0dec..7dc95c0a17f7 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -426,16 +426,25 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_= context *ctx, *value =3D vm->mm_range; return 0; case MSM_PARAM_HIGHEST_BANK_BIT: - *value =3D adreno_gpu->ubwc_config->highest_bank_bit; + if (!adreno_gpu->ubwc_config) + *value =3D 13; + else + *value =3D adreno_gpu->ubwc_config->highest_bank_bit; return 0; case MSM_PARAM_RAYTRACING: *value =3D adreno_gpu->has_ray_tracing; return 0; case MSM_PARAM_UBWC_SWIZZLE: - *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; + if (!adreno_gpu->ubwc_config) + *value =3D 0; + else + *value =3D adreno_gpu->ubwc_config->ubwc_swizzle; return 0; case MSM_PARAM_MACROTILE_MODE: - *value =3D adreno_gpu->ubwc_config->macrotile_mode; + if (!adreno_gpu->ubwc_config) + *value =3D 0; + else + *value =3D adreno_gpu->ubwc_config->macrotile_mode; return 0; case MSM_PARAM_UCHE_TRAP_BASE: *value =3D adreno_gpu->uche_trap_base; --- base-commit: 36ece9697e89016181e5ae87510e40fb31d86f2b change-id: 20260407-adreno-fix-ubwc-6a2564710e21 Best regards, -- =20 With best wishes Dmitry